From: "Alvin Šipraga" <ALSI@bang-olufsen.dk>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Mauri Sandberg <sandberg@mailfence.com>,
DENG Qingfang <dqfext@gmail.com>
Subject: Re: [PATCH net-next 1/4 v4] net: dsa: rtl8366rb: Support disabling learning
Date: Tue, 5 Oct 2021 07:59:41 +0000 [thread overview]
Message-ID: <d255f7eb-a85d-6fb6-8e86-ccb9669dd339@bang-olufsen.dk> (raw)
In-Reply-To: <CACRpkdZ5O0pf+mZphr5ypDNXtkQwfomwBnUToY2arXvtDHki+g@mail.gmail.com>
Hi Linus,
On 10/4/21 10:57 PM, Linus Walleij wrote:
> On Thu, Sep 30, 2021 at 12:45 PM Alvin Šipraga <ALSI@bang-olufsen.dk> wrote:
>
>> Following your discussion with Vladimir [1], did you come to a
>> conclusion on how you will handle this?
>
> I haven't gotten around to running the experiments (short on
> time), so I intended to play it safe for now. Unless I feel I have
> to.
Yeah I understand, it takes some time to figure out how these switches
really behave... :-)
You have Vladimir's Reviewed-by: tag so I guess this change is OK from
the maintainer's perspective.
>
> BTW: all the patches i have left are extensions to RTL8366RB
> specifically so I think it should be fine for you to submit patches
> for your switch on top of net-next, maybe we can test this
> on you chip too, I suspect it works the same on all Realtek
> switches?
Generally speaking I don't think that the patches you have sent for 66RB
are particularly relevant for the 65MB because the register layout and
some chip semantics are totally different. Regarding CPU port learning
for the RTL8365MB chip: right now I am playing around with the "third
way" Vladimir suggested, by enabling learning selectively only for
bridge-layer packets (skb->offload_fwd_mark == true). To begin with I'm
not even sure if you have this capability with the RTL8366RB.
Alvin
>
> Yours,
> Linus Walleij
>
next prev parent reply other threads:[~2021-10-05 7:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 21:03 [PATCH net-next 0/4 v4] RTL8366RB enhancements Linus Walleij
2021-09-29 21:03 ` [PATCH net-next 1/4 v4] net: dsa: rtl8366rb: Support disabling learning Linus Walleij
2021-09-29 21:58 ` Vladimir Oltean
2021-09-30 10:45 ` Alvin Šipraga
2021-10-04 20:57 ` Linus Walleij
2021-10-05 7:59 ` Alvin Šipraga [this message]
2021-10-05 14:07 ` Linus Walleij
2021-10-05 14:45 ` Alvin Šipraga
2021-09-29 21:03 ` [PATCH net-next 2/4 v4] net: dsa: rtl8366rb: Support flood control Linus Walleij
2021-09-29 21:57 ` Vladimir Oltean
2021-09-30 9:09 ` Alvin Šipraga
2021-10-04 22:22 ` Linus Walleij
2021-09-29 21:03 ` [PATCH net-next 3/4 v4] net: dsa: rtl8366rb: Support fast aging Linus Walleij
2021-09-29 21:45 ` Vladimir Oltean
2021-10-04 22:41 ` Linus Walleij
2021-09-29 21:03 ` [PATCH net-next 4/4 v4] net: dsa: rtl8366rb: Support setting STP state Linus Walleij
2021-09-29 21:54 ` Vladimir Oltean
2021-10-04 21:07 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d255f7eb-a85d-6fb6-8e86-ccb9669dd339@bang-olufsen.dk \
--to=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sandberg@mailfence.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox