Netdev List
 help / color / mirror / Atom feed
* [PATCH net v3] net: phy: DP83TC811: add reading of abilities
@ 2026-05-11 14:56 Sven Schuchmann
  2026-05-11 15:10 ` Andrew Lunn
  0 siblings, 1 reply; 6+ messages in thread
From: Sven Schuchmann @ 2026-05-11 14:56 UTC (permalink / raw)
  To: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Florian Fainelli,
	Dan Murphy, netdev, linux-kernel
  Cc: maxime.chevallier, Sven Schuchmann

At this time the driver is not listing any speeds
it supports. This should be ETHTOOL_LINK_MODE_100baseT1_Full_BIT
for DP83TC811. Add the missing call for phylib to read the abilities.

v3:
 - Fixed indentitation problems. no code changes.
v2:
 - Fixed subject and added fixes tag. no code changes.

Fixes: b753a9faaf9a ("net: phy: DP83TC811: Introduce support for the DP83TC811 phy")
Suggested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de>
---
 drivers/net/phy/dp83tc811.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/phy/dp83tc811.c b/drivers/net/phy/dp83tc811.c
index e480c2a07450..252fb12b3e68 100644
--- a/drivers/net/phy/dp83tc811.c
+++ b/drivers/net/phy/dp83tc811.c
@@ -393,6 +393,7 @@ static struct phy_driver dp83811_driver[] = {
 		.config_init = dp83811_config_init,
 		.config_aneg = dp83811_config_aneg,
 		.soft_reset = dp83811_phy_reset,
+		.get_features = genphy_c45_pma_read_ext_abilities,
 		.get_wol = dp83811_get_wol,
 		.set_wol = dp83811_set_wol,
 		.config_intr = dp83811_config_intr,
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH net v3] net: phy: DP83TC811: add reading of abilities
  2026-05-11 14:56 Sven Schuchmann
@ 2026-05-11 15:10 ` Andrew Lunn
  0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2026-05-11 15:10 UTC (permalink / raw)
  To: Sven Schuchmann
  Cc: Heiner Kallweit, Russell King, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Florian Fainelli, Dan Murphy, netdev,
	linux-kernel, maxime.chevallier

On Mon, May 11, 2026 at 04:56:30PM +0200, Sven Schuchmann wrote:
> At this time the driver is not listing any speeds
> it supports. This should be ETHTOOL_LINK_MODE_100baseT1_Full_BIT
> for DP83TC811. Add the missing call for phylib to read the abilities.
> 
> v3:
>  - Fixed indentitation problems. no code changes.
> v2:
>  - Fixed subject and added fixes tag. no code changes.
> 
> Fixes: b753a9faaf9a ("net: phy: DP83TC811: Introduce support for the DP83TC811 phy")
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH net v3] net: phy: DP83TC811: add reading of abilities
@ 2026-05-12  7:19 Sven Schuchmann
  2026-05-12 12:23 ` Andrew Lunn
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Sven Schuchmann @ 2026-05-12  7:19 UTC (permalink / raw)
  To: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Florian Fainelli,
	Dan Murphy, netdev, linux-kernel
  Cc: maxime.chevallier, Sven Schuchmann

At this time the driver is not listing any speeds
it supports. This should be ETHTOOL_LINK_MODE_100baseT1_Full_BIT
for DP83TC811. Add the missing call for phylib to read the abilities.

v3:
 - Fixed indentitation problems. no code changes.
v2:
 - Fixed subject and added fixes tag. no code changes.

Fixes: b753a9faaf9a ("net: phy: DP83TC811: Introduce support for the DP83TC811 phy")
Suggested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de>
---
 drivers/net/phy/dp83tc811.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/phy/dp83tc811.c b/drivers/net/phy/dp83tc811.c
index e480c2a07450..252fb12b3e68 100644
--- a/drivers/net/phy/dp83tc811.c
+++ b/drivers/net/phy/dp83tc811.c
@@ -393,6 +393,7 @@ static struct phy_driver dp83811_driver[] = {
 		.config_init = dp83811_config_init,
 		.config_aneg = dp83811_config_aneg,
 		.soft_reset = dp83811_phy_reset,
+		.get_features = genphy_c45_pma_read_ext_abilities,
 		.get_wol = dp83811_get_wol,
 		.set_wol = dp83811_set_wol,
 		.config_intr = dp83811_config_intr,
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH net v3] net: phy: DP83TC811: add reading of abilities
  2026-05-12  7:19 [PATCH net v3] net: phy: DP83TC811: add reading of abilities Sven Schuchmann
@ 2026-05-12 12:23 ` Andrew Lunn
  2026-05-14 13:19 ` Paolo Abeni
  2026-05-14 13:20 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2026-05-12 12:23 UTC (permalink / raw)
  To: Sven Schuchmann
  Cc: Heiner Kallweit, Russell King, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Florian Fainelli, Dan Murphy, netdev,
	linux-kernel, maxime.chevallier

On Tue, May 12, 2026 at 09:19:47AM +0200, Sven Schuchmann wrote:
> At this time the driver is not listing any speeds
> it supports. This should be ETHTOOL_LINK_MODE_100baseT1_Full_BIT
> for DP83TC811. Add the missing call for phylib to read the abilities.
> 
> v3:
>  - Fixed indentitation problems. no code changes.
> v2:
>  - Fixed subject and added fixes tag. no code changes.
> 
> Fixes: b753a9faaf9a ("net: phy: DP83TC811: Introduce support for the DP83TC811 phy")
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net v3] net: phy: DP83TC811: add reading of abilities
  2026-05-12  7:19 [PATCH net v3] net: phy: DP83TC811: add reading of abilities Sven Schuchmann
  2026-05-12 12:23 ` Andrew Lunn
@ 2026-05-14 13:19 ` Paolo Abeni
  2026-05-14 13:20 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 6+ messages in thread
From: Paolo Abeni @ 2026-05-14 13:19 UTC (permalink / raw)
  To: Sven Schuchmann, Andrew Lunn, Heiner Kallweit, Russell King,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Florian Fainelli,
	Dan Murphy, netdev, linux-kernel
  Cc: maxime.chevallier

On 5/12/26 9:19 AM, Sven Schuchmann wrote:
> At this time the driver is not listing any speeds
> it supports. This should be ETHTOOL_LINK_MODE_100baseT1_Full_BIT
> for DP83TC811. Add the missing call for phylib to read the abilities.
> 
> v3:
>  - Fixed indentitation problems. no code changes.
> v2:
>  - Fixed subject and added fixes tag. no code changes.

For future submissions please remember that the revision history should
follow the '---' separator.

I'm stripping it while applying so no repost needed here.

/P


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net v3] net: phy: DP83TC811: add reading of abilities
  2026-05-12  7:19 [PATCH net v3] net: phy: DP83TC811: add reading of abilities Sven Schuchmann
  2026-05-12 12:23 ` Andrew Lunn
  2026-05-14 13:19 ` Paolo Abeni
@ 2026-05-14 13:20 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-05-14 13:20 UTC (permalink / raw)
  To: Sven Schuchmann
  Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni,
	f.fainelli, dmurphy, netdev, linux-kernel, maxime.chevallier

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 12 May 2026 09:19:47 +0200 you wrote:
> At this time the driver is not listing any speeds
> it supports. This should be ETHTOOL_LINK_MODE_100baseT1_Full_BIT
> for DP83TC811. Add the missing call for phylib to read the abilities.
> 
> v3:
>  - Fixed indentitation problems. no code changes.
> v2:
>  - Fixed subject and added fixes tag. no code changes.
> 
> [...]

Here is the summary with links:
  - [net,v3] net: phy: DP83TC811: add reading of abilities
    https://git.kernel.org/netdev/net/c/c78bdba7b966

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-05-14 13:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-12  7:19 [PATCH net v3] net: phy: DP83TC811: add reading of abilities Sven Schuchmann
2026-05-12 12:23 ` Andrew Lunn
2026-05-14 13:19 ` Paolo Abeni
2026-05-14 13:20 ` patchwork-bot+netdevbpf
  -- strict thread matches above, loose matches on Subject: below --
2026-05-11 14:56 Sven Schuchmann
2026-05-11 15:10 ` Andrew Lunn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox