From: Andrew Lunn <andrew@lunn.ch>
To: "Srinivasan, Vijay" <vijay.srinivasan@intel.com>
Cc: "D H, Siddaraju" <siddaraju.dh@intel.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
David Laight <david.laight.linux@gmail.com>,
Michal Kubecek <mkubecek@suse.cz>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Chintalapalle, Balaji" <balaji.chintalapalle@intel.com>,
"Das, Shubham" <shubham.das@intel.com>,
"Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
"Keller, Jacob E" <jacob.e.keller@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"singhai.anjali55@gmail.com" <singhai.anjali55@gmail.com>,
"Brandeburg, Jesse" <jbrandeburg@cloudflare.com>
Subject: Re: Ethtool is missing C2C link modes
Date: Wed, 22 Jul 2026 14:52:04 +0200 [thread overview]
Message-ID: <e1d14d88-dbe4-4e15-b794-6277f9df7e6d@lunn.ch> (raw)
In-Reply-To: <BL3PR11MB63856413FCFB7F30D30E469688C22@BL3PR11MB6385.namprd11.prod.outlook.com>
On Tue, Jul 21, 2026 at 11:29:05PM +0000, Srinivasan, Vijay wrote:
> > As for your comment/question about FW vs linux controiling the HW, the intent here
> > is to use linux to tell FW where to go based on user input.
> > How the link is eventually achieved is all in FW.
>
> > I don't see how that works. ethtool has no APIs around
> > phy_interface_t. All ethtool offers is link modes. How do you see
> > this working?
>
> Correct me if I am wrong but isn't that the role of the driver?
> I expect device driver to translate Ethtool link mode argument and pass it to
> FW via driver-FW handshake (device specific SET/GET functions).
> MAC and PHY config. which includes phy_interface_t for that specific link speed
> is then implicitly handled by FW. No other intervention from user should be
> required.
It is. But if the driver is talking to firmware, it is using whatever
proprietary values defined by the firmware.
It only makes sense to use phy_interface_t for communication between
different Linux components, or uAPI and a Linux component.
Andrew
next prev parent reply other threads:[~2026-07-22 12:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 21:45 Ethtool is missing C2C link modes D H, Siddaraju
2026-07-10 22:54 ` Andrew Lunn
2026-07-11 6:31 ` David Laight
2026-07-11 8:42 ` Maxime Chevallier
2026-07-14 13:29 ` D H, Siddaraju
2026-07-14 19:43 ` Andrew Lunn
2026-07-21 22:43 ` Srinivasan, Vijay
2026-07-21 23:12 ` Andrew Lunn
2026-07-21 23:29 ` Srinivasan, Vijay
2026-07-22 12:52 ` Andrew Lunn [this message]
2026-07-22 17:36 ` Srinivasan, Vijay
2026-07-27 22:11 ` D H, Siddaraju
2026-07-13 23:18 ` Eric Joyner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1d14d88-dbe4-4e15-b794-6277f9df7e6d@lunn.ch \
--to=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=balaji.chintalapalle@intel.com \
--cc=david.laight.linux@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=jbrandeburg@cloudflare.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=shubham.das@intel.com \
--cc=siddaraju.dh@intel.com \
--cc=singhai.anjali55@gmail.com \
--cc=sridhar.samudrala@intel.com \
--cc=vijay.srinivasan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox