* [PATCH] r8169: Fix netpoll oops
@ 2018-06-20 12:01 Ville Syrjala
2018-06-20 18:51 ` Heiner Kallweit
2018-06-21 0:56 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Ville Syrjala @ 2018-06-20 12:01 UTC (permalink / raw)
To: netdev
Cc: Realtek linux nic maintainers, Heiner Kallweit, David S . Miller,
Ville Syrjälä
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Pass the correct thing to rtl8169_interrupt() from netpoll.
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>
Cc: netdev@vger.kernel.org
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Fixes: ebcd5daa7ffd ("r8169: change interrupt handler argument type")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/net/ethernet/realtek/r8169.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 75dfac0248f4..f4cae2be0fda 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -7148,7 +7148,7 @@ static void rtl8169_netpoll(struct net_device *dev)
{
struct rtl8169_private *tp = netdev_priv(dev);
- rtl8169_interrupt(pci_irq_vector(tp->pci_dev, 0), dev);
+ rtl8169_interrupt(pci_irq_vector(tp->pci_dev, 0), tp);
}
#endif
--
2.16.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] r8169: Fix netpoll oops
2018-06-20 12:01 [PATCH] r8169: Fix netpoll oops Ville Syrjala
@ 2018-06-20 18:51 ` Heiner Kallweit
2018-06-21 0:56 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Heiner Kallweit @ 2018-06-20 18:51 UTC (permalink / raw)
To: Ville Syrjala, netdev; +Cc: Realtek linux nic maintainers, David S . Miller
On 20.06.2018 14:01, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Pass the correct thing to rtl8169_interrupt() from netpoll.
>
Indeed, this place I missed to change.
Only small remark: The patch should be annotated as "net" so
that it can go to 4.18.
> Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>
> Cc: netdev@vger.kernel.org
> Cc: Heiner Kallweit <hkallweit1@gmail.com>
> Cc: David S. Miller <davem@davemloft.net>
> Fixes: ebcd5daa7ffd ("r8169: change interrupt handler argument type")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/net/ethernet/realtek/r8169.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 75dfac0248f4..f4cae2be0fda 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -7148,7 +7148,7 @@ static void rtl8169_netpoll(struct net_device *dev)
> {
> struct rtl8169_private *tp = netdev_priv(dev);
>
> - rtl8169_interrupt(pci_irq_vector(tp->pci_dev, 0), dev);
> + rtl8169_interrupt(pci_irq_vector(tp->pci_dev, 0), tp);
> }
> #endif
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] r8169: Fix netpoll oops
2018-06-20 12:01 [PATCH] r8169: Fix netpoll oops Ville Syrjala
2018-06-20 18:51 ` Heiner Kallweit
@ 2018-06-21 0:56 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-06-21 0:56 UTC (permalink / raw)
To: ville.syrjala; +Cc: netdev, nic_swsd, hkallweit1
From: Ville Syrjala <ville.syrjala@linux.intel.com>
Date: Wed, 20 Jun 2018 15:01:53 +0300
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Pass the correct thing to rtl8169_interrupt() from netpoll.
>
> Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>
> Cc: netdev@vger.kernel.org
> Cc: Heiner Kallweit <hkallweit1@gmail.com>
> Cc: David S. Miller <davem@davemloft.net>
> Fixes: ebcd5daa7ffd ("r8169: change interrupt handler argument type")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-21 0:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-20 12:01 [PATCH] r8169: Fix netpoll oops Ville Syrjala
2018-06-20 18:51 ` Heiner Kallweit
2018-06-21 0:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox