From: Xin Xie <xiexinet@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
horms@kernel.org, shuah@kernel.org, lukma@denx.de,
m-karicheri2@ti.com, fmaurer@redhat.com, luka.gejak@linux.dev,
bigeasy@linutronix.de, ali@iusegentoo.com,
qingfang.deng@linux.dev, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net v3 2/3] net: hsr: return private clones from the tagged-frame helpers
Date: Fri, 18 Sep 2026 23:50:42 +0200 [thread overview]
Message-ID: <f36f2ae7-9c48-4663-b3ba-7eb45c0bb977@gmail.com> (raw)
In-Reply-To: <20260814012738.2806035-1-kuba@kernel.org>
On 14/08/2026 03:27, Jakub Kicinski wrote:
> [Severity: High]
> This isn't a bug introduced by this patch, but should the sibling
> get_untagged_frame() callbacks be privatized the same way?
> ...
> One more consumer of the same bytes: an AF_PACKET listener on the slave
> device gets its clone in packet_rcv() before hsr_handle_frame() runs, so
> does it also observe the rewritten h_source?
Yes. Master delivery can rewrite frame->skb_std through its clone before
the later slave copies it. When the learned A and B addresses differ,
that copy preserves the substituted address rather than the original
source. An earlier packet-socket clone can also be affected.
I'll compare private untagged returns with COW at the writers before
settling the v4 ownership changes.
--
Xin
next prev parent reply other threads:[~2026-09-18 21:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-08 0:45 [PATCH net v3 0/3] net: hsr: fix shared-skb mutations in the forwarding path Xin Xie
2026-08-08 0:45 ` [PATCH net v3 1/3] net: hsr: privatize interlink-bound skbs before address mutation Xin Xie
2026-08-14 1:27 ` Jakub Kicinski
2026-09-18 21:47 ` Xin Xie
2026-08-14 1:27 ` Jakub Kicinski
2026-08-17 15:39 ` Xin Xie
2026-09-18 21:42 ` Xin Xie
2026-08-08 0:45 ` [PATCH net v3 2/3] net: hsr: return private clones from the tagged-frame helpers Xin Xie
2026-08-14 1:27 ` Jakub Kicinski
2026-09-18 21:50 ` Xin Xie [this message]
2026-08-08 0:45 ` [PATCH net v3 3/3] selftests: net: hsr: add shared-mutation regression test Xin Xie
2026-08-10 23:18 ` Xin Xie
2026-08-14 1:27 ` Jakub Kicinski
2026-09-18 22:06 ` Xin Xie
2026-08-14 1:30 ` Jakub Kicinski
2026-09-18 21:59 ` Xin Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f36f2ae7-9c48-4663-b3ba-7eb45c0bb977@gmail.com \
--to=xiexinet@gmail.com \
--cc=ali@iusegentoo.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=lukma@denx.de \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qingfang.deng@linux.dev \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox