* ixp4xx_hss. Little bug in hss_init_one
@ 2008-11-26 17:13 Miguel Ángel Álvarez
2008-12-04 20:32 ` Krzysztof Halasa
0 siblings, 1 reply; 3+ messages in thread
From: Miguel Ángel Álvarez @ 2008-11-26 17:13 UTC (permalink / raw)
To: netdev, Krzysztof Halasa
Hi
I have found that platform_set_drvdata is not correctly called if we
have an error in requesting npe. Am I right?
Signed-off-by: Miguel Ángel Álvarez (gotzoncabanes@gmail.com)
---
--- ixp4xx_hss.c.orig 2008-11-19 11:26:54.000000000 +0100
+++ ixp4xx_hss.c.initone 2008-11-26 18:09:22.000000000 +0100
@@ -2698,8 +2698,8 @@
free_netdev(dev);
err_plat:
npe_release(port->npe);
- platform_set_drvdata(pdev, NULL);
err_free:
+ platform_set_drvdata(pdev, NULL);
kfree(port);
return err;
}
Thanks
Miguel Ángel Álvarez
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ixp4xx_hss. Little bug in hss_init_one
2008-11-26 17:13 ixp4xx_hss. Little bug in hss_init_one Miguel Ángel Álvarez
@ 2008-12-04 20:32 ` Krzysztof Halasa
2008-12-05 7:56 ` Miguel Ángel Álvarez
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Halasa @ 2008-12-04 20:32 UTC (permalink / raw)
To: Miguel Ángel Álvarez; +Cc: netdev
Hi,
"Miguel Ángel Álvarez" <gotzoncabanes@gmail.com> writes:
> I have found that platform_set_drvdata is not correctly called if we
> have an error in requesting npe. Am I right?
Definitely. Though I will just move platform_set_drvdata() past
npe_request() (and register_hdlc_device()).
Thanks for spotting this bug.
--
Krzysztof Halasa
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ixp4xx_hss. Little bug in hss_init_one
2008-12-04 20:32 ` Krzysztof Halasa
@ 2008-12-05 7:56 ` Miguel Ángel Álvarez
0 siblings, 0 replies; 3+ messages in thread
From: Miguel Ángel Álvarez @ 2008-12-05 7:56 UTC (permalink / raw)
To: Krzysztof Halasa; +Cc: netdev
My pleasure.
2008/12/4 Krzysztof Halasa <khc@pm.waw.pl>:
> Hi,
>
> "Miguel Ángel Álvarez" <gotzoncabanes@gmail.com> writes:
>
>> I have found that platform_set_drvdata is not correctly called if we
>> have an error in requesting npe. Am I right?
>
> Definitely. Though I will just move platform_set_drvdata() past
> npe_request() (and register_hdlc_device()).
>
> Thanks for spotting this bug.
> --
> Krzysztof Halasa
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-12-05 7:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-26 17:13 ixp4xx_hss. Little bug in hss_init_one Miguel Ángel Álvarez
2008-12-04 20:32 ` Krzysztof Halasa
2008-12-05 7:56 ` Miguel Ángel Álvarez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox