* [PATCH 1/1] ixp4xx_hss: Non-used lut variable
@ 2008-11-24 14:37 Miguel Ángel Álvarez
2008-11-24 16:36 ` Krzysztof Halasa
0 siblings, 1 reply; 3+ messages in thread
From: Miguel Ángel Álvarez @ 2008-11-24 14:37 UTC (permalink / raw)
To: netdev, Krzysztof Halasa
Hi.
Taking a look to ixp4xx_hss code, I have found a non-used variable in
hss_config_set_lut. I suppose it is part of a deprecated code. This
patch removes it.
Signed-off-by: Miguel Ángel Álvarez (gotzoncabanes@gmail.com)
---
diff -urN linux-2.6.26.7_hssorig/drivers/net/wan/ixp4xx_hss.c
linux-2.6.26.7_hsspatched/drivers/net/wan/ixp4xx_hss.c
--- linux-2.6.26.7_hssorig/drivers/net/wan/ixp4xx_hss.c 2008-11-24
15:29:27.000000000 +0100
+++ linux-2.6.26.7_hsspatched/drivers/net/wan/ixp4xx_hss.c 2008-11-24
15:33:55.000000000 +0100
@@ -521,9 +521,7 @@
{
struct msg msg;
int chan_count = 0, log_chan = 0, i, ch;
- u32 lut[MAX_CHANNELS / 4];
-
- memset(lut, 0, sizeof(lut));
+
for (i = 0; i < MAX_CHAN_DEVICES; i++)
if (port->chan_devices[i])
port->chan_devices[i]->chan_count = 0;
Thanks
Miguel Ángel Álvarez
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ixp4xx_hss: Non-used lut variable
2008-11-24 14:37 [PATCH 1/1] ixp4xx_hss: Non-used lut variable Miguel Ángel Álvarez
@ 2008-11-24 16:36 ` Krzysztof Halasa
2008-11-24 17:13 ` Miguel Ángel Álvarez
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Halasa @ 2008-11-24 16:36 UTC (permalink / raw)
To: Miguel Ángel Álvarez; +Cc: netdev
"Miguel Ángel Álvarez" <gotzoncabanes@gmail.com> writes:
> Taking a look to ixp4xx_hss code, I have found a non-used variable in
> hss_config_set_lut. I suppose it is part of a deprecated code. This
> patch removes it.
You must be right. Thanks.
--
Krzysztof Halasa
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ixp4xx_hss: Non-used lut variable
2008-11-24 16:36 ` Krzysztof Halasa
@ 2008-11-24 17:13 ` Miguel Ángel Álvarez
0 siblings, 0 replies; 3+ messages in thread
From: Miguel Ángel Álvarez @ 2008-11-24 17:13 UTC (permalink / raw)
To: Krzysztof Halasa; +Cc: netdev
Hi
2008/11/24 Krzysztof Halasa <khc@pm.waw.pl>:
> "Miguel Ángel Álvarez" <gotzoncabanes@gmail.com> writes:
>
>> Taking a look to ixp4xx_hss code, I have found a non-used variable in
>> hss_config_set_lut. I suppose it is part of a deprecated code. This
>> patch removes it.
>
> You must be right. Thanks.
My pleasure.
Miguel Ángel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-24 17:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-24 14:37 [PATCH 1/1] ixp4xx_hss: Non-used lut variable Miguel Ángel Álvarez
2008-11-24 16:36 ` Krzysztof Halasa
2008-11-24 17:13 ` Miguel Ángel Álvarez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox