* Re: [IPv6] Add v4mapped address inline
From: David Miller @ 2007-08-25 6:16 UTC (permalink / raw)
To: brian.haley; +Cc: yoshfuji, netdev, lksctp-developers
In-Reply-To: <46CDCE8B.6010909@hp.com>
From: Brian Haley <brian.haley@hp.com>
Date: Thu, 23 Aug 2007 14:14:35 -0400
> YOSHIFUJI Hideaki / ???? wrote:
> > Please put this just after ipv6_addr_any(), not after
> > ipv6_addr_diff().
>
> Ok, updated patch attached.
>
> Add v4mapped address inline to avoid calls to ipv6_addr_type().
>
> Signed-off-by: Brian Haley <brian.haley@hp.com>
Applied, thanks Brian.
^ permalink raw reply
* Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG
From: David Miller @ 2007-08-25 6:14 UTC (permalink / raw)
To: linville; +Cc: johannes, joe, netdev
In-Reply-To: <20070823170830.GE2989@tuxdriver.com>
From: "John W. Linville" <linville@tuxdriver.com>
Date: Thu, 23 Aug 2007 13:08:30 -0400
> On Thu, Aug 23, 2007 at 06:12:00PM +0200, Johannes Berg wrote:
> > On Thu, 2007-08-23 at 09:01 -0700, Joe Perches wrote:
> > > There are also several different uses of the equivalent of
> > >
> > > printk("%02x",addr[0])
> > > for (i=1; i<6; i++)
> > > printk(":%02x",addr[i]);
> > >
> > > to print an ethernet MAC address.
> >
> > Hm. I didn't know that, I can go through in a later patch if desired.
> >
> > > http://www.uwsg.iu.edu/hypermail/linux/net/0602.1/0002.html
> > >
> > > As not all device MAC addresses are 6 bytes, colon separated,
> > > perhaps an appropriate ethernet/tr MAC designation is EUI48.
> > >
> > > http://standards.ieee.org/regauth/oui/tutorials/EUI48.html
> >
> > Practically, however, nobody is going to even find macros named
> > EUI48_FMT/EUI48_ARG, would they? I don't much care, but I find it rather
> > unsatisfying that both wireless code bases define these macros.
>
> Yeah, accomodating non-48-bit MAC addresses is a bit pedantic.
>
> I ACK the original patch, FWIW.
I like the patch too, applied to net-2.6.24, thanks everyone.
^ permalink raw reply
* Re: [PATCH 1/1] net/core: Fix crash in dev_mc_sync()/dev_mc_unsync()
From: David Miller @ 2007-08-25 6:12 UTC (permalink / raw)
To: kaber; +Cc: benjamin.thery, netdev
In-Reply-To: <46CD9E3C.2020002@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Thu, 23 Aug 2007 16:48:28 +0200
> Benjamin Thery wrote:
> > From: benjamin.thery@bull.net
> > Subject: net/core: Fix crash in dev_mc_sync()/dev_mc_unsync()
> >
> > This patch fixes a crash that may occur when the routine dev_mc_sync()
> > deletes an address from the list it is currently going through. It
> > saves the pointer to the next element before deleting the current one.
> > The problem may also exist in dev_mc_unsync().
> >
> > Signed-off-by: Benjamin Thery <benjamin.thery@bull.net>
>
> Looks good, thanks Benjamin.
>
> Acked-by: Patrick McHardy <kaber@trash.net>
Applied, thanks everyone.
^ permalink raw reply
* Re: [PATCH] shaper: mark for removal
From: David Miller @ 2007-08-25 6:10 UTC (permalink / raw)
To: shemminger; +Cc: alan, netdev, bunk
In-Reply-To: <20070823094430.036f2d28@freepuppy.rosehill.hemminger.net>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Thu, 23 Aug 2007 09:44:30 -0700
> Subject: shaper: mark for removal
>
> This driver has been marked obsolete for a long time and
> is superseded by traffic schedulers.
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Applied, thanks Stephen.
^ permalink raw reply
* Re: [PATCH] udp: randomize port selection
From: David Miller @ 2007-08-25 6:10 UTC (permalink / raw)
To: shemminger; +Cc: rick.jones2, panther, netdev
In-Reply-To: <20070823113226.30d6a4b6@freepuppy.rosehill.hemminger.net>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Thu, 23 Aug 2007 11:32:26 -0700
> This patch causes UDP port allocation to be randomized like TCP.
> The earlier code would always choose same port (ie first empty list).
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Applied to net-2.6.24, thanks Stephen.
^ permalink raw reply
* Re: [PATCH 2/2] [RFC] E1000: Fix hang in netdev_wait_allrefs()
From: David Miller @ 2007-08-25 6:08 UTC (permalink / raw)
To: krkumar2; +Cc: netdev
In-Reply-To: <20070823090431.13099.2597.sendpatchset@localhost.localdomain>
From: Krishna Kumar <krkumar2@in.ibm.com>
Date: Thu, 23 Aug 2007 14:34:31 +0530
> After applying patch1, I started getting "waiting for count" messages when
> doing ifdown. Not sure if this is the right fix since the count was already
> showing as -1 in that message, but this patch fixes the problem.
>
> Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
I've applied this because is fixes the problem and there have
be no objections coming along with better fixes :)
If this is bogus we can rever it and put in a more proper fix.
^ permalink raw reply
* Re: [PATCH 1/2] E1000: Fix ifdown hang in git-2.6.24
From: David Miller @ 2007-08-25 6:07 UTC (permalink / raw)
To: krkumar2; +Cc: netdev
In-Reply-To: <20070823090418.13099.89298.sendpatchset@localhost.localdomain>
From: Krishna Kumar <krkumar2@in.ibm.com>
Date: Thu, 23 Aug 2007 14:34:18 +0530
> Doing napi_disable twice hangs "ifdown" of the device. e1000_down is the
> common place to call napi_disable.
>
> Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
Applied, thanks a lot.
^ permalink raw reply
* Re: [PATCH] IOAT: ioatdma needs to to play nice in a multi-dma-client world
From: David Miller @ 2007-08-25 6:03 UTC (permalink / raw)
To: shannon.nelson; +Cc: netdev, akpm, linux-kernel, dan.j.williams, jgarzik
In-Reply-To: <20070823001218.11648.49528.stgit@localhost.localdomain>
From: Shannon Nelson <shannon.nelson@intel.com>
Date: Wed, 22 Aug 2007 17:12:18 -0700
> Now that the DMA engine has a multi-client interface, fix the ioatdma
> driver to play along. At the same time, remove a couple of unnecessary
> reads and writes.
>
> Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
Applied, thanks Shannon.
^ permalink raw reply
* Re: [PATCH net-2.6.24] [NET] Cleanup: DIV_ROUND_UP
From: David Miller @ 2007-08-25 6:00 UTC (permalink / raw)
To: ilpo.jarvinen; +Cc: netdev
In-Reply-To: <Pine.LNX.4.64.0708221347010.16255@kivilampi-30.cs.helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Wed, 22 Aug 2007 13:48:14 +0300 (EEST)
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Applied, thanks Ilpo.
^ permalink raw reply
* Re: ppp dependency on slhc
From: David Miller @ 2007-08-25 5:57 UTC (permalink / raw)
To: akpm; +Cc: paulus, netdev
In-Reply-To: <20070821013057.48e5af73.akpm@linux-foundation.org>
From: Andrew Morton <akpm@linux-foundation.org>
Date: Tue, 21 Aug 2007 01:30:57 -0700
> ERROR: "slhc_init" [drivers/net/ppp_generic.ko] undefined!
> ERROR: "slhc_free" [drivers/net/ppp_generic.ko] undefined!
> ERROR: "slhc_uncompress" [drivers/net/ppp_generic.ko] undefined!
> ERROR: "slhc_compress" [drivers/net/ppp_generic.ko] undefined!
> ERROR: "slhc_toss" [drivers/net/ppp_generic.ko] undefined!
> ERROR: "slhc_remember" [drivers/net/ppp_generic.ko] undefined!
>
> yet another reminder that select doesn't work ;)
Indeed :-)
However it is a good example of the kind of cases select was
made for, nobody should have to know about SLHC in order to
get PPP offered in the config.
^ permalink raw reply
* Re: [PATCH 5/5] [TCP] MIB: Add counters for discarded SACK blocks
From: David Miller @ 2007-08-25 5:56 UTC (permalink / raw)
To: ilpo.jarvinen; +Cc: netdev
In-Reply-To: <1187615793520-git-send-email-ilpo.jarvinen@helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Mon, 20 Aug 2007 16:16:33 +0300
> In DSACK case, some events are not extraordinary, such as packet
> duplication generated DSACK. They can arrive easily below
> snd_una when undo_marker is not set (TCP being in CA_Open),
> counting such DSACKs amoung SACK discards will likely just
> mislead if they occur in some scenario when there are other
> problems as well. Similarly, excessively delayed packets could
> cause "normal" DSACKs. Therefore, separate counters are
> allocated for DSACK events.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Also applied, thanks a lot!
^ permalink raw reply
* Re: [PATCH 4/5] [TCP]: Discard fuzzy SACK blocks
From: David Miller @ 2007-08-25 5:55 UTC (permalink / raw)
To: ilpo.jarvinen; +Cc: netdev
In-Reply-To: <11876157932029-git-send-email-ilpo.jarvinen@helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Mon, 20 Aug 2007 16:16:32 +0300
> SACK processing code has been a sort of russian roulette as no
> validation of SACK blocks is previously attempted. Besides, it
> is not very clear what all kinds of broken SACK blocks really
> mean (e.g., one that has start and end sequence numbers
> reversed). So now close the roulette once and for all.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Thanks a lot for coding this up, I like it a lot, applied.
I have some minor worries about the D-SACK lower bound, but
it's probably OK and I'm just being paranoid :-)
^ permalink raw reply
* Re: [PATCH 3/5] [TCP]: Rename tcp_ack_packets_out -> tcp_rearm_rto
From: David Miller @ 2007-08-25 5:53 UTC (permalink / raw)
To: ilpo.jarvinen; +Cc: netdev
In-Reply-To: <118761579328-git-send-email-ilpo.jarvinen@helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Mon, 20 Aug 2007 16:16:31 +0300
> Only thing that tiny function does is rearming the RTO (if
> necessary), name it accordingly.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 2/5] [TCP]: tcp_packets_out_inc to tcp_output.c (no callers elsewhere)
From: David Miller @ 2007-08-25 5:44 UTC (permalink / raw)
To: ilpo.jarvinen; +Cc: netdev
In-Reply-To: <1187615793583-git-send-email-ilpo.jarvinen@helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Mon, 20 Aug 2007 16:16:30 +0300
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Applied.
^ permalink raw reply
* Re: [PATCH 1/5] [TCP]: Remove unnecessary wrapper tcp_packets_out_dec
From: David Miller @ 2007-08-25 5:43 UTC (permalink / raw)
To: ilpo.jarvinen; +Cc: netdev
In-Reply-To: <1187615793197-git-send-email-ilpo.jarvinen@helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Mon, 20 Aug 2007 16:16:29 +0300
> Makes caller side more obvious, there's no need to have
> a wrapper for this oneliner!
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] net/802: indentation cleanup
From: David Miller @ 2007-08-25 5:42 UTC (permalink / raw)
To: shemminger; +Cc: netdev
In-Reply-To: <20070824.223940.56806419.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Fri, 24 Aug 2007 22:39:40 -0700 (PDT)
> From: Stephen Hemminger <shemminger@linux-foundation.org>
> Date: Fri, 17 Aug 2007 18:53:11 -0700
>
> > Run the 802 related protocols through Lindent (and hand cleanup)
> > to fix indentation and whitespace style issues.
>
> Applied to net-2.6.24, thanks.
Actually reverted.
Nothing in the world makes me more furious than a "coding
style" change that wasn't even compile tested.
net/802/tr.c: In function ^[$,1rx^[(Btr_add_rif_info^[$,1ry^[(B:
net/802/tr.c:400: error: expected identifier before ^[$,1rx^[(B!^[$,1ry^[(B token
Stephen I see you do things like this, forget sign offs,
and many other things that all say in big huge letters
"sloppy".
Please shape up and test your changes no matter how trivial.
Thanks.
^ permalink raw reply
* Re: [PATCH] net/802: indentation cleanup
From: David Miller @ 2007-08-25 5:39 UTC (permalink / raw)
To: shemminger; +Cc: netdev
In-Reply-To: <20070817185311.5564198a@freepuppy.rosehill.hemminger.net>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 17 Aug 2007 18:53:11 -0700
> Run the 802 related protocols through Lindent (and hand cleanup)
> to fix indentation and whitespace style issues.
Applied to net-2.6.24, thanks.
^ permalink raw reply
* Re: [PATCH] atm: replace DPRINTK() with pr_debug
From: David Miller @ 2007-08-25 5:37 UTC (permalink / raw)
To: shemminger; +Cc: chas, linux-atm-general, netdev
In-Reply-To: <20070817183131.05c3a9fb@freepuppy.rosehill.hemminger.net>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 17 Aug 2007 18:31:31 -0700
> Get rid of using DPRINTK macro in ATM and use pr_debug (in kernel.h).
> Using the standard macro is cleaner and forces code to check for bad arguments
> and formatting.
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Applied to net-2.6.24, thanks Stephen.
^ permalink raw reply
* Re: [PATCH] ethernet: optimize memcpy and memset
From: David Miller @ 2007-08-25 5:35 UTC (permalink / raw)
To: shemminger; +Cc: netdev
In-Reply-To: <20070817162950.6d8d07cd@freepuppy.rosehill.hemminger.net>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 17 Aug 2007 16:29:50 -0700
> The ethernet header management only needs to handle a fixed
> size address (6 bytes). If the memcpy/memset are changed to
> be passed a constant length, then compiler can optimize for
> this case (and if it is smart eliminate string instructions).
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Applied.
^ permalink raw reply
* Re: [kj] is_power_of_2 in net/core/neighbour.c
From: David Miller @ 2007-08-25 5:28 UTC (permalink / raw)
To: vigneshbabu, vignesh.babu; +Cc: roque, kuznet, netdev, kernel-janitors
In-Reply-To: <1187010227.7273.16.camel@merlin.linuxcoe.com>
From: vignesh babu <vignesh.babu@wipro.com>
Date: Mon, 13 Aug 2007 18:33:47 +0530
> Replacing n & (n - 1) for power of 2 check by is_power_of_2(n)
>
> Signed-off-by: vignesh babu <vignesh.babu@wipro.com>
Patch applied, thanks.
^ permalink raw reply
* Re: [PATCH] [NET]: fix multicast list when cloning sockets
From: David Miller @ 2007-08-25 5:16 UTC (permalink / raw)
To: fleitner; +Cc: netdev, dlstevens, acme
In-Reply-To: <20070731182940.GE4002@redhat.com>
From: Flavio Leitner <fleitner@redhat.com>
Date: Tue, 31 Jul 2007 15:29:40 -0300
> On Tue, Jul 31, 2007 at 12:00:41AM -0300, Arnaldo Carvalho de Melo wrote:
> > On 7/30/07, David Miller <davem@davemloft.net> wrote:
> > > Allowing non-datagram sockets to end up with a non-NULL inet->mc_list
> > > in the first place is a bug.
> > >
> > > Multicast subscriptions cannot even be used with TCP and DCCP, which
> > > are the only two users of these connection oriented socket functions.
> > >
> > > The first thing that TCP and DCCP do, in fact, for input packet
> > > processing is drop the packet if it is not unicast.
> > >
> > > Therefore the fix really is for the inet layer to reject multicast
> > > subscription requests on sockets for which that absolutely does not
> > > make sense. There is no reason these functions in
> > > inet_connection_sock.c should need to be mindful of multicast
> > > state. :-)
> >
> > Well, we can add a BUG_ON there then 8)
> >
> > Flavio, take a look at do_ip_setsockopt in net/ipv4/ip_sockglue.c, in
> > the IP_{ADD,DROP}_MEMBERSHIP labels.
> >
> > Don't forget IPV6 (net/ipv6/ipv6_sockglue.c)
>
> yes, right. What about the one below?
>
> [NET]: Fix IP_ADD/DROP_MEMBERSHIP to handle only connectionless
>
> Fix IP[V6]_ADD_MEMBERSHIP and IP[V6]_DROP_MEMBERSHIP to
> return -EPROTO for connection oriented sockets.
>
> Signed-off-by: Flavio Leitner <fleitner@redhat.com>
This looks great, patch applied.
Thanks!
^ permalink raw reply
* Re: [PATCH 1/2] myri10ge: use pcie_get/set_readrq
From: Jeff Garzik @ 2007-08-25 4:41 UTC (permalink / raw)
To: Brice Goglin; +Cc: netdev
In-Reply-To: <46CE814D.2060704@myri.com>
Brice Goglin wrote:
> Based on a patch from Peter Oruba, convert myri10ge to use pcie_get_readrq()
> and pcie_set_readrq() instead of our own PCI calls and arithmetics.
>
> These driver changes incorporate the proposed PCI-X / PCI-Express read byte
> count interface. Reading and setting those values doesn't take place
> "manually", instead wrapping functions are called to allow quirks for some
> PCI bridges.
>
> Signed-off-by: Brice Goglin <brice@myri.com>
> Signed-off by: Peter Oruba <peter.oruba@amd.com>
> Based on work by Stephen Hemminger <shemminger@linux-foundation.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> drivers/net/myri10ge/myri10ge.c | 32 ++++++--------------------------
> 1 file changed, 6 insertions(+), 26 deletions(-)
applied 1-2
^ permalink raw reply
* Re: [PATCH 1/4] ehea: fix interface to DLPAR tools
From: Jeff Garzik @ 2007-08-25 4:41 UTC (permalink / raw)
To: Jan-Bernd Themann
Cc: netdev, Christoph Raisch, Jan-Bernd Themann, linux-kernel,
linux-ppc, Marcus Eder, Thomas Klein, Stefan Roscher
In-Reply-To: <200708221620.59078.ossthema@de.ibm.com>
Jan-Bernd Themann wrote:
> Userspace DLPAR tool expects decimal numbers to be written to
> and read from sysfs entries.
>
> Signed-off-by: Jan-Bernd Themann <themann@de.ibm.com>
applied 1-3
^ permalink raw reply
* Re: [NET] sgiseeq: Fix return type of sgiseeq_remove
From: Jeff Garzik @ 2007-08-25 4:41 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Andrew Morton, netdev
In-Reply-To: <20070822150352.GA18889@linux-mips.org>
Ralf Baechle wrote:
> The driver remove method needs to return an int not void. This was just
> never noticed because usually this driver is not being built as a module.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
applied
^ permalink raw reply
* Re: [PATCH] DM9000: fix interface hang under load
From: Jeff Garzik @ 2007-08-25 4:40 UTC (permalink / raw)
To: Florian Westphal; +Cc: akpm, netdev
In-Reply-To: <20070820233342.GG9315@Chamillionaire.breakpoint.cc>
Florian Westphal wrote:
> When transferring data at full speed, the DM9000 network interface
> sometimes stops sending/receiving data. Worse, ksoftirqd consumes
> 100% cpu and the net tx watchdog never triggers.
> Fix by spin_lock_irqsave() in dm9000_start_xmit() to prevent the
> interrupt handler from interfering.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> Actually the comments ('Disable all interrupts, iow(db, DM9000_IMR, IMR_PAR) etc)
> give the impression that the interrupt handler cannot run during dm9000_start_xmit(),
> however this isn't correct (perhaps the chipset has some weird timing issues?).
> The interface lockup usually occurs between 30 and 360 seconds after starting transmitting
> data (netcat /dev/zero) at full speed; with this patch applied I haven't been able
> to reproduce hangs yet (ran for > 2h).
> FTR: This is a dm9000 on XScale-PXA255 rev 6 (ARMv5TE)/Compulab CM-x255, i.e.
> a module not supported by the vanilla kernel. Tested on (patched) 2.6.18.
>
> dm9000.c | 25 +++++++------------------
> 1 file changed, 7 insertions(+), 18 deletions(-)
applied
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox