* Re: [PATCHv2 1/2] mcastv6: Local variable shadows function argument
From: David Miller @ 2009-07-21 18:13 UTC (permalink / raw)
To: gerrit; +Cc: dlstevens, netdev
In-Reply-To: <20090721181153.GA5970@gerrit.erg.abdn.ac.uk>
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Tue, 21 Jul 2009 20:11:53 +0200
> mcastv6: Local variable shadows function argument
>
> The local variable 'idev' shadows the function argument 'idev' to
> ip6_mc_add_src(). Fixed by removing the local declaration, as pmc->idev
> should be identical with 'idev' passed as argument.
>
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
> Acked-by: David L Stevens <dlstevens@us.ibm.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [net-next 1/10] bnx2x: Stop management traffic in loopback test
From: David Miller @ 2009-07-21 18:20 UTC (permalink / raw)
To: eilong; +Cc: netdev
In-Reply-To: <1248191242.18195.39.camel@lb-tlvb-eilong>
All 10 patches applied, thanks.
On patch #10, the version bump, you ommitted the "bnx2x" in the
subject line. Please don't do that, as the text you add there
becomes the commit message header line.
I fixed it up this time, but next time I will bounce the entire
patch set back to you.
Thanks.
^ permalink raw reply
* Re: [PATCH] macsonic, jazzsonic - fix oops on module unload
From: David Miller @ 2009-07-21 19:22 UTC (permalink / raw)
To: fthain; +Cc: netdev, gregkh, u.kleine-koenig
In-Reply-To: <alpine.OSX.2.00.0907220119060.796@silk.local>
From: Finn Thain <fthain@telegraphics.com.au>
Date: Wed, 22 Jul 2009 01:40:02 +1000 (EST)
>
> Set the driver data before using it. Fixes an oops when doing rmmod.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Applied, thanks.
^ permalink raw reply
* Re: [0/4] trivial cleanups for via-velocity.c
From: Dave Jones @ 2009-07-21 19:27 UTC (permalink / raw)
To: David Miller; +Cc: netdev
In-Reply-To: <20090721.111235.211304996.davem@davemloft.net>
On Tue, Jul 21, 2009 at 11:12:35AM -0700, David Miller wrote:
> From: Dave Jones <davej@redhat.com>
> Date: Mon, 20 Jul 2009 23:34:56 -0400
>
> > I've had these sitting around for a while, they should be safe to apply.
> > I checked a diff of the disassembly from objdump before/after, and
> > the only diffs were the placement of the functions & jump offsets changing
> > due to the reordering in diff 3/4.
>
> These do not apply to the driver in the current tree, particularly
> it doesn't apply at all to net-next-2.6 which is where I would
> add this.
>
> Please fix this up and resubmit, thanks.
Actually only 1/4 needs rediffing. It removes the only line that changes
in via-velocity in net-next. I'll send a rediff.
thanks,
Dave
^ permalink raw reply
* [1/4 v2] Remove unused zero-copy code from velocity NIC driver.
From: Dave Jones @ 2009-07-21 19:28 UTC (permalink / raw)
To: netdev
This code hasn't been enabled in forever.
Signed-off-by: Dave Jones <davej@redhat.com>
---
drivers/net/via-velocity.c | 77 ++++++-------------------------------------
1 files changed, 11 insertions(+), 66 deletions(-)
diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
index 42365e5..4ebe2ca 100644
--- a/drivers/net/via-velocity.c
+++ b/drivers/net/via-velocity.c
@@ -976,9 +976,6 @@ static int __devinit velocity_found1(struct pci_dev *pdev, const struct pci_devi
dev->netdev_ops = &velocity_netdev_ops;
dev->ethtool_ops = &velocity_ethtool_ops;
-#ifdef VELOCITY_ZERO_COPY_SUPPORT
- dev->features |= NETIF_F_SG;
-#endif
dev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_FILTER |
NETIF_F_HW_VLAN_RX;
@@ -1849,11 +1846,7 @@ static void velocity_free_tx_buf(struct velocity_info *vptr, struct velocity_td_
pktlen = max_t(unsigned int, skb->len, ETH_ZLEN);
for (i = 0; i < tdinfo->nskb_dma; i++) {
-#ifdef VELOCITY_ZERO_COPY_SUPPORT
- pci_unmap_single(vptr->pdev, tdinfo->skb_dma[i], le16_to_cpu(td->tdesc1.len), PCI_DMA_TODEVICE);
-#else
pci_unmap_single(vptr->pdev, tdinfo->skb_dma[i], pktlen, PCI_DMA_TODEVICE);
-#endif
tdinfo->skb_dma[i] = 0;
}
}
@@ -2095,13 +2088,6 @@ static int velocity_xmit(struct sk_buff *skb, struct net_device *dev)
len = cpu_to_le16(pktlen);
-#ifdef VELOCITY_ZERO_COPY_SUPPORT
- if (skb_shinfo(skb)->nr_frags > 6 && __skb_linearize(skb)) {
- kfree_skb(skb);
- return NETDEV_TX_OK;
- }
-#endif
-
spin_lock_irqsave(&vptr->lock, flags);
index = vptr->tx.curr[qnum];
@@ -2111,59 +2097,18 @@ static int velocity_xmit(struct sk_buff *skb, struct net_device *dev)
td_ptr->tdesc1.TCR = TCR0_TIC;
td_ptr->td_buf[0].size &= ~TD_QUEUE;
-#ifdef VELOCITY_ZERO_COPY_SUPPORT
- if (skb_shinfo(skb)->nr_frags > 0) {
- int nfrags = skb_shinfo(skb)->nr_frags;
- tdinfo->skb = skb;
- if (nfrags > 6) {
- skb_copy_from_linear_data(skb, tdinfo->buf, skb->len);
- tdinfo->skb_dma[0] = tdinfo->buf_dma;
- td_ptr->tdesc0.len = len;
- td_ptr->tx.buf[0].pa_low = cpu_to_le32(tdinfo->skb_dma[0]);
- td_ptr->tx.buf[0].pa_high = 0;
- td_ptr->tx.buf[0].size = len; /* queue is 0 anyway */
- tdinfo->nskb_dma = 1;
- } else {
- int i = 0;
- tdinfo->nskb_dma = 0;
- tdinfo->skb_dma[i] = pci_map_single(vptr->pdev, skb->data,
- skb_headlen(skb), PCI_DMA_TODEVICE);
-
- td_ptr->tdesc0.len = len;
-
- /* FIXME: support 48bit DMA later */
- td_ptr->tx.buf[i].pa_low = cpu_to_le32(tdinfo->skb_dma);
- td_ptr->tx.buf[i].pa_high = 0;
- td_ptr->tx.buf[i].size = cpu_to_le16(skb_headlen(skb));
-
- for (i = 0; i < nfrags; i++) {
- skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
- void *addr = (void *)page_address(frag->page) + frag->page_offset;
-
- tdinfo->skb_dma[i + 1] = pci_map_single(vptr->pdev, addr, frag->size, PCI_DMA_TODEVICE);
-
- td_ptr->tx.buf[i + 1].pa_low = cpu_to_le32(tdinfo->skb_dma[i + 1]);
- td_ptr->tx.buf[i + 1].pa_high = 0;
- td_ptr->tx.buf[i + 1].size = cpu_to_le16(frag->size);
- }
- tdinfo->nskb_dma = i - 1;
- }
+ /*
+ * Map the linear network buffer into PCI space and
+ * add it to the transmit ring.
+ */
+ tdinfo->skb = skb;
+ tdinfo->skb_dma[0] = pci_map_single(vptr->pdev, skb->data, pktlen, PCI_DMA_TODEVICE);
+ td_ptr->tdesc0.len = len;
+ td_ptr->td_buf[0].pa_low = cpu_to_le32(tdinfo->skb_dma[0]);
+ td_ptr->td_buf[0].pa_high = 0;
+ td_ptr->td_buf[0].size = len;
+ tdinfo->nskb_dma = 1;
- } else
-#endif
- {
- /*
- * Map the linear network buffer into PCI space and
- * add it to the transmit ring.
- */
- tdinfo->skb = skb;
- tdinfo->skb_dma[0] = pci_map_single(vptr->pdev, skb->data, pktlen, PCI_DMA_TODEVICE);
- td_ptr->tdesc0.len = len;
- td_ptr->td_buf[0].pa_low = cpu_to_le32(tdinfo->skb_dma[0]);
- td_ptr->td_buf[0].pa_high = 0;
- td_ptr->td_buf[0].size = len;
- tdinfo->nskb_dma = 1;
- }
td_ptr->tdesc1.cmd = TCPLS_NORMAL + (tdinfo->nskb_dma + 1) * 16;
if (vptr->vlgrp && vlan_tx_tag_present(skb)) {
^ permalink raw reply related
* Re: [1/4 v2] Remove unused zero-copy code from velocity NIC driver.
From: David Miller @ 2009-07-21 19:32 UTC (permalink / raw)
To: davej; +Cc: netdev
In-Reply-To: <200907211928.n6LJSLbe004367@gelk.kernelslacker.org>
From: Dave Jones <davej@redhat.com>
Date: Tue Jul 21 15:15:49 2009 -0400
> This code hasn't been enabled in forever.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
David it still doesn't apply....
Try to apply this using GIT to net-next-2.6, it won't go.
^ permalink raw reply
* Re: [1/4 v2] Remove unused zero-copy code from velocity NIC driver.
From: David Miller @ 2009-07-21 19:32 UTC (permalink / raw)
To: davej; +Cc: netdev
In-Reply-To: <20090721.123202.173837534.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 21 Jul 2009 12:32:02 -0700 (PDT)
> From: Dave Jones <davej@redhat.com>
> Date: Tue Jul 21 15:15:49 2009 -0400
>
>> This code hasn't been enabled in forever.
>>
>> Signed-off-by: Dave Jones <davej@redhat.com>
>
> David it still doesn't apply....
>
> Try to apply this using GIT to net-next-2.6, it won't go.
Sorry, PEBKAC....
^ permalink raw reply
* Re: [1/4 v2] Remove unused zero-copy code from velocity NIC driver.
From: David Miller @ 2009-07-21 19:33 UTC (permalink / raw)
To: davej; +Cc: netdev
In-Reply-To: <20090721.123227.85658631.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 21 Jul 2009 12:32:27 -0700 (PDT)
> From: David Miller <davem@davemloft.net>
> Date: Tue, 21 Jul 2009 12:32:02 -0700 (PDT)
>
>> From: Dave Jones <davej@redhat.com>
>> Date: Tue Jul 21 15:15:49 2009 -0400
>>
>>> This code hasn't been enabled in forever.
>>>
>>> Signed-off-by: Dave Jones <davej@redhat.com>
>>
>> David it still doesn't apply....
>>
>> Try to apply this using GIT to net-next-2.6, it won't go.
>
> Sorry, PEBKAC....
Ok, all applied to net-next-2.6, thanks.
^ permalink raw reply
* Re: [PATCH] Phonet: sockets list through proc_fs
From: David Miller @ 2009-07-21 19:34 UTC (permalink / raw)
To: remi.denis-courmont; +Cc: netdev
In-Reply-To: <1248177479-12669-1-git-send-email-remi.denis-courmont@nokia.com>
From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Date: Tue, 21 Jul 2009 14:57:57 +0300
> From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
>
> This provides a list of sockets with their Phonet bind addresses and
> some socket debug informations through /proc/net/phonet.
>
> Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Applied.
But why don't you create a pn_sock_init() function so you don't
have to export so many things from socket.c?
^ permalink raw reply
* Re: [PATCH] Phonet: account for dropped RX packets
From: David Miller @ 2009-07-21 19:34 UTC (permalink / raw)
To: remi.denis-courmont; +Cc: netdev
In-Reply-To: <1248177479-12669-3-git-send-email-remi.denis-courmont@nokia.com>
From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Date: Tue, 21 Jul 2009 14:57:59 +0300
> From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
>
> Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Applied.
^ permalink raw reply
* Re: [PATCH] Phonet: dropped datagrams accounting
From: David Miller @ 2009-07-21 19:35 UTC (permalink / raw)
To: remi.denis-courmont; +Cc: netdev
In-Reply-To: <1248177479-12669-2-git-send-email-remi.denis-courmont@nokia.com>
From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Date: Tue, 21 Jul 2009 14:57:58 +0300
> From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
>
> The per-socket drop count is visible via /proc/net/phonet.
>
> Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH][be2net] Add GRO support to the be2net driver. LRO is not supported anymore.
From: David Miller @ 2009-07-21 19:36 UTC (permalink / raw)
To: ajitk; +Cc: netdev
In-Reply-To: <20090721120701.GA7570@serverengines.com>
From: Ajit Khaparde <ajitk@serverengines.com>
Date: Tue, 21 Jul 2009 17:37:11 +0530
>
> This patch removes support for INET_LRO and switches over to GRO.
>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied, thanks a lot for doing this work.
^ permalink raw reply
* Re: [PATCH] dm9000: switch to dev_pm_ops
From: David Miller @ 2009-07-21 19:37 UTC (permalink / raw)
To: ben; +Cc: mike, netdev
In-Reply-To: <4A65D8E6.5010005@simtec.co.uk>
From: Ben Dooks <ben@simtec.co.uk>
Date: Tue, 21 Jul 2009 16:04:06 +0100
> Mike Rapoport wrote:
>> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
> Acked-by: Ben Dooks <ben-linux@fluff.org>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next-2.6] can: sja1000: Add support for the new 4 channel EMS CPC-PCI cards
From: David Miller @ 2009-07-21 19:38 UTC (permalink / raw)
To: wg; +Cc: netdev, Socketcan-core, haas
In-Reply-To: <4A65EB78.80008@grandegger.com>
From: Wolfgang Grandegger <wg@grandegger.com>
Date: Tue, 21 Jul 2009 18:23:20 +0200
> This patch adds support to the ems_pci driver for the new, v2,
> 4 channel CPC-PCI/PCIe/104P CAN cards from EMS Dr. Thomas Wuensche.
>
> Signed-off-by: Sebastian Haas <haas@ems-wuensche.com>
> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
Applied to net-next-2.6, thanks.
^ permalink raw reply
* Re: [PATCH] USB host CDC Phonet network interface driver
From: David Miller @ 2009-07-21 19:42 UTC (permalink / raw)
To: remi.denis-courmont; +Cc: netdev, linux-usb
In-Reply-To: <1247824566-9141-1-git-send-email-remi.denis-courmont@nokia.com>
From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Date: Fri, 17 Jul 2009 12:56:06 +0300
> From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
>
> Many Nokia handsets support a Phonet interface to the cellular modem
> via a vendor-specific USB interface. CDC Phonet follows the
> Communications Device Class model, with one control interface, and
> and a pair of inactive and active data alternative interface. The later
> has two bulk endpoint, one per direction.
>
> This was tested against Nokia E61, Nokia N95, and the existing Phonet
> gadget function for the Linux composite USB gadget framework.
>
> Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Applied, thanks.
^ permalink raw reply
* Re: [1/1] connector maintainer/mail update.
From: David Miller @ 2009-07-21 19:44 UTC (permalink / raw)
To: zbr; +Cc: akpm, vapier.adi, netdev
In-Reply-To: <20090718142533.GA1948@ioremap.net>
From: Evgeniy Polyakov <zbr@ioremap.net>
Date: Sat, 18 Jul 2009 18:25:33 +0400
> Signed-off-by: Evgeniy Polyakov <zbr@ioremap.net>
Applied, thanks.
^ permalink raw reply
* Re: [1/4 v2] Remove unused zero-copy code from velocity NIC driver.
From: Dave Jones @ 2009-07-21 19:44 UTC (permalink / raw)
To: David Miller; +Cc: netdev
In-Reply-To: <20090721.123322.118453668.davem@davemloft.net>
On Tue, Jul 21, 2009 at 12:33:22PM -0700, David Miller wrote:
> >> David it still doesn't apply....
> >>
> >> Try to apply this using GIT to net-next-2.6, it won't go.
> >
> > Sorry, PEBKAC....
>
> Ok, all applied to net-next-2.6, thanks.
Phew, I was hella confused for a moment ;-)
thanks !
Dave
^ permalink raw reply
* PATCH: veth: Zero timestamp in xmit path.
From: Ben Greear @ 2009-07-21 19:46 UTC (permalink / raw)
To: NetDev
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
This patch zero's the timestamp before handing the packet to
the peer interface. This lets the peer recalculate the rx timestamp
if it cares about timestamps.
The patch is against net-next, compile tested there. Similar patch was
functionally tested against 2.6.31-rc3.
Signed-Off-By: Ben Greear<greearb@candelatech.com>
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index f1d753d..190f784 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -171,6 +171,7 @@ static int veth_xmit(struct sk_buff *skb, struct net_device *dev)
if (skb->len > (rcv->mtu + MTU_PAD))
goto rx_drop;
+ skb->tstamp.tv64 = 0;
skb->pkt_type = PACKET_HOST;
skb->protocol = eth_type_trans(skb, rcv);
if (dev->features & NETIF_F_NO_CSUM)
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
[-- Attachment #2: veth_ts.patch --]
[-- Type: text/plain, Size: 422 bytes --]
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index f1d753d..190f784 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -171,6 +171,7 @@ static int veth_xmit(struct sk_buff *skb, struct net_device *dev)
if (skb->len > (rcv->mtu + MTU_PAD))
goto rx_drop;
+ skb->tstamp.tv64 = 0;
skb->pkt_type = PACKET_HOST;
skb->protocol = eth_type_trans(skb, rcv);
if (dev->features & NETIF_F_NO_CSUM)
^ permalink raw reply related
* Re: PATCH: veth: Zero timestamp in xmit path.
From: David Miller @ 2009-07-21 19:51 UTC (permalink / raw)
To: greearb; +Cc: netdev
In-Reply-To: <4A661B2F.7000608@candelatech.com>
From: Ben Greear <greearb@candelatech.com>
Date: Tue, 21 Jul 2009 12:46:55 -0700
> This patch zero's the timestamp before handing the packet to
> the peer interface. This lets the peer recalculate the rx timestamp
> if it cares about timestamps.
>
> The patch is against net-next, compile tested there. Similar patch
> was
> functionally tested against 2.6.31-rc3.
>
>
> Signed-Off-By: Ben Greear<greearb@candelatech.com>
Oh, where to begin... sigh...
The "off" and "by" in "Signed-off-by" is not capitalized.
There should not be two spaces after the Signed-off-by colon, there
should be only one.
There should be a space between your name and your <> enclosed email
address.
> @@ -171,6 +171,7 @@ static int veth_xmit(struct sk_buff *skb, struct
> net_device *dev)
Your email client corrupted the patch by splitting up this line.
This is all just being sloppy, and it shows a lack of care put
into your submission.
Nevertheless I'm a sucker and I fixed this all up and applied your
patch.
^ permalink raw reply
* Re: [PATCH 0/4] inet6: minor cleanups
From: David Miller @ 2009-07-21 19:57 UTC (permalink / raw)
To: gerrit; +Cc: netdev
In-Reply-To: <1248027819-23959-1-git-send-email-gerrit@erg.abdn.ac.uk>
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Sun, 19 Jul 2009 20:23:35 +0200
> This is a small set of minor-cleanup patches, found while
> studying the tclass code.
>
> Patch #1: Unifies return convention of datagram_send_ctl().
OK.
> Patch #2: Consolidates cmsg code for Traffic Class / Hop Limit.
You delete the 'addr_type' variable but that's rediculious.
The name of the variable describes what is held in it, now
that value gets stored in 'val' which makes the code harder
to read and understand.
I'm not applying this, it's noise, and on top of that it's
bad noise and makes the code worse.
> Patch #3: Simplifies assignments from u8 to int (no conversion).
OK.
> Patch #4: Finds that RT_TOS() redefines IPTOS_TOS().
This macro probably exists so that if the ipv4 route cache entry TOS
representation changes compared to IPTOS_TOS(), we would simply have
to change the definition of this macro.
Just because they happen to be the same now is no reason to kill off
this macro I think.
I'm not applying this either.
^ permalink raw reply
* Re: Kernel oops on setting sky2 interfaces down
From: Rene Mayrhofer @ 2009-07-21 19:59 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, Richard Leitner
In-Reply-To: <20090721095853.30f4fbda@nehalam>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Stephen Hemminger wrote:
> Looks like the device is disappearing from the PCI bus when
> brought down. Can you reproduce it with 2.6.30.2 or 2.6.31-rc3?
>
> Try later kernels.
This is, as mentioned in my initial email, unfortunately not an option
until later kernel support squashfs-lzma again. These embedded
appliances boot from compact flash with the root FS in squashfs.
The question probably is if newer sky2 module sources would compile and
work with 2.6.28.10. Is this expected to work?
Rene
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkpmHjIACgkQq7SPDcPCS95QPwCdHoFXzDWKJVc7ZX5pfGvGq0JB
q6AAnR633XVUQA0DlVDObSKLGvBIJ6nM
=drfT
-----END PGP SIGNATURE-----
^ permalink raw reply
* Re: [PATCH 4/10] drivers/net: Move a dereference below a NULL test
From: David Miller @ 2009-07-21 20:01 UTC (permalink / raw)
To: julia; +Cc: eilong, netdev, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0907191726140.16542@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Sun, 19 Jul 2009 17:26:35 +0200 (CEST)
> From: Julia Lawall <julia@diku.dk>
>
> If the NULL test is necessary, then the dereference should be moved below
> the NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: [PATCH] drivers/net/mlx4: Adjust constant
From: David Miller @ 2009-07-21 20:01 UTC (permalink / raw)
To: julia; +Cc: netdev, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0907191809050.16542@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Sun, 19 Jul 2009 18:09:25 +0200 (CEST)
> From: Julia Lawall <julia@diku.dk>
>
> The values in the advertising field are typically ADVERTISED_xxx, not
> SUPPORTED_xxx. Both SUPPORTED_10000baseT_Full and
> ADVERTISED_1000baseT_Full have the same value.
>
> The semantic match that finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: [PATCH 10/10, corrected diffstat] drivers/net: Move a dereference below a NULL test
From: David Miller @ 2009-07-21 20:01 UTC (permalink / raw)
To: julia; +Cc: netdev, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0907191812010.16542@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Sun, 19 Jul 2009 18:13:04 +0200 (CEST)
> From: Julia Lawall <julia@diku.dk>
>
> If the NULL test is necessary, then the dereferences should be moved below
> the NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: PATCH: veth: Zero timestamp in xmit path.
From: Ben Greear @ 2009-07-21 20:02 UTC (permalink / raw)
To: David Miller; +Cc: netdev
In-Reply-To: <20090721.125155.168882282.davem@davemloft.net>
On 07/21/2009 12:51 PM, David Miller wrote:
> From: Ben Greear<greearb@candelatech.com>
> Date: Tue, 21 Jul 2009 12:46:55 -0700
>
>> This patch zero's the timestamp before handing the packet to
>> the peer interface. This lets the peer recalculate the rx timestamp
>> if it cares about timestamps.
>>
>> The patch is against net-next, compile tested there. Similar patch
>> was
>> functionally tested against 2.6.31-rc3.
>>
>>
>> Signed-Off-By: Ben Greear<greearb@candelatech.com>
>
> Oh, where to begin... sigh...
>
> The "off" and "by" in "Signed-off-by" is not capitalized.
>
> There should not be two spaces after the Signed-off-by colon, there
> should be only one.
>
> There should be a space between your name and your<> enclosed email
> address.
I had no idea that was so important.
>
>> @@ -171,6 +171,7 @@ static int veth_xmit(struct sk_buff *skb, struct
>> net_device *dev)
>
> Your email client corrupted the patch by splitting up this line.
>
> This is all just being sloppy, and it shows a lack of care put
> into your submission.
I sent as attachment as well to help mitigate this. If sending only
an attachment is better, I will do so next time.
> Nevertheless I'm a sucker and I fixed this all up and applied your
> patch.
As always, your forbearance is appreciated!
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox