* Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34
From: Andrew Hendry @ 2010-07-09 0:48 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, Maciej Rutecki, Andrew Morton,
Linus Torvalds, Kernel Testers List, Network Development,
Linux ACPI, Linux PM List, Linux SCSI List, Linux Wireless List,
DRI
In-Reply-To: <-IGZ64uxA6G.A.P0H.bLmNMB@chimera>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16175
Subject : 2.6.35-rc1 system oom, many processes killed but
memory not free
Submitter : andrew hendry <andrew.hendry@gmail.com>
Date : 2010-06-05 0:46 (34 days old)
Message-ID : <AANLkTim7CiW-yfugZUAHZCqLvXKgt9CwolCvbLGdCLAk@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127569877714937&w=2
Can be put down to bad ramdisk settings > actual memory, its probably
not a regression.
I think it can be closed for now, i'll do some testing and see if
ramdisk should complain before letting such configuration go through.
On Fri, Jul 9, 2010 at 9:33 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> This message contains a list of some regressions from 2.6.34,
> for which there are no fixes in the mainline known to the tracking team.
> If any of them have been fixed already, please let us know.
>
> If you know of any other unresolved regressions from 2.6.34, please let us
> know either and we'll add them to the list. Also, please let us know
> if any of the entries below are invalid.
>
> Each entry from the list will be sent additionally in an automatic reply
> to this message with CCs to the people involved in reporting and handling
> the issue.
>
>
> Listed regressions statistics:
>
> Date Total Pending Unresolved
> ----------------------------------------
> 2010-07-09 79 45 37
> 2010-06-21 46 37 26
> 2010-06-09 15 13 10
>
>
> Unresolved regressions
> ----------------------
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16353
> Subject : 2.6.35 regression
> Submitter : Zeev Tarantov <zeev.tarantov@gmail.com>
> Date : 2010-07-05 13:04 (4 days old)
> Message-ID : <loom.20100705T144459-919@post.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127836002702522&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16346
> Subject : 2.6.35-rc3-git8 - include/linux/fdtable.h:88 invoked rcu_dereference_check() without protection!
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-07-04 22:04 (5 days old)
> Message-ID : <AANLkTinof0k28rk4rMr66aubxcRL2rFa5ZEArj1lqD3o@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127828107815930&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16337
> Subject : general protection fault: 0000 [#1] SMP
> Submitter : Justin P. Mattock <justinmattock@gmail.com>
> Date : 2010-07-03 22:59 (6 days old)
> Message-ID : <4C2FC0E3.6050101@gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127819798215589&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16334
> Subject : reiserfs locking (v2)
> Submitter : Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Date : 2010-07-02 9:34 (7 days old)
> Message-ID : <20100702093451.GA3973@swordfish.minsk.epam.com>
> References : http://marc.info/?l=linux-kernel&m=127806306303590&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16333
> Subject : iwl3945: HARDWARE GONE??
> Submitter : Priit Laes <plaes@plaes.org>
> Date : 2010-07-02 16:02 (7 days old)
> Message-ID : <1278086575.2889.8.camel@chi>
> References : http://marc.info/?l=linux-kernel&m=127808659705983&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16332
> Subject : Kernel crashes in tty code (tty_open)
> Submitter : werner@guyane.yi.org
> Date : 2010-07-02 3:34 (7 days old)
> Message-ID : <1278041650.12788@guyane.yi.org>
> References : http://marc.info/?l=linux-kernel&m=127804167511930&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16330
> Subject : Dynamic Debug broken on 2.6.35-rc3?
> Submitter : Thomas Renninger <trenn@suse.de>
> Date : 2010-07-01 15:44 (8 days old)
> Message-ID : <201007011744.19564.trenn@suse.de>
> References : http://marc.info/?l=linux-kernel&m=127799907218877&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16329
> Subject : 2.6.35-rc3: Load average climbing to 3+ with no apparent reason: CPU 98% idle, with hardly no I/O
> Submitter : Török Edwin <edwintorok@gmail.com>
> Date : 2010-07-01 7:40 (8 days old)
> Message-ID : <20100701104022.404410d6@debian>
> References : http://marc.info/?l=linux-kernel&m=127797005030536&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16324
> Subject : Oops while running fs_racer test on a POWER6 box against latest git
> Submitter : divya <dipraksh@linux.vnet.ibm.com>
> Date : 2010-06-30 11:34 (9 days old)
> Message-ID : <4C2B28F3.7000006@linux.vnet.ibm.com>
> References : http://marc.info/?l=linux-kernel&m=127789697303061&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16323
> Subject : 2.6.35-rc3-git4 - kernel/sched.c:616 invoked rcu_dereference_check() without protection!
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-07-01 12:21 (8 days old)
> Message-ID : <AANLkTini6hz2LFeZi8CMUmY3xw1MU7NxmyesuxZ4oCdo@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127798693125541&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16322
> Subject : WARNING: at /arch/x86/include/asm/processor.h:1005 read_measured_perf_ctrs+0x5a/0x70()
> Submitter : boris64 <bugzilla.kernel.org@boris64.net>
> Date : 2010-07-01 13:54 (8 days old)
> Handled-By : H. Peter Anvin <hpa@zytor.com>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16312
> Subject : WARNING: at fs/fs-writeback.c:1127 __mark_inode_dirty
> Submitter : Zdenek Kabelac <zdenek.kabelac@gmail.com>
> Date : 2010-06-28 9:40 (11 days old)
> Message-ID : <AANLkTin24fr5O4_q5Xbo9Y_NKkEmtcp6Hgmr9_4qXaFz@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127771804806465&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16311
> Subject : [REGRESSION][SUSPEND] 2.6.35-rcX won't suspend Lenovo W500 laptop
> Submitter : Shawn Starr <shawn.starr@rogers.com>
> Date : 2010-06-28 0:45 (11 days old)
> Message-ID : <201006272045.17004.shawn.starr@rogers.com>
> References : http://marc.info/?l=linux-kernel&m=127768633705286&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16309
> Subject : 2.6.35-rc3 oops trying to suspend.
> Submitter : Andrew Hendry <andrew.hendry@gmail.com>
> Date : 2010-06-27 12:40 (12 days old)
> Message-ID : <AANLkTinUH2p33-AWxOVDrLsNkn9rgEVrlwn5mfK7P8NH@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127764249926781&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16307
> Subject : i915 in kernel 2.6.35-rc3, high number of wakeups
> Submitter : Enrico Bandiello <enban@postal.uv.es>
> Date : 2010-06-26 16:57 (13 days old)
> Message-ID : <4C26317A.5070309@postal.uv.es>
> References : http://marc.info/?l=linux-kernel&m=127757403404259&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16306
> Subject : 2.6.35-rc3 BUG: unable to handle kernel NULL pointer dereference at 0000000000000048 cifs_show_options
> Submitter : Andrew Hendry <andrew.hendry@gmail.com>
> Date : 2010-06-26 10:46 (13 days old)
> Message-ID : <AANLkTilhTrEBYZd4HxeXQk8B6-yV8rCJ2C0jXsEREgIR@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127754922110501&w=2
> Handled-By : Jeff Layton <jlayton@redhat.com>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16304
> Subject : i915 - high number of wakeups
> Submitter : Enrico Bandiello <enban@postal.uv.es>
> Date : 2010-06-27 09:52 (12 days old)
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16294
> Subject : [Q35 bisected] hang at init of i915 driver
> Submitter : Kees Cook <kees@outflux.net>
> Date : 2010-06-25 18:20 (14 days old)
> First-Bad-Commit: http://git.kernel.org/linus/f1befe71fa7a79ab733011b045639d8d809924ad
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16288
> Subject : kernel panic with iwlagn for Intel Wifi Link 5100
> Submitter : <yanshuang.zheng@intel.com>
> Date : 2010-06-25 08:14 (14 days old)
> Handled-By : Reinette Chatre <reinette.chatre@intel.com>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16284
> Subject : Hitting WARN_ON in hw_breakpoint code
> Submitter : Paul Mackerras <paulus@samba.org>
> Date : 2010-06-23 12:57 (16 days old)
> Message-ID : <20100623125740.GA3368@brick.ozlabs.ibm.com>
> References : http://marc.info/?l=linux-kernel&m=127729789113432&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16265
> Subject : Why is kslowd accumulating so much CPU time?
> Submitter : Theodore Ts'o <tytso@mit.edu>
> Date : 2010-06-09 18:36 (30 days old)
> First-Bad-Commit: http://git.kernel.org/linus/fbf81762e385d3d45acad057b654d56972acf58c
> Message-ID : <E1OMQ88-0002a1-Gb@closure.thunk.org>
> References : http://marc.info/?l=linux-kernel&m=127610857819033&w=4
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16257
> Subject : sysfs changes break hwsim and bnep drivers
> Submitter : Johannes Berg <johannes@sipsolutions.net>
> Date : 2010-06-20 11:23 (19 days old)
> References : http://thread.gmane.org/gmane.linux.network/162754
> Handled-By : Eric W. Biederman <ebiederm@xmission.com>
> Kay Sievers <kay.sievers@vrfy.org>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16234
> Subject : [2.6.35-rc3] reboot mutex 'bug'...
> Submitter : Daniel J Blueman <daniel.blueman@gmail.com>
> Date : 2010-06-14 15:16 (25 days old)
> Message-ID : <AANLkTimDcTnyEPmt2ZcCM1UWtn4AYKotiqyjobJApkO7@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127652861118933&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16230
> Subject : inconsistent IN-HARDIRQ-W -> HARDIRQ-ON-W usage: fasync, 2.6.35-rc3
> Submitter : Dominik Brodowski <linux@dominikbrodowski.net>
> Date : 2010-06-13 9:53 (26 days old)
> Message-ID : <20100613095305.GA13231@comet.dominikbrodowski.net>
> References : http://marc.info/?l=linux-kernel&m=127642282208277&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16228
> Subject : BUG/boot failure on Dell Precision T3500 (pci/ahci_stop_engine)
> Submitter : Brian Bloniarz <phunge0@hotmail.com>
> Date : 2010-06-16 17:57 (23 days old)
> Handled-By : Bjorn Helgaas <bjorn.helgaas@hp.com>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16221
> Subject : 2.6.35-rc2-git5 -- [drm:drm_mode_getfb] *ERROR* invalid framebuffer id
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-06-11 20:31 (28 days old)
> Message-ID : <AANLkTim0jVRyqkwlGOcrg_XTvUQwcBYfWJX-aRzkkrLG@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127628828119623&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16205
> Subject : acpi: freeing invalid memtype bf799000-bf79a000
> Submitter : Marcin Slusarz <marcin.slusarz@gmail.com>
> Date : 2010-06-09 20:09 (30 days old)
> Message-ID : <20100609200910.GA2876@joi.lan>
> References : http://marc.info/?l=linux-kernel&m=127611427029914&w=2
> http://marc.info/?l=linux-kernel&m=127688398513862&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16201
> Subject : SIOCGIWFREQ ioctl fails to get frequency info
> Submitter : nuh <nuh@mailinator.net>
> Date : 2010-06-14 10:45 (25 days old)
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16199
> Subject : 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked rcu_dereference_check() without protection!
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-06-07 18:14 (32 days old)
> Message-ID : <AANLkTin2pPqOUx--9fIX3BH3e-cU6oCRufijcx_4ozx5@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127593447812015&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16197
> Subject : [BUG on 2.6.35-rc2] sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:11.0/0000:02:03.0/slot'
> Submitter : Ryan Wang <openspace.wang@gmail.com>
> Date : 2010-06-07 0:23 (32 days old)
> Message-ID : <AANLkTincwMZPnYW3S4uz4k2GOn52RpgBIBRfzyD010Yo@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127587022219378&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16187
> Subject : Carrier detection failed in dhcpcd when link is up
> Submitter : Christian Casteyde <casteyde.christian@free.fr>
> Date : 2010-06-12 15:15 (27 days old)
> First-Bad-Commit: http://git.kernel.org/linus/10708f37ae729baba9b67bd134c3720709d4ae62
> Handled-By : Andrew Morton <akpm@linux-foundation.org>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16184
> Subject : Container, X86-64, i386, iptables rule
> Submitter : Jean-Marc Pigeon <jmp@safe.ca>
> Date : 2010-06-12 04:17 (27 days old)
> Handled-By : Patrick McHardy <kaber@trash.net>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16179
> Subject : 2.6.35-rc2 completely hosed on intel gfx?
> Submitter : Norbert Preining <preining@logic.at>
> Date : 2010-06-06 11:55 (33 days old)
> Message-ID : <20100606115534.GA9399@gamma.logic.tuwien.ac.at>
> References : http://marc.info/?l=linux-kernel&m=127582534931581&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16175
> Subject : 2.6.35-rc1 system oom, many processes killed but memory not free
> Submitter : andrew hendry <andrew.hendry@gmail.com>
> Date : 2010-06-05 0:46 (34 days old)
> Message-ID : <AANLkTim7CiW-yfugZUAHZCqLvXKgt9CwolCvbLGdCLAk@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127569877714937&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16173
> Subject : After uncompressing the kernel, at boot time, the server hangs.
> Submitter : David Hill <hilld@binarystorm.net>
> Date : 2010-06-09 23:25 (30 days old)
> First-Bad-Commit: http://git.kernel.org/linus/cf7500c0ea133d66f8449d86392d83f840102632
> Handled-By : Eric W. Biederman <ebiederm@xmission.com>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16145
> Subject : Unable to boot unless "notsc" or "clocksource=hpet", or acpi_pad disabling the TSC
> Submitter : Tom Gundersen <teg@jklm.no>
> Date : 2010-06-07 13:11 (32 days old)
> Handled-By : Venkatesh Pallipadi <venki@google.com>
> Len Brown <lenb@kernel.org>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16122
> Subject : 2.6.35-rc1: WARNING at fs/fs-writeback.c:1142 __mark_inode_dirty+0x103/0x170
> Submitter : Larry Finger <Larry.Finger@lwfinger.net>
> Date : 2010-06-04 13:18 (35 days old)
> Handled-By : Jens Axboe <axboe@kernel.dk>
>
>
> Regressions with patches
> ------------------------
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16310
> Subject : arm omap invalid module format
> Submitter : Robert Nelson <robertcnelson@gmail.com>
> Date : 2010-06-28 17:30 (11 days old)
> First-Bad-Commit: http://git.kernel.org/linus/d0679c730395d0bde9a46939e7ba255b4ba7dd7c
> Handled-By : Michal Marek <mmarek@suse.cz>
> Patch : https://bugzilla.kernel.org/attachment.cgi?id=26999
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16278
> Subject : lvm snapshot causes deadlock in 2.6.35
> Submitter : Phillip Susi <psusi@cfl.rr.com>
> Date : 2010-06-23 16:55 (16 days old)
> Handled-By : Eric Sandeen <sandeen@redhat.com>
> Patch : https://bugzilla.kernel.org/attachment.cgi?id=26933
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16271
> Subject : 2.6.35-rc3 regression: IBM Maia system is unbootable [ACPI related?]
> Submitter : James Bottomley <James.Bottomley@hansenpartnership.com>
> Date : 2010-06-21 16:03 (18 days old)
> Message-ID : <1277136189.10998.63.camel@mulgrave.site>
> References : http://marc.info/?l=linux-kernel&m=127713622821166&w=2
> Handled-By : Len Brown <len.brown@intel.com>
> Patch : https://patchwork.kernel.org/patch/108497/
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16256
> Subject : tpm_tis breaks suspend/hibernate on kernels > 2.6.34
> Submitter : Helmut Schaa <helmut.schaa@googlemail.com>
> Date : 2010-06-20 11:15 (19 days old)
> First-Bad-Commit: http://git.kernel.org/linus/225a9be24d799aa16d543c31fb09f0c9ed1d9caa
> Handled-By : Helmut Schaa <helmut.schaa@googlemail.com>
> Patch : http://marc.info/?l=tpmdd-devel&m=127609160616162&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16255
> Subject : 2.6.35-rc3 deadlocks on semaphore operations
> Submitter : Christoph Lameter <cl@linux-foundation.org>
> Date : 2010-06-18 14:49 (21 days old)
> Message-ID : <alpine.DEB.2.00.1006180940140.11575@router.home>
> References : http://marc.info/?l=linux-kernel&m=127687262727707&w=2
> Handled-By : Manfred Spraul <manfred@colorfullife.com>
> Patch : http://marc.info/?l=linux-kernel&m=127731055203402&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16232
> Subject : 2.6.35-rc3 - WARNING:iwl_set_dynamic_key
> Submitter : Mario Guenterberg <mario.guenterberg@googlemail.com>
> Date : 2010-06-14 11:55 (25 days old)
> Message-ID : <20100614115510.GA7904@guenti-laptop>
> References : http://marc.info/?l=linux-kernel&m=127651695627147&w=2
> Handled-By : Reinette Chatre <reinette.chatre@intel.com>
> Patch : http://article.gmane.org/gmane.linux.kernel.wireless.general/52893
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16215
> Subject : sysfs: cannot create duplicate filename '/class/net/bnep0'
> Submitter : Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
> Date : 2010-06-15 14:55 (24 days old)
> Handled-By : Eric W. Biederman <ebiederm@xmission.com>
> Patch : https://bugzilla.kernel.org/show_bug.cgi?id=16215#c10
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16169
> Subject : Complain from preemptive debug
> Submitter : Sedat Dilek <sedat.dilek@googlemail.com>
> Date : 2010-05-31 10:10 (39 days old)
> Message-ID : <AANLkTilTnAAZIizKinYsxFkNTkrmPqk6XJJuUjjhJ7EP@mail.gmail.com>
> References : http://lkml.org/lkml/2010/5/31/77
> Handled-By : Dmitry Monakhov <dmonakhov@openvz.org>
> Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Patch : http://www.spinics.net/lists/cpufreq/msg01631.html
> https://patchwork.kernel.org/patch/106555/
>
>
> For details, please visit the bug entries and follow the links given in
> references.
>
> As you can see, there is a Bugzilla entry for each of the listed regressions.
> There also is a Bugzilla entry used for tracking the regressions from 2.6.34,
> unresolved as well as resolved, at:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=16055
>
> Please let the tracking team know if there are any Bugzilla entries that
> should be added to the list in there.
>
> Thanks!
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply
* Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34
From: Linus Torvalds @ 2010-07-09 1:34 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Jens Axboe, DRI, Linux SCSI List, Patrick McHardy,
Network Development, Linux Wireless List,
Linux Kernel Mailing List, Jesse Barnes, David S. Miller,
Linux ACPI, Al Viro, Frederic Weisbecker, Dave Airlie,
Andrew Morton, Kernel Testers List, Shawn Starr, Linux PM List,
Maciej Rutecki
In-Reply-To: <-IGZ64uxA6G.A.P0H.bLmNMB@chimera>
On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>
> Unresolved regressions
> ----------------------
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16353
> Subject : 2.6.35 regression
> Submitter : Zeev Tarantov <zeev.tarantov@gmail.com>
> Date : 2010-07-05 13:04 (4 days old)
> Message-ID : <loom.20100705T144459-919@post.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127836002702522&w=2
This is a gcc-4.5 issue. Whether it's also something that we should
change in the kernel is unclear, but at least as of now, the rule is
that you cannot compile the kernel with gcc-4.5. No idea whether the
compiler is just entirely broken, or whether it's just that it
triggers something iffy by being overly clever.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16346
> Subject : 2.6.35-rc3-git8 - include/linux/fdtable.h:88 invoked rcu_dereference_check() without protection!
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-07-04 22:04 (5 days old)
> Message-ID : <AANLkTinof0k28rk4rMr66aubxcRL2rFa5ZEArj1lqD3o@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127828107815930&w=2
I'm not entirely sure if these RCU proving things should count as regressions.
Sure, the option to enable RCU proving is new, but the things it
reports about generally are not new - and they are usually not even
bugs in the sense that they necessarily cause any real problems.
That particular one is in the single-thread optimizated case for fget_light, ie
if (likely((atomic_read(&files->count) == 1))) {
file = fcheck_files(files, fd);
where I think it should be entirely safe in all ways without any
locking. So I think it's a false positive too.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16334
> Subject : reiserfs locking (v2)
> Submitter : Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Date : 2010-07-02 9:34 (7 days old)
> Message-ID : <20100702093451.GA3973@swordfish.minsk.epam.com>
> References : http://marc.info/?l=linux-kernel&m=127806306303590&w=2
Frederic? Al? I assume this is some late fallout from the BKL removal
ages ago.. It's the old filldir-vs-mmap crud, but normally it should
be impossible to trigger because the inode for a directory should
never be mmap'able, so we should never have the same i_mutex lock used
for both mmap and for filldir protection.
We saw some of that oddity long ago, I wonder if it's lockdep being
confused about some inodes.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16333
> Subject : iwl3945: HARDWARE GONE??
> Submitter : Priit Laes <plaes@plaes.org>
> Date : 2010-07-02 16:02 (7 days old)
> Message-ID : <1278086575.2889.8.camel@chi>
> References : http://marc.info/?l=linux-kernel&m=127808659705983&w=2
This either got fixed, or will be practically impossible to debug. The
reporter ends up being unable to reproduce the issue.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16332
> Subject : Kernel crashes in tty code (tty_open)
> Submitter : werner@guyane.yi.org
> Date : 2010-07-02 3:34 (7 days old)
> Message-ID : <1278041650.12788@guyane.yi.org>
> References : http://marc.info/?l=linux-kernel&m=127804167511930&w=2
This seems to be due to CONFIG_MRST (Moorestown).
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16330
> Subject : Dynamic Debug broken on 2.6.35-rc3?
> Submitter : Thomas Renninger <trenn@suse.de>
> Date : 2010-07-01 15:44 (8 days old)
> Message-ID : <201007011744.19564.trenn@suse.de>
> References : http://marc.info/?l=linux-kernel&m=127799907218877&w=2
There's a suggested patch in
http://marc.info/?l=linux-kernel&m=127862524404291&w=2
but no reply to it yet.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16329
> Subject : 2.6.35-rc3: Load average climbing to 3+ with no apparent reason: CPU 98% idle, with hardly no I/O
> Submitter : Török Edwin <edwintorok@gmail.com>
> Date : 2010-07-01 7:40 (8 days old)
> Message-ID : <20100701104022.404410d6@debian>
> References : http://marc.info/?l=linux-kernel&m=127797005030536&w=2
This seems to be partly a confusion about what "load average" is. It's
not a CPU load, it's a system load average, and disk-wait processes
count towards it. He has some problem with his CD-ROM, and it sounds
like it might be hardware on the verge of going bad.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16324
> Subject : Oops while running fs_racer test on a POWER6 box against latest git
> Submitter : divya <dipraksh@linux.vnet.ibm.com>
> Date : 2010-06-30 11:34 (9 days old)
> Message-ID : <4C2B28F3.7000006@linux.vnet.ibm.com>
> References : http://marc.info/?l=linux-kernel&m=127789697303061&w=2
I wonder if this is the writeback problem. That POWER crash dump is
unreadable, so it's hard to tell, but the load in question makes that
at least likely.
If so, it should hopefully be fixed in today's git (commit
83ba7b071f30f7c01f72518ad72d5cd203c27502 and friends).
> Bug-entry : http://bugzilla.kernel.org/show_bug.cgi?id=16323
> Subject : 2.6.35-rc3-git4 - kernel/sched.c:616 invoked rcu_dereference_check() without protection!
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-07-01 12:21 (8 days old)
> Message-ID : <AANLkTini6hz2LFeZi8CMUmY3xw1MU7NxmyesuxZ4oCdo@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127798693125541&w=2
See earlier about these being marked as regressions, but it should be
fixed by commit dc61b1d6 ("sched: Fix PROVE_RCU vs cpu_cgroup").
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16322
> Subject : WARNING: at /arch/x86/include/asm/processor.h:1005 read_measured_perf_ctrs+0x5a/0x70()
> Submitter : boris64 <bugzilla.kernel.org@boris64.net>
> Date : 2010-07-01 13:54 (8 days old)
> Handled-By : H. Peter Anvin <hpa@zytor.com>
Magic. Strange and dark magic.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16311
> Subject : [REGRESSION][SUSPEND] 2.6.35-rcX won't suspend Lenovo W500 laptop
> Submitter : Shawn Starr <shawn.starr@rogers.com>
> Date : 2010-06-28 0:45 (11 days old)
> Message-ID : <201006272045.17004.shawn.starr@rogers.com>
> References : http://marc.info/?l=linux-kernel&m=127768633705286&w=2
I think this might be usefully bisected. Shawn?
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16309
> Subject : 2.6.35-rc3 oops trying to suspend.
> Submitter : Andrew Hendry <andrew.hendry@gmail.com>
> Date : 2010-06-27 12:40 (12 days old)
> Message-ID : <AANLkTinUH2p33-AWxOVDrLsNkn9rgEVrlwn5mfK7P8NH@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127764249926781&w=2
I'm pretty sure this was fixed by Nick in commit 57439f878afa ("fs:
fix superblock iteration race").
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16307
> Subject : i915 in kernel 2.6.35-rc3, high number of wakeups
> Submitter : Enrico Bandiello <enban@postal.uv.es>
> Date : 2010-06-26 16:57 (13 days old)
> Message-ID : <4C26317A.5070309@postal.uv.es>
> References : http://marc.info/?l=linux-kernel&m=127757403404259&w=2
I don't think anybody noticed this one. Jesse?
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16304
> Subject : i915 - high number of wakeups
> Submitter : Enrico Bandiello <enban@postal.uv.es>
> Date : 2010-06-27 09:52 (12 days old)
Duplicate of that 16307 one.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16284
> Subject : Hitting WARN_ON in hw_breakpoint code
> Submitter : Paul Mackerras <paulus@samba.org>
> Date : 2010-06-23 12:57 (16 days old)
> Message-ID : <20100623125740.GA3368@brick.ozlabs.ibm.com>
> References : http://marc.info/?l=linux-kernel&m=127729789113432&w=2
This has "I have a fix, will post it very soon." in the thread from
Frederic, but I'm not seeing anything else. Frederic?
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16265
> Subject : Why is kslowd accumulating so much CPU time?
> Submitter : Theodore Ts'o <tytso@mit.edu>
> Date : 2010-06-09 18:36 (30 days old)
> First-Bad-Commit: http://git.kernel.org/linus/fbf81762e385d3d45acad057b654d56972acf58c
> Message-ID : <E1OMQ88-0002a1-Gb@closure.thunk.org>
> References : http://marc.info/?l=linux-kernel&m=127610857819033&w=4
Dave, Jesse?
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16234
> Subject : [2.6.35-rc3] reboot mutex 'bug'...
> Submitter : Daniel J Blueman <daniel.blueman@gmail.com>
> Date : 2010-06-14 15:16 (25 days old)
> Message-ID : <AANLkTimDcTnyEPmt2ZcCM1UWtn4AYKotiqyjobJApkO7@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127652861118933&w=2
Ok, this is definitely harmless. Whether we should silence the warning
somehow is a separate question.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16230
> Subject : inconsistent IN-HARDIRQ-W -> HARDIRQ-ON-W usage: fasync, 2.6.35-rc3
> Submitter : Dominik Brodowski <linux@dominikbrodowski.net>
> Date : 2010-06-13 9:53 (26 days old)
> Message-ID : <20100613095305.GA13231@comet.dominikbrodowski.net>
> References : http://marc.info/?l=linux-kernel&m=127642282208277&w=2
Fixed by commit f4985dc714d7.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16228
> Subject : BUG/boot failure on Dell Precision T3500 (pci/ahci_stop_engine)
> Submitter : Brian Bloniarz <phunge0@hotmail.com>
> Date : 2010-06-16 17:57 (23 days old)
> Handled-By : Bjorn Helgaas <bjorn.helgaas@hp.com>
This has a butt-ugly suggested patch that certainly won't be applied.
I saw the thread, but lost sight of it. Jesse, did that end up with
some resolution?
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16221
> Subject : 2.6.35-rc2-git5 -- [drm:drm_mode_getfb] *ERROR* invalid framebuffer id
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-06-11 20:31 (28 days old)
> Message-ID : <AANLkTim0jVRyqkwlGOcrg_XTvUQwcBYfWJX-aRzkkrLG@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127628828119623&w=2
I dunno. Old, and apparently seen by two people. Dave?
Might be helped by bisection.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16205
> Subject : acpi: freeing invalid memtype bf799000-bf79a000
> Submitter : Marcin Slusarz <marcin.slusarz@gmail.com>
> Date : 2010-06-09 20:09 (30 days old)
> Message-ID : <20100609200910.GA2876@joi.lan>
> References : http://marc.info/?l=linux-kernel&m=127611427029914&w=2
> http://marc.info/?l=linux-kernel&m=127688398513862&w=2
This should be fixed by commit b945d6b2554d ("rbtree: Undo augmented
trees performance damage and regression").
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16199
> Subject : 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked rcu_dereference_check() without protection!
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-06-07 18:14 (32 days old)
> Message-ID : <AANLkTin2pPqOUx--9fIX3BH3e-cU6oCRufijcx_4ozx5@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127593447812015&w=2
Another RCU proving thing. And this one looks the same as the 16323
one above, and fixed by the same commit as that one.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16197
> Subject : [BUG on 2.6.35-rc2] sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:11.0/0000:02:03.0/slot'
> Submitter : Ryan Wang <openspace.wang@gmail.com>
> Date : 2010-06-07 0:23 (32 days old)
> Message-ID : <AANLkTincwMZPnYW3S4uz4k2GOn52RpgBIBRfzyD010Yo@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127587022219378&w=2
These should all be gone. See commit 3be434f0244ee by Jesse ('Revert
"PCI: create function symlinks in /sys/bus/pci/slots/N/"').
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16187
> Subject : Carrier detection failed in dhcpcd when link is up
> Submitter : Christian Casteyde <casteyde.christian@free.fr>
> Date : 2010-06-12 15:15 (27 days old)
> First-Bad-Commit: http://git.kernel.org/linus/10708f37ae729baba9b67bd134c3720709d4ae62
> Handled-By : Andrew Morton <akpm@linux-foundation.org>
David? This bisects to a networking commit. Doesn't look sensible, but
what do I know?
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16184
> Subject : Container, X86-64, i386, iptables rule
> Submitter : Jean-Marc Pigeon <jmp@safe.ca>
> Date : 2010-06-12 04:17 (27 days old)
> Handled-By : Patrick McHardy <kaber@trash.net>
Patrick, Davem? Ping?
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16179
> Subject : 2.6.35-rc2 completely hosed on intel gfx?
> Submitter : Norbert Preining <preining@logic.at>
> Date : 2010-06-06 11:55 (33 days old)
> Message-ID : <20100606115534.GA9399@gamma.logic.tuwien.ac.at>
> References : http://marc.info/?l=linux-kernel&m=127582534931581&w=2
Hmm. That one is the vt.c bug coupled with another problem, which in
turn got opened as a separate bugzilla entry:
http://bugzilla.kernel.org/show_bug.cgi?id=16252
which in turn then got closed. I dunno.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16175
> Subject : 2.6.35-rc1 system oom, many processes killed but memory not free
> Submitter : andrew hendry <andrew.hendry@gmail.com>
> Date : 2010-06-05 0:46 (34 days old)
> Message-ID : <AANLkTim7CiW-yfugZUAHZCqLvXKgt9CwolCvbLGdCLAk@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127569877714937&w=2
Not a regression or a kernel bug at all. See the thread. Big ramdisk
filled up all of memory when it was filled by the builds.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16145
> Subject : Unable to boot unless "notsc" or "clocksource=hpet", or acpi_pad disabling the TSC
> Submitter : Tom Gundersen <teg@jklm.no>
> Date : 2010-06-07 13:11 (32 days old)
> Handled-By : Venkatesh Pallipadi <venki@google.com>
> Len Brown <lenb@kernel.org>
This is not a regression. See the full bugzilla details. The same
problem persists at least back to 2.6.30 with his config. So it's
somehow specific to his particular config use that requires "notsc" to
boot.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16122
> Subject : 2.6.35-rc1: WARNING at fs/fs-writeback.c:1142 __mark_inode_dirty+0x103/0x170
> Submitter : Larry Finger <Larry.Finger@lwfinger.net>
> Date : 2010-06-04 13:18 (35 days old)
> Handled-By : Jens Axboe <axboe@kernel.dk>
This looks like a duplicate of that 16312 bugzilla entry. Jens, has
this been resolved?
Linus
^ permalink raw reply
* linux-next: manual merge of the wireless tree with the net tree
From: Stephen Rothwell @ 2010-07-09 1:51 UTC (permalink / raw)
To: John W. Linville
Cc: linux-next, linux-kernel, Luciano Coelho, Eric Dumazet,
David Miller, netdev
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
Hi John,
Today's linux-next merge of the wireless tree got a conflict in
drivers/net/wireless/wl12xx/wl1271_cmd.h between commit
ba2d3587912f82d1ab4367975b1df460db60fb1e ("drivers/net: use __packed
annotation") from the net tree and commit
34dd2aaac4a4b908c093980a9894fd878aeb6deb ("wl1271: moved scan operations
to a separate file") from the wireless tree.
I didn't bother changing __attribute((packed)) to __packed where this
code has been moved to. Maybe someone could write a patch to do that ...
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply
* Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34
From: Frederic Weisbecker @ 2010-07-09 2:04 UTC (permalink / raw)
To: Linus Torvalds
Cc: Rafael J. Wysocki, Linux Kernel Mailing List, Maciej Rutecki,
Andrew Morton, Kernel Testers List, Network Development,
Linux ACPI, Linux PM List, Linux SCSI List, Linux Wireless List,
DRI, Al Viro, Shawn Starr, Jesse Barnes, Dave Airlie,
David S. Miller, Patrick McHardy, Jens Axboe
In-Reply-To: <AANLkTiknnzWyVpqnPCpyiEVHLgkewd0zaGzLInABRe2G-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, Jul 08, 2010 at 06:34:25PM -0700, Linus Torvalds wrote:
> On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki <rjw-KKrjLPT3xs0@public.gmane.org> wrote:
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16284
> > Subject : Hitting WARN_ON in hw_breakpoint code
> > Submitter : Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> > Date : 2010-06-23 12:57 (16 days old)
> > Message-ID : <20100623125740.GA3368-oklZEfemRj05kJ7NmlRacFaTQe2KTcn/@public.gmane.org>
> > References : http://marc.info/?l=linux-kernel&m=127729789113432&w=2
>
> This has "I have a fix, will post it very soon." in the thread from
> Frederic, but I'm not seeing anything else. Frederic?
Right. In fact it wasn't a regression. The per task breakpoint reservation
design was broken from the beginning and this warning has revealed the
problem. This only touched perf, and it did since perf support breakpoints.
Fortunately ptrace wasn't concerned by this problem, even not by side effects
of this.
The fix is invasive as it's a rewrite of a (little) part of the breakpoint
reservation. And since the symptom is only a warning and also breakpoints
never released from the constraint table (just a counter, no memory leak),
the fix is headed for 2.6.36.
It is ready in tip:/perf/core:
http://git.kernel.org/?p=linux/kernel/git/tip/linux-2.6-tip.git;a=commitdiff;h=45a73372efe4a63f44aa2e1125d4a777c2fdc8d8
I think this ticket can be safely closed.
Thanks.
^ permalink raw reply
* Re: [PATCH linux-2.6.35-rc3] ks8842 driver
From: Simon Horman @ 2010-07-09 2:40 UTC (permalink / raw)
To: Choi, David; +Cc: netdev, Li, Charles
In-Reply-To: <C43529A246480145B0A6D0234BDB0F0D481D67@MELANITE.micrel.com>
On Thu, Jul 08, 2010 at 12:01:51PM -0700, Choi, David wrote:
> Hi Simon,
>
> Thank you for your comments.
>
> The original ks8842 driver is designed to work on the customized bus
> interface based on an FPGA. This patch is intended to address the more
> commonly used generic bus interface available on the majority of SoC in
> the market.
>
> It is unlikely that for a system to use both FPGA based and generic bus
> interface for ks8842, I am quite certain that those 2 devices are used
> mutual exclusively.
Hi David,
Understood, in that case I think that using #ifdef is reasonable.
Though to my mind it would be nicer to try and abstract it out,
as you have in the first hunk, to something of the form:
foo()
{
A
#ifdef CONFIG_MICREL_KS884X
B
#else
C
#endif
D
}
And then call foo() unconditionally.
I think this is cleaner than, for example ks8842_rx_frame()
where there are several instances of the same #ifdef condition.
>
> Regards,
> David J. Choi
>
>
> -----Original Message-----
> From: Simon Horman [mailto:horms@verge.net.au]
> Sent: Thursday, July 08, 2010 12:53 AM
> To: Choi, David
> Cc: netdev@vger.kernel.org; Li, Charles
> Subject: Re: [PATCH linux-2.6.35-rc3] ks8842 driver
>
> On Wed, Jul 07, 2010 at 08:24:33AM -0700, Choi, David wrote:
> > To whom it may have concerned,
> >
> > It seems that there are differences between Micrel ks8842 device and
> Timberdale FPGA based device with generic bus interface. In order to
> check the differences, I have sent several times but have not received
> any response. This patch is to support ks8841/ks8842 device from Micrel.
>
> Is it desirable that the code can never be compiled to work with both
> devices?
> Is this code likely to be included in a generic/distro kernel?
>
> >
> > From: David J. Choi <david.choi@micrel.com>
> >
> > Body of the explanation:
> > -support 16bit and 32bit bus width.
> > -add device reset for ks8842/8841 Micrel device.
> > -set 100Mbps as a default for Micrel device.
> > -set MAC address in both MAC/Switch layer with different sequence
> for Micrel device,
> > as mentioned in data sheet.
> >
> > Signed-off-by: David J. Choi <david.choi@micrel.com>
> >
> > ---
> > --- linux-2.6.35-rc3/drivers/net/ks8842.c.orig 2010-07-01
> 16:26:50.000000000 -0700
> > +++ linux-2.6.35-rc3/drivers/net/ks8842.c 2010-07-07
> 07:41:03.000000000 -0700
> > @@ -18,6 +18,7 @@
> >
> > /* Supports:
> > * The Micrel KS8842 behind the timberdale FPGA
> > + * The genuine Micrel KS8841/42 device with ISA 16/32bit bus
> interface
> > */
> >
> > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > @@ -191,6 +192,12 @@ static inline u32 ks8842_read32(struct k
> >
> > static void ks8842_reset(struct ks8842_adapter *adapter)
> > {
> > +#ifdef CONFIG_MICREL_KS884X
> > + ks8842_write16(adapter, 3, 1, REG_GRR);
> > + msleep(10);
> > + iowrite16(0, adapter->hw_addr + REG_GRR);
> > +
> > +#else
> > /* The KS8842 goes haywire when doing softare reset
> > * a work around in the timberdale IP is implemented to
> > * do a hardware reset instead
> > @@ -201,6 +208,7 @@ static void ks8842_reset(struct ks8842_a
> > iowrite16(32, adapter->hw_addr + REG_SELECT_BANK);
> > iowrite32(0x1, adapter->hw_addr + REG_TIMB_RST);
> > msleep(20);
> > +#endif
> > }
> >
> > static void ks8842_update_link_status(struct net_device *netdev,
> > @@ -269,8 +277,11 @@ static void ks8842_reset_hw(struct ks884
> >
> > /* restart port auto-negotiation */
> > ks8842_enable_bits(adapter, 49, 1 << 13, REG_P1CR4);
> > +
> > +#ifndef CONFIG_MICREL_KS884X
> > /* only advertise 10Mbps */
> > ks8842_clear_bits(adapter, 49, 3 << 2, REG_P1CR4);
> > +#endif
> >
> > /* Enable the transmitter */
> > ks8842_enable_tx(adapter);
> > @@ -296,6 +307,20 @@ static void ks8842_read_mac_addr(struct
> > for (i = 0; i < ETH_ALEN; i++)
> > dest[ETH_ALEN - i - 1] = ks8842_read8(adapter, 2,
> REG_MARL + i);
> >
> > +#ifdef CONFIG_MICREL_KS884X
> > + /*
> > + the sequence of saving mac addr between MAC and Switch
> is
> > + different.
> > + */
> > +
> > + mac = ks8842_read16(adapter, 2, REG_MARL);
> > + ks8842_write16(adapter, 39, mac, REG_MACAR3);
> > + mac = ks8842_read16(adapter, 2, REG_MARM);
> > + ks8842_write16(adapter, 39, mac, REG_MACAR2);
> > + mac = ks8842_read16(adapter, 2, REG_MARH);
> > + ks8842_write16(adapter, 39, mac, REG_MACAR1);
> > +#else
> > +
> > /* make sure the switch port uses the same MAC as the QMU */
> > mac = ks8842_read16(adapter, 2, REG_MARL);
> > ks8842_write16(adapter, 39, mac, REG_MACAR1);
> > @@ -303,6 +328,7 @@ static void ks8842_read_mac_addr(struct
> > ks8842_write16(adapter, 39, mac, REG_MACAR2);
> > mac = ks8842_read16(adapter, 2, REG_MARH);
> > ks8842_write16(adapter, 39, mac, REG_MACAR3);
> > +#endif
> > }
> >
> > static void ks8842_write_mac_addr(struct ks8842_adapter *adapter, u8
> *mac)
> > @@ -313,8 +339,13 @@ static void ks8842_write_mac_addr(struct
> > spin_lock_irqsave(&adapter->lock, flags);
> > for (i = 0; i < ETH_ALEN; i++) {
> > ks8842_write8(adapter, 2, mac[ETH_ALEN - i - 1],
> REG_MARL + i);
> > +#ifdef CONFIG_MICREL_KS884X
> > + ks8842_write8(adapter, 39, mac[ETH_ALEN - i - 1],
> > + REG_MACAR3 + 1 - i);
> > +#else
> > ks8842_write8(adapter, 39, mac[ETH_ALEN - i - 1],
> > REG_MACAR1 + i);
> > +#endif
> > }
> > spin_unlock_irqrestore(&adapter->lock, flags);
> > }
> > @@ -328,8 +359,12 @@ static int ks8842_tx_frame(struct sk_buf
> > {
> > struct ks8842_adapter *adapter = netdev_priv(netdev);
> > int len = skb->len;
> > +#ifdef CONFIG_KS884X_16BIT
> > + u16 *ptr16 = (u16 *)skb->data;
> > +#else
> > u32 *ptr = (u32 *)skb->data;
> > u32 ctrl;
> > +#endif
> >
> > dev_dbg(&adapter->pdev->dev,
> > "%s: len %u head %p data %p tail %p end %p\n",
> > @@ -340,6 +375,18 @@ static int ks8842_tx_frame(struct sk_buf
> > if (ks8842_tx_fifo_space(adapter) < len + 8)
> > return NETDEV_TX_BUSY;
> >
> > +#ifdef CONFIG_KS884X_16BIT
> > + ks8842_write16(adapter, 17, 0x8000 | 0x100, REG_QMU_DATA_LO);
> > + ks8842_write16(adapter, 17, (u16)len, REG_QMU_DATA_HI);
> > + netdev->stats.tx_bytes += len;
> > +
> > + /* copy buffer */
> > + while (len > 0) {
> > + iowrite16(*ptr16++, adapter->hw_addr + REG_QMU_DATA_LO);
> > + iowrite16(*ptr16++, adapter->hw_addr + REG_QMU_DATA_HI);
> > + len -= sizeof(u32);
> > + }
> > +#else
> > /* the control word, enable IRQ, port 1 and the length */
> > ctrl = 0x8000 | 0x100 | (len << 16);
> > ks8842_write32(adapter, 17, ctrl, REG_QMU_DATA_LO);
> > @@ -352,6 +399,7 @@ static int ks8842_tx_frame(struct sk_buf
> > len -= sizeof(u32);
> > ptr++;
> > }
> > +#endif
> >
> > /* enqueue packet */
> > ks8842_write16(adapter, 17, 1, REG_TXQCR);
> > @@ -364,10 +412,15 @@ static int ks8842_tx_frame(struct sk_buf
> > static void ks8842_rx_frame(struct net_device *netdev,
> > struct ks8842_adapter *adapter)
> > {
> > +#ifdef CONFIG_KS884X_16BIT
> > + u16 status = ks8842_read16(adapter, 17, REG_QMU_DATA_LO);
> > + int len = (int)ks8842_read16(adapter, 17, REG_QMU_DATA_HI) &
> 0xffff;
> > +#else
> > u32 status = ks8842_read32(adapter, 17, REG_QMU_DATA_LO);
> > int len = (status >> 16) & 0x7ff;
> >
> > status &= 0xffff;
> > +#endif
> >
> > dev_dbg(&adapter->pdev->dev, "%s - rx_data: status: %x\n",
> > __func__, status);
> > @@ -379,13 +432,28 @@ static void ks8842_rx_frame(struct net_d
> > dev_dbg(&adapter->pdev->dev, "%s, got package, len:
> %d\n",
> > __func__, len);
> > if (skb) {
> > +#ifdef CONFIG_KS884X_16BIT
> > + u16 *data16;
> > +#else
> > u32 *data;
> > +#endif
> >
> > netdev->stats.rx_packets++;
> > netdev->stats.rx_bytes += len;
> > if (status & RXSR_MULTICAST)
> > netdev->stats.multicast++;
> >
> > +#ifdef CONFIG_KS884X_16BIT
> > + data16 = (u16 *)skb_put(skb, len);
> > + ks8842_select_bank(adapter, 17);
> > + while (len > 0) {
> > + *data16++ = ioread16(adapter->hw_addr +
> > + REG_QMU_DATA_LO);
> > + *data16++ = ioread16(adapter->hw_addr +
> > + REG_QMU_DATA_HI);
> > + len -= sizeof(u32);
> > + }
> > +#else
> > data = (u32 *)skb_put(skb, len);
> >
> > ks8842_select_bank(adapter, 17);
> > @@ -397,6 +465,7 @@ static void ks8842_rx_frame(struct net_d
> >
> > skb->protocol = eth_type_trans(skb, netdev);
> > netif_rx(skb);
> > +#endif
> > } else
> > netdev->stats.rx_dropped++;
> > } else {
> > --- linux-2.6.35-rc3/drivers/net/Kconfig.orig 2010-07-02
> 15:52:41.000000000 -0700
> > +++ linux-2.6.35-rc3/drivers/net/Kconfig 2010-07-07
> 07:45:47.000000000 -0700
> > @@ -1748,11 +1748,29 @@ config TLAN
> > Please email feedback to <torben.mathiasen@compaq.com>.
> >
> > config KS8842
> > - tristate "Micrel KSZ8842"
> > + tristate "Micrel KSZ8841/42 with generic bus interface"
> > depends on HAS_IOMEM
> > help
> > - This platform driver is for Micrel KSZ8842 / KS8842
> > - 2-port ethernet switch chip (managed, VLAN, QoS).
> > + This platform driver is for KSZ8841(1-port) / KS8842(2-port)
> > + ethernet switch chip (managed, VLAN, QoS) from Micrel or
> > + Timberdale(FPGA).
> > +
> > +if KS8842
> > +config MICREL_KS884X
> > + boolean "KSZ8841/42 device from Micrel"
> > + default n
> > + help
> > + Say Y to use Micrel device. Otherwise Timberdale(FPGA) device
> is
> > + selected.
> > +
> > +config KS884X_16BIT
> > + boolean "16bit bus width"
> > + default y
> > + help
> > + This option specifies 16bit or 32bit bus interface. Say Y to
> use
> > + 16bit bus. Otherwise 32bit bus is selected.
> > +
> > +endif # KS8842
> >
> > config KS8851
> > tristate "Micrel KS8851 SPI"
> > ---
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34
From: Frederic Weisbecker @ 2010-07-09 2:56 UTC (permalink / raw)
To: Linus Torvalds
Cc: Rafael J. Wysocki, Linux Kernel Mailing List, Maciej Rutecki,
Andrew Morton, Kernel Testers List, Network Development,
Linux ACPI, Linux PM List, Linux SCSI List, Linux Wireless List,
DRI, Al Viro, Shawn Starr, Jesse Barnes, Dave Airlie,
David S. Miller, Patrick McHardy, Jens Axboe
In-Reply-To: <AANLkTiknnzWyVpqnPCpyiEVHLgkewd0zaGzLInABRe2G@mail.gmail.com>
On Thu, Jul 08, 2010 at 06:34:25PM -0700, Linus Torvalds wrote:
> On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16334
> > Subject : reiserfs locking (v2)
> > Submitter : Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Date : 2010-07-02 9:34 (7 days old)
> > Message-ID : <20100702093451.GA3973@swordfish.minsk.epam.com>
> > References : http://marc.info/?l=linux-kernel&m=127806306303590&w=2
>
> Frederic? Al? I assume this is some late fallout from the BKL removal
> ages ago.. It's the old filldir-vs-mmap crud, but normally it should
> be impossible to trigger because the inode for a directory should
> never be mmap'able, so we should never have the same i_mutex lock used
> for both mmap and for filldir protection.
>
> We saw some of that oddity long ago, I wonder if it's lockdep being
> confused about some inodes.
I think it has been there from the beginning. At least it was there before
the reiserfs bkl removal in .32.
Indeed the readdir <-> unmap/release inversion problem can not happen.
But Al said that can happen between write and release. (Although I don't see
where write takes the inode mutex).
He also highlighted the fact that reiserfs refcounting based on i_count
was totally broken.
He has a fix the whole in the vfs tree, in the for-next branch on commit
6c2bdaf089a3876226893fab00dd83596c465ad2
"Fix reiserfs_file_release()"
No more uses of the i_mutex on release after that, nor i_count, but a private
openers refcount and a tailpack mutex per reiserfs inode.
^ permalink raw reply
* Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34
From: Shawn Starr @ 2010-07-09 3:36 UTC (permalink / raw)
To: Linus Torvalds
Cc: Rafael J. Wysocki, Linux Kernel Mailing List, Maciej Rutecki,
Andrew Morton, Kernel Testers List, Network Development,
Linux ACPI, Linux PM List, Linux SCSI List, Linux Wireless List,
DRI, Frederic Weisbecker, Al Viro, Jesse Barnes, Dave Airlie,
David S. Miller, Patrick McHardy, Jens Axboe
In-Reply-To: <AANLkTiknnzWyVpqnPCpyiEVHLgkewd0zaGzLInABRe2G@mail.gmail.com>
On Thursday, July 08, 2010 09:34:25 pm Linus Torvalds wrote:
> On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > Unresolved regressions
> > ----------------------
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16353
> > Subject : 2.6.35 regression
> > Submitter : Zeev Tarantov <zeev.tarantov@gmail.com>
> > Date : 2010-07-05 13:04 (4 days old)
> > Message-ID : <loom.20100705T144459-919@post.gmane.org>
> > References : http://marc.info/?l=linux-kernel&m=127836002702522&w=2
>
> This is a gcc-4.5 issue. Whether it's also something that we should
> change in the kernel is unclear, but at least as of now, the rule is
> that you cannot compile the kernel with gcc-4.5. No idea whether the
> compiler is just entirely broken, or whether it's just that it
> triggers something iffy by being overly clever.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16346
> > Subject : 2.6.35-rc3-git8 - include/linux/fdtable.h:88 invoked
> > rcu_dereference_check() without protection! Submitter : Miles Lane
> > <miles.lane@gmail.com>
> > Date : 2010-07-04 22:04 (5 days old)
> > Message-ID :
> > <AANLkTinof0k28rk4rMr66aubxcRL2rFa5ZEArj1lqD3o@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=127828107815930&w=2
>
> I'm not entirely sure if these RCU proving things should count as
> regressions.
>
> Sure, the option to enable RCU proving is new, but the things it
> reports about generally are not new - and they are usually not even
> bugs in the sense that they necessarily cause any real problems.
>
> That particular one is in the single-thread optimizated case for
> fget_light, ie
>
> if (likely((atomic_read(&files->count) == 1))) {
> file = fcheck_files(files, fd);
>
> where I think it should be entirely safe in all ways without any
> locking. So I think it's a false positive too.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16334
> > Subject : reiserfs locking (v2)
> > Submitter : Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Date : 2010-07-02 9:34 (7 days old)
> > Message-ID : <20100702093451.GA3973@swordfish.minsk.epam.com>
> > References : http://marc.info/?l=linux-kernel&m=127806306303590&w=2
>
> Frederic? Al? I assume this is some late fallout from the BKL removal
> ages ago.. It's the old filldir-vs-mmap crud, but normally it should
> be impossible to trigger because the inode for a directory should
> never be mmap'able, so we should never have the same i_mutex lock used
> for both mmap and for filldir protection.
>
> We saw some of that oddity long ago, I wonder if it's lockdep being
> confused about some inodes.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16333
> > Subject : iwl3945: HARDWARE GONE??
> > Submitter : Priit Laes <plaes@plaes.org>
> > Date : 2010-07-02 16:02 (7 days old)
> > Message-ID : <1278086575.2889.8.camel@chi>
> > References : http://marc.info/?l=linux-kernel&m=127808659705983&w=2
>
> This either got fixed, or will be practically impossible to debug. The
> reporter ends up being unable to reproduce the issue.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16332
> > Subject : Kernel crashes in tty code (tty_open)
> > Submitter : werner@guyane.yi.org
> > Date : 2010-07-02 3:34 (7 days old)
> > Message-ID : <1278041650.12788@guyane.yi.org>
> > References : http://marc.info/?l=linux-kernel&m=127804167511930&w=2
>
> This seems to be due to CONFIG_MRST (Moorestown).
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16330
> > Subject : Dynamic Debug broken on 2.6.35-rc3?
> > Submitter : Thomas Renninger <trenn@suse.de>
> > Date : 2010-07-01 15:44 (8 days old)
> > Message-ID : <201007011744.19564.trenn@suse.de>
> > References : http://marc.info/?l=linux-kernel&m=127799907218877&w=2
>
> There's a suggested patch in
>
> http://marc.info/?l=linux-kernel&m=127862524404291&w=2
>
> but no reply to it yet.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16329
> > Subject : 2.6.35-rc3: Load average climbing to 3+ with no
> > apparent reason: CPU 98% idle, with hardly no I/O Submitter :
> > Török Edwin <edwintorok@gmail.com>
> > Date : 2010-07-01 7:40 (8 days old)
> > Message-ID : <20100701104022.404410d6@debian>
> > References : http://marc.info/?l=linux-kernel&m=127797005030536&w=2
>
> This seems to be partly a confusion about what "load average" is. It's
> not a CPU load, it's a system load average, and disk-wait processes
> count towards it. He has some problem with his CD-ROM, and it sounds
> like it might be hardware on the verge of going bad.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16324
> > Subject : Oops while running fs_racer test on a POWER6 box
> > against latest git Submitter : divya <dipraksh@linux.vnet.ibm.com>
> > Date : 2010-06-30 11:34 (9 days old)
> > Message-ID : <4C2B28F3.7000006@linux.vnet.ibm.com>
> > References : http://marc.info/?l=linux-kernel&m=127789697303061&w=2
>
> I wonder if this is the writeback problem. That POWER crash dump is
> unreadable, so it's hard to tell, but the load in question makes that
> at least likely.
>
> If so, it should hopefully be fixed in today's git (commit
> 83ba7b071f30f7c01f72518ad72d5cd203c27502 and friends).
>
> > Bug-entry : http://bugzilla.kernel.org/show_bug.cgi?id=16323
> > Subject : 2.6.35-rc3-git4 - kernel/sched.c:616 invoked
> > rcu_dereference_check() without protection! Submitter : Miles Lane
> > <miles.lane@gmail.com>
> > Date : 2010-07-01 12:21 (8 days old)
> > Message-ID :
> > <AANLkTini6hz2LFeZi8CMUmY3xw1MU7NxmyesuxZ4oCdo@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=127798693125541&w=2
>
> See earlier about these being marked as regressions, but it should be
> fixed by commit dc61b1d6 ("sched: Fix PROVE_RCU vs cpu_cgroup").
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16322
> > Subject : WARNING: at /arch/x86/include/asm/processor.h:1005
> > read_measured_perf_ctrs+0x5a/0x70() Submitter : boris64
> > <bugzilla.kernel.org@boris64.net>
> > Date : 2010-07-01 13:54 (8 days old)
> > Handled-By : H. Peter Anvin <hpa@zytor.com>
>
> Magic. Strange and dark magic.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16311
> > Subject : [REGRESSION][SUSPEND] 2.6.35-rcX won't suspend Lenovo
> > W500 laptop Submitter : Shawn Starr <shawn.starr@rogers.com>
> > Date : 2010-06-28 0:45 (11 days old)
> > Message-ID : <201006272045.17004.shawn.starr@rogers.com>
> > References : http://marc.info/?l=linux-kernel&m=127768633705286&w=2
>
> I think this might be usefully bisected. Shawn?
>
I'll have to try bisecting this weekend. It continues in Linux sh0n.net
2.6.35-rc4+ #1 SMP Wed Jul 7 23:58:41 EDT 2010 x86_64 x86_64 x86_64 GNU/Linux
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16309
> > Subject : 2.6.35-rc3 oops trying to suspend.
> > Submitter : Andrew Hendry <andrew.hendry@gmail.com>
> > Date : 2010-06-27 12:40 (12 days old)
> > Message-ID :
> > <AANLkTinUH2p33-AWxOVDrLsNkn9rgEVrlwn5mfK7P8NH@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=127764249926781&w=2
>
> I'm pretty sure this was fixed by Nick in commit 57439f878afa ("fs:
> fix superblock iteration race").
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16307
> > Subject : i915 in kernel 2.6.35-rc3, high number of wakeups
> > Submitter : Enrico Bandiello <enban@postal.uv.es>
> > Date : 2010-06-26 16:57 (13 days old)
> > Message-ID : <4C26317A.5070309@postal.uv.es>
> > References : http://marc.info/?l=linux-kernel&m=127757403404259&w=2
>
> I don't think anybody noticed this one. Jesse?
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16304
> > Subject : i915 - high number of wakeups
> > Submitter : Enrico Bandiello <enban@postal.uv.es>
> > Date : 2010-06-27 09:52 (12 days old)
>
> Duplicate of that 16307 one.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16284
> > Subject : Hitting WARN_ON in hw_breakpoint code
> > Submitter : Paul Mackerras <paulus@samba.org>
> > Date : 2010-06-23 12:57 (16 days old)
> > Message-ID : <20100623125740.GA3368@brick.ozlabs.ibm.com>
> > References : http://marc.info/?l=linux-kernel&m=127729789113432&w=2
>
> This has "I have a fix, will post it very soon." in the thread from
> Frederic, but I'm not seeing anything else. Frederic?
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16265
> > Subject : Why is kslowd accumulating so much CPU time?
> > Submitter : Theodore Ts'o <tytso@mit.edu>
> > Date : 2010-06-09 18:36 (30 days old)
> > First-Bad-Commit:
> > http://git.kernel.org/linus/fbf81762e385d3d45acad057b654d56972acf58c
> > Message-ID : <E1OMQ88-0002a1-Gb@closure.thunk.org>
> > References : http://marc.info/?l=linux-kernel&m=127610857819033&w=4
>
> Dave, Jesse?
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16234
> > Subject : [2.6.35-rc3] reboot mutex 'bug'...
> > Submitter : Daniel J Blueman <daniel.blueman@gmail.com>
> > Date : 2010-06-14 15:16 (25 days old)
> > Message-ID :
> > <AANLkTimDcTnyEPmt2ZcCM1UWtn4AYKotiqyjobJApkO7@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=127652861118933&w=2
>
> Ok, this is definitely harmless. Whether we should silence the warning
> somehow is a separate question.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16230
> > Subject : inconsistent IN-HARDIRQ-W -> HARDIRQ-ON-W usage:
> > fasync, 2.6.35-rc3 Submitter : Dominik Brodowski
> > <linux@dominikbrodowski.net> Date : 2010-06-13 9:53 (26 days
> > old)
> > Message-ID : <20100613095305.GA13231@comet.dominikbrodowski.net>
> > References : http://marc.info/?l=linux-kernel&m=127642282208277&w=2
>
> Fixed by commit f4985dc714d7.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16228
> > Subject : BUG/boot failure on Dell Precision T3500
> > (pci/ahci_stop_engine) Submitter : Brian Bloniarz
> > <phunge0@hotmail.com>
> > Date : 2010-06-16 17:57 (23 days old)
> > Handled-By : Bjorn Helgaas <bjorn.helgaas@hp.com>
>
> This has a butt-ugly suggested patch that certainly won't be applied.
> I saw the thread, but lost sight of it. Jesse, did that end up with
> some resolution?
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16221
> > Subject : 2.6.35-rc2-git5 -- [drm:drm_mode_getfb] *ERROR* invalid
> > framebuffer id Submitter : Miles Lane <miles.lane@gmail.com>
> > Date : 2010-06-11 20:31 (28 days old)
> > Message-ID :
> > <AANLkTim0jVRyqkwlGOcrg_XTvUQwcBYfWJX-aRzkkrLG@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=127628828119623&w=2
>
> I dunno. Old, and apparently seen by two people. Dave?
>
> Might be helped by bisection.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16205
> > Subject : acpi: freeing invalid memtype bf799000-bf79a000
> > Submitter : Marcin Slusarz <marcin.slusarz@gmail.com>
> > Date : 2010-06-09 20:09 (30 days old)
> > Message-ID : <20100609200910.GA2876@joi.lan>
> > References : http://marc.info/?l=linux-kernel&m=127611427029914&w=2
> > http://marc.info/?l=linux-kernel&m=127688398513862&w=2
>
> This should be fixed by commit b945d6b2554d ("rbtree: Undo augmented
> trees performance damage and regression").
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16199
> > Subject : 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked
> > rcu_dereference_check() without protection! Submitter : Miles Lane
> > <miles.lane@gmail.com>
> > Date : 2010-06-07 18:14 (32 days old)
> > Message-ID :
> > <AANLkTin2pPqOUx--9fIX3BH3e-cU6oCRufijcx_4ozx5@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=127593447812015&w=2
>
> Another RCU proving thing. And this one looks the same as the 16323
> one above, and fixed by the same commit as that one.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16197
> > Subject : [BUG on 2.6.35-rc2] sysfs: cannot create duplicate
> > filename '/devices/pci0000:00/0000:00:11.0/0000:02:03.0/slot' Submitter
> > : Ryan Wang <openspace.wang@gmail.com>
> > Date : 2010-06-07 0:23 (32 days old)
> > Message-ID :
> > <AANLkTincwMZPnYW3S4uz4k2GOn52RpgBIBRfzyD010Yo@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=127587022219378&w=2
>
> These should all be gone. See commit 3be434f0244ee by Jesse ('Revert
> "PCI: create function symlinks in /sys/bus/pci/slots/N/"').
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16187
> > Subject : Carrier detection failed in dhcpcd when link is up
> > Submitter : Christian Casteyde <casteyde.christian@free.fr>
> > Date : 2010-06-12 15:15 (27 days old)
> > First-Bad-Commit:
> > http://git.kernel.org/linus/10708f37ae729baba9b67bd134c3720709d4ae62
> > Handled-By : Andrew Morton <akpm@linux-foundation.org>
>
> David? This bisects to a networking commit. Doesn't look sensible, but
> what do I know?
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16184
> > Subject : Container, X86-64, i386, iptables rule
> > Submitter : Jean-Marc Pigeon <jmp@safe.ca>
> > Date : 2010-06-12 04:17 (27 days old)
> > Handled-By : Patrick McHardy <kaber@trash.net>
>
> Patrick, Davem? Ping?
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16179
> > Subject : 2.6.35-rc2 completely hosed on intel gfx?
> > Submitter : Norbert Preining <preining@logic.at>
> > Date : 2010-06-06 11:55 (33 days old)
> > Message-ID : <20100606115534.GA9399@gamma.logic.tuwien.ac.at>
> > References : http://marc.info/?l=linux-kernel&m=127582534931581&w=2
>
> Hmm. That one is the vt.c bug coupled with another problem, which in
> turn got opened as a separate bugzilla entry:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=16252
>
> which in turn then got closed. I dunno.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16175
> > Subject : 2.6.35-rc1 system oom, many processes killed but memory
> > not free Submitter : andrew hendry <andrew.hendry@gmail.com>
> > Date : 2010-06-05 0:46 (34 days old)
> > Message-ID :
> > <AANLkTim7CiW-yfugZUAHZCqLvXKgt9CwolCvbLGdCLAk@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=127569877714937&w=2
>
> Not a regression or a kernel bug at all. See the thread. Big ramdisk
> filled up all of memory when it was filled by the builds.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16145
> > Subject : Unable to boot unless "notsc" or "clocksource=hpet", or
> > acpi_pad disabling the TSC Submitter : Tom Gundersen <teg@jklm.no>
> > Date : 2010-06-07 13:11 (32 days old)
> > Handled-By : Venkatesh Pallipadi <venki@google.com>
> > Len Brown <lenb@kernel.org>
>
> This is not a regression. See the full bugzilla details. The same
> problem persists at least back to 2.6.30 with his config. So it's
> somehow specific to his particular config use that requires "notsc" to
> boot.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16122
> > Subject : 2.6.35-rc1: WARNING at fs/fs-writeback.c:1142
> > __mark_inode_dirty+0x103/0x170 Submitter : Larry Finger
> > <Larry.Finger@lwfinger.net>
> > Date : 2010-06-04 13:18 (35 days old)
> > Handled-By : Jens Axboe <axboe@kernel.dk>
>
> This looks like a duplicate of that 16312 bugzilla entry. Jens, has
> this been resolved?
>
> Linus
^ permalink raw reply
* Re: [PATCH 1/1] Bluetooth: hidp: Add support for hidraw HIDIOCGFEATURE and HIDIOCSFEATURE
From: Alan Ott @ 2010-07-09 3:51 UTC (permalink / raw)
To: Marcel Holtmann
Cc: David S Miller, Jiri Kosina, Michael Poole, Bastien Nocera,
Eric Dumazet, linux-bluetooth-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <1278623485.10421.73.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
On 07/08/2010 05:11 PM, Marcel Holtmann wrote:
> I looked at this and I am bit worried that this should not be done in
> this detail in the HIDP driver. Essentially HIDP is a pure transport
> driver. It should not handle all these details. Can we make this a bit
> easier for the transport drivers to support such features?
>
> Regards
>
> Marcel
>
Hi Marcel,
I put these changes (most notably the addition of hidp_get_raw_report())
in hidp because that's where the parallel function
hidp_output_raw_report() was already located. I figured the input should
go with the output. That said, if there's a better place for both of
them (input and output) to go, let me know where you think it should be,
and I'll get them moved into the proper spot.
I'm not sure what you mean about HIDP being a pure transport driver.
Alan.
^ permalink raw reply
* Re: [PATCH net-next-2.6 1/2] net: Get rid of rtnl_link_stats64 / net_device_stats union
From: Eric Dumazet @ 2010-07-09 4:25 UTC (permalink / raw)
To: Ben Hutchings; +Cc: David Miller, netdev, linux-net-drivers
In-Reply-To: <1278631762.16013.307.camel@achroite.uk.solarflarecom.com>
Le vendredi 09 juillet 2010 à 00:29 +0100, Ben Hutchings a écrit :
> In commit be1f3c2c027cc5ad735df6a45a542ed1db7ec48b "net: Enable 64-bit
> net device statistics on 32-bit architectures" I redefined struct
> net_device_stats so that it could be used in a union with struct
> rtnl_link_stats64, avoiding the need for explicit copying or
> conversion between the two. However, this is unsafe because there is
> no locking required and no lock consistently held around calls to
> dev_get_stats() and use of the statistics structure it returns.
>
> In commit 28172739f0a276eb8d6ca917b3974c2edb036da3 "net: fix 64 bit
> counters on 32 bit arches" Eric Dumazet dealt with that problem by
> requiring callers of dev_get_stats() to provide storage for the
> result. This means that the net_device::stats64 field and the padding
> in struct net_device_stats are now redundant, so remove them.
>
> Update the comment on net_device_ops::ndo_get_stats64 to reflect its
> new usage.
>
> Change dev_txq_stats_fold() to use struct rtnl_link_stats64, since
> that is what all its callers are really using and it is no longer
> going to be compatible with struct net_device_stats.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> drivers/net/macvlan.c | 2 +-
> include/linux/netdevice.h | 70 ++++++++++++++++++---------------------------
> net/8021q/vlan_dev.c | 2 +-
> net/core/dev.c | 19 +++++++++---
> 4 files changed, 44 insertions(+), 49 deletions(-)
>
> diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
> index 6112f14..1b28aae 100644
> --- a/drivers/net/macvlan.c
> +++ b/drivers/net/macvlan.c
> @@ -436,7 +436,7 @@ static struct rtnl_link_stats64 *macvlan_dev_get_stats64(struct net_device *dev,
> {
> struct macvlan_dev *vlan = netdev_priv(dev);
>
> - dev_txq_stats_fold(dev, (struct net_device_stats *)stats);
> + dev_txq_stats_fold(dev, stats);
>
> if (vlan->rx_stats) {
> struct macvlan_rx_stats *p, accum = {0};
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 8018f6b..17e95e3 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -162,42 +162,32 @@ static inline bool dev_xmit_complete(int rc)
> /*
> * Old network device statistics. Fields are native words
> * (unsigned long) so they can be read and written atomically.
> - * Each field is padded to 64 bits for compatibility with
> - * rtnl_link_stats64.
> */
>
> -#if BITS_PER_LONG == 64
> -#define NET_DEVICE_STATS_DEFINE(name) unsigned long name
> -#elif defined(__LITTLE_ENDIAN)
> -#define NET_DEVICE_STATS_DEFINE(name) unsigned long name, pad_ ## name
> -#else
> -#define NET_DEVICE_STATS_DEFINE(name) unsigned long pad_ ## name, name
> -#endif
> -
> struct net_device_stats {
> - NET_DEVICE_STATS_DEFINE(rx_packets);
> - NET_DEVICE_STATS_DEFINE(tx_packets);
> - NET_DEVICE_STATS_DEFINE(rx_bytes);
> - NET_DEVICE_STATS_DEFINE(tx_bytes);
> - NET_DEVICE_STATS_DEFINE(rx_errors);
> - NET_DEVICE_STATS_DEFINE(tx_errors);
> - NET_DEVICE_STATS_DEFINE(rx_dropped);
> - NET_DEVICE_STATS_DEFINE(tx_dropped);
> - NET_DEVICE_STATS_DEFINE(multicast);
> - NET_DEVICE_STATS_DEFINE(collisions);
> - NET_DEVICE_STATS_DEFINE(rx_length_errors);
> - NET_DEVICE_STATS_DEFINE(rx_over_errors);
> - NET_DEVICE_STATS_DEFINE(rx_crc_errors);
> - NET_DEVICE_STATS_DEFINE(rx_frame_errors);
> - NET_DEVICE_STATS_DEFINE(rx_fifo_errors);
> - NET_DEVICE_STATS_DEFINE(rx_missed_errors);
> - NET_DEVICE_STATS_DEFINE(tx_aborted_errors);
> - NET_DEVICE_STATS_DEFINE(tx_carrier_errors);
> - NET_DEVICE_STATS_DEFINE(tx_fifo_errors);
> - NET_DEVICE_STATS_DEFINE(tx_heartbeat_errors);
> - NET_DEVICE_STATS_DEFINE(tx_window_errors);
> - NET_DEVICE_STATS_DEFINE(rx_compressed);
> - NET_DEVICE_STATS_DEFINE(tx_compressed);
> + unsigned long rx_packets;
> + unsigned long tx_packets;
> + unsigned long rx_bytes;
> + unsigned long tx_bytes;
> + unsigned long rx_errors;
> + unsigned long tx_errors;
> + unsigned long rx_dropped;
> + unsigned long tx_dropped;
> + unsigned long multicast;
> + unsigned long collisions;
> + unsigned long rx_length_errors;
> + unsigned long rx_over_errors;
> + unsigned long rx_crc_errors;
> + unsigned long rx_frame_errors;
> + unsigned long rx_fifo_errors;
> + unsigned long rx_missed_errors;
> + unsigned long tx_aborted_errors;
> + unsigned long tx_carrier_errors;
> + unsigned long tx_fifo_errors;
> + unsigned long tx_heartbeat_errors;
> + unsigned long tx_window_errors;
> + unsigned long rx_compressed;
> + unsigned long tx_compressed;
> };
>
> #endif /* __KERNEL__ */
> @@ -666,14 +656,13 @@ struct netdev_rx_queue {
> * Callback uses when the transmitter has not made any progress
> * for dev->watchdog ticks.
> *
> - * struct rtnl_link_stats64* (*ndo_get_stats64)(struct net_device *dev
> + * struct rtnl_link_stats64* (*ndo_get_stats64)(struct net_device *dev,
> * struct rtnl_link_stats64 *storage);
> * struct net_device_stats* (*ndo_get_stats)(struct net_device *dev);
> * Called when a user wants to get the network device usage
> * statistics. Drivers must do one of the following:
> - * 1. Define @ndo_get_stats64 to update a rtnl_link_stats64 structure
> - * (which should normally be dev->stats64) and return a ponter to
> - * it. The structure must not be changed asynchronously.
> + * 1. Define @ndo_get_stats64 to fill in a zero-initialised
> + * rtnl_link_stats64 structure passed by the caller.
> * 2. Define @ndo_get_stats to update a net_device_stats structure
> * (which should normally be dev->stats) and return a pointer to
> * it. The structure may be changed asynchronously only if each
> @@ -888,10 +877,7 @@ struct net_device {
> int ifindex;
> int iflink;
>
> - union {
> - struct rtnl_link_stats64 stats64;
> - struct net_device_stats stats;
> - };
> + struct net_device_stats stats;
>
> #ifdef CONFIG_WIRELESS_EXT
> /* List of functions to handle Wireless Extensions (instead of ioctl).
> @@ -2147,7 +2133,7 @@ extern void dev_mcast_init(void);
> extern const struct rtnl_link_stats64 *dev_get_stats(struct net_device *dev,
> struct rtnl_link_stats64 *storage);
> extern void dev_txq_stats_fold(const struct net_device *dev,
> - struct net_device_stats *stats);
> + struct rtnl_link_stats64 *stats);
>
> extern int netdev_max_backlog;
> extern int netdev_tstamp_prequeue;
> diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
> index 7865a4c..e66c9bf 100644
> --- a/net/8021q/vlan_dev.c
> +++ b/net/8021q/vlan_dev.c
> @@ -805,7 +805,7 @@ static u32 vlan_ethtool_get_flags(struct net_device *dev)
>
> static struct rtnl_link_stats64 *vlan_dev_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats)
> {
> - dev_txq_stats_fold(dev, (struct net_device_stats *)stats);
> + dev_txq_stats_fold(dev, stats);
>
> if (vlan_dev_info(dev)->vlan_rx_stats) {
> struct vlan_rx_stats *p, accum = {0};
> diff --git a/net/core/dev.c b/net/core/dev.c
> index eb4201c..5ec2eec 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -5274,10 +5274,10 @@ void netdev_run_todo(void)
> /**
> * dev_txq_stats_fold - fold tx_queues stats
> * @dev: device to get statistics from
> - * @stats: struct net_device_stats to hold results
> + * @stats: struct rtnl_link_stats64 to hold results
> */
> void dev_txq_stats_fold(const struct net_device *dev,
> - struct net_device_stats *stats)
> + struct rtnl_link_stats64 *stats)
> {
> unsigned long tx_bytes = 0, tx_packets = 0, tx_dropped = 0;
> unsigned int i;
> @@ -5311,17 +5311,26 @@ const struct rtnl_link_stats64 *dev_get_stats(struct net_device *dev,
> struct rtnl_link_stats64 *storage)
> {
> const struct net_device_ops *ops = dev->netdev_ops;
> + size_t i, n = sizeof(*storage) / sizeof(u64);
> + u64 *stats64 = (u64 *)storage;
> + const unsigned long *stats;
>
> if (ops->ndo_get_stats64) {
> memset(storage, 0, sizeof(*storage));
> return ops->ndo_get_stats64(dev, storage);
> }
> +
> if (ops->ndo_get_stats) {
> - memcpy(storage, ops->ndo_get_stats(dev), sizeof(*storage));
> + stats = (const unsigned long *)ops->ndo_get_stats(dev);
> + for (i = 0; i < n; i++)
> + stats64[i] = stats[i];
This could be a small helper function, to hide the sizeof(*storage) /
sizeof(u64) magic..
static void stats_to_stats64(struct rtnl_link_stats64 *dst,
const net_device_stats *src)
{
#if BITS_PER_LONG == 64
BUILD_BUG_ON(sizeof(*dst) != sizeof(*src));
memcpy(dst, src, sizeof(*src));
#else
size_t i, n = sizeof(*dst) / sizeof(u64);
u64 *stats64 = (u64 *)dst;
const unsigned long *stats = (const unsigned long *)src;
BUILD_BUG_ON(sizeof(*src) != n * sizeof(unsigned long));
for (i = 0; i < n, i++)
stats64[i] = stats[i];
#endif
}
Thanks !
^ permalink raw reply
* Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34
From: David Miller @ 2010-07-09 4:34 UTC (permalink / raw)
To: torvalds; +Cc: rjw, linux-kernel, akpm, netdev, kaber, jengelh
In-Reply-To: <AANLkTiknnzWyVpqnPCpyiEVHLgkewd0zaGzLInABRe2G@mail.gmail.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Thu, 8 Jul 2010 18:34:25 -0700
> On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>>
>> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16187
>> Subject : Carrier detection failed in dhcpcd when link is up
>> Submitter : Christian Casteyde <casteyde.christian@free.fr>
>> Date : 2010-06-12 15:15 (27 days old)
>> First-Bad-Commit: http://git.kernel.org/linus/10708f37ae729baba9b67bd134c3720709d4ae62
>> Handled-By : Andrew Morton <akpm@linux-foundation.org>
>
> David? This bisects to a networking commit. Doesn't look sensible, but
> what do I know?
My suspicion is that dhcpd uses netlink to dump the info of the
available links, and due to some bug gets confused with the new 64-bit
statistic netlink attribute being there now.
That shouldn't happen, applications should just ignore the attributes
which they don't understand.
I'll try to find a second to have a look at this.
^ permalink raw reply
* Re: [RFC] gre: propagate ipv6 transport class
From: David Miller @ 2010-07-09 4:36 UTC (permalink / raw)
To: shemminger; +Cc: yoshfuji, herbert, netdev
In-Reply-To: <20100706105821.7b0e2538@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 6 Jul 2010 10:58:21 -0700
> This patch makes IPV6 over IPv4 GRE tunnel propagate the transport
> class field from the underlying IPV6 header to the IPV4 Type Of Service
> field. Without the patch, all IPV6 packets in tunnel look the same to QoS.
>
> This assumes that IPV6 transport class is exactly the same
> as IPv4 TOS. Not sure if that is always the case? Maybe need
> to mask off some bits.
>
> The mask and shift to get tclass is copied from ipv6/datagram.c
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Looks good, but we should use ipv6_get_dsfield() just like
ipgre_ecn_encapsulate() does.
Note that this also influences the route since this 'tos' feeds
into the flowi lookup key. We should make sure that this is OK
too.
Anyways, I've committed the following to net-next-2.6, thanks!
--------------------
gre: propagate ipv6 transport class
This patch makes IPV6 over IPv4 GRE tunnel propagate the transport
class field from the underlying IPV6 header to the IPV4 Type Of Service
field. Without the patch, all IPV6 packets in tunnel look the same to QoS.
This assumes that IPV6 transport class is exactly the same
as IPv4 TOS. Not sure if that is always the case? Maybe need
to mask off some bits.
The mask and shift to get tclass is copied from ipv6/datagram.c
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/ipv4/ip_gre.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index 749e548..945b20a 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip_gre.c
@@ -731,6 +731,8 @@ static netdev_tx_t ipgre_tunnel_xmit(struct sk_buff *skb, struct net_device *dev
tos = 0;
if (skb->protocol == htons(ETH_P_IP))
tos = old_iph->tos;
+ else if (skb->protocol == htons(ETH_P_IPV6))
+ tos = ipv6_get_dsfield((struct ipv6hdr *)old_iph);
}
{
--
1.7.1.1
^ permalink raw reply related
* Re: [PATCH linux-2.6.35-rc3] ks8842 driver
From: David Miller @ 2010-07-09 4:41 UTC (permalink / raw)
To: David.Choi; +Cc: horms, netdev, Charles.Li
In-Reply-To: <C43529A246480145B0A6D0234BDB0F0D481D67@MELANITE.micrel.com>
From: "Choi, David" <David.Choi@Micrel.Com>
Date: Thu, 8 Jul 2010 12:01:51 -0700
> The original ks8842 driver is designed to work on the customized bus
> interface based on an FPGA. This patch is intended to address the more
> commonly used generic bus interface available on the majority of SoC in
> the market.
>
> It is unlikely that for a system to use both FPGA based and generic bus
> interface for ks8842, I am quite certain that those 2 devices are used
> mutual exclusively.
Like Simon, I'm not to thrilled with this approach.
Any flag bit test you'd need to add to the driver to handle both cases
will have zero performance impact since the cost of the MMIO accesses
will dominate such tests entirely.
Add a boolean flag bit to the driver software state, set it based upon
some platform_device private setting, and test it in these paths to
device what to do.
As a bonus, anyone who enables this driver at all in their build will
test the compilation of both code paths. And to me, that extra
compilation testing trumps whatever arguments you may make for not
making this support dynamic.
Thanks.
^ permalink raw reply
* Re: [PATCH] ks8842: Do the TX timeout work in workqueue context.
From: David Miller @ 2010-07-09 4:43 UTC (permalink / raw)
To: richard.rojfors; +Cc: netdev
In-Reply-To: <1278429625.32432.10.camel@debian>
From: Richard Röjfors <richard.rojfors@pelagicore.com>
Date: Tue, 06 Jul 2010 17:20:25 +0200
> Currently all code that needs to be run at TX timeout is done in the
> calling context, where bottom halves are disabled. Some of the code
> blocks, so it needs to be done in a different context. This patch
> adds in a work struct which is scheduled at TX timeout. Then the
> timeout code is executed within work queue context.
>
> Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
Your patch is corrupted by your email client, and it does more than
you say it does in this commit message:
> static inline void ks8842_select_bank(struct ks8842_adapter *adapter,
> u16 bank)
> @@ -197,7 +199,6 @@ static void ks8842_reset(struct ks8842_adapter
> *adapter)
Your email client is wrapping long lines in the patch, corrupting it
and making it unusable. Please fix your email client to not molest
the patch in any way.
> msleep(10);
> iowrite16(0, adapter->hw_addr + REG_GRR);
> */
> - iowrite16(32, adapter->hw_addr + REG_SELECT_BANK);
> iowrite32(0x1, adapter->hw_addr + REG_TIMB_RST);
> msleep(20);
> }
Your commit message fails to describe what this REG_SELECT_BANK write
removal is needed for. It must be accounted for in your log message
otherwise other developers won't understand why this line gets
removed in your change.
Thanks.
^ permalink raw reply
* Re: [PATCH net-2.6] Phonet: fix skb leak in pipe endpoint accept()
From: David Miller @ 2010-07-09 4:45 UTC (permalink / raw)
To: remi.denis-courmont; +Cc: netdev
In-Reply-To: <1278572213-6239-1-git-send-email-remi.denis-courmont@nokia.com>
From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Date: Thu, 8 Jul 2010 09:56:53 +0300
> From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
>
> Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Applied, thank you.
^ permalink raw reply
* Re: [PATCH v4 1/9] atm: propagate signal changes via notifier
From: David Miller @ 2010-07-09 4:47 UTC (permalink / raw)
To: karl; +Cc: linux-atm-general, netdev, chas
In-Reply-To: <1278578095-25324-2-git-send-email-karl@hiramoto.org>
From: Karl Hiramoto <karl@hiramoto.org>
Date: Thu, 8 Jul 2010 10:34:47 +0200
> +
> +/*
> + * atm_dev_signal_change
> + *
> + * Propagate lower layer signal change in atm_dev->signal to netdevice.
> + * The event will be sent via a notifier call chain.
> + */
I said to format comments:
/* Like
* this.
*/
not:
/*
* Like
* this.
*/
Honestly, I don't know how I can be more clear about this :-)
^ permalink raw reply
* Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34
From: Eric Dumazet @ 2010-07-09 5:28 UTC (permalink / raw)
To: David Miller
Cc: torvalds, rjw, linux-kernel, akpm, netdev, kaber, jengelh,
casteyde.christian
In-Reply-To: <20100708.213420.112614033.davem@davemloft.net>
Le jeudi 08 juillet 2010 à 21:34 -0700, David Miller a écrit :
> From: Linus Torvalds <torvalds@linux-foundation.org>
> Date: Thu, 8 Jul 2010 18:34:25 -0700
>
> > On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> >>
> >> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16187
> >> Subject : Carrier detection failed in dhcpcd when link is up
> >> Submitter : Christian Casteyde <casteyde.christian@free.fr>
> >> Date : 2010-06-12 15:15 (27 days old)
> >> First-Bad-Commit: http://git.kernel.org/linus/10708f37ae729baba9b67bd134c3720709d4ae62
> >> Handled-By : Andrew Morton <akpm@linux-foundation.org>
> >
> > David? This bisects to a networking commit. Doesn't look sensible, but
> > what do I know?
>
> My suspicion is that dhcpd uses netlink to dump the info of the
> available links, and due to some bug gets confused with the new 64-bit
> statistic netlink attribute being there now.
> a second to have a look at this.
It could be a dhcpcd bug because of extended size of answer
According to strace, dhcpcd tries a recvmsg() call with
a 256 bytes buffer to hold answer.
Looking at current dhcpcd source, I confirm it cannot realloc its buffer
static int
get_netlink(int fd, int flags,
int (*callback)(struct nlmsghdr *))
{
char *buffer = NULL;
ssize_t bytes;
struct nlmsghdr *nlm;
int r = -1;
buffer = xzalloc(sizeof(char) * BUFFERLEN);
for (;;) {
bytes = recv(fd, buffer, BUFFERLEN, flags);
if (bytes == -1) {
if (errno == EAGAIN) {
r = 0;
goto eexit;
}
if (errno == EINTR)
continue;
goto eexit;
}
This program needs to fix this.
^ permalink raw reply
* [PATCH] tproxy: the length of lines should be within 80
From: Changli Gao @ 2010-07-09 5:31 UTC (permalink / raw)
To: Patrick McHardy; +Cc: David S. Miller, netfilter-devel, netdev, Changli Gao
tproxy: the length of lines should be within 80
According to the Documentation/CodingStyle, the length of lines should be
within 80.
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
----
net/netfilter/xt_TPROXY.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/netfilter/xt_TPROXY.c b/net/netfilter/xt_TPROXY.c
index e1a0ded..c61294d 100644
--- a/net/netfilter/xt_TPROXY.c
+++ b/net/netfilter/xt_TPROXY.c
@@ -37,8 +37,10 @@ tproxy_tg(struct sk_buff *skb, const struct xt_action_param *par)
return NF_DROP;
sk = nf_tproxy_get_sock_v4(dev_net(skb->dev), iph->protocol,
- iph->saddr, tgi->laddr ? tgi->laddr : iph->daddr,
- hp->source, tgi->lport ? tgi->lport : hp->dest,
+ iph->saddr,
+ tgi->laddr ? tgi->laddr : iph->daddr,
+ hp->source,
+ tgi->lport ? tgi->lport : hp->dest,
par->in, true);
/* NOTE: assign_sock consumes our sk reference */
^ permalink raw reply related
* Re: [PATCH v2] ks8842: Do the TX timeout work in workqueue context.
From: David Miller @ 2010-07-09 6:07 UTC (permalink / raw)
To: richard.rojfors; +Cc: netdev
In-Reply-To: <1278655286.5481.4.camel@debian>
From: Richard Röjfors <richard.rojfors@pelagicore.com>
Date: Fri, 09 Jul 2010 08:01:26 +0200
> Currently all code that needs to be run at TX timeout is done in the
> calling context, where bottom halves are disabled. Some of the code
> blocks, so it needs to be done in a different context. This patch
> adds in a work struct which is scheduled at TX timeout. Then the
> timeout code is executed within work queue context.
>
> In the process an unnecessary bank change before resetting the
> controller was removed.
>
> Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
If the bank change removal is unrelated to this change you should
do it in a seperate change.
This way it's easy for someone to find out if a regression is
caused by the TX workqueue bits, rather than this bank change
removal.
So, please submit this as a two patch sequence, one that does
the bank change line removal. And then a second that does
the TX workqueue bits.
Thanks.
^ permalink raw reply
* Re: [PATCH linux-2.6.35-rc3] ks8842 driver
From: Simon Horman @ 2010-07-09 6:08 UTC (permalink / raw)
To: David Miller; +Cc: David.Choi, netdev, Charles.Li
In-Reply-To: <20100708.214101.39178389.davem@davemloft.net>
On Thu, Jul 08, 2010 at 09:41:01PM -0700, David Miller wrote:
> From: "Choi, David" <David.Choi@Micrel.Com>
> Date: Thu, 8 Jul 2010 12:01:51 -0700
>
> > The original ks8842 driver is designed to work on the customized bus
> > interface based on an FPGA. This patch is intended to address the more
> > commonly used generic bus interface available on the majority of SoC in
> > the market.
> >
> > It is unlikely that for a system to use both FPGA based and generic bus
> > interface for ks8842, I am quite certain that those 2 devices are used
> > mutual exclusively.
>
> Like Simon, I'm not to thrilled with this approach.
>
> Any flag bit test you'd need to add to the driver to handle both cases
> will have zero performance impact since the cost of the MMIO accesses
> will dominate such tests entirely.
>
> Add a boolean flag bit to the driver software state, set it based upon
> some platform_device private setting, and test it in these paths to
> device what to do.
>
> As a bonus, anyone who enables this driver at all in their build will
> test the compilation of both code paths. And to me, that extra
> compilation testing trumps whatever arguments you may make for not
> making this support dynamic.
I was thinking more in terms of needing fewer kernels,
but yes build coverage is a big win.
^ permalink raw reply
* Re: [PATCH] cxgb4vf: remove obsolete DECLARE_PCI_UNMAP_ADDR usage
From: David Miller @ 2010-07-09 6:08 UTC (permalink / raw)
To: fujita.tomonori; +Cc: netdev, leedom
In-Reply-To: <20100708185111D.fujita.tomonori@lab.ntt.co.jp>
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Date: Thu, 8 Jul 2010 18:52:37 +0900
> We could use DEFINE_DMA_UNMAP_ADDR instead but using
> CONFIG_NEED_DMA_MAP_STATE is a simpler way to see if a platform does
> real DMA unmapping.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Applied.
^ permalink raw reply
* Re: [PATCH] cxgb3: simplify need_skb_unmap
From: David Miller @ 2010-07-09 6:08 UTC (permalink / raw)
To: fujita.tomonori; +Cc: netdev, divy
In-Reply-To: <20100708185209E.fujita.tomonori@lab.ntt.co.jp>
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Date: Thu, 8 Jul 2010 18:52:38 +0900
> We can use CONFIG_NEED_DMA_MAP_STATE to see if a platform does real
> DMA unmapping.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Applied.
^ permalink raw reply
* Re: [PATCH] cxgb4vf: remove obsolete DECLARE_PCI_UNMAP_ADDR usage
From: David Miller @ 2010-07-09 6:09 UTC (permalink / raw)
To: fujita.tomonori; +Cc: leedom, netdev
In-Reply-To: <20100708190126X.fujita.tomonori@lab.ntt.co.jp>
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Date: Thu, 08 Jul 2010 19:01:26 +0900
> On Thu, 8 Jul 2010 18:52:37 +0900
> FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
>
>> We could use DEFINE_DMA_UNMAP_ADDR instead but using
>> CONFIG_NEED_DMA_MAP_STATE is a simpler way to see if a platform does
>> real DMA unmapping.
>>
>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>> ---
>> drivers/net/cxgb4vf/sge.c | 14 +++++---------
>> 1 files changed, 5 insertions(+), 9 deletions(-)
>
> btw, I'm not sure that seeing if a platform does real DMA unmapping in
> a driver is a good thing. But I suppose that we need to accept it if
> this leads to big performance boost.
>
> Both can be applied to net-next.
I think the value of these "optimizations" is rapidly decreasing to
zero. And I believe I've told the authors of either this driver or
another one that they should just remove this stuff completely.
^ permalink raw reply
* Re: [PATCH v2] vlan: allow TSO setting on vlan interfaces
From: David Miller @ 2010-07-09 6:10 UTC (permalink / raw)
To: eric.dumazet; +Cc: bhutchings, netdev, kaber
In-Reply-To: <1278581971.2651.10.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 08 Jul 2010 11:39:31 +0200
> When we need to shape traffic with low speeds, we need to disable tso on
> network interface :
>
> ethtool -K eth0.2240 tso off
>
> It seems vlan interfaces miss the set_tso() ethtool method.
> Propagating tso changes from lower device is not always wanted, some
> vlans want TSO on, others want TSO off.
>
> Before enabling TSO, we must check real device supports it.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied to net-next-2.6, thanks Eric.
^ permalink raw reply
* Re: [PATCH v3] vlan: allow TSO setting on vlan interfaces
From: David Miller @ 2010-07-09 6:10 UTC (permalink / raw)
To: bhutchings; +Cc: eric.dumazet, netdev, kaber
In-Reply-To: <1278613548.16013.193.camel@achroite.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Thu, 08 Jul 2010 19:25:48 +0100
> On Thu, 2010-07-08 at 18:37 +0200, Eric Dumazet wrote:
>> When we need to shape traffic using low speeds, we need to
>> disable tso on network interface :
>>
>> ethtool -K eth0.2240 tso off
>>
>> It seems vlan interfaces miss the set_tso() ethtool method.
>>
>> Before enabling TSO, we must check real device supports
>> TSO for VLAN-tagged packets and enables TSO.
>>
>> Note that a TSO change on real device propagates TSO setting
>> on all vlans, even if admin selected a different TSO setting.
>>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Ok, just to clarify, I'll make sure I get this version instead of "v2"
which I just replied to :)
^ permalink raw reply
* Re: [PATCH net-next-2.6] tg3: allow TSO on vlan devices
From: David Miller @ 2010-07-09 6:12 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, mcarlson, mchan
In-Reply-To: <1278605695.2651.48.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 08 Jul 2010 18:14:55 +0200
> Similar to commit 72dccb01e8632aa (bnx2: Update vlan_features)
>
> In order to enable TSO on vlan devices, tg3 needs to update
> dev->vlan_features.
>
> Tested on HP NC326m (aka BCM5715S (rev a3))
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox