* [PATCH] drivers: rtl818x: request DMA-able memory
From: Serafeim Zanikolas @ 2010-10-24 20:32 UTC (permalink / raw)
To: herton, htl10, Larry.Finger, linville, joe, davem, linux-wireless,
netdev
Cc: Serafeim Zanikolas
Despite the indicated intention in comment, the kmalloc() call was not
explicitly requesting memory from ZONE_DMA.
Signed-off-by: Serafeim Zanikolas <sez@debian.org>
---
drivers/net/wireless/rtl818x/rtl8187_dev.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/rtl818x/rtl8187_dev.c b/drivers/net/wireless/rtl818x/rtl8187_dev.c
index 38fa824..771794d 100644
--- a/drivers/net/wireless/rtl818x/rtl8187_dev.c
+++ b/drivers/net/wireless/rtl818x/rtl8187_dev.c
@@ -1343,7 +1343,8 @@ static int __devinit rtl8187_probe(struct usb_interface *intf,
priv->is_rtl8187b = (id->driver_info == DEVICE_RTL8187B);
/* allocate "DMA aware" buffer for register accesses */
- priv->io_dmabuf = kmalloc(sizeof(*priv->io_dmabuf), GFP_KERNEL);
+ priv->io_dmabuf = kmalloc(sizeof(*priv->io_dmabuf),
+ GFP_DMA | GFP_KERNEL);
if (!priv->io_dmabuf) {
err = -ENOMEM;
goto err_free_dev;
--
1.7.1
^ permalink raw reply related
* Re: [PATCH] connector: remove lazy workqueue creation
From: David Miller @ 2010-10-24 21:21 UTC (permalink / raw)
To: tj; +Cc: zbr, netdev, fweisbec
In-Reply-To: <4CB8250A.7040902@kernel.org>
From: Tejun Heo <tj@kernel.org>
Date: Fri, 15 Oct 2010 11:55:22 +0200
> Commit 1a5645bc (connector: create connector workqueue only while
> needed once) implements lazy workqueue creation for connector
> workqueue. With cmwq now in place, lazy workqueue creation doesn't
> make much sense while adding a lot of complexity. Remove it and
> allocate an ordered workqueue during initialization.
>
> This also removes a call to flush_scheduled_work() which is deprecated
> and scheduled to be removed.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
Applied, thank you.
^ permalink raw reply
* Re: PROBLEM: NULL pointer dereference in rpcauth_refreshcred
From: Trond Myklebust @ 2010-10-24 21:29 UTC (permalink / raw)
To: Rob Leslie
Cc: J. Bruce Fields, Neil Brown, David S. Miller,
linux-nfs-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <3DE04C32-0B15-4BBF-A541-27152D3EC69B-O+g/SLjAo04@public.gmane.org>
On Sat, 2010-10-23 at 14:50 -0700, Rob Leslie wrote:
> [1.] One line summary of the problem:
>
> NULL pointer dereference in rpcauth_refreshcred
Hi Rob,
I suspect the following one-line patch should fix the problem.
Cheers
Trond
------------------------------------------------------------------------------------------------------
>From 118df3d17f11733b294ea2cd988d56ee376ef9fd Mon Sep 17 00:00:00 2001
From: Trond Myklebust <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
Date: Sun, 24 Oct 2010 17:17:31 -0400
Subject: [PATCH] SUNRPC: After calling xprt_release(), we must restart from call_reserve
Rob Leslie reports seeing the following Oops after his Kerberos session
expired.
BUG: unable to handle kernel NULL pointer dereference at 00000058
IP: [<e186ed94>] rpcauth_refreshcred+0x11/0x12c [sunrpc]
*pde = 00000000
Oops: 0000 [#1]
last sysfs file: /sys/devices/platform/pc87360.26144/temp3_input
Modules linked in: autofs4 authenc esp4 xfrm4_mode_transport ipt_LOG ipt_REJECT xt_limit xt_state ipt_REDIRECT xt_owner xt_HL xt_hl xt_tcpudp xt_mark cls_u32 cls_tcindex sch_sfq sch_htb sch_dsmark geodewdt deflate ctr twofish_generic twofish_i586 twofish_common camellia serpent blowfish cast5 cbc xcbc rmd160 sha512_generic sha1_generic hmac crypto_null af_key rpcsec_gss_krb5 nfsd exportfs nfs lockd fscache nfs_acl auth_rpcgss sunrpc ip_gre sit tunnel4 dummy ext3 jbd nf_nat_irc nf_conntrack_irc nf_nat_ftp nf_conntrack_ftp iptable_mangle iptable_nat nf_nat nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 iptable_filter ip_tables x_tables pc8736x_gpio nsc_gpio pc87360 hwmon_vid loop aes_i586 aes_generic sha256_generic dm_crypt cs5535_gpio serio_raw cs5535_mfgpt hifn_795x des_generic geode_rng rn
g_core led_class ext4 mbcache jbd2 crc16 dm_mirror dm_region_hash dm_log dm_snapshot dm_mod sd_mod crc_t10dif ide_pci_generic cs5536 amd74xx ide_core pata_cs5536 ata_generic libata usb_storage via_rhine mii scsi_mod btrfs zlib_deflate crc32c libcrc32c [last unloaded: scsi_wait_scan]
Pid: 12875, comm: sudo Not tainted 2.6.36-net5501 #1 /
EIP: 0060:[<e186ed94>] EFLAGS: 00010292 CPU: 0
EIP is at rpcauth_refreshcred+0x11/0x12c [sunrpc]
EAX: 00000000 EBX: defb13a0 ECX: 00000006 EDX: e18683b8
ESI: defb13a0 EDI: 00000000 EBP: 00000000 ESP: de571d58
DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068
Process sudo (pid: 12875, ti=de570000 task=decd1430 task.ti=de570000)
Stack:
e186e008 00000000 defb13a0 0000000d deda6000 e1868f22 e196f12b defb13a0
<0> defb13d8 00000000 00000000 e186e0aa 00000000 defb13a0 de571dac 00000000
<0> e186956c de571e34 debea5c0 de571dc8 e186967a 00000000 debea5c0 de571e34
Call Trace:
[<e186e008>] ? rpc_wake_up_next+0x114/0x11b [sunrpc]
[<e1868f22>] ? call_decode+0x24a/0x5af [sunrpc]
[<e196f12b>] ? nfs4_xdr_dec_access+0x0/0xa2 [nfs]
[<e186e0aa>] ? __rpc_execute+0x62/0x17b [sunrpc]
[<e186956c>] ? rpc_run_task+0x91/0x97 [sunrpc]
[<e186967a>] ? rpc_call_sync+0x40/0x5b [sunrpc]
[<e1969ca2>] ? nfs4_proc_access+0x10a/0x176 [nfs]
[<e19572fa>] ? nfs_do_access+0x2b1/0x2c0 [nfs]
[<e186ed61>] ? rpcauth_lookupcred+0x62/0x84 [sunrpc]
[<e19573b6>] ? nfs_permission+0xad/0x13b [nfs]
[<c0177824>] ? exec_permission+0x15/0x4b
[<c0177fbd>] ? link_path_walk+0x4f/0x456
[<c017867d>] ? path_walk+0x4c/0xa8
[<c0179678>] ? do_path_lookup+0x1f/0x68
[<c017a3fb>] ? user_path_at+0x37/0x5f
[<c016359c>] ? handle_mm_fault+0x229/0x55b
[<c0170a2d>] ? sys_faccessat+0x93/0x146
[<c0170aef>] ? sys_access+0xf/0x13
[<c02cf615>] ? syscall_call+0x7/0xb
Code: 0f 94 c2 84 d2 74 09 8b 44 24 0c e8 6a e9 8b de 83 c4 14 89 d8 5b 5e 5f 5d c3 55 57 56 53 83 ec 1c fc 89 c6 8b 40 10 89 44 24 04 <8b> 58 58 85 db 0f 85 d4 00 00 00 0f b7 46 70 8b 56 20 89 c5 83
EIP: [<e186ed94>] rpcauth_refreshcred+0x11/0x12c [sunrpc] SS:ESP 0068:de571d58
CR2: 0000000000000058
This appears to be caused by the function rpc_verify_header() first
calling xprt_release(), then doing a call_refresh. If we release the
transport slot, we should _always_ jump back to call_reserve before
calling anything else.
Signed-off-by: Trond Myklebust <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
Cc: stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
---
net/sunrpc/clnt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index 2388d83..3d28ae8 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -1677,7 +1677,7 @@ rpc_verify_header(struct rpc_task *task)
rpcauth_invalcred(task);
/* Ensure we obtain a new XID! */
xprt_release(task);
- task->tk_action = call_refresh;
+ task->tk_action = call_reserve;
goto out_retry;
case RPC_AUTH_BADCRED:
case RPC_AUTH_BADVERF:
--
1.7.2.3
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* Re: [PATCH net-next-2.6 v1] can: Topcliff: Update PCH_CAN driver to 2.6.35
From: David Miller @ 2010-10-24 21:43 UTC (permalink / raw)
To: masa-korg-ECg8zkTtlr0C6LszWs/t0g
Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w,
sameo-VuQAYsv1563Yd54FQh9/CA,
margie.foster-ral2JQCrhuEAvxtiuMwx3w,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w, wg-5Yr1BZd7O62+XT7JhA+gdA,
morinaga526-ECg8zkTtlr0C6LszWs/t0g,
joel.clark-ral2JQCrhuEAvxtiuMwx3w,
yong.y.wang-ral2JQCrhuEAvxtiuMwx3w, chripell-VaTbYqLCNhc,
qi.wang-ral2JQCrhuEAvxtiuMwx3w
In-Reply-To: <4CB8506C.3060600-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
From: Masayuki Ohtak <masa-korg-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
Date: Fri, 15 Oct 2010 22:00:28 +0900
> CAN driver of Topcliff PCH
>
> Topcliff PCH is the platform controller hub that is going to be used in
> Intel's upcoming general embedded platform. All IO peripherals in
> Topcliff PCH are actually devices sitting on AMBA bus.
> Topcliff PCH has CAN I/F. This driver enables CAN function.
>
> Signed-off-by: Masayuki Ohtake <masa-korg-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 00/10] can: at91: bugfixes and improvements
From: David Miller @ 2010-10-24 21:48 UTC (permalink / raw)
To: mkl; +Cc: socketcan-core, netdev
In-Reply-To: <1287658882-26914-1-git-send-email-mkl@pengutronix.de>
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Thu, 21 Oct 2010 13:01:12 +0200
> this series of patches fixes three bugs (CAN_CTRLMODE_3_SAMPLES,
> extended frames, use-after-free), a compiler warning (uninit'ed variable) and
> a section mismatch. Further it add the implementation of the
> do_get_berr_counter callback, the bittiming setting is now done in chip_start.
> As requested by Russell King the driver uses __raw_readl instead of readl.
>
> The last two patches do some cleanups, they convert dev_<level> printing
> to netdev_<level> and add the KBUILD_MODNAME to the bit timing constant
> to identify the driver.
All applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next-2.6 v1] can: Topcliff: Update PCH_CAN driver to 2.6.35
From: David Miller @ 2010-10-24 21:55 UTC (permalink / raw)
To: masa-korg-ECg8zkTtlr0C6LszWs/t0g
Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w,
sameo-VuQAYsv1563Yd54FQh9/CA,
margie.foster-ral2JQCrhuEAvxtiuMwx3w,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w, wg-5Yr1BZd7O62+XT7JhA+gdA,
morinaga526-ECg8zkTtlr0C6LszWs/t0g,
joel.clark-ral2JQCrhuEAvxtiuMwx3w,
yong.y.wang-ral2JQCrhuEAvxtiuMwx3w, chripell-VaTbYqLCNhc,
qi.wang-ral2JQCrhuEAvxtiuMwx3w
In-Reply-To: <20101024.144312.104048720.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Please send a patch against the current driver which will fix these
build warnings that occur when CONFIG_PM is disabled:
drivers/net/can/pch_can.c:258:13: warning: 'pch_can_set_int_custom' defined but not used
drivers/net/can/pch_can.c:269:13: warning: 'pch_can_get_int_enables' defined but not used
drivers/net/can/pch_can.c:420:13: warning: 'pch_can_get_rx_enable' defined but not used
drivers/net/can/pch_can.c:438:13: warning: 'pch_can_get_tx_enable' defined but not used
drivers/net/can/pch_can.c:462:13: warning: 'pch_can_set_rx_buffer_link' defined but not used
drivers/net/can/pch_can.c:480:13: warning: 'pch_can_get_rx_buffer_link' defined but not used
Thank you.
^ permalink raw reply
* Re: [PATCH net-next-2.6 v1] can: Topcliff: Update PCH_CAN driver to 2.6.35
From: Marc Kleine-Budde @ 2010-10-24 22:05 UTC (permalink / raw)
To: David Miller
Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
sameo-VuQAYsv1563Yd54FQh9/CA,
margie.foster-ral2JQCrhuEAvxtiuMwx3w,
netdev-u79uwXL29TY76Z2rM5mHXA, chripell-VaTbYqLCNhc,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
yong.y.wang-ral2JQCrhuEAvxtiuMwx3w,
masa-korg-ECg8zkTtlr0C6LszWs/t0g,
kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w,
joel.clark-ral2JQCrhuEAvxtiuMwx3w,
morinaga526-ECg8zkTtlr0C6LszWs/t0g, wg-5Yr1BZd7O62+XT7JhA+gdA,
qi.wang-ral2JQCrhuEAvxtiuMwx3w
In-Reply-To: <20101024.144312.104048720.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 1062 bytes --]
On 10/24/2010 11:43 PM, David Miller wrote:
> From: Masayuki Ohtak <masa-korg-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
> Date: Fri, 15 Oct 2010 22:00:28 +0900
>
>> CAN driver of Topcliff PCH
>>
>> Topcliff PCH is the platform controller hub that is going to be used in
>> Intel's upcoming general embedded platform. All IO peripherals in
>> Topcliff PCH are actually devices sitting on AMBA bus.
>> Topcliff PCH has CAN I/F. This driver enables CAN function.
>>
>> Signed-off-by: Masayuki Ohtake <masa-korg-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
>
> Applied, thanks.
IMHO this driver needs some improvements. There are some open points
from Wolfgangs and my review. On the other side, it's a new driver and
there's some time left before it hits mainline.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
[-- Attachment #2: Type: text/plain, Size: 188 bytes --]
_______________________________________________
Socketcan-core mailing list
Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org
https://lists.berlios.de/mailman/listinfo/socketcan-core
^ permalink raw reply
* Re: [PATCH 06/12] ipconfig: make local variables/function static
From: David Miller @ 2010-10-24 22:06 UTC (permalink / raw)
To: shemminger; +Cc: netdev
In-Reply-To: <20101021175148.504406585@vyatta.com>
git grep ic_set_manually -- arch/sparc
^ permalink raw reply
* Re: [PATCH net-next-2.6 v1] can: Topcliff: Update PCH_CAN driver to 2.6.35
From: David Miller @ 2010-10-24 22:09 UTC (permalink / raw)
To: mkl-bIcnvbaLZ9MEGnE8C9+IrQ
Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
sameo-VuQAYsv1563Yd54FQh9/CA,
margie.foster-ral2JQCrhuEAvxtiuMwx3w,
netdev-u79uwXL29TY76Z2rM5mHXA, chripell-VaTbYqLCNhc,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
yong.y.wang-ral2JQCrhuEAvxtiuMwx3w,
masa-korg-ECg8zkTtlr0C6LszWs/t0g,
kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w,
joel.clark-ral2JQCrhuEAvxtiuMwx3w,
morinaga526-ECg8zkTtlr0C6LszWs/t0g, wg-5Yr1BZd7O62+XT7JhA+gdA,
qi.wang-ral2JQCrhuEAvxtiuMwx3w
In-Reply-To: <4CC4ADA5.8-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
From: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Date: Mon, 25 Oct 2010 00:05:25 +0200
> On 10/24/2010 11:43 PM, David Miller wrote:
>> From: Masayuki Ohtak <masa-korg-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
>> Date: Fri, 15 Oct 2010 22:00:28 +0900
>>
>>> CAN driver of Topcliff PCH
>>>
>>> Topcliff PCH is the platform controller hub that is going to be used in
>>> Intel's upcoming general embedded platform. All IO peripherals in
>>> Topcliff PCH are actually devices sitting on AMBA bus.
>>> Topcliff PCH has CAN I/F. This driver enables CAN function.
>>>
>>> Signed-off-by: Masayuki Ohtake <masa-korg-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
>>
>> Applied, thanks.
>
> IMHO this driver needs some improvements. There are some open points
> from Wolfgangs and my review. On the other side, it's a new driver and
> there's some time left before it hits mainline.
When people have more than a week to review and provide feedback,
and don't, I have zero sympathy especially this early in the
release cycle.
So if adding it to the tree is what I have to do to get you guys to
post your comments and suggest fixes, then that's what I am going to
(continue) to do. :-)
^ permalink raw reply
* Re: [PATCH net-next-2.6 v1] can: Topcliff: Update PCH_CAN driver to 2.6.35
From: Marc Kleine-Budde @ 2010-10-24 22:15 UTC (permalink / raw)
To: David Miller
Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w,
masa-korg-ECg8zkTtlr0C6LszWs/t0g, sameo-VuQAYsv1563Yd54FQh9/CA,
margie.foster-ral2JQCrhuEAvxtiuMwx3w,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
yong.y.wang-ral2JQCrhuEAvxtiuMwx3w,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w,
joel.clark-ral2JQCrhuEAvxtiuMwx3w,
morinaga526-ECg8zkTtlr0C6LszWs/t0g,
qi.wang-ral2JQCrhuEAvxtiuMwx3w, chripell-VaTbYqLCNhc,
wg-5Yr1BZd7O62+XT7JhA+gdA
In-Reply-To: <20101024.150905.39179588.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 1813 bytes --]
On 10/25/2010 12:09 AM, David Miller wrote:
> From: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Date: Mon, 25 Oct 2010 00:05:25 +0200
>
>> On 10/24/2010 11:43 PM, David Miller wrote:
>>> From: Masayuki Ohtak <masa-korg-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
>>> Date: Fri, 15 Oct 2010 22:00:28 +0900
>>>
>>>> CAN driver of Topcliff PCH
>>>>
>>>> Topcliff PCH is the platform controller hub that is going to be used in
>>>> Intel's upcoming general embedded platform. All IO peripherals in
>>>> Topcliff PCH are actually devices sitting on AMBA bus.
>>>> Topcliff PCH has CAN I/F. This driver enables CAN function.
>>>>
>>>> Signed-off-by: Masayuki Ohtake <masa-korg-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
>>>
>>> Applied, thanks.
>>
>> IMHO this driver needs some improvements. There are some open points
>> from Wolfgangs and my review. On the other side, it's a new driver and
>> there's some time left before it hits mainline.
>
> When people have more than a week to review and provide feedback,
> and don't, I have zero sympathy especially this early in the
> release cycle.
Let me see....Crap, it's my fault, I just replied to the socketcan
mailinglist ;( [1]
> So if adding it to the tree is what I have to do to get you guys to
> post your comments and suggest fixes, then that's what I am going to
> (continue) to do. :-)
...or to learn how to reply properly :)
regards, Marc
[1]
https://lists.berlios.de/pipermail/socketcan-core/2010-October/004757.html
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
[-- Attachment #2: Type: text/plain, Size: 188 bytes --]
_______________________________________________
Socketcan-core mailing list
Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org
https://lists.berlios.de/mailman/listinfo/socketcan-core
^ permalink raw reply
* Re: [PATCH net-next-2.6] mlx4: make functions local and remove dead code.
From: David Miller @ 2010-10-24 22:19 UTC (permalink / raw)
To: shemminger; +Cc: yevgenyp, netdev, eli
In-Reply-To: <20101021095920.17bd21f1@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Thu, 21 Oct 2010 09:59:20 -0700
> Make the following function static: mlx4_UNMAP_ICM
> Remove the following unused function: mlx4_MAP_ICM_page
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply
* Re: [PATCH 00/12] last of the namespace cleanups
From: David Miller @ 2010-10-24 22:20 UTC (permalink / raw)
To: shemminger; +Cc: netdev
In-Reply-To: <20101021175045.625707607@vyatta.com>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Thu, 21 Oct 2010 10:50:45 -0700
> These are the last of the cleanups to networking for 2.6.37 based
> on "make namespacecheck" reports.
All applied except the ipconfig patch that breaks the sparc build.
Thanks.
^ permalink raw reply
* Re: [PATCH] macb: Don't re-enable interrupts while in polling mode
From: David Miller @ 2010-10-24 22:23 UTC (permalink / raw)
To: Joshua.Hoke
Cc: nicolas.ferre, jpirko, peter.korsgaard, eric.dumazet,
haavard.skinnemoen, netdev, linux-kernel, akpm
In-Reply-To: <C8F551D39A7C724E987CF8DD11D3178304D02F88@svr3.sixnetio.com>
From: "Joshua Hoke" <Joshua.Hoke@sixnet.com>
Date: Tue, 19 Oct 2010 12:48:22 -0400
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index ff2f158..36cf594 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -515,14 +515,15 @@ static int macb_poll(struct napi_struct *napi, int
> budget)
Your email client is breaking up long lines which corrupts the
patch.
Please fix this up in your email client and resubmit.
Thank you.
^ permalink raw reply
* Re: [PATCH] pktgen: clean up handling of local/transient counter vars
From: David Miller @ 2010-10-24 22:23 UTC (permalink / raw)
To: paul.gortmaker; +Cc: netdev
In-Reply-To: <1287440084-4848-1-git-send-email-paul.gortmaker@windriver.com>
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Mon, 18 Oct 2010 18:14:44 -0400
> The temporary variable "i" is needlessly initialized to zero
> in two distinct cases in this file:
>
> 1) where it is set to zero and then used as an argument in an addition
> before being assigned a non-zero value.
>
> 2) where it is only used in a standard/typical loop counter
>
> For (1), simply delete assignment to zero and usages while still
> zero; for (2) simply make the loop start at zero as per standard
> practice as seen everywhere else in the same file.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Applied.
^ permalink raw reply
* Re: [PATCH] ip6_tunnel dont update the mtu on the route.
From: David Miller @ 2010-10-24 22:24 UTC (permalink / raw)
To: eric.dumazet; +Cc: Anders.Franzen, netdev
In-Reply-To: <1287498728.2676.110.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 19 Oct 2010 16:32:08 +0200
> Le mardi 19 octobre 2010 à 15:50 +0200, Anders.Franzen@ericsson.com a
> écrit :
>> From: Anders Franzen <anders.franzen@ericsson.com>
>>
>> The ip6_tunnel device did not unset the flag,
>> IFF_XMIT_DST_RELEASE. This will make the dev layer
>> to release the dst before calling the tunnel.
>> The tunnel will not update any mtu/pmtu info, since
>> it does not have a dst on the skb.
...
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
Anders, please provide a proper "Signed-off-by: " tag in your
commit messages in the future.
Thanks.
^ permalink raw reply
* Re: [PATCH net-next-2.6 v2] can: tscan1: add driver for TS-CAN1 boards
From: David Miller @ 2010-10-24 22:27 UTC (permalink / raw)
To: w.sang-bIcnvbaLZ9MEGnE8C9+IrQ
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
netdev-u79uwXL29TY76Z2rM5mHXA, anbadeol-Re5JQEeQqe8AvxtiuMwx3w
In-Reply-To: <20101019192730.GA31336-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Date: Tue, 19 Oct 2010 21:27:30 +0200
> On Tue, Oct 19, 2010 at 08:47:27AM +0100, Andre B. Oliveira wrote:
>> Add driver for Technologic Systems TS-CAN1 PC104 peripheral boards.
>>
>> Signed-off-by: Andre B. Oliveira <anbadeol-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> This one already had a round on the socketcan-list, so:
>
> Reviewed-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Applied, thanks everyone.
^ permalink raw reply
* Re: [Patch] Limit sysctl_tcp_mem and sysctl_udp_mem initializers to prevent integer overflows.
From: David Miller @ 2010-10-24 22:28 UTC (permalink / raw)
To: holt
Cc: w, linux-kernel, netdev, linux-sctp, kuznet, pekkas, jmorris,
yoshfuji, kaber, vladislav.yasevich, sri
In-Reply-To: <20101020120345.436404838@gulag1.americas.sgi.com>
From: Robin Holt <holt@sgi.com>
Date: Wed, 20 Oct 2010 07:03:37 -0500
> Subject: [Patch] Limit sysctl_tcp_mem and sysctl_udp_mem initializers to prevent integer overflows.
>
> On a 16TB x86_64 machine, sysctl_tcp_mem[2], sysctl_udp_mem[2], and
> sysctl_sctp_mem[2] can integer overflow. Set limit such that they are
> maximized without overflowing.
>
> Signed-off-by: Robin Holt <holt@sgi.com>
I'll queue this up for -stable, thanks Robin!
^ permalink raw reply
* Re: [PATCH 1/2 v3] xps: Improvements in TX queue selection
From: David Miller @ 2010-10-24 22:32 UTC (permalink / raw)
To: therbert; +Cc: netdev, eric.dumazet
In-Reply-To: <alpine.DEB.1.00.1010211303390.30535@pokey.mtv.corp.google.com>
From: Tom Herbert <therbert@google.com>
Date: Thu, 21 Oct 2010 13:17:08 -0700 (PDT)
> @@ -822,8 +822,10 @@ static int tcp_transmit_skb(struct sock *sk, struct sk_buff *skb, int clone_it,
> &md5);
> tcp_header_size = tcp_options_size + sizeof(struct tcphdr);
>
> - if (tcp_packets_in_flight(tp) == 0)
> + if (tcp_packets_in_flight(tp) == 0) {
> tcp_ca_event(sk, CA_EVENT_TX_START);
> + skb->ooo_okay = 1;
> + }
>
You'll need to clear this flag the moment the first transmit of
this packet happens, otherwise OOO won't be handled correctly in
the event that fast retransmit is necessary later.
^ permalink raw reply
* Re: [PATCH] ibmveth: Increase default copybreak limits to 2k
From: David Miller @ 2010-10-24 22:40 UTC (permalink / raw)
To: rcj; +Cc: netdev
In-Reply-To: <20101021151746.GB5567@linux.vnet.ibm.com>
From: Robert Jennings <rcj@linux.vnet.ibm.com>
Date: Thu, 21 Oct 2010 10:17:46 -0500
> The value of copybreak is the point where we stop using the bounce
> buffer and start to copy data to new buffers; having the overhead of
> additional TCE entry setup/teardown. For the default MTU of 1500,
> increasing the copybreak value to 2k will result in all packets using
> the bounce buffer now. Expanding the use of the bounce buffer up to 2k
> with the default MTU resulted in ~10% throughput improvement.
On the RX side the copybreak serves another purpose.
First of all, when you RX a < ~128 byte frame, you incur the cost
mostly of the cache miss to touch the packet headers. The extra
allocated SKB and the copy are close to free.
But more importantly, if you always pass the RX descriptor SKB
into the network stack, even for tiny frames, the skb->truesize
(which is what gets charged to the socket) is larger than we
want it to be.
For a 128 byte frame, the socket gets charged the full MTU packet
size. Because that is how much memory it is really using.
This is what the RX side copybreak is dealing with and you
therefore cannot remove it so trivially.
I am not applying this patch.
^ permalink raw reply
* Re: [PATCH net-next-2.6] jme: Support WoL after shutdown
From: David Miller @ 2010-10-24 22:42 UTC (permalink / raw)
To: cooldavid; +Cc: netdev, Taoga, arieslee, devinchiu, hcchao, ethanhsiao
In-Reply-To: <1287711220-20075-1-git-send-email-cooldavid@cooldavid.org>
From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
Date: Fri, 22 Oct 2010 09:33:40 +0800
> From: Guo-Fu Tseng <cooldavid@cooldavid.org>
>
> Adding shutdown function that setup wake if wol is enabled.
> Add jme_phy_on in jme_set_100m_half in case it is shutting down
> or suspending when interface is down(phy_off by default).
>
> Reported_and_helped_by: Сtac <Taoga@yandex.ru>
> Signed-off-by: Guo-Fu Tseng <cooldavid@cooldavid.org>
Applied.
^ permalink raw reply
* Re: [PATCH 0/2] cxgb4 updates
From: David Miller @ 2010-10-24 22:42 UTC (permalink / raw)
To: dm; +Cc: netdev
In-Reply-To: <1287696596-15175-1-git-send-email-dm@chelsio.com>
From: Dimitris Michailidis <dm@chelsio.com>
Date: Thu, 21 Oct 2010 14:29:54 -0700
>
> Here are two patches for cxgb4. The first fixes a crash triggered by
> e6484930d7c73d324bccda7d43d131088da697b9. The second updates the driver
> to utilize the newer VLAN infrastructure. If it's too late for the latter
> let me know and I'll resend it when net-next reopens.
Both applied, thanks!
^ permalink raw reply
* Re: [PATCH 1/3] vmxnet3: remove set_flag_le{16,64} helpers
From: David Miller @ 2010-10-24 22:43 UTC (permalink / raw)
To: harvey.harrison; +Cc: sbhatewara, netdev, shemminger
In-Reply-To: <1287720334-15469-1-git-send-email-harvey.harrison@gmail.com>
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Thu, 21 Oct 2010 21:05:32 -0700
> It's easier to just annotate the constants as little endian types and set/clear
> the flags directly.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/3] vmxnet3: annotate hwaddr members as __iomem pointers
From: David Miller @ 2010-10-24 22:43 UTC (permalink / raw)
To: harvey.harrison; +Cc: sbhatewara, netdev, shemminger
In-Reply-To: <1287720334-15469-2-git-send-email-harvey.harrison@gmail.com>
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Thu, 21 Oct 2010 21:05:33 -0700
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 3/3] vmxnet3: fix typo setting confPA
From: David Miller @ 2010-10-24 22:43 UTC (permalink / raw)
To: harvey.harrison; +Cc: sbhatewara, netdev, shemminger
In-Reply-To: <1287720334-15469-3-git-send-email-harvey.harrison@gmail.com>
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Thu, 21 Oct 2010 21:05:34 -0700
> It's a le64, not a le32, typo in one place only.
>
> Noticed by sparse:
> drivers/net/vmxnet3/vmxnet3_drv.c:2668:52: warning: incorrect type in assignment (different base types)
> drivers/net/vmxnet3/vmxnet3_drv.c:2668:52: expected restricted __le64 [usertype] confPA
> drivers/net/vmxnet3/vmxnet3_drv.c:2668:52: got restricted __le32 [usertype] <noident>
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 3/3] vmxnet3: fix typo setting confPA
From: David Miller @ 2010-10-24 22:44 UTC (permalink / raw)
To: harvey.harrison; +Cc: sbhatewara, netdev, shemminger
In-Reply-To: <AANLkTimy5Pg1aUMfCZG+r+Zb=A_udx8NsYf3TXVHHTsf@mail.gmail.com>
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Fri, 22 Oct 2010 10:52:15 -0700
> On Fri, Oct 22, 2010 at 10:46 AM, Shreyas Bhatewara
> <sbhatewara@vmware.com> wrote:
>>> From: Harvey Harrison [mailto:harvey.harrison@gmail.com]
>>> One question I had when looking into this, why are you doing
>>> byteswapping in the VMXNET_{READ,WRITE}_BAR{0,1}
>>> macros?
>>
>> Because values need to be written in LE orders in registers. For eg. when rx_ring.next2fill index is written to RXPROD reg, it should be converted from CPU order to LE.
>
> Yes, but (unless I'm mistaken) writel always writes out in
> little-endian, so there isn't a need to swap the arguments,
> similarly for readl in the other direction.
That's right, readl() and writel() translate to little-endian.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox