* Re: [PATCH RESEND] ssb: fix nvram_get on bcm47xx platform
From: Ralf Baechle @ 2010-11-27 19:11 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: linux-mips, mb, netdev
In-Reply-To: <1290882392-28327-1-git-send-email-hauke@hauke-m.de>
On Sat, Nov 27, 2010 at 07:26:32PM +0100, Hauke Mehrtens wrote:
> Date: Sat, 27 Nov 2010 19:26:32 +0100
> From: Hauke Mehrtens <hauke@hauke-m.de>
> To: ralf@linux-mips.org, linux-mips@linux-mips.org
> Cc: mb@bu3sch.de, netdev@vger.kernel.org, Hauke Mehrtens <hauke@hauke-m.de>
> Subject: [PATCH RESEND] ssb: fix nvram_get on bcm47xx platform
This has been applied in August, so bitbucket.
Ralf
^ permalink raw reply
* Re: [PATCH RESEND] ssb: fix nvram_get on bcm47xx platform
From: Ralf Baechle @ 2010-11-27 19:24 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: linux-mips, mb, netdev
In-Reply-To: <20101127191138.GB4867@linux-mips.org>
On Sat, Nov 27, 2010 at 07:11:38PM +0000, Ralf Baechle wrote:
> On Sat, Nov 27, 2010 at 07:26:32PM +0100, Hauke Mehrtens wrote:
> > Date: Sat, 27 Nov 2010 19:26:32 +0100
> > From: Hauke Mehrtens <hauke@hauke-m.de>
> > To: ralf@linux-mips.org, linux-mips@linux-mips.org
> > Cc: mb@bu3sch.de, netdev@vger.kernel.org, Hauke Mehrtens <hauke@hauke-m.de>
> > Subject: [PATCH RESEND] ssb: fix nvram_get on bcm47xx platform
>
> This has been applied in August, so bitbucket.
Sorry - there was a different patch of similar subject which I accepted.
Will feed this one upstream after I seen an ACK from one of the SSB/BCM47xx
folks.
Ralf
^ permalink raw reply
* Re: [PATCH RESEND] ssb: fix nvram_get on bcm47xx platform
From: Michael Büsch @ 2010-11-27 19:27 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Hauke Mehrtens, linux-mips, netdev
In-Reply-To: <20101127192407.GA7175@linux-mips.org>
On Sat, 2010-11-27 at 19:24 +0000, Ralf Baechle wrote:
> On Sat, Nov 27, 2010 at 07:11:38PM +0000, Ralf Baechle wrote:
>
> > On Sat, Nov 27, 2010 at 07:26:32PM +0100, Hauke Mehrtens wrote:
> > > Date: Sat, 27 Nov 2010 19:26:32 +0100
> > > From: Hauke Mehrtens <hauke@hauke-m.de>
> > > To: ralf@linux-mips.org, linux-mips@linux-mips.org
> > > Cc: mb@bu3sch.de, netdev@vger.kernel.org, Hauke Mehrtens <hauke@hauke-m.de>
> > > Subject: [PATCH RESEND] ssb: fix nvram_get on bcm47xx platform
> >
> > This has been applied in August, so bitbucket.
>
> Sorry - there was a different patch of similar subject which I accepted.
> Will feed this one upstream after I seen an ACK from one of the SSB/BCM47xx
> folks.
Acked-by: Michael Buesch <mb@bu3sch.de>
--
Greetings Michael.
^ permalink raw reply
* Re: [PATCH 5/6] forcedeth: use KERN_ facility level in printk
From: Joe Perches @ 2010-11-27 19:45 UTC (permalink / raw)
To: Ben Hutchings; +Cc: Szymon Janc, netdev
In-Reply-To: <1290884641.3292.0.camel@localhost>
On Sat, 2010-11-27 at 19:04 +0000, Ben Hutchings wrote:
> On Sat, 2010-11-27 at 19:39 +0100, Szymon Janc wrote:
> > diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
> > index 2f092d7..a2b6681 100644
> > --- a/drivers/net/forcedeth.c
> > +++ b/drivers/net/forcedeth.c
> > @@ -958,7 +958,7 @@ static int reg_delay(struct net_device *dev, int offset, u32 mask, u32 target,
> > delaymax -= delay;
> > if (delaymax < 0) {
> > if (msg)
> > - printk("%s", msg);
> > + printk(KERN_WARNING "%s", msg);
> No, msg already includes a log level.
True. The messages are still broken though.
Some have trailing newlines, others not.
It'd be better to move the msg after the reg_delay
call and add the missing newlines.
---
drivers/net/forcedeth.c | 28 +++++++++++++---------------
1 files changed, 13 insertions(+), 15 deletions(-)
diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index 0fa1776..2d11028f 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -948,7 +948,7 @@ static bool nv_optimized(struct fe_priv *np)
}
static int reg_delay(struct net_device *dev, int offset, u32 mask, u32 target,
- int delay, int delaymax, const char *msg)
+ int delay, int delaymax)
{
u8 __iomem *base = get_hwbase(dev);
@@ -956,11 +956,8 @@ static int reg_delay(struct net_device *dev, int offset, u32 mask, u32 target,
do {
udelay(delay);
delaymax -= delay;
- if (delaymax < 0) {
- if (msg)
- printk("%s", msg);
+ if (delaymax < 0)
return 1;
- }
} while ((readl(base + offset) & mask) != target);
return 0;
}
@@ -1145,7 +1142,7 @@ static int mii_rw(struct net_device *dev, int addr, int miireg, int value)
writel(reg, base + NvRegMIIControl);
if (reg_delay(dev, NvRegMIIControl, NVREG_MIICTL_INUSE, 0,
- NV_MIIPHY_DELAY, NV_MIIPHY_DELAYMAX, NULL)) {
+ NV_MIIPHY_DELAY, NV_MIIPHY_DELAYMAX)) {
dprintk(KERN_DEBUG "%s: mii_rw of reg %d at PHY %d timed out.\n",
dev->name, miireg, addr);
retval = -1;
@@ -1547,9 +1544,9 @@ static void nv_stop_rx(struct net_device *dev)
else
rx_ctrl |= NVREG_RCVCTL_RX_PATH_EN;
writel(rx_ctrl, base + NvRegReceiverControl);
- reg_delay(dev, NvRegReceiverStatus, NVREG_RCVSTAT_BUSY, 0,
- NV_RXSTOP_DELAY1, NV_RXSTOP_DELAY1MAX,
- KERN_INFO "nv_stop_rx: ReceiverStatus remained busy");
+ if (reg_delay(dev, NvRegReceiverStatus, NVREG_RCVSTAT_BUSY, 0,
+ NV_RXSTOP_DELAY1, NV_RXSTOP_DELAY1MAX))
+ printk(KERN_INFO "nv_stop_rx: ReceiverStatus remained busy\n");
udelay(NV_RXSTOP_DELAY2);
if (!np->mac_in_use)
@@ -1582,9 +1579,9 @@ static void nv_stop_tx(struct net_device *dev)
else
tx_ctrl |= NVREG_XMITCTL_TX_PATH_EN;
writel(tx_ctrl, base + NvRegTransmitterControl);
- reg_delay(dev, NvRegTransmitterStatus, NVREG_XMITSTAT_BUSY, 0,
- NV_TXSTOP_DELAY1, NV_TXSTOP_DELAY1MAX,
- KERN_INFO "nv_stop_tx: TransmitterStatus remained busy");
+ if (reg_delay(dev, NvRegTransmitterStatus, NVREG_XMITSTAT_BUSY, 0,
+ NV_TXSTOP_DELAY1, NV_TXSTOP_DELAY1MAX))
+ printk(KERN_INFO "nv_stop_tx: TransmitterStatus remained busy\n");
udelay(NV_TXSTOP_DELAY2);
if (!np->mac_in_use)
@@ -5216,9 +5213,10 @@ static int nv_open(struct net_device *dev)
writel(np->vlanctl_bits, base + NvRegVlanControl);
pci_push(base);
writel(NVREG_TXRXCTL_BIT1|np->txrxctl_bits, base + NvRegTxRxControl);
- reg_delay(dev, NvRegUnknownSetupReg5, NVREG_UNKSETUP5_BIT31, NVREG_UNKSETUP5_BIT31,
- NV_SETUP5_DELAY, NV_SETUP5_DELAYMAX,
- KERN_INFO "open: SetupReg5, Bit 31 remained off\n");
+ if (reg_delay(dev, NvRegUnknownSetupReg5,
+ NVREG_UNKSETUP5_BIT31, NVREG_UNKSETUP5_BIT31,
+ NV_SETUP5_DELAY, NV_SETUP5_DELAYMAX))
+ printk(KERN_INFO "open: SetupReg5, Bit 31 remained off\n");
writel(0, base + NvRegMIIMask);
writel(NVREG_IRQSTAT_MASK, base + NvRegIrqStatus);
^ permalink raw reply related
* Regression 2.6.36 - driver rtl8169 crashes kernel, triggered by user app
From: Michael Monnerie @ 2010-11-27 20:22 UTC (permalink / raw)
To: linux-kernel; +Cc: romieu, netdev
[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]
This is the 3rd time I send this, and I did not get any answer.
I thought *regressions* are a bad thing that would be handled quickly?
Maybe this helps: *SHITTY DRIVER NOT WORKING ANYMORE*
Dear list, I've hunted down a bug which does *NOT* occur in kernel
2.6.34.7-0.5-desktop from openSUSE 11.3, but crashes stock kernel 2.6.36
triggered by a user!
It's actually very simple. From my desktop (kernel 2.6.36) I "cd" to an
NFS4 share, where a xz compressed image of Win7-64.iso.xz is located.
# cd /q/iso-images
and then I try to uncompress it there (as user, not root!):
# xz -kv Win7-64.iso.xz
With kernel 2.6.34.7-0.5-desktop, this runs with ~41MiB/s without
problems.
With kernel 2.6.36, it runs at ~26MiB/s, and while doing so, dmesg shows
a lot of noise about r8169 complaining:
http://zmi.at/x/kernel2.6.36-crash86.jpg
Here are 2 pictures of different crashes:
http://zmi.at/x/kernel2.6.36-crash84.jpg
http://zmi.at/x/kernel2.6.36-crash85.jpg
Neither the dmesg-messages nor the crash happens with kernel
2.6.34.7-0.5-desktop as delivered by openSUSE 11.3, but it always fully
crashes 2.6.36. I've retried about 10 times, it *never* finished to
uncompress the ~3GB image. At around 500-1000MB the kernel was gone.
I'm sure someone knows how to fix it. :-)
--
mit freundlichen Grüssen,
Michael Monnerie, Ing. BSc
it-management Internet Services
http://proteger.at [gesprochen: Prot-e-schee]
Tel: 0660 / 415 65 31
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* [PATCH net-next] vmxnet3: fix compilation when RSS is disabled
From: Scott J. Goldman @ 2010-11-27 20:33 UTC (permalink / raw)
To: netdev, linux-kernel, linux-next; +Cc: pv-drivers, randy.dunlap
Since this was reported on linux-next, we may want to merge it there too.
^ permalink raw reply
* [PATCH] vmxnet3: fix compilation when RSS is disabled
From: Scott J. Goldman @ 2010-11-27 20:33 UTC (permalink / raw)
To: netdev, linux-kernel, linux-next
Cc: pv-drivers, randy.dunlap, Scott J. Goldman
In-Reply-To: <1290890035-32285-1-git-send-email-scottjg@vmware.com>
If RSS is disabled, we can ifdef out some RSS specific code. This fixes
the compile error found by Randy Dunlap.
Signed-off-by: Scott J. Goldman <scottjg@vmware.com>
---
drivers/net/vmxnet3/vmxnet3_ethtool.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethtool.c b/drivers/net/vmxnet3/vmxnet3_ethtool.c
index 9ddaea6..8e17fc8 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethtool.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c
@@ -553,7 +553,7 @@ vmxnet3_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *info,
return -EOPNOTSUPP;
}
-
+#ifdef VMXNET3_RSS
static int
vmxnet3_get_rss_indir(struct net_device *netdev,
struct ethtool_rxfh_indir *p)
@@ -598,6 +598,7 @@ vmxnet3_set_rss_indir(struct net_device *netdev,
return 0;
}
+#endif
static struct ethtool_ops vmxnet3_ethtool_ops = {
.get_settings = vmxnet3_get_settings,
@@ -623,8 +624,10 @@ static struct ethtool_ops vmxnet3_ethtool_ops = {
.get_ringparam = vmxnet3_get_ringparam,
.set_ringparam = vmxnet3_set_ringparam,
.get_rxnfc = vmxnet3_get_rxnfc,
+#ifdef VMXNET3_RSS
.get_rxfh_indir = vmxnet3_get_rss_indir,
.set_rxfh_indir = vmxnet3_set_rss_indir,
+#endif
};
void vmxnet3_set_ethtool_ops(struct net_device *netdev)
--
1.7.0.4
^ permalink raw reply related
* Re: linux-next: Tree for November 26
From: Mariusz Kozlowski @ 2010-11-27 20:55 UTC (permalink / raw)
To: Jarek Poplawski
Cc: Zimny Lech, Stephen Rothwell, linux-next, LKML, Shreyas Bhatewara,
VMware, Inc., netdev
In-Reply-To: <4CF155CF.5090601@gmail.com>
On Sat, Nov 27, 2010 at 08:02:39PM +0100, Jarek Poplawski wrote:
> Zimny Lech wrote:
> ...
> > --
> > Slawa!
> > Zimny "Żyj i pozwól umrzeć" Lech z Wawelu
>
> FYI:
> http://www.kernel.org/pub/linux/docs/lkml/#s3-12
Also:
- be brave and use your real name
- change your email address to something that is not offending to people
who can read Polish
Too bad we have this in git history already.
--
Mariusz Kozlowski
^ permalink raw reply
* Re: Regression 2.6.36 - driver rtl8169 crashes kernel, triggered by user app
From: Francois Romieu @ 2010-11-27 21:52 UTC (permalink / raw)
To: Michael Monnerie; +Cc: linux-kernel, netdev
In-Reply-To: <201011272122.28164@zmi.at>
Michael Monnerie <michael.monnerie@is.it-management.at> :
> This is the 3rd time I send this, and I did not get any answer.
What about changing your mx blacklisting policy or checking the mailing-list
archive (http://marc.info/?t=128950098300003) ?
> I thought *regressions* are a bad thing that would be handled quickly?
You are strongly suggested to try current -git kernel. A regression
with similar symptoms has already been fixed.
> Maybe this helps: *SHITTY DRIVER NOT WORKING ANYMORE*
It does not help, Krusty. Try running for Congress.
--
Ueimor
^ permalink raw reply
* [PATCH] econet: Move to staging; remove from defconfig
From: Ben Hutchings @ 2010-11-27 22:44 UTC (permalink / raw)
To: Greg KH
Cc: David Miller, netdev, devel, linux-arm-kernel,
Debian kernel maintainers
Recent review has revealed several bugs in econet and other obscure
protocol implementations that can be exploited by local users for
denial of service or privilege escalation.
The econet protocol (PF_ECONET) is unmaintained. There appear to be
no published applications for it, and it has never progressed beyond
'experimental' status.
This protocol generally should not be enabled by distributions, since
the cost of a security flaw affecting all installed systems presumably
outweighs the benefit to the few (if any) legitimate users.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
As requested, I'm actually renaming the directory this time. I also
noticed that ECONET was enabled in a couple of ARM defconfigs and
explicitly disabled in various other defconfigs, so I've removed those
lines as well.
This is based on linux-next; I hope it applies to staging.
Ben.
arch/arm/configs/ixp4xx_defconfig | 3 ---
arch/arm/configs/pnx4008_defconfig | 3 ---
arch/mips/configs/gpr_defconfig | 3 ---
arch/mips/configs/mtx1_defconfig | 3 ---
arch/um/defconfig | 1 -
arch/xtensa/configs/common_defconfig | 1 -
arch/xtensa/configs/iss_defconfig | 1 -
arch/xtensa/configs/s6105_defconfig | 1 -
drivers/staging/Kconfig | 2 ++
drivers/staging/Makefile | 1 +
{net => drivers/staging}/econet/Kconfig | 0
{net => drivers/staging}/econet/Makefile | 0
{net => drivers/staging}/econet/af_econet.c | 0
net/Kconfig | 1 -
net/Makefile | 1 -
15 files changed, 3 insertions(+), 18 deletions(-)
rename {net => drivers/staging}/econet/Kconfig (100%)
rename {net => drivers/staging}/econet/Makefile (100%)
rename {net => drivers/staging}/econet/af_econet.c (100%)
diff --git a/arch/arm/configs/ixp4xx_defconfig b/arch/arm/configs/ixp4xx_defconfig
index 5c50239..bd85c32 100644
--- a/arch/arm/configs/ixp4xx_defconfig
+++ b/arch/arm/configs/ixp4xx_defconfig
@@ -88,9 +88,6 @@ CONFIG_IPDDP_ENCAP=y
CONFIG_IPDDP_DECAP=y
CONFIG_X25=m
CONFIG_LAPB=m
-CONFIG_ECONET=m
-CONFIG_ECONET_AUNUDP=y
-CONFIG_ECONET_NATIVE=y
CONFIG_WAN_ROUTER=m
CONFIG_NET_SCHED=y
CONFIG_NET_SCH_CBQ=m
diff --git a/arch/arm/configs/pnx4008_defconfig b/arch/arm/configs/pnx4008_defconfig
index bd481f0..8301e4a 100644
--- a/arch/arm/configs/pnx4008_defconfig
+++ b/arch/arm/configs/pnx4008_defconfig
@@ -101,9 +101,6 @@ CONFIG_IPDDP_ENCAP=y
CONFIG_IPDDP_DECAP=y
CONFIG_X25=m
CONFIG_LAPB=m
-CONFIG_ECONET=m
-CONFIG_ECONET_AUNUDP=y
-CONFIG_ECONET_NATIVE=y
CONFIG_WAN_ROUTER=m
CONFIG_NET_SCHED=y
CONFIG_NET_SCH_CBQ=m
diff --git a/arch/mips/configs/gpr_defconfig b/arch/mips/configs/gpr_defconfig
index 53edc13..9f9aa97 100644
--- a/arch/mips/configs/gpr_defconfig
+++ b/arch/mips/configs/gpr_defconfig
@@ -116,9 +116,6 @@ CONFIG_IPDDP_ENCAP=y
CONFIG_IPDDP_DECAP=y
CONFIG_X25=m
CONFIG_LAPB=m
-CONFIG_ECONET=m
-CONFIG_ECONET_AUNUDP=y
-CONFIG_ECONET_NATIVE=y
CONFIG_WAN_ROUTER=m
CONFIG_NET_SCHED=y
CONFIG_NET_SCH_CBQ=m
diff --git a/arch/mips/configs/mtx1_defconfig b/arch/mips/configs/mtx1_defconfig
index 8146997..79cfb0b 100644
--- a/arch/mips/configs/mtx1_defconfig
+++ b/arch/mips/configs/mtx1_defconfig
@@ -154,9 +154,6 @@ CONFIG_IPDDP_ENCAP=y
CONFIG_IPDDP_DECAP=y
CONFIG_X25=m
CONFIG_LAPB=m
-CONFIG_ECONET=m
-CONFIG_ECONET_AUNUDP=y
-CONFIG_ECONET_NATIVE=y
CONFIG_WAN_ROUTER=m
CONFIG_NET_SCHED=y
CONFIG_NET_SCH_CBQ=m
diff --git a/arch/um/defconfig b/arch/um/defconfig
index 564f3de..1fd4718 100644
--- a/arch/um/defconfig
+++ b/arch/um/defconfig
@@ -296,7 +296,6 @@ CONFIG_DEFAULT_TCP_CONG="cubic"
# CONFIG_ATALK is not set
# CONFIG_X25 is not set
# CONFIG_LAPB is not set
-# CONFIG_ECONET is not set
# CONFIG_WAN_ROUTER is not set
# CONFIG_NET_SCHED is not set
diff --git a/arch/xtensa/configs/common_defconfig b/arch/xtensa/configs/common_defconfig
index 1d230ee..8c8916c 100644
--- a/arch/xtensa/configs/common_defconfig
+++ b/arch/xtensa/configs/common_defconfig
@@ -239,7 +239,6 @@ CONFIG_IP_PNP_RARP=y
# CONFIG_X25 is not set
# CONFIG_LAPB is not set
# CONFIG_NET_DIVERT is not set
-# CONFIG_ECONET is not set
# CONFIG_WAN_ROUTER is not set
#
diff --git a/arch/xtensa/configs/iss_defconfig b/arch/xtensa/configs/iss_defconfig
index 7368164..de0c75f 100644
--- a/arch/xtensa/configs/iss_defconfig
+++ b/arch/xtensa/configs/iss_defconfig
@@ -249,7 +249,6 @@ CONFIG_DEFAULT_TCP_CONG="cubic"
# CONFIG_ATALK is not set
# CONFIG_X25 is not set
# CONFIG_LAPB is not set
-# CONFIG_ECONET is not set
# CONFIG_WAN_ROUTER is not set
# CONFIG_PHONET is not set
# CONFIG_IEEE802154 is not set
diff --git a/arch/xtensa/configs/s6105_defconfig b/arch/xtensa/configs/s6105_defconfig
index bb84fbc..c273505 100644
--- a/arch/xtensa/configs/s6105_defconfig
+++ b/arch/xtensa/configs/s6105_defconfig
@@ -204,7 +204,6 @@ CONFIG_DEFAULT_TCP_CONG="cubic"
# CONFIG_ATALK is not set
# CONFIG_X25 is not set
# CONFIG_LAPB is not set
-# CONFIG_ECONET is not set
# CONFIG_WAN_ROUTER is not set
# CONFIG_NET_SCHED is not set
# CONFIG_DCB is not set
diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index 9f83e21..695110d 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -192,5 +192,7 @@ source "drivers/staging/cptm1217/Kconfig"
source "drivers/staging/ste_rmi4/Kconfig"
+source "drivers/staging/econet/Kconfig"
+
endif # !STAGING_EXCLUDE_BUILD
endif # STAGING
diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
index 75c0c1f..03f08ed 100644
--- a/drivers/staging/Makefile
+++ b/drivers/staging/Makefile
@@ -71,3 +71,4 @@ obj-$(CONFIG_SND_INTEL_SST) += intel_sst/
obj-$(CONFIG_SPEAKUP) += speakup/
obj-$(CONFIG_TOUCHSCREEN_CLEARPAD_TM1217) += cptm1217/
obj-$(CONFIG_TOUCHSCREEN_SYNAPTICS_I2C_RMI4) += ste_rmi4/
+obj-$(CONFIG_ECONET) += econet/
diff --git a/net/econet/Kconfig b/drivers/staging/econet/Kconfig
similarity index 100%
rename from net/econet/Kconfig
rename to drivers/staging/econet/Kconfig
diff --git a/net/econet/Makefile b/drivers/staging/econet/Makefile
similarity index 100%
rename from net/econet/Makefile
rename to drivers/staging/econet/Makefile
diff --git a/net/econet/af_econet.c b/drivers/staging/econet/af_econet.c
similarity index 100%
rename from net/econet/af_econet.c
rename to drivers/staging/econet/af_econet.c
diff --git a/net/Kconfig b/net/Kconfig
index 5e203b5..4d5b5ed 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -207,7 +207,6 @@ source "net/ipx/Kconfig"
source "drivers/net/appletalk/Kconfig"
source "net/x25/Kconfig"
source "net/lapb/Kconfig"
-source "net/econet/Kconfig"
source "net/wanrouter/Kconfig"
source "net/phonet/Kconfig"
source "net/ieee802154/Kconfig"
diff --git a/net/Makefile b/net/Makefile
index 6b7bfd7..0f4ed79 100644
--- a/net/Makefile
+++ b/net/Makefile
@@ -42,7 +42,6 @@ obj-$(CONFIG_AF_RXRPC) += rxrpc/
obj-$(CONFIG_ATM) += atm/
obj-$(CONFIG_L2TP) += l2tp/
obj-$(CONFIG_DECNET) += decnet/
-obj-$(CONFIG_ECONET) += econet/
obj-$(CONFIG_PHONET) += phonet/
ifneq ($(CONFIG_VLAN_8021Q),)
obj-y += 8021q/
--
1.7.2.3
^ permalink raw reply related
* Re: Regression 2.6.36 - driver rtl8169 crashes kernel, triggered by user app
From: Jarek Poplawski @ 2010-11-27 22:44 UTC (permalink / raw)
To: Francois Romieu; +Cc: Michael Monnerie, linux-kernel, netdev
In-Reply-To: <20101127215219.GA2691@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> Michael Monnerie <michael.monnerie@is.it-management.at> :
>> This is the 3rd time I send this, and I did not get any answer.
>
> What about changing your mx blacklisting policy or checking the mailing-list
> archive (http://marc.info/?t=128950098300003) ?
Maybe some artificial intelligence in the driver? ;-)
Jarek P.
>
>> I thought *regressions* are a bad thing that would be handled quickly?
>
> You are strongly suggested to try current -git kernel. A regression
> with similar symptoms has already been fixed.
>
>> Maybe this helps: *SHITTY DRIVER NOT WORKING ANYMORE*
>
> It does not help, Krusty. Try running for Congress.
>
^ permalink raw reply
* Re: [PATCH] econet: Move to staging; remove from defconfig
From: Greg KH @ 2010-11-28 0:21 UTC (permalink / raw)
To: Ben Hutchings
Cc: David Miller, netdev, devel, linux-arm-kernel,
Debian kernel maintainers
In-Reply-To: <1290897868.3292.59.camel@localhost>
On Sat, Nov 27, 2010 at 10:44:28PM +0000, Ben Hutchings wrote:
> Recent review has revealed several bugs in econet and other obscure
> protocol implementations that can be exploited by local users for
> denial of service or privilege escalation.
>
> The econet protocol (PF_ECONET) is unmaintained. There appear to be
> no published applications for it, and it has never progressed beyond
> 'experimental' status.
>
> This protocol generally should not be enabled by distributions, since
> the cost of a security flaw affecting all installed systems presumably
> outweighs the benefit to the few (if any) legitimate users.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> As requested, I'm actually renaming the directory this time. I also
> noticed that ECONET was enabled in a couple of ARM defconfigs and
> explicitly disabled in various other defconfigs, so I've removed those
> lines as well.
>
> This is based on linux-next; I hope it applies to staging.
>
> Ben.
>
> arch/arm/configs/ixp4xx_defconfig | 3 ---
> arch/arm/configs/pnx4008_defconfig | 3 ---
> arch/mips/configs/gpr_defconfig | 3 ---
> arch/mips/configs/mtx1_defconfig | 3 ---
> arch/um/defconfig | 1 -
> arch/xtensa/configs/common_defconfig | 1 -
> arch/xtensa/configs/iss_defconfig | 1 -
> arch/xtensa/configs/s6105_defconfig | 1 -
No need to change the defconfigs, they will get updated on their own if
they need to be.
> drivers/staging/Kconfig | 2 ++
> drivers/staging/Makefile | 1 +
> {net => drivers/staging}/econet/Kconfig | 0
> {net => drivers/staging}/econet/Makefile | 0
> {net => drivers/staging}/econet/af_econet.c | 0
> net/Kconfig | 1 -
> net/Makefile | 1 -
> 15 files changed, 3 insertions(+), 18 deletions(-)
> rename {net => drivers/staging}/econet/Kconfig (100%)
> rename {net => drivers/staging}/econet/Makefile (100%)
> rename {net => drivers/staging}/econet/af_econet.c (100%)
>
> diff --git a/arch/arm/configs/ixp4xx_defconfig b/arch/arm/configs/ixp4xx_defconfig
> index 5c50239..bd85c32 100644
> --- a/arch/arm/configs/ixp4xx_defconfig
> +++ b/arch/arm/configs/ixp4xx_defconfig
> @@ -88,9 +88,6 @@ CONFIG_IPDDP_ENCAP=y
> CONFIG_IPDDP_DECAP=y
> CONFIG_X25=m
> CONFIG_LAPB=m
> -CONFIG_ECONET=m
> -CONFIG_ECONET_AUNUDP=y
> -CONFIG_ECONET_NATIVE=y
Doesn't this imply that someone is actually using this?
> CONFIG_WAN_ROUTER=m
> CONFIG_NET_SCHED=y
> CONFIG_NET_SCH_CBQ=m
> diff --git a/arch/arm/configs/pnx4008_defconfig b/arch/arm/configs/pnx4008_defconfig
> index bd481f0..8301e4a 100644
> --- a/arch/arm/configs/pnx4008_defconfig
> +++ b/arch/arm/configs/pnx4008_defconfig
> @@ -101,9 +101,6 @@ CONFIG_IPDDP_ENCAP=y
> CONFIG_IPDDP_DECAP=y
> CONFIG_X25=m
> CONFIG_LAPB=m
> -CONFIG_ECONET=m
> -CONFIG_ECONET_AUNUDP=y
> -CONFIG_ECONET_NATIVE=y
Same here and for the others.
I also need a TODO file for the staging directory location (see the
others for drivers that are going away as an example.)
And I need an ack from the networking maintainer to be able to accept
this also.
thanks,
greg k-h
^ permalink raw reply
* [PATCH 0/5] Firewire networking assorted fixes
From: Maxim Levitsky @ 2010-11-28 1:15 UTC (permalink / raw)
To: linux1394-devel; +Cc: Stefan Richter, netdev
Here is few patches to fix few annoying problems with firewire networking.
I need a feedback on patch #3 from netdev folks.
patch #2 implements initial version of IR/IR resume support.
Best regards,
Maxim Levitsky
^ permalink raw reply
* [PATCH 1/5] firewire: ohci: restore GUID register on resume.
From: Maxim Levitsky @ 2010-11-28 1:15 UTC (permalink / raw)
To: linux1394-devel; +Cc: Stefan Richter, netdev, Maxim Levitsky
In-Reply-To: <1290906936-14472-1-git-send-email-maximlevitsky@gmail.com>
Some lousy BIOSes, eg my Aspire 5720 BIOS forgets to restore
device GUID on resume from ram.
Fix that by programming GUID register on resume from ram
Since that register is one time programable according to spec,
that has no effect on systems that have sane BIOS (Are there any?)
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
---
drivers/firewire/ohci.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c
index 6dd56cd..cadd6af 100644
--- a/drivers/firewire/ohci.c
+++ b/drivers/firewire/ohci.c
@@ -3240,6 +3240,10 @@ static int pci_resume(struct pci_dev *dev)
return err;
}
+ /* Some bioses forget to reinitialize the GUID. Do that ourselves */
+ reg_write(ohci, OHCI1394_GUIDLo, ohci->card.guid & 0xFFFFFFFF);
+ reg_write(ohci, OHCI1394_GUIDHi, (ohci->card.guid >> 32) & 0xFFFFFFFF);
+
return ohci_enable(&ohci->card, NULL, 0);
}
#endif
--
1.7.1
^ permalink raw reply related
* [PATCH 2/5] firewire: ohci: restart ISO channels on resume
From: Maxim Levitsky @ 2010-11-28 1:15 UTC (permalink / raw)
To: linux1394-devel; +Cc: Stefan Richter, netdev, Maxim Levitsky
In-Reply-To: <1290906936-14472-1-git-send-email-maximlevitsky@gmail.com>
ISO streams are supposed to be not interrupted
on bus resets, and suspend resume can be though
as one big bus reset.
Of course users must as soon as they notice the
bus reset, revalidate the ISO channel with IRM.
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
---
drivers/firewire/ohci.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++-
1 files changed, 48 insertions(+), 1 deletions(-)
diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c
index cadd6af..9704b34 100644
--- a/drivers/firewire/ohci.c
+++ b/drivers/firewire/ohci.c
@@ -40,6 +40,7 @@
#include <linux/spinlock.h>
#include <linux/string.h>
#include <linux/time.h>
+#include <linux/bitops.h>
#include <asm/byteorder.h>
#include <asm/page.h>
@@ -167,6 +168,9 @@ struct iso_context {
int excess_bytes;
void *header;
size_t header_length;
+
+ u8 sync;
+ u8 tags;
};
#define CONFIG_ROM_SIZE 1024
@@ -199,8 +203,11 @@ struct fw_ohci {
u32 it_context_mask; /* unoccupied IT contexts */
struct iso_context *it_context_list;
+ u32 it_active_mask;
+
u64 ir_context_channels; /* unoccupied channels */
u32 ir_context_mask; /* unoccupied IR contexts */
+ u32 ir_active_mask; /*running IR contexts */
struct iso_context *ir_context_list;
u64 mc_channels; /* channels in use by the multichannel IR context */
bool mc_allocated;
@@ -2596,6 +2603,7 @@ static int ohci_start_iso(struct fw_iso_context *base,
reg_write(ohci, OHCI1394_IsoXmitIntEventClear, 1 << index);
reg_write(ohci, OHCI1394_IsoXmitIntMaskSet, 1 << index);
+ ohci->it_active_mask |= (1 << index);
context_run(&ctx->context, match);
break;
@@ -2613,7 +2621,12 @@ static int ohci_start_iso(struct fw_iso_context *base,
reg_write(ohci, OHCI1394_IsoRecvIntEventClear, 1 << index);
reg_write(ohci, OHCI1394_IsoRecvIntMaskSet, 1 << index);
reg_write(ohci, CONTEXT_MATCH(ctx->context.regs), match);
+ ohci->ir_active_mask |= (1 << index);
context_run(&ctx->context, control);
+
+ ctx->sync = sync;
+ ctx->tags = tags;
+
break;
}
@@ -2630,12 +2643,14 @@ static int ohci_stop_iso(struct fw_iso_context *base)
case FW_ISO_CONTEXT_TRANSMIT:
index = ctx - ohci->it_context_list;
reg_write(ohci, OHCI1394_IsoXmitIntMaskClear, 1 << index);
+ ohci->it_active_mask &= ~(1 << index);
break;
case FW_ISO_CONTEXT_RECEIVE:
case FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL:
index = ctx - ohci->ir_context_list;
reg_write(ohci, OHCI1394_IsoRecvIntMaskClear, 1 << index);
+ ohci->ir_active_mask &= ~(1 << index);
break;
}
flush_writes(ohci);
@@ -2711,6 +2726,33 @@ static int ohci_set_iso_channels(struct fw_iso_context *base, u64 *channels)
return ret;
}
+static int ohci_resume_iso(struct fw_ohci *ohci)
+{
+ int i, err;
+ struct iso_context *ctx;
+
+ for_each_set_bit(i, (unsigned long *)&ohci->ir_active_mask,
+ sizeof(ohci->ir_active_mask)) {
+ ctx = &ohci->ir_context_list[i];
+ err = ohci_start_iso(&ctx->base, 0, ctx->sync, ctx->tags);
+
+ if (err)
+ return err;
+ }
+
+ for_each_set_bit(i, (unsigned long *)&ohci->it_active_mask,
+ sizeof(ohci->it_active_mask)) {
+ ctx = &ohci->it_context_list[i];
+ err = ohci_start_iso(&ctx->base, 0, 0, 0);
+
+ if (err)
+ return err;
+ }
+
+
+ return 0;
+}
+
static int queue_iso_transmit(struct iso_context *ctx,
struct fw_iso_packet *packet,
struct fw_iso_buffer *buffer,
@@ -3244,7 +3286,12 @@ static int pci_resume(struct pci_dev *dev)
reg_write(ohci, OHCI1394_GUIDLo, ohci->card.guid & 0xFFFFFFFF);
reg_write(ohci, OHCI1394_GUIDHi, (ohci->card.guid >> 32) & 0xFFFFFFFF);
- return ohci_enable(&ohci->card, NULL, 0);
+ err = ohci_enable(&ohci->card, NULL, 0);
+
+ if (err)
+ return err;
+
+ return ohci_resume_iso(ohci);
}
#endif
--
1.7.1
^ permalink raw reply related
* [PATCH 4/5] firewire: net: invalidate ARP entries for removed nodes.
From: Maxim Levitsky @ 2010-11-28 1:15 UTC (permalink / raw)
To: linux1394-devel; +Cc: Stefan Richter, netdev, Maxim Levitsky
In-Reply-To: <1290906936-14472-1-git-send-email-maximlevitsky@gmail.com>
This allows to be able to connect to nodes that disappered
from the bus and after some time appeared again.
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
---
drivers/firewire/net.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
index 1a467a9..d422519 100644
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -189,6 +189,7 @@ struct fwnet_peer {
struct fwnet_device *dev;
u64 guid;
u64 fifo;
+ __be32 ip;
/* guarded by dev->lock */
struct list_head pd_list; /* received partial datagrams */
@@ -568,6 +569,8 @@ static int fwnet_finish_incoming_packet(struct net_device *net,
peer->speed = sspd;
if (peer->max_payload > max_payload)
peer->max_payload = max_payload;
+
+ peer->ip = arp1394->sip;
}
spin_unlock_irqrestore(&dev->lock, flags);
@@ -1443,6 +1446,7 @@ static int fwnet_add_peer(struct fwnet_device *dev,
peer->dev = dev;
peer->guid = (u64)device->config_rom[3] << 32 | device->config_rom[4];
peer->fifo = FWNET_NO_FIFO_ADDR;
+ peer->ip = 0;
INIT_LIST_HEAD(&peer->pd_list);
peer->pdg_size = 0;
peer->datagram_label = 0;
@@ -1558,6 +1562,9 @@ static int fwnet_remove(struct device *_dev)
mutex_lock(&fwnet_device_mutex);
+ if (dev->netdev && peer->ip)
+ arp_invalidate(dev->netdev, peer->ip);
+
fwnet_remove_peer(peer);
if (list_empty(&dev->peer_list)) {
--
1.7.1
^ permalink raw reply related
* [PATCH 3/5] NET: ARP: allow to invalidate specific ARP entries
From: Maxim Levitsky @ 2010-11-28 1:15 UTC (permalink / raw)
To: linux1394-devel; +Cc: Stefan Richter, netdev, Maxim Levitsky
In-Reply-To: <1290906936-14472-1-git-send-email-maximlevitsky@gmail.com>
IPv4 over firewire needs to be able to remove ARP entries
from cache that belong to nodes that are removed, because
IPv4 over firewire uses ARP packets for private information
about nodes.
This information becames invalid on node removal, thus
as soon as it is connected again, ARP packet should be sent
to it which is not done due to valid cache entry.
CC: netdev@vger.kernel.org
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
---
include/net/arp.h | 1 +
net/ipv4/arp.c | 29 ++++++++++++++++++-----------
2 files changed, 19 insertions(+), 11 deletions(-)
diff --git a/include/net/arp.h b/include/net/arp.h
index f4cf6ce..91f0568 100644
--- a/include/net/arp.h
+++ b/include/net/arp.h
@@ -25,5 +25,6 @@ extern struct sk_buff *arp_create(int type, int ptype, __be32 dest_ip,
const unsigned char *src_hw,
const unsigned char *target_hw);
extern void arp_xmit(struct sk_buff *skb);
+int arp_invalidate(struct net_device *dev, __be32 ip);
#endif /* _ARP_H */
diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c
index d8e540c..35b1272 100644
--- a/net/ipv4/arp.c
+++ b/net/ipv4/arp.c
@@ -1142,6 +1142,23 @@ static int arp_req_get(struct arpreq *r, struct net_device *dev)
return err;
}
+int arp_invalidate(struct net_device *dev, __be32 ip)
+{
+ int err = -ENXIO;
+ struct neighbour *neigh = neigh_lookup(&arp_tbl, &ip, dev);
+
+ if (neigh) {
+ if (neigh->nud_state & ~NUD_NOARP)
+ err = neigh_update(neigh, NULL, NUD_FAILED,
+ NEIGH_UPDATE_F_OVERRIDE|
+ NEIGH_UPDATE_F_ADMIN);
+ neigh_release(neigh);
+ }
+
+ return err;
+}
+EXPORT_SYMBOL(arp_invalidate);
+
static int arp_req_delete_public(struct net *net, struct arpreq *r,
struct net_device *dev)
{
@@ -1162,7 +1179,6 @@ static int arp_req_delete(struct net *net, struct arpreq *r,
{
int err;
__be32 ip;
- struct neighbour *neigh;
if (r->arp_flags & ATF_PUBL)
return arp_req_delete_public(net, r, dev);
@@ -1180,16 +1196,7 @@ static int arp_req_delete(struct net *net, struct arpreq *r,
if (!dev)
return -EINVAL;
}
- err = -ENXIO;
- neigh = neigh_lookup(&arp_tbl, &ip, dev);
- if (neigh) {
- if (neigh->nud_state & ~NUD_NOARP)
- err = neigh_update(neigh, NULL, NUD_FAILED,
- NEIGH_UPDATE_F_OVERRIDE|
- NEIGH_UPDATE_F_ADMIN);
- neigh_release(neigh);
- }
- return err;
+ return arp_invalidate(dev, ip);
}
/*
--
1.7.1
^ permalink raw reply related
* [PATCH 5/5] firewire: net: ratelimit error messages
From: Maxim Levitsky @ 2010-11-28 1:15 UTC (permalink / raw)
To: linux1394-devel; +Cc: Stefan Richter, netdev, Maxim Levitsky
In-Reply-To: <1290906936-14472-1-git-send-email-maximlevitsky@gmail.com>
This patch ensures that firewire-net won't be able to flood
the logs with errors by combining series of same errors together.
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
---
drivers/firewire/net.c | 16 ++++++++++++----
1 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
index d422519..ac563d6 100644
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -999,15 +999,23 @@ static void fwnet_transmit_packet_failed(struct fwnet_packet_task *ptask)
static void fwnet_write_complete(struct fw_card *card, int rcode,
void *payload, size_t length, void *data)
{
- struct fwnet_packet_task *ptask;
-
- ptask = data;
+ struct fwnet_packet_task *ptask = data;
+ static unsigned long j;
+ static int last_rcode, errors_skipped;
if (rcode == RCODE_COMPLETE) {
fwnet_transmit_packet_done(ptask);
} else {
- fw_error("fwnet_write_complete: failed: %x\n", rcode);
fwnet_transmit_packet_failed(ptask);
+
+ if (printk_timed_ratelimit(&j, 1000) || rcode != last_rcode) {
+ fw_error("fwnet_write_complete: "
+ "failed: %x (skipped %d)\n", rcode, errors_skipped);
+
+ errors_skipped = 0;
+ last_rcode = rcode;
+ } else
+ errors_skipped++;
}
}
--
1.7.1
^ permalink raw reply related
* Re: [PATCH] econet: Move to staging; remove from defconfig
From: David Miller @ 2010-11-28 1:26 UTC (permalink / raw)
To: gregkh; +Cc: ben, netdev, devel, linux-arm-kernel, debian-kernel
In-Reply-To: <20101128002135.GA4562@suse.de>
From: Greg KH <gregkh@suse.de>
Date: Sat, 27 Nov 2010 16:21:35 -0800
> And I need an ack from the networking maintainer to be able to accept
> this also.
I'm not applying this, nor do I want anyone else to.
If people think this protocol is not maintained adequately
right now, wait until you push it into staging.
Furthermore, once Phil Blundell was made aware of security
holes in econet he fixed them within a few days. Which is
much better than I can say for some of the other protocols
and filesystems in the tree.
Moving this into staging, is therefore not appropriate.
^ permalink raw reply
* Re: [PATCH] econet: Move to staging; remove from defconfig
From: Greg KH @ 2010-11-28 1:39 UTC (permalink / raw)
To: David Miller; +Cc: devel, netdev, ben, linux-arm-kernel, debian-kernel
In-Reply-To: <20101127.172644.226781076.davem@davemloft.net>
On Sat, Nov 27, 2010 at 05:26:44PM -0800, David Miller wrote:
> From: Greg KH <gregkh@suse.de>
> Date: Sat, 27 Nov 2010 16:21:35 -0800
>
> > And I need an ack from the networking maintainer to be able to accept
> > this also.
>
> I'm not applying this, nor do I want anyone else to.
>
> If people think this protocol is not maintained adequately
> right now, wait until you push it into staging.
>
> Furthermore, once Phil Blundell was made aware of security
> holes in econet he fixed them within a few days. Which is
> much better than I can say for some of the other protocols
> and filesystems in the tree.
>
> Moving this into staging, is therefore not appropriate.
Agreed.
Ben, why are you trying to remove these protocols that people use and
maintain? This is the third one that has been shot down recently...
^ permalink raw reply
* Re: [PATCH] Net: ceph: Makefile: Remove unnessary code
From: David Miller @ 2010-11-28 1:39 UTC (permalink / raw)
To: tdent48227; +Cc: sage, ceph-devel, linux-kernel, netdev
In-Reply-To: <1290389030-2743-1-git-send-email-tdent48227@gmail.com>
From: Tracey Dent <tdent48227@gmail.com>
Date: Sun, 21 Nov 2010 20:23:50 -0500
> Remove the if and else conditional because the code is in mainline and there
> is no need in it being there.
>
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 2/2] pch_gbe driver: The wrong of initializer entry
From: David Miller @ 2010-11-28 1:41 UTC (permalink / raw)
To: toshiharu-linux
Cc: linux, randy.dunlap, john.linn, ralf, kristoffer, mbizon,
gregory.v.rose, netdev, linux-kernel, masa-korg, qi.wang,
yong.y.wang, andrew.chih.howe.khor, joel.clark, margie.foster,
kok.howg.ewe
In-Reply-To: <4CEA069D.20009@dsn.okisemi.com>
From: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
Date: Mon, 22 Nov 2010 14:58:53 +0900
> The wrong of initializer entry was modified.
>
> Signed-off-by: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
How about you give some credit to David Alan Gilbert who made
you aware of this issue?
^ permalink raw reply
* Re: [PATCH] econet: Move to staging; remove from defconfig
From: Ben Hutchings @ 2010-11-28 1:53 UTC (permalink / raw)
To: David Miller; +Cc: gregkh, netdev, devel, linux-arm-kernel, debian-kernel
In-Reply-To: <20101127.172644.226781076.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
On Sat, 2010-11-27 at 17:26 -0800, David Miller wrote:
> From: Greg KH <gregkh@suse.de>
> Date: Sat, 27 Nov 2010 16:21:35 -0800
>
> > And I need an ack from the networking maintainer to be able to accept
> > this also.
>
> I'm not applying this, nor do I want anyone else to.
>
> If people think this protocol is not maintained adequately
> right now, wait until you push it into staging.
>
> Furthermore, once Phil Blundell was made aware of security
> holes in econet he fixed them within a few days. Which is
> much better than I can say for some of the other protocols
> and filesystems in the tree.
Those bugs were present for years and would have been obvious to anyone
who cared to read the code. While I very much appreciate Phil's quick
response, I don't think this reactive maintenance is enough.
> Moving this into staging, is therefore not appropriate.
Oh well, it's not enough as if many distributions bothered to build it
anyway, and we've learned our lesson now. Whether it's labelled as
staging or not, it's dead, Jim.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply
* Re: [PATCH] econet: Move to staging; remove from defconfig
From: Ben Hutchings @ 2010-11-28 2:02 UTC (permalink / raw)
To: Greg KH; +Cc: David Miller, netdev, devel, linux-arm-kernel, debian-kernel
In-Reply-To: <20101128013923.GA9285@suse.de>
[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]
On Sat, 2010-11-27 at 17:39 -0800, Greg KH wrote:
> On Sat, Nov 27, 2010 at 05:26:44PM -0800, David Miller wrote:
> > From: Greg KH <gregkh@suse.de>
> > Date: Sat, 27 Nov 2010 16:21:35 -0800
> >
> > > And I need an ack from the networking maintainer to be able to accept
> > > this also.
> >
> > I'm not applying this, nor do I want anyone else to.
> >
> > If people think this protocol is not maintained adequately
> > right now, wait until you push it into staging.
> >
> > Furthermore, once Phil Blundell was made aware of security
> > holes in econet he fixed them within a few days. Which is
> > much better than I can say for some of the other protocols
> > and filesystems in the tree.
> >
> > Moving this into staging, is therefore not appropriate.
>
> Agreed.
>
> Ben, why are you trying to remove these protocols that people use and
> maintain? This is the third one that has been shot down recently...
Moving to staging is a step toward removal, but not removal itself. I
already stated the reasons I picked those three protocols; I'm not going
to push the issue if David disagrees.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply
* Re: [PATCH 0/5] Firewire networking assorted fixes
From: Maxim Levitsky @ 2010-11-28 3:02 UTC (permalink / raw)
To: linux1394-devel; +Cc: netdev, Stefan Richter
In-Reply-To: <1290906936-14472-1-git-send-email-maximlevitsky@gmail.com>
On Sun, 2010-11-28 at 03:15 +0200, Maxim Levitsky wrote:
> Here is few patches to fix few annoying problems with firewire networking.
>
> I need a feedback on patch #3 from netdev folks.
>
> patch #2 implements initial version of IR/IR resume support.
Sorry for bad spelling and grammar in the changelogs and here, usually I
mange much better than that....
------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox