* Re: [PATCH 15/36] net,rcu: convert call_rcu(ipv6_mc_socklist_reclaim) to kfree_rcu()
From: David Miller @ 2011-03-18 19:36 UTC (permalink / raw)
To: laijs
Cc: paulmck, mingo, kuznet, pekkas, jmorris, yoshfuji, kaber, netdev,
linux-kernel
In-Reply-To: <4D82D8F2.5020208@cn.fujitsu.com>
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Date: Fri, 18 Mar 2011 12:00:50 +0800
>
>
> The rcu callback ipv6_mc_socklist_reclaim() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(ipv6_mc_socklist_reclaim).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 06/36] net,rcu: convert call_rcu(__gen_kill_estimator) to kfree_rcu()
From: David Miller @ 2011-03-18 19:35 UTC (permalink / raw)
To: laijs
Cc: paulmck, mingo, axboe, robert.w.love, James.Bottomley, nhorman,
kuznet, pekkas, jmorris, yoshfuji, kaber, eric.dumazet,
shemminger, tj, jarkao2, linux-kernel, devel, linux-scsi, netdev
In-Reply-To: <4D82D4DE.60105@cn.fujitsu.com>
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Date: Fri, 18 Mar 2011 11:43:26 +0800
>
>
> The rcu callback __gen_kill_estimator() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(__gen_kill_estimator).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 07/36] net, rcu: convert call_rcu(ip_mc_list_reclaim) to kfree_rcu()
From: David Miller @ 2011-03-18 19:35 UTC (permalink / raw)
To: laijs-BthXqXjhjHXQFUHtdCDX3A
Cc: axboe-tSWWG44O7X1aa/9Udqfwiw, pekkas-UjJjq++bwZ7HOG6cAo2yLw,
nhorman-2XuSBdqkA4R54TAoqtyWWQ, yoshfuji-VfPWfsRibaP+Ru+s062T9g,
netdev-u79uwXL29TY76Z2rM5mHXA, shemminger-ZtmgI6mnKB3QT0dZR+AlfA,
jmorris-gx6/JNMH7DfYtjvyW6yDsg,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-scsi-u79uwXL29TY76Z2rM5mHXA, James.Bottomley-l3A5Bk7waGM,
devel-s9riP+hp16TNLxjTenLetw, eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w,
tj-DgEjT+Ai2ygdnm+yROfE0A, kuznet-v/Mj1YrvjDBInbfyfbPRSQ,
mingo-X9Un+BFzKDI, paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8,
kaber-dcUjhNyLwpNeoWH0uzbU5w, jarkao2-Re5JQEeQqe8AvxtiuMwx3w
In-Reply-To: <4D82D508.5080901-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
From: Lai Jiangshan <laijs-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Date: Fri, 18 Mar 2011 11:44:08 +0800
>
>
> The rcu callback ip_mc_list_reclaim() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(ip_mc_list_reclaim).
>
> Signed-off-by: Lai Jiangshan <laijs-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Acked-by: David S. Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
^ permalink raw reply
* Re: [PATCH 08/36] net,rcu: convert call_rcu(ip_sf_socklist_reclaim) to kfree_rcu()
From: David Miller @ 2011-03-18 19:35 UTC (permalink / raw)
To: laijs
Cc: paulmck, mingo, axboe, robert.w.love, James.Bottomley, nhorman,
kuznet, pekkas, jmorris, yoshfuji, kaber, eric.dumazet,
shemminger, tj, jarkao2, linux-kernel, devel, linux-scsi, netdev
In-Reply-To: <4D82D52E.1010501@cn.fujitsu.com>
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Date: Fri, 18 Mar 2011 11:44:46 +0800
>
>
> The rcu callback ip_sf_socklist_reclaim() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(ip_sf_socklist_reclaim).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 18/36] net,rcu: convert call_rcu(xps_dev_maps_release) to kfree_rcu()
From: David Miller @ 2011-03-18 19:36 UTC (permalink / raw)
To: laijs
Cc: paulmck, mingo, eric.dumazet, therbert, ebiederm, gregkh, netdev,
linux-kernel
In-Reply-To: <4D82D967.7090408@cn.fujitsu.com>
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Date: Fri, 18 Mar 2011 12:02:47 +0800
>
>
> The rcu callback xps_dev_maps_release() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(xps_dev_maps_release).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 09/36] net, rcu: convert call_rcu(ip_mc_socklist_reclaim) to kfree_rcu()
From: David Miller @ 2011-03-18 19:36 UTC (permalink / raw)
To: laijs-BthXqXjhjHXQFUHtdCDX3A
Cc: axboe-tSWWG44O7X1aa/9Udqfwiw, pekkas-UjJjq++bwZ7HOG6cAo2yLw,
nhorman-2XuSBdqkA4R54TAoqtyWWQ, yoshfuji-VfPWfsRibaP+Ru+s062T9g,
netdev-u79uwXL29TY76Z2rM5mHXA, shemminger-ZtmgI6mnKB3QT0dZR+AlfA,
jmorris-gx6/JNMH7DfYtjvyW6yDsg,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-scsi-u79uwXL29TY76Z2rM5mHXA, James.Bottomley-l3A5Bk7waGM,
devel-s9riP+hp16TNLxjTenLetw, eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w,
tj-DgEjT+Ai2ygdnm+yROfE0A, kuznet-v/Mj1YrvjDBInbfyfbPRSQ,
mingo-X9Un+BFzKDI, paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8,
kaber-dcUjhNyLwpNeoWH0uzbU5w, jarkao2-Re5JQEeQqe8AvxtiuMwx3w
In-Reply-To: <4D82D544.6090509-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
From: Lai Jiangshan <laijs-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Date: Fri, 18 Mar 2011 11:45:08 +0800
>
>
> The rcu callback ip_mc_socklist_reclaim() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(ip_mc_socklist_reclaim).
>
> Signed-off-by: Lai Jiangshan <laijs-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Acked-by: David S. Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
^ permalink raw reply
* Re: [PATCH 11/36] ixgbe, rcu: convert call_rcu(ring_free_rcu) to kfree_rcu()
From: David Miller @ 2011-03-18 19:36 UTC (permalink / raw)
To: laijs
Cc: e1000-devel, bruce.w.allan, jesse.brandeburg, linux-kernel,
john.ronciak, netdev, mingo, paulmck
In-Reply-To: <4D82D821.1070101@cn.fujitsu.com>
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Date: Fri, 18 Mar 2011 11:57:21 +0800
>
>
> The rcu callback ring_free_rcu() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(ring_free_rcu).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: David S. Miller <davem@davemloft.net>
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
^ permalink raw reply
* Re: [PATCH 14/36] macvlan,rcu: convert call_rcu(macvlan_port_rcu_free) to kfree_rcu()
From: David Miller @ 2011-03-18 19:36 UTC (permalink / raw)
To: laijs; +Cc: paulmck, mingo, kaber, netdev, linux-kernel
In-Reply-To: <4D82D8C7.3040608@cn.fujitsu.com>
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Date: Fri, 18 Mar 2011 12:00:07 +0800
>
>
> The rcu callback macvlan_port_rcu_free() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(macvlan_port_rcu_free).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 16/36] net,rcu: convert call_rcu(rps_map_release) to kfree_rcu()
From: David Miller @ 2011-03-18 19:36 UTC (permalink / raw)
To: laijs
Cc: paulmck, mingo, eric.dumazet, therbert, ebiederm, gregkh, netdev,
linux-kernel
In-Reply-To: <4D82D91B.1080102@cn.fujitsu.com>
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Date: Fri, 18 Mar 2011 12:01:31 +0800
>
>
> The rcu callback rps_map_release() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(rps_map_release).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 17/36] net,rcu: convert call_rcu(xps_map_release) to kfree_rcu()
From: David Miller @ 2011-03-18 19:36 UTC (permalink / raw)
To: laijs
Cc: paulmck, mingo, eric.dumazet, therbert, ebiederm, gregkh, netdev,
linux-kernel
In-Reply-To: <4D82D94C.2090507@cn.fujitsu.com>
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Date: Fri, 18 Mar 2011 12:02:20 +0800
>
>
> The rcu callback xps_map_release() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(xps_map_release).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 28/36] net,rcu: convert call_rcu(phonet_device_rcu_free) to kfree_rcu()
From: David Miller @ 2011-03-18 19:37 UTC (permalink / raw)
To: laijs; +Cc: paulmck, mingo, remi.denis-courmont, netdev, linux-kernel
In-Reply-To: <4D82DADF.4010802@cn.fujitsu.com>
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Date: Fri, 18 Mar 2011 12:09:03 +0800
>
>
> The rcu callback phonet_device_rcu_free() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(phonet_device_rcu_free).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 30/36] net,rcu: convert call_rcu(wq_free_rcu) to kfree_rcu()
From: David Miller @ 2011-03-18 19:37 UTC (permalink / raw)
To: laijs; +Cc: paulmck, mingo, netdev, linux-kernel
In-Reply-To: <4D82DB31.7050007@cn.fujitsu.com>
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Date: Fri, 18 Mar 2011 12:10:25 +0800
>
>
> The rcu callback wq_free_rcu() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(wq_free_rcu).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 20/36] net,rcu: convert call_rcu(netlbl_unlhsh_free_addr4) to kfree_rcu()
From: David Miller @ 2011-03-18 19:36 UTC (permalink / raw)
To: laijs; +Cc: paulmck, mingo, paul.moore, netdev, linux-kernel
In-Reply-To: <4D82D9AC.30205@cn.fujitsu.com>
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Date: Fri, 18 Mar 2011 12:03:56 +0800
>
>
> The rcu callback netlbl_unlhsh_free_addr4() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(netlbl_unlhsh_free_addr4).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 24/36] net,rcu: convert call_rcu(net_generic_release) to kfree_rcu()
From: David Miller @ 2011-03-18 19:37 UTC (permalink / raw)
To: laijs; +Cc: paulmck, mingo, jpirko, eric.dumazet, netdev, linux-kernel
In-Reply-To: <4D82DA48.2070305@cn.fujitsu.com>
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Date: Fri, 18 Mar 2011 12:06:32 +0800
>
>
> The rcu callback net_generic_release() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(net_generic_release).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 25/36] net,rcu: convert call_rcu(__nf_ct_ext_free_rcu) to kfree_rcu()
From: David Miller @ 2011-03-18 19:37 UTC (permalink / raw)
To: laijs
Cc: paulmck, mingo, kaber, netfilter-devel, netfilter, coreteam,
netdev, linux-kernel
In-Reply-To: <4D82DA6D.7030100@cn.fujitsu.com>
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Date: Fri, 18 Mar 2011 12:07:09 +0800
>
>
> The rcu callback __nf_ct_ext_free_rcu() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(__nf_ct_ext_free_rcu).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: [PATCH 36/36] net,rcu: convert call_rcu(xt_osf_finger_free_rcu) to kfree_rcu()
From: David Miller @ 2011-03-18 19:37 UTC (permalink / raw)
To: laijs
Cc: paulmck, mingo, kaber, netfilter-devel, netfilter, coreteam,
netdev, linux-kernel
In-Reply-To: <4D82DC46.5010905@cn.fujitsu.com>
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Date: Fri, 18 Mar 2011 12:15:02 +0800
>
>
> The rcu callback xt_osf_finger_free_rcu() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(xt_osf_finger_free_rcu).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
* Re: patch for format issues and header bug in net/ipv4/icmp.c
From: Ben Hutchings @ 2011-03-18 19:41 UTC (permalink / raw)
To: Jeffrin Jose; +Cc: David S. Miller, Alexey Kuznetsov, linux-kernel, netdev
In-Reply-To: <20110318183529.GA3617@debian.Jeff>
On Sat, 2011-03-19 at 00:05 +0530, Jeffrin Jose wrote:
> hello ,
>
> I have created a patch for net/ipv4/icmp.c
> using checkpatch.pl script to fix several warnings
> and an error.
You need to learn C programming before trying to correct C programs.
You should not just do what it takes to make checkpatch.pl happy.
Ben.
> I have attached the patch along with this mail.
>
> /Thanks
>
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply
* Re: [PATCH] net: implement dev_disable_lro() hw_features compatibility
From: David Miller @ 2011-03-18 19:43 UTC (permalink / raw)
To: bhutchings; +Cc: mirq-linux, netdev
In-Reply-To: <1300471986.2589.26.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Fri, 18 Mar 2011 18:13:06 +0000
> Local function declarations are a very bad idea, as they are not checked
> against the function definition. Please declare the function in
> <linux/ethtool.h>; that does not oblige us to export it.
Agreed.
^ permalink raw reply
* Re: [PATCH] net: ipv4: add IPPROTO_ICMP socket kind
From: David Miller @ 2011-03-18 19:47 UTC (permalink / raw)
To: segoon
Cc: linux-kernel, netdev, peak, solar, kees.cook, dan.j.rosenberg,
eugene, nelhage, kuznet, pekkas, jmorris, yoshfuji, kaber
In-Reply-To: <20110318180002.GA30912@albatros>
From: Vasiliy Kulikov <segoon@openwall.com>
Date: Fri, 18 Mar 2011 21:00:02 +0300
> This patch adds IPPROTO_ICMP socket kind.
I kindly asked the other day for people to not submit new feature
patches while we are amidst the merge window:
http://marc.info/?l=linux-netdev&m=130023005214910&w=2
Please, if you want to do networking development, pay attention to
such important announcements which decreases the burdon upon me and
makes everything operate more smoothly.
Thanks.
^ permalink raw reply
* [PATCH] net: drop NETIF_F_GSO from hw_features without NETIF_F_SG
From: Roger Luethi @ 2011-03-18 19:50 UTC (permalink / raw)
To: netdev; +Cc: mirqus
register_netdevice() removes NETIF_F_GSO from dev->features and
dev->wanted_features for hardware without NETIF_F_SG to "avoid warning from
netdev_fix_features()".
However, as the flag remains set in dev->hw_features, users trying to
enable GSO via ethtool will still end up with NETIF_F_GSO stuck in
wanted_features, resulting in a warning every time they try to change any
feature (until they use ethtool to "disable" GSO):
# ethtool -K eth2 gso on
via-rhine 0000:03:00.0: eth2: Dropping NETIF_F_GSO since no SG feature.
# ethtool -K eth2 rx on
via-rhine 0000:03:00.0: eth2: Dropping NETIF_F_GSO since no SG feature.
via-rhine 0000:03:00.0: eth2: Features changed: 0x00004380 -> 0x20004380
# ethtool -K eth2 rx off
via-rhine 0000:03:00.0: eth2: Dropping NETIF_F_GSO since no SG feature.
via-rhine 0000:03:00.0: eth2: Features changed: 0x20004380 -> 0x00004380
# ethtool -K eth2 gso off
#
With NETIF_F_GSO depending on NETIF_F_SG, it seems we should not
advertise the former as a changeable option if the latter is missing.
---
net/core/dev.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 0d39032..122d4ca 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5433,6 +5433,7 @@ int register_netdevice(struct net_device *dev)
/* Avoid warning from netdev_fix_features() for GSO without SG */
if (!(dev->wanted_features & NETIF_F_SG)) {
+ dev->hw_features &= ~NETIF_F_GSO;
dev->wanted_features &= ~NETIF_F_GSO;
dev->features &= ~NETIF_F_GSO;
}
--
1.7.3.4
^ permalink raw reply related
* Re: LRO disable warnings on kernel 2.6.38
From: David Miller @ 2011-03-18 19:52 UTC (permalink / raw)
To: shemminger
Cc: eric.dumazet, bhutchings, jdb, netdev, nhorman, alexander.h.duyck
In-Reply-To: <20110318081524.42d18bd2@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 18 Mar 2011 08:15:24 -0700
> On Fri, 18 Mar 2011 15:33:04 +0100
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>> Le vendredi 18 mars 2011 à 14:17 +0000, Ben Hutchings a écrit :
>>
>> > WARN is correct as this is a driver bug. But I agree that the
>> > device/driver ID should be included.
>>
>> stack trace gives absolutely no useful indication here.
>>
>> Bug is in driver, yet we dump information on core network stack ?
>>
>> pr_err() is an error indication, not a warning by the way ;)
>
> The advantage of WARN is that it doesn't get ignored and shows
> up in kernel oops. But agreed it should print out as much device
> info as possible to finger the broken device driver.
Infrastructure is not static, therefore we could add a WARN_ON_NETDEV()
or similar. An in fact such things would probably be very useful.
^ permalink raw reply
* Re: patch for format issues and header bug in net/ipv4/icmp.c
From: David Miller @ 2011-03-18 19:57 UTC (permalink / raw)
To: bhutchings; +Cc: ahiliation, kuznet, linux-kernel, netdev
In-Reply-To: <1300477261.2589.28.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Fri, 18 Mar 2011 19:41:01 +0000
> On Sat, 2011-03-19 at 00:05 +0530, Jeffrin Jose wrote:
>> hello ,
>>
>> I have created a patch for net/ipv4/icmp.c
>> using checkpatch.pl script to fix several warnings
>> and an error.
>
> You need to learn C programming before trying to correct C programs.
> You should not just do what it takes to make checkpatch.pl happy.
I completely agree, and I absolutely refuse to apply this patch.
^ permalink raw reply
* Re: LRO disable warnings on kernel 2.6.38
From: Ben Hutchings @ 2011-03-18 19:58 UTC (permalink / raw)
To: David Miller
Cc: shemminger, eric.dumazet, jdb, netdev, nhorman, alexander.h.duyck
In-Reply-To: <20110318.125221.212667543.davem@davemloft.net>
On Fri, 2011-03-18 at 12:52 -0700, David Miller wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Fri, 18 Mar 2011 08:15:24 -0700
>
> > On Fri, 18 Mar 2011 15:33:04 +0100
> > Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >
> >> Le vendredi 18 mars 2011 à 14:17 +0000, Ben Hutchings a écrit :
> >>
> >> > WARN is correct as this is a driver bug. But I agree that the
> >> > device/driver ID should be included.
> >>
> >> stack trace gives absolutely no useful indication here.
> >>
> >> Bug is in driver, yet we dump information on core network stack ?
> >>
> >> pr_err() is an error indication, not a warning by the way ;)
> >
> > The advantage of WARN is that it doesn't get ignored and shows
> > up in kernel oops. But agreed it should print out as much device
> > info as possible to finger the broken device driver.
>
> Infrastructure is not static, therefore we could add a WARN_ON_NETDEV()
> or similar. An in fact such things would probably be very useful.
You mean like netdev_WARN()? :-)
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply
* Re: LRO disable warnings on kernel 2.6.38
From: David Miller @ 2011-03-18 19:59 UTC (permalink / raw)
To: bhutchings
Cc: shemminger, eric.dumazet, jdb, netdev, nhorman, alexander.h.duyck
In-Reply-To: <1300478286.2589.29.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Fri, 18 Mar 2011 19:58:06 +0000
> You mean like netdev_WARN()? :-)
Perfect, but it's be nice if we had a variant where the condition were
embedded into the macro as well.
^ permalink raw reply
* Re: [PATCH] net: ipv4: add IPPROTO_ICMP socket kind
From: Vasiliy Kulikov @ 2011-03-18 19:59 UTC (permalink / raw)
To: David Miller
Cc: linux-kernel, netdev, peak, solar, kees.cook, dan.j.rosenberg,
eugene, nelhage, kuznet, pekkas, jmorris, yoshfuji, kaber
In-Reply-To: <20110318.124711.116396341.davem@davemloft.net>
On Fri, Mar 18, 2011 at 12:47 -0700, David Miller wrote:
> I kindly asked the other day for people to not submit new feature
> patches while we are amidst the merge window:
Sorry, I should have grepped the archives before sending the patch
(I'm not a subscriber of netdev@). I'll wait for .39-rc1.
Thanks,
--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox