* Re: route.c:645 suspicious rcu_dereference_check()
From: David Miller @ 2012-08-31 20:54 UTC (permalink / raw)
To: eric.dumazet; +Cc: proski, netdev
In-Reply-To: <1346413814.2591.7.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 31 Aug 2012 04:50:14 -0700
> On Thu, 2012-08-30 at 13:34 -0400, David Miller wrote:
>> From: Eric Dumazet <eric.dumazet@gmail.com>
>> Date: Tue, 28 Aug 2012 15:33:07 -0700
>>
>> > From: Eric Dumazet <edumazet@google.com>
>> >
>> > [PATCH] ipv4: must use rcu protection while calling fib_lookup
>> >
>> > Following lockdep splat was reported by Pavel Roskin :
>> ...
>> > Signed-off-by: Eric Dumazet <edumazet@google.com>
>> > Reported-by: Pavel Roskin <proski@gnu.org>
>>
>> Applied, thanks.
>>
>> It looks like the redirect handlers might have the same problem?
>
> Hi David
>
> Correct me if I am wrong, but redirect handlers should all run under
> rcu_read_lock() protection already.
>
> rcu_read_lock() is done in ip_local_deliver_finish() or
> ip_rt_send_redirect() for the forward path.
>
> And above of them, we also have rcu_read_lock() done in
> __netif_receive_skb()
Indeed, you're right, thanks.
^ permalink raw reply
* Re: [PATCH 0/3] tcp: TCP Fast Open, Server Side
From: David Miller @ 2012-08-31 20:53 UTC (permalink / raw)
To: hkchu; +Cc: ycheng, edumazet, ncardwell, sivasankar, therbert, netdev
In-Reply-To: <1346369948-1722-1-git-send-email-hkchu@google.com>
From: "H.K. Jerry Chu" <hkchu@google.com>
Date: Thu, 30 Aug 2012 16:39:05 -0700
> This patch series provides the server (passive open) side code
> for TCP Fast Open. Together with the earlier client side patches
> it completes the TCP Fast Open implementation.
Build warnings:
net/ipv4/tcp_ipv4.c: In function ‘tcp_v4_conn_request’:
net/ipv4/tcp_ipv4.c:1480:25: warning: unused variable ‘fastopenq’ [-Wunused-variable]
Please address this and Eric Dumazet's feedback, thanks.
^ permalink raw reply
* Re: [PATCH] bonding: add some slack to arp monitoring time limits
From: David Miller @ 2012-08-31 20:37 UTC (permalink / raw)
To: jbohac; +Cc: fubar, chris.friesen, andy, netdev, ptesarik
In-Reply-To: <20120830220247.GB17263@midget.suse.cz>
From: Jiri Bohac <jbohac@suse.cz>
Date: Fri, 31 Aug 2012 00:02:47 +0200
> Currently, all the time limits in the bonding ARP monitor are in
> multiples of arp_interval -- the time interval at which the ARP
> monitor is periodically scheduled.
>
> With a fast network round-trip and a little scheduling latency
> of the ARP monitor work, a limit of n*delta_in_ticks may
> effectively mean (n-1)*delta_in_ticks.
>
> This is fatal in case of n==1 (the link will stay down
> forever) and makes the behaviour non-deterministic in all the
> other cases.
>
> Add a delta_in_ticks/2 time slack to all the time limits.
>
> Signed-off-by: Jiri Bohac <jbohac@suse.cz>
Applied to net-next, thanks.
^ permalink raw reply
* Re: [PATCH] net: ethernet: fix kernel OOPS when remove davinci_mdio module
From: David Miller @ 2012-08-31 20:35 UTC (permalink / raw)
To: b-liu; +Cc: mugunthanvnm, vaibhav.bedia, netdev, linux-kernel
In-Reply-To: <1346344652-28487-1-git-send-email-b-liu@ti.com>
From: Bin Liu <b-liu@ti.com>
Date: Thu, 30 Aug 2012 11:37:32 -0500
> davinci mdio device is not unregistered from mdiobus when removing
> the module, which causes BUG_ON() when free the device from mdiobus.
>
> Calling mdiobus_unregister() before mdiobus_free() fixes the issue.
>
> Signed-off-by: Bin Liu <b-liu@ti.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] ipv6: remove some deadcode
From: David Miller @ 2012-08-31 20:34 UTC (permalink / raw)
To: sdumitru; +Cc: netdev, kuznet, jmorris, yoshfuji, kaber
In-Reply-To: <1346328105-19541-1-git-send-email-sdumitru@ixiacom.com>
From: Sorin Dumitru <sdumitru@ixiacom.com>
Date: Thu, 30 Aug 2012 15:01:45 +0300
> __ipv6_regen_rndid no longer returns anything other than 0
> so there's no point in verifying what it returns
>
> Signed-off-by: Sorin Dumitru <sdumitru@ixiacom.com>
Applied to net-next, thanks.
^ permalink raw reply
* Re: [PATCH net-next] r8169: add D-Link DGE-560T identifiers.
From: David Miller @ 2012-08-31 20:28 UTC (permalink / raw)
To: bhutchings; +Cc: romieu, netdev, in
In-Reply-To: <1346308591.17040.20.camel@deadeye.wl.decadent.org.uk>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Wed, 29 Aug 2012 23:36:31 -0700
> On Wed, 2012-08-29 at 21:40 +0200, Francois Romieu wrote:
>> This one includes a 8168. Not to be confused with the sky2 driven
>> one whose PCI vendor and device ID are the same.
>>
>> Reported-by: Neyuki Inaya <in@joblog.ru>
>> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
>> ---
>>
>> The patch applies to Linus's branch as well.
>>
>> drivers/net/ethernet/realtek/r8169.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
>> index b47d5b3..ab1cc56 100644
>> --- a/drivers/net/ethernet/realtek/r8169.c
>> +++ b/drivers/net/ethernet/realtek/r8169.c
>> @@ -288,6 +288,8 @@ static DEFINE_PCI_DEVICE_TABLE(rtl8169_pci_tbl) = {
>> { PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8168), 0, 0, RTL_CFG_1 },
>> { PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8169), 0, 0, RTL_CFG_0 },
>> { PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4300), 0, 0, RTL_CFG_0 },
>> + { PCI_VENDOR_ID_DLINK, 0x4300,
>> + PCI_VENDOR_ID_DLINK, 0x4b10, 0, 0, RTL_CFG_1 },
>
> This has no effect, as the preceding entry will match all the same
> devices. I think you need to insert it before that.
Francois please fix up this patch, thanks.
^ permalink raw reply
* Re: [PATCH 5/7] net/xfrm/xfrm_state.c: fix error return code
From: David Miller @ 2012-08-31 20:28 UTC (permalink / raw)
To: Julia.Lawall; +Cc: kernel-janitors, netdev, linux-kernel
In-Reply-To: <1346258957-7649-6-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Wed, 29 Aug 2012 18:49:15 +0200
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Initialize return variable before exiting on an error path.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 2/7] net: ipv6: fix error return code
From: David Miller @ 2012-08-31 20:28 UTC (permalink / raw)
To: Julia.Lawall
Cc: kernel-janitors, kuznet, jmorris, yoshfuji, kaber, netdev,
linux-kernel
In-Reply-To: <1346258957-7649-3-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Wed, 29 Aug 2012 18:49:12 +0200
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Initialize return variable before exiting on an error path.
>
> The initial initialization of the return variable is also dropped, because
> that value is never used.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH] net: qmi_wwan: new device: Foxconn/Novatel E396
From: David Miller @ 2012-08-31 20:25 UTC (permalink / raw)
To: bjorn-yOkvZcmFvRU
Cc: aleksander-bhGbAngMcJvQT0dZR+AlfA, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA, dcbw-H+wXaHxf7aLQT0dZR+AlfA,
benchan-hpIqsD4AKlfQT0dZR+AlfA
In-Reply-To: <87r4qq89ix.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
From: Bjørn Mork <bjorn-yOkvZcmFvRU@public.gmane.org>
Date: Wed, 29 Aug 2012 09:03:34 +0200
> Aleksander Morgado <aleksander-bhGbAngMcJvQT0dZR+AlfA@public.gmane.org> writes:
>
>> Foxconn-branded Novatel E396, Gobi3k modem.
>>
>> Cc: Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> Cc: Bjørn Mork <bjorn-yOkvZcmFvRU@public.gmane.org>
>> Cc: Ben Chan <benchan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
>> Signed-off-by: Aleksander Morgado <aleksander-bhGbAngMcJvQT0dZR+AlfA@public.gmane.org>
...
> If it matters to anyone:
>
> Acked-by: Bjørn Mork <bjorn-yOkvZcmFvRU@public.gmane.org>
Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 1/1] net: fix documentation of skb_needs_linearize().
From: David Miller @ 2012-08-31 20:24 UTC (permalink / raw)
To: rosenr; +Cc: netdev
In-Reply-To: <1346146764-23516-1-git-send-email-rosenr@marvell.com>
From: Rami Rosen <rosenr@marvell.com>
Date: Tue, 28 Aug 2012 12:39:24 +0300
> skb_needs_linearize() does not check highmem DMA as it does not call
> illegal_highdma() anymore, so there is no need to mention highmem DMA here.
>
> (Indeed, ~NETIF_F_SG flag, which is checked in skb_needs_linearize(), can
> be set when illegal_highdma() returns true, and we are assured that
> illegal_highdma() is invoked prior to skb_needs_linearize() as
> skb_needs_linearize() is a static method called only once.
> But ~NETIF_F_SG can be set not only there in this same invocation path.
> It can also be set when can_checksum_protocol() returns false).
>
> see commit 02932ce9e2c136e6fab2571c8e0dd69ae8ec9853,
> Convert skb_need_linearize() to use precomputed features.
> Signed-off-by: Rami Rosen <rosenr@marvell.com>
Applied to net-next, thanks Rami.
^ permalink raw reply
* Re: [PATCH] ipv4: Minor logic clean-up in ipv4_mtu
From: David Miller @ 2012-08-31 20:23 UTC (permalink / raw)
To: alexander.h.duyck; +Cc: netdev, jeffrey.t.kirsher
In-Reply-To: <20120827162930.2969.96733.stgit@gitlad.jf.intel.com>
From: Alexander Duyck <alexander.h.duyck@intel.com>
Date: Mon, 27 Aug 2012 09:30:01 -0700
> In ipv4_mtu there is some logic where we are testing for a non-zero value
> and a timer expiration, then setting the value to zero, and then testing if
> the value is zero we set it to a value based on the dst. Instead of
> bothering with the extra steps it is easier to just cleanup the logic so
> that we set it to the dst based value if it is zero or if the timer has
> expired.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Applied to net-next, thanks.
^ permalink raw reply
* Re: [PATCH v3] net: add new QCA alx ethernet driver
From: David Miller @ 2012-08-31 20:20 UTC (permalink / raw)
To: cjren; +Cc: netdev, linux-kernel, qca-linux-team, nic-devel, xiong, rodrigue
In-Reply-To: <1346083963-17610-1-git-send-email-cjren@qca.qualcomm.com>
From: <cjren@qca.qualcomm.com>
Date: Tue, 28 Aug 2012 00:12:43 +0800
> +/*
> + * Definition to enable some features
> + */
> +#undef CONFIG_ALX_MSIX
> +#undef CONFIG_ALX_MSI
> +#undef CONFIG_ALX_MTQ
> +#undef CONFIG_ALX_MRQ
> +#undef CONFIG_ALX_RSS
> +/* #define CONFIG_ALX_MSIX */
> +#define CONFIG_ALX_MSI
> +#define CONFIG_ALX_MTQ
> +#define CONFIG_ALX_MRQ
> +#ifdef CONFIG_ALX_MRQ
> +#define CONFIG_ALX_RSS
> +#endif
> +
Get rid of all of these. You may never use private feature control macros
in the CONFIG_* namespace, those are for the Kconfig system only.
Local controls of this nature are only appropriate for a driver amidst
development, and not a final version that should be included in the
upstream kernel tree.
You must remove all of these CPP macros, and all code that is currently
protected by the ones which are off.
Just so that your expectations are set appropriately, I anticipate
that there will be at least 5 more rounds of review for things of this
nature before we can even remotely consider adding this driver to the
tree. This driver is very poorly written and is far away from meeting
our standards for incusion.
^ permalink raw reply
* Re: [PATCH 2/5] net:atm:fix up ENOIOCTLCMD error handling
From: David Miller @ 2012-08-31 20:14 UTC (permalink / raw)
To: gaowanlong; +Cc: linux-kernel, netdev
In-Reply-To: <1346052196-32682-3-git-send-email-gaowanlong@cn.fujitsu.com>
From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Date: Mon, 27 Aug 2012 15:23:13 +0800
> At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
> translated as ENOTTY to user mode.
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Applied to net-next, thanks.
^ permalink raw reply
* Re: [Stlinux-devel] [PATCH linux-stm 4/4] net:stmmac: convert driver to use devm_request_and_ioremap.
From: David Miller @ 2012-08-31 20:13 UTC (permalink / raw)
To: srinivas.kandagatla; +Cc: netdev, peppe.cavallaro
In-Reply-To: <1346341869-20211-1-git-send-email-srinivas.kandagatla@st.com>
From: Srinivas KANDAGATLA <srinivas.kandagatla@st.com>
Date: Thu, 30 Aug 2012 16:51:09 +0100
> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>
> This patch moves calls to ioremap and request_mem_region to
> devm_request_and_ioremap call.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
Applied.
^ permalink raw reply
* Re: [Stlinux-devel] [PATCH linux-stm 3/4] net/stmmac: Remove bus_id from mdio platform data.
From: David Miller @ 2012-08-31 20:13 UTC (permalink / raw)
To: srinivas.kandagatla; +Cc: netdev, peppe.cavallaro
In-Reply-To: <1346341843-20169-1-git-send-email-srinivas.kandagatla@st.com>
From: Srinivas KANDAGATLA <srinivas.kandagatla@st.com>
Date: Thu, 30 Aug 2012 16:50:43 +0100
> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>
> This patch removes bus_id from mdio platform data, The reason to remove
> bus_id is, stmmac mdio bus_id is always same as stmmac bus-id, so there
> is no point in passing this in different variable.
> Also stmmac ethernet driver connects to phy with bus_id passed its
> platform data.
> So, having single bus-id is much simpler.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
Applied.
^ permalink raw reply
* Re: [Stlinux-devel] [PATCH linux-stm 2/4] net:stmmac: fix broken stmmac_pltfr_remove.
From: David Miller @ 2012-08-31 20:12 UTC (permalink / raw)
To: srinivas.kandagatla; +Cc: netdev, peppe.cavallaro
In-Reply-To: <1346341819-20125-1-git-send-email-srinivas.kandagatla@st.com>
From: Srinivas KANDAGATLA <srinivas.kandagatla@st.com>
Date: Thu, 30 Aug 2012 16:50:19 +0100
> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>
> This patch fixes stmmac_pltfr_remove function, which is broken because,
> it is accessing plat variable via freed memory priv pointer which gets
> freed by free_netdev called from stmmac_dvr_remove.
>
> In short this patch caches the plat pointer in local variable before
> calling stmmac_dvr_remove to prevent code accessing freed memory.
>
> Without this patch any attempt to remove the stmmac device will fail as
> below:
...
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
Applied.
^ permalink raw reply
* Re: [Stlinux-devel] [PATCH linux-stm 1/4] net:stmmac: Add check if mdiobus is registered in stmmac_mdio_unregister
From: David Miller @ 2012-08-31 20:12 UTC (permalink / raw)
To: srinivas.kandagatla; +Cc: netdev, peppe.cavallaro
In-Reply-To: <1346341798-19704-1-git-send-email-srinivas.kandagatla@st.com>
From: Srinivas KANDAGATLA <srinivas.kandagatla@st.com>
Date: Thu, 30 Aug 2012 16:49:58 +0100
> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>
> This patch adds a basic check in stmmac_mdio_unregister to see if mdio
> bus registeration for this driver was actually sucessfull or not.
>
> Use case here is, if BSP considers using mdio-gpio bus along with stmmac
> driver by passing mdio_bus_data as NULL in platform data.
> Call to stmmac_mdio_register with mdio_bus_data as NULL returns 0, which
> is a considered sucessfull call form stmmac. Then again when we unload
> the driver we just call stmmac_mdio_unregister, this is were the actual
> problem is stmmac-mdio code dont really know at this instance of calling
> that stmmac_mdio_register was actually successful.
>
> So Adding a check in stmmac_mdio_unregister is always safe.
>
> Without this patch stmmac driver calls stmmac_mdio_register from
> stmmac_release which Segfaults as mii bus was never registered at the
> first point.
>
> Originally the this bug was found when unloading an stmmac driver
> instance which uses mdio-gpio for smi access.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
Applied.
^ permalink raw reply
* Re: [PATCH] usbnet: fix deadlock in resume
From: David Miller @ 2012-08-31 20:12 UTC (permalink / raw)
To: oliver; +Cc: netdev, ming.lei, oneukum, stable
In-Reply-To: <1346049698-10740-1-git-send-email-oliver@neukum.org>
From: oliver@neukum.org
Date: Mon, 27 Aug 2012 08:41:38 +0200
> From: Oliver Neukum <oliver@neukum.org>
>
> A usbnet device can share a multifunction device
> with a storage device. If the storage device is autoresumed
> the usbnet devices also needs to be autoresumed. Allocating
> memory with GFP_KERNEL can deadlock in this case.
>
> This should go back into all kernels that have
> commit 65841fd5132c3941cdf5df09e70df3ed28323212
> That is 3.5
>
> Signed-off-by: Oliver Neukum <oneukum@suse.de>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 01/12] qlcnic: Refactoring - template based hardware interface
From: David Miller @ 2012-08-31 20:05 UTC (permalink / raw)
To: sony.chacko; +Cc: netdev, Dept_NX_Linux_NIC_Driver, anirban.chakraborty
In-Reply-To: <1346394541-3486-2-git-send-email-sony.chacko@qlogic.com>
From: Sony Chacko <sony.chacko@qlogic.com>
Date: Fri, 31 Aug 2012 02:28:50 -0400
> +static inline int
> +qlcnic_config_bridged_mode(struct qlcnic_adapter *adapter, u32 enable)
> +{
> + return adapter->nic_ops->config_bridged_mode(adapter, enable);
> +
> +}
> +
> +static inline int
> +qlcnic_config_led(struct qlcnic_adapter *adapter, u32 state, u32 rate)
> +{
> + return adapter->nic_ops->config_led(adapter, state, rate);
> +
> +}
> +
Please get rid of those unnecessary empty lines in the function bodies.
^ permalink raw reply
* Re: [net-next 0/8][pull request] Intel Wired LAN Driver Updates
From: David Miller @ 2012-08-31 20:03 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, sassmann
In-Reply-To: <1346390174-30449-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 30 Aug 2012 22:16:06 -0700
> This series contains updates to e1000e and ixgbevf.
>
> The following are changes since commit 761743ebc92df72053e736fce953a5d2e90099d5:
> net/fsl_pq_mdio: add support for the Fman 1G MDIO controller
> and are available in the git repository at:
> git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master
Pulled, thanks Jeff.
^ permalink raw reply
* Re: [PATCH] openvswitch: using kfree_rcu() to simplify the code
From: David Miller @ 2012-08-31 19:57 UTC (permalink / raw)
To: jesse; +Cc: weiyj.lk, yongjun_wei, dev, netdev
In-Reply-To: <CAEP_g=_9PYpQQbu-1eH7uF-Dk1+LbOfW1GAS6v6=Vu-8hq42yg@mail.gmail.com>
From: Jesse Gross <jesse@nicira.com>
Date: Tue, 28 Aug 2012 16:00:24 -0700
> On Sun, Aug 26, 2012 at 9:20 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> The callback function of call_rcu() just calls a kfree(), so we
>> can use kfree_rcu() instead of call_rcu() + callback function.
>>
>> spatch with a semantic match is used to found this problem.
>> (http://coccinelle.lip6.fr/)
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Thanks Wei.
>
> Acked-by: Jesse Gross <jesse@nicira.com>
Applied to net-next
^ permalink raw reply
* Re: [PATCH] af_unix: fix shutdown parameter checking
From: David Miller @ 2012-08-31 19:57 UTC (permalink / raw)
To: xi.wang; +Cc: netdev, linux-kernel
In-Reply-To: <1346035633-2492-1-git-send-email-xi.wang@gmail.com>
From: Xi Wang <xi.wang@gmail.com>
Date: Sun, 26 Aug 2012 22:47:13 -0400
> Return -EINVAL rather than 0 given an invalid "mode" parameter.
>
> Signed-off-by: Xi Wang <xi.wang@gmail.com>
Applied to net-next
^ permalink raw reply
* Re: [PATCH] decnet: fix shutdown parameter checking
From: David Miller @ 2012-08-31 19:57 UTC (permalink / raw)
To: swhiteho; +Cc: xi.wang, netdev, linux-kernel
In-Reply-To: <1346059001.2703.7.camel@menhir>
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Mon, 27 Aug 2012 10:16:41 +0100
> On Sun, 2012-08-26 at 22:37 -0400, Xi Wang wrote:
>> The allowed value of "how" is SHUT_RD/SHUT_WR/SHUT_RDWR (0/1/2),
>> rather than SHUTDOWN_MASK (3).
>>
>> Signed-off-by: Xi Wang <xi.wang@gmail.com>
> Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Applied to net-next.
> Although it could be argued that we should also continue to accept the
> value 3 just in case there is any userland software out there which
> sends that value,
True, but this is a rather standard BSD socket interface with a very
specific small set of legitimate input parameters. Allowing
deviation, even for compatability for specific protocols, is largely
unwise.
^ permalink raw reply
* Re: [PATCH v2] cs89x0 : packet reception not working
From: David Miller @ 2012-08-31 19:49 UTC (permalink / raw)
To: jaccon.bastiaansen; +Cc: joe, linux-arm-kernel, netdev, s.hauer, festevam
In-Reply-To: <1346104431-3784-1-git-send-email-jaccon.bastiaansen@gmail.com>
From: Jaccon Bastiaansen <jaccon.bastiaansen@gmail.com>
Date: Mon, 27 Aug 2012 23:53:51 +0200
> The RxCFG register of the CS89x0 could be configured incorrectly
> (because of misplaced parentheses), resulting in the disabling
> of packet reception.
>
> Signed-off-by: Jaccon Bastiaansen <jaccon.bastiaansen@gmail.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply
* Re: [PATCH 1/1] tcp: Wrong timeout for SYN segments
From: David Miller @ 2012-08-31 19:47 UTC (permalink / raw)
To: eric.dumazet; +Cc: alex, hkjerry.chu, netdev, linux-kernel
In-Reply-To: <20120831.154234.735439593093335863.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Fri, 31 Aug 2012 15:42:34 -0400 (EDT)
> Applied with some minor comment formatting and wording adjustments.
BTW, please keep in mind that when you modify the value
of TCP_SYN_RETRIES, you are having an influence upon DCCP
as well.
TCP is not the only protocol which uses this value.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox