* Re: [Patch net-next] vlan: use IS_ENABLED()
From: David Miller @ 2012-11-03 19:03 UTC (permalink / raw)
To: amwang; +Cc: netdev
In-Reply-To: <1351567348-15229-1-git-send-email-amwang@redhat.com>
From: Cong Wang <amwang@redhat.com>
Date: Tue, 30 Oct 2012 11:22:28 +0800
> #if defined(CONFIG_FOO) || defined(CONFIG_FOO_MODULE)
>
> can be replaced by
>
> #if IS_ENABLED(CONFIG_FOO)
>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Cong Wang <amwang@redhat.com>
Applied.
^ permalink raw reply
* Re: [PATCH] net/at91_ether: fix the use of macb structure
From: David Miller @ 2012-11-03 19:04 UTC (permalink / raw)
To: nicolas.ferre
Cc: netdev, havard, bhutchings, linux-arm-kernel, plagnioj,
patrice.vilchez, linux-kernel, manabian
In-Reply-To: <1351596628-3405-1-git-send-email-nicolas.ferre@atmel.com>
From: Nicolas Ferre <nicolas.ferre@atmel.com>
Date: Tue, 30 Oct 2012 12:30:28 +0100
> Due to the use of common structure in at91_ether and macb drivers,
> change the name of DMA descriptor structures in at91_ether as well:
> dma_desc => macb_dma_desc
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
This does not apply to net-next, respin it if this change is
still relevant.
^ permalink raw reply
* Re: [PATCH] if_ether.h: add B.A.T.M.A.N.-Advanced Ethertype
From: David Miller @ 2012-11-03 19:05 UTC (permalink / raw)
To: ordex-GaUfNO9RBHfsrOwW+9ziJQ
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r
In-Reply-To: <1351606121-2405-1-git-send-email-ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
From: Antonio Quartulli <ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
Date: Tue, 30 Oct 2012 15:08:41 +0100
> Add Ethertype 0x4305 (not an officially registered id).
> This Ethertype is used by every frame generated by B.A.T.M.A.N.-Advanced. Its
> definition is currently batman-adv local only and since it is not officially
> registered it is better to make its definition kernel-wide so that we avoid
> collisions given by future unofficial uses of the same Ethertype.
>
> Signed-off-by: Antonio Quartulli <ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
Applied.
^ permalink raw reply
* Re: [PATCH 3/3] tipc: do not use tasklet_disable before tasklet_kill
From: David Miller @ 2012-11-03 19:15 UTC (permalink / raw)
To: xtfeng
Cc: linux-kernel, dannyfeng, jon.maloy, allan.stephens, netdev,
tipc-discussion
In-Reply-To: <1351670761-26749-3-git-send-email-xtfeng@gmail.com>
From: Xiaotian Feng <xtfeng@gmail.com>
Date: Wed, 31 Oct 2012 16:06:01 +0800
> If tasklet_disable() is called before related tasklet handled,
> tasklet_kill will never be finished. tasklet_kill is enough.
>
> Signed-off-by: Xiaotian Feng <dannyfeng@tencent.com>
Applied.
^ permalink raw reply
* Re: [PATCH] drivers/net: use tasklet_kill in device remove/close process
From: David Miller @ 2012-11-03 19:16 UTC (permalink / raw)
To: xtfeng; +Cc: linux-kernel, dannyfeng, netdev
In-Reply-To: <1351679397-26994-1-git-send-email-xtfeng@gmail.com>
From: Xiaotian Feng <xtfeng@gmail.com>
Date: Wed, 31 Oct 2012 18:29:57 +0800
> Some driver uses tasklet_disable in device remove/close process,
> tasklet_disable will inc tasklet->count and return. If the tasklet
> is not handled yet because some softirq pressure, the tasklet will
> placed on the tasklet_vec, never have a chance to excute. This might
> lead to ksoftirqd heavy loaded, wakeup with pending_softirq, but
> tasklet is disabled. tasklet_kill should be used in this case.
>
> Signed-off-by: Xiaotian Feng <dannyfeng@tencent.com>
Applied.
^ permalink raw reply
* Re: [RFC] net: netlink -- Allow netlink_dump to return error code if protocol handler is missed
From: Cyrill Gorcunov @ 2012-11-03 19:16 UTC (permalink / raw)
To: Pavel Emelyanov; +Cc: NETDEV, David Miller, Eric Dumazet
In-Reply-To: <20121103163958.GB6055@moon>
On Sat, Nov 03, 2012 at 08:39:58PM +0400, Cyrill Gorcunov wrote:
> On Sat, Nov 03, 2012 at 08:17:50PM +0400, Pavel Emelyanov wrote:
> > > static int inet_diag_dump(struct sk_buff *skb, struct netlink_callback *cb)
> > > Index: linux-2.6.git/net/netlink/af_netlink.c
> > > ===================================================================
> > > --- linux-2.6.git.orig/net/netlink/af_netlink.c
> > > +++ linux-2.6.git/net/netlink/af_netlink.c
> > > @@ -1740,6 +1740,10 @@ static int netlink_dump(struct sock *sk)
> > > else
> > > __netlink_sendskb(sk, skb);
> > > return 0;
> > > + } else if (len < 0) {
> > > + err = len;
> > > + nlk->cb = NULL;
> > > + goto errout_skb;
> >
> > When family-level handler is absent and sock_diag returns error this error
> > gets propagated back to user without this fix. Why do we need it in case
> > we return error from protocol-level handler?
>
> Because as far as I can say the family-level handler already has such error
> returning code in __sock_diag_rcv_msg. Or you mean something else?
OK, it seems I got what you mean, cooking/testing new patch.
^ permalink raw reply
* Re: [PATCH v2] r8169: Fix WoL on RTL8168d/8111d.
From: David Miller @ 2012-11-03 19:16 UTC (permalink / raw)
To: romieu; +Cc: kibi, netdev, nic_swsd, hayeswang, linux-kernel, florent.fourcot
In-Reply-To: <20121101222113.GB7708@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Thu, 1 Nov 2012 23:21:13 +0100
> Cyril Brulebois <kibi@debian.org> :
>> This regression was spotted between Debian squeeze and Debian wheezy
>> kernels (respectively based on 2.6.32 and 3.2). More info about
>> Wake-on-LAN issues with Realtek's 816x chipsets can be found in the
>> following thread: http://marc.info/?t=132079219400004
>
> David, please apply to -net.
Done.
^ permalink raw reply
* Re: [PATCH 1/9] batman-adv: add UNICAST_4ADDR packet type
From: David Miller @ 2012-11-03 19:22 UTC (permalink / raw)
To: ordex-GaUfNO9RBHfsrOwW+9ziJQ
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r
In-Reply-To: <1351968514-12357-2-git-send-email-ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
From: Antonio Quartulli <ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
Date: Sat, 3 Nov 2012 19:48:26 +0100
> The current unicast packet type does not contain the orig source address. This
> patches add a new unicast packet (called UNICAST_4ADDR) which provides two new
> fields: the originator source address and the subtype (the type of the data
> contained in the packet payload). The former is useful to identify the node
> which injected the packet into the network and the latter is useful to avoid
> creating new unicast packet types in the future: a macro defining a new subtype
> will be enough.
>
> Signed-off-by: Antonio Quartulli <ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
Your packet layouts are very poorly designed and I want you to stop
and think seriously about things before extending things further.
All of this __packed stuff is a serious problem.
It means that on RISC system, fields such as your 32-bit sequence
number, will be read and written using byte loads and stores.
This is terrible.
Instead, design the structures so that they are full filled out to
at least 4 byte boundaries, so that they and the contents after
them, are 4 byte aligned too.
Then you won't need to mark all of your packet header structs
with __packed, and therefore the compiler can use full 32-bit
loads and stores to access 32-bit fields.
I'm not applying this series, sorry, it just continues a major
problem that the batman-adv code already has.
^ permalink raw reply
* Re: [PATCH 1/1] smsc75xx: add wol support for more frame types
From: David Miller @ 2012-11-03 19:24 UTC (permalink / raw)
To: steve.glendinning; +Cc: netdev
In-Reply-To: <1351619192-11022-2-git-send-email-steve.glendinning@shawell.net>
From: Steve Glendinning <steve.glendinning@shawell.net>
Date: Tue, 30 Oct 2012 17:46:32 +0000
> This patch adds support for wol wakeup on unicast, broadcast,
> multicast and arp frames.
>
> Signed-off-by: Steve Glendinning <steve.glendinning@shawell.net>
Applied.
^ permalink raw reply
* Re: [PATCH] vxlan: allow a user to set TTL value
From: David Miller @ 2012-11-03 19:25 UTC (permalink / raw)
To: bernat; +Cc: shemminger, netdev
In-Reply-To: <1351628836-23094-1-git-send-email-bernat@luffy.cx>
From: Vincent Bernat <bernat@luffy.cx>
Date: Tue, 30 Oct 2012 21:27:16 +0100
> "ip link add ... type vxlan ... ttl X" allows a user to set the TTL
> used by a VXLAN for encapsulation. The provided value was ignored by
> vxlan module and the default value of 1 was used when encapsulating
> multicast packets.
>
> Signed-off-by: Vincent Bernat <bernat@luffy.cx>
Applied net-next.
^ permalink raw reply
* Re: [PATCH net-next V3] htb: improved accuracy at high rates
From: David Miller @ 2012-11-03 19:25 UTC (permalink / raw)
To: j.vimal; +Cc: jhs, eric.dumazet, netdev
In-Reply-To: <1351699451-79317-1-git-send-email-j.vimal@gmail.com>
From: Vimalkumar <j.vimal@gmail.com>
Date: Wed, 31 Oct 2012 09:04:11 -0700
> Current HTB (and TBF) uses rate table computed by the "tc"
> userspace program, which has the following issue:
>
> The rate table has 256 entries to map packet lengths
> to token (time units). With TSO sized packets, the
> 256 entry granularity leads to loss/gain of rate,
> making the token bucket inaccurate.
>
> Thus, instead of relying on rate table, this patch
> explicitly computes the time and accounts for packet
> transmission times with nanosecond granularity.
>
> This greatly improves accuracy of HTB with a wide
> range of packet sizes.
...
> Signed-off-by: Vimalkumar <j.vimal@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net 1/1] r8169: allow multicast packets on sub-8168f chipset.
From: David Miller @ 2012-11-03 19:27 UTC (permalink / raw)
To: romieu; +Cc: netdev, hayeswang, faceprint
In-Reply-To: <20121101220847.GA7708@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Thu, 1 Nov 2012 23:08:47 +0100
> From: Nathan Walp <faceprint@faceprint.com>
>
> RTL_GIGA_MAC_VER_35 includes no multicast hardware filter.
>
> Signed-off-by: Nathan Walp <faceprint@faceprint.com>
> Suggested-by: Hayes Wang <hayeswang@realtek.com>
> Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Applied.
^ permalink raw reply
* Re: [net] ptp: update adjfreq callback description
From: David Miller @ 2012-11-03 19:27 UTC (permalink / raw)
To: jeffrey.t.kirsher
Cc: jacob.e.keller, netdev, gospo, sassmann, stable, richard.cochran,
john.stultz
In-Reply-To: <1351809016-29237-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 1 Nov 2012 15:30:16 -0700
> From: Jacob Keller <jacob.e.keller@intel.com>
>
> This patch updates the adjfreq callback description to include a note that the
> delta in ppb is always relative to the base frequency, and not to the current
> frequency of the hardware clock.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> CC: stable@vger.kernel.org [v3.5+]
> CC: Richard Cochran <richard.cochran@gmail.com>
> CC: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net PATCH] rtnetlink: Use nlmsg type RTM_NEWNEIGH from dflt fdb dump
From: David Miller @ 2012-11-03 19:27 UTC (permalink / raw)
To: john.r.fastabend; +Cc: netdev
In-Reply-To: <20121102022310.2692.60718.stgit@jf-dev1-dcblab>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Thu, 01 Nov 2012 19:23:10 -0700
> Change the dflt fdb dump handler to use RTM_NEWNEIGH to
> be compatible with bridge dump routines.
>
> The dump reply from the network driver handlers should
> match the reply from bridge handler. The fact they were
> not in the ixgbe case was effectively a bug. This patch
> resolves it.
>
> Applications that were not checking the nlmsg type will
> continue to work. And now applications that do check
> the type will work as expected.
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied.
^ permalink raw reply
* [PATCH] net: inet_diag -- Return error code if protocol handler is missed
From: Cyrill Gorcunov @ 2012-11-03 19:30 UTC (permalink / raw)
To: NETDEV; +Cc: David Miller, Eric Dumazet, Pavel Emelyanov
We've observed that in case if UDP diag module is not
supported in kernel the netlink returns NLMSG_DONE without
notifying a caller that handler is missed.
This patch makes __inet_diag_dump to return error code instead.
So as example it become possible to detect such situation
and handle it gracefully on userspace level.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
CC: David Miller <davem@davemloft.net>
CC: Eric Dumazet <eric.dumazet@gmail.com>
CC: Pavel Emelyanov <xemul@parallels.com>
---
net/ipv4/inet_diag.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Index: linux-2.6.git/net/ipv4/inet_diag.c
===================================================================
--- linux-2.6.git.orig/net/ipv4/inet_diag.c
+++ linux-2.6.git/net/ipv4/inet_diag.c
@@ -895,13 +895,16 @@ static int __inet_diag_dump(struct sk_bu
struct inet_diag_req_v2 *r, struct nlattr *bc)
{
const struct inet_diag_handler *handler;
+ int err = 0;
handler = inet_diag_lock_handler(r->sdiag_protocol);
if (!IS_ERR(handler))
handler->dump(skb, cb, r, bc);
+ else
+ err = PTR_ERR(handler);
inet_diag_unlock_handler(handler);
- return skb->len;
+ return err ? : skb->len;
}
static int inet_diag_dump(struct sk_buff *skb, struct netlink_callback *cb)
^ permalink raw reply
* Re: [PATCH] smsc95xx: fix tx checksum offload for big endian
From: David Miller @ 2012-11-03 19:30 UTC (permalink / raw)
To: steve.glendinning; +Cc: netdev, jose.ventura
In-Reply-To: <1351853060-2330-1-git-send-email-steve.glendinning@shawell.net>
From: Steve Glendinning <steve.glendinning@shawell.net>
Date: Fri, 2 Nov 2012 10:44:20 +0000
> f7b2927 introduced tx checksum offload support for smsc95xx,
> and enabled it by default. This feature doesn't take
> endianness into account, so causes most tx to fail on
> those platforms.
>
> This patch fixes the problem fully by adding the missing
> conversion.
>
> An alternate workaround is to disable TX checksum offload
> on those platforms. The cpu impact of this feature is very low.
>
> Signed-off-by: Steve Glendinning <steve.glendinning@shawell.net>
Applied and queued up for -stable, thanks.
^ permalink raw reply
* Re: [PATCH] [trivial] net: bnx2x: Fix typo in bnx2x driver
From: David Miller @ 2012-11-03 19:32 UTC (permalink / raw)
To: standby24x7; +Cc: trivial, linux-kernel, eilong, netdev
In-Reply-To: <1351866977-6251-1-git-send-email-standby24x7@gmail.com>
From: Masanari Iida <standby24x7@gmail.com>
Date: Fri, 2 Nov 2012 23:36:17 +0900
> Correct spelling typo in bnx2x driver
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] ptp: fixup Kconfig for two PHC drivers.
From: David Miller @ 2012-11-03 19:37 UTC (permalink / raw)
To: richardcochran; +Cc: netdev
In-Reply-To: <1351850258-5072-1-git-send-email-richardcochran@gmail.com>
From: Richard Cochran <richardcochran@gmail.com>
Date: Fri, 2 Nov 2012 10:57:38 +0100
> Ben Hutchings recently came up with a better way to handle the kconfig
> dependencies for the PTP hardware clocks. This patch converts one new and
> one older driver to the new scheme.
>
> Signed-off-by: Richard Cochran <richardcochran@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH RESEND] net: sh_eth: Fix a typo - replace regist with register.
From: David Miller @ 2012-11-03 19:38 UTC (permalink / raw)
To: yoshfuji; +Cc: netdev
In-Reply-To: <201211021445.qA2Ej7f8005697@94.43.138.210.xn.2iij.net>
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Fri, 2 Nov 2012 23:45:07 +0900
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Applied.
^ permalink raw reply
* Re: [PATCH RESEND] net: neterion: Do not break word unregister.
From: David Miller @ 2012-11-03 19:38 UTC (permalink / raw)
To: yoshfuji; +Cc: netdev
In-Reply-To: <201211021445.qA2EjOoL005756@94.43.138.210.xn.2iij.net>
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Fri, 2 Nov 2012 23:45:24 +0900
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] macb: Keep driver's speed/duplex in sync with actual NCFGR
From: David Miller @ 2012-11-03 19:38 UTC (permalink / raw)
To: vitas; +Cc: netdev, nicolas.ferre, plagnioj, havard, jamie, linux-arm-kernel
In-Reply-To: <201211021909.25473.vitas@nppfactor.kiev.ua>
From: Vitalii Demianets <vitas@nppfactor.kiev.ua>
Date: Fri, 2 Nov 2012 19:09:24 +0200
> When underlying phy driver restores its state very fast after being brought
> down and up so that macb driver function macb_handle_link_change() was never
> called with link state "down", driver's internal representation of phy speed
> and duplex (bp->speed and bp->duplex) didn't change. So, macb driver sees no
> reason to perform actual write to the NCFGR register, although the speed and
> duplex settings in that register were reset when interface was brought down
> and up. In that case actual phy speed and duplex differ from NCFGR settings.
> The patch fixes that by keeping internal driver representation of speed and
> duplex in sync with actual content of NCFGR.
>
> Signed-off-by: Vitalii Demianets <vitas@nppfactor.kiev.ua>
Applied.
^ permalink raw reply
* Re: [net-next PATCH] net: fix bridge notify hook to manage flags correctly
From: David Miller @ 2012-11-03 19:38 UTC (permalink / raw)
To: john.r.fastabend; +Cc: bhutchings, netdev
In-Reply-To: <20121103023236.8177.63714.stgit@localhost6.localdomain6>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Fri, 02 Nov 2012 19:32:36 -0700
> The bridge notify hook rtnl_bridge_notify() was not handling the
> case where the master flags was set or with both flags set. First
> flags are not being passed correctly and second the logic to parse
> them is broken.
>
> This patch passes the original flags value and fixes the
> logic.
>
> Reported-by: Ben Hutchings <bhutchings@solarflare.com>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 0/2] cpsw: fix resource leak for v3.8
From: David Miller @ 2012-11-03 19:38 UTC (permalink / raw)
To: richardcochran; +Cc: netdev, linux-arm-kernel, cyril, mugunthanvnm, hvaibhav
In-Reply-To: <cover.1351930782.git.richardcochran@gmail.com>
From: Richard Cochran <richardcochran@gmail.com>
Date: Sat, 3 Nov 2012 09:25:28 +0100
> While looking at the idea of removing all of the register offsets in
> the CPSW's device tree, I noticed that the driver would be leaking IO
> mappings. Although this is, strictly speaking, a bug fix, still it can
> wait to appear in v3.8, since there is no way to use the driver in
> v3.7 (or earlier) anyhow.
All applied, thanks.
^ permalink raw reply
* Re: [PATCH 10/16] drivers/net/ethernet/ibm/emac/mal.c: use WARN
From: David Miller @ 2012-11-03 19:43 UTC (permalink / raw)
To: Julia.Lawall; +Cc: netdev, kernel-janitors, linux-kernel
In-Reply-To: <1351940317-14812-11-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sat, 3 Nov 2012 11:58:31 +0100
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Use WARN rather than printk followed by WARN_ON(1), for conciseness.
>
> A simplified version of the semantic patch that makes this transformation
> is as follows: (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH] atp: remove set_rx_mode_8012()
From: David Miller @ 2012-11-03 19:43 UTC (permalink / raw)
To: pebolle; +Cc: netdev, linux-kernel
In-Reply-To: <1351936395.1434.2.camel@x61.thuisdomein>
From: Paul Bolle <pebolle@tiscali.nl>
Date: Sat, 03 Nov 2012 10:53:15 +0100
> Building atp.o triggers this GCC warning:
> drivers/net/ethernet/realtek/atp.c: In function ‘set_rx_mode’:
> drivers/net/ethernet/realtek/atp.c:871:26: warning: ‘mc_filter[0]’ may be used uninitialized in this function [-Wuninitialized]
>
> GCC is correct. In promiscuous mode 'mc_filter' will be used
> uninitialized in set_rx_mode_8012(), which is apparently inlined into
> set_rx_mode().
>
> But it turns out set_rx_mode_8012() will never be called, since
> net_local.chip_type will always be RTL8002. So we can just remove
> set_rx_mode_8012() and do some related cleanups.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox