* Re: [PATCH net-next v2] tcp: Change return value of tcp_rcv_established()
From: David Miller @ 2013-09-04 4:55 UTC (permalink / raw)
To: subramanian.vijay; +Cc: netdev
In-Reply-To: <1378236202-27486-1-git-send-email-subramanian.vijay@gmail.com>
From: Vijay Subramanian <subramanian.vijay@gmail.com>
Date: Tue, 3 Sep 2013 12:23:22 -0700
> tcp_rcv_established() returns only one value namely 0. We change the return
> value to void (as suggested by David Miller).
>
> After commit 0c24604b (tcp: implement RFC 5961 4.2), we no longer send RSTs in
> response to SYNs. We can remove the check and processing on the return value of
> tcp_rcv_established().
>
> We also fix jtcp_rcv_established() in tcp_probe.c to match that of
> tcp_rcv_established().
>
>
> Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] net: tcp_probe: adapt tbuf size for recent changes
From: David Miller @ 2013-09-04 4:55 UTC (permalink / raw)
To: dborkman; +Cc: netdev
In-Reply-To: <1378225442-6676-1-git-send-email-dborkman@redhat.com>
From: Daniel Borkmann <dborkman@redhat.com>
Date: Tue, 3 Sep 2013 18:24:02 +0200
> With recent changes in tcp_probe module (e.g. f925d0a62d ("net: tcp_probe:
> add IPv6 support")) we also need to take into account that tbuf needs to
> be updated as format string will be further expanded. tbuf sits on the stack
> in tcpprobe_read() function that is invoked when user space reads procfs
> file /proc/net/tcpprobe, hence not fast path as in jtcp_rcv_established().
> Having a size similarly as in sctp_probe module of 256 bytes is fully
> sufficient for that, we need theoretical maximum of 252 bytes otherwise we
> could get truncated.
>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 1/1] qlcnic: Fix sparse warning.
From: David Miller @ 2013-09-04 4:54 UTC (permalink / raw)
To: sucheta.chakraborty; +Cc: netdev, Dept-HSGLinuxNICDev
In-Reply-To: <1378199257-9514-1-git-send-email-sucheta.chakraborty@qlogic.com>
From: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>
Date: Tue, 3 Sep 2013 05:07:37 -0400
> This patch fixes warning "warning: symbol 'qlcnic_set_dcb_ops' was
> not declared. Should it be static?"
>
> Signed-off-by: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>
Applied.
^ permalink raw reply
* Re: [patch] qlcnic: remove a stray semicolon
From: David Miller @ 2013-09-04 4:54 UTC (permalink / raw)
To: dan.carpenter
Cc: himanshu.madhani, rajesh.borundia, shahed.shaikh,
jitendra.kalsaria, sony.chacko, sucheta.chakraborty, linux-driver,
netdev, kernel-janitors
In-Reply-To: <20130903091347.GA4630@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 3 Sep 2013 12:13:47 +0300
> Just remove a small semicolon.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply
* Re: [patch] x25: add a sanity check parsing X.25 facilities
From: David Miller @ 2013-09-04 4:54 UTC (permalink / raw)
To: dan.carpenter; +Cc: andrew.hendry, linux-x25, netdev, kernel-janitors
In-Reply-To: <20130903090340.GB4351@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 3 Sep 2013 12:03:40 +0300
> This was found with a manual audit and I don't have a reproducer. We
> limit ->calling_len and ->called_len when we get them from
> copy_from_user() in x25_ioctl() so when they come from skb->data then
> we should cap them there as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply
* Re: [patch] caif: add a sanity check to the tty name
From: David Miller @ 2013-09-04 4:54 UTC (permalink / raw)
To: dan.carpenter; +Cc: dmitry.tarnyagin, netdev, kernel-janitors
In-Reply-To: <20130903090232.GA4351@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 3 Sep 2013 12:02:32 +0300
> "tty->name" and "name" are a 64 character buffers. My static checker
> complains because we add the "cf" on the front so it look like we are
> copying a 66 character string into a 64 character buffer.
>
> Also if the name is larger than IFNAMSIZ (16) it triggers a BUG_ON()
> inside the call to alloc_netdev().
>
> This is all under CAP_SYS_ADMIN so it's not a security fix, it just adds
> a little robustness.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply
* Re: [PATCH] ibmveth: Fix little endian issues
From: David Miller @ 2013-09-04 4:53 UTC (permalink / raw)
To: anton; +Cc: santil, netdev
In-Reply-To: <20130903095532.507dcb44@kryten>
From: Anton Blanchard <anton@samba.org>
Date: Tue, 3 Sep 2013 09:55:32 +1000
>
> The hypervisor is big endian, so little endian kernel builds need
> to byteswap.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
Applied.
^ permalink raw reply
* Re: [PATCH V2] net: netx-eth: remove unnecessary casting
From: David Miller @ 2013-09-04 4:53 UTC (permalink / raw)
To: jg1.han; +Cc: netdev, sergei.shtylyov
In-Reply-To: <001101cea837$b49bf370$1dd3da50$%han@samsung.com>
From: Jingoo Han <jg1.han@samsung.com>
Date: Tue, 03 Sep 2013 08:54:04 +0900
> Casting from 'void *' is unnecessary, because casting from 'void *'
> to any pointer type is automatic.
>
> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] net: correctly interlink lower/upper devices
From: David Miller @ 2013-09-04 4:53 UTC (permalink / raw)
To: vfalico; +Cc: netdev, edumazet, jiri, alexander.h.duyck, amwang
In-Reply-To: <1378132011-2910-1-git-send-email-vfalico@redhat.com>
From: Veaceslav Falico <vfalico@redhat.com>
Date: Mon, 2 Sep 2013 16:26:51 +0200
> Currently we're linking upper devices to lower ones, which results in
> upside-down relationship: upper devices seeing lower devices via its upper
> lists.
>
> Fix this by correctly linking lower devices to the upper ones.
>
> Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 0/5] cnic: Remove duplicate bnx2x definitions
From: David Miller @ 2013-09-04 4:53 UTC (permalink / raw)
To: mchan; +Cc: netdev
In-Reply-To: <1378147352-9076-1-git-send-email-mchan@broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Mon, 2 Sep 2013 11:42:27 -0700
> Adapt the code to use existing macros and struct fields in bnx2x.h to
> avoid duplication.
Series applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next 0/5] tunnels: harmonize skb scrubbing during encapsulation/decapsulation
From: David Miller @ 2013-09-04 4:52 UTC (permalink / raw)
To: nicolas.dichtel; +Cc: pshelar, netdev, jesse, dev
In-Reply-To: <1378128898-15136-1-git-send-email-nicolas.dichtel@6wind.com>
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Mon, 2 Sep 2013 15:34:53 +0200
> We talk recently about harmonizing tunnels so they behave consistently wrt. SKB
> orphaning, cleaning netfilter state, etc.
> The goal of this serie is to achieve this.
>
> Note that I test only ipip, sit and ip6_tunnels modules.
>
> v2: add patch 2/5
> rebase on head
> remove 'RFC' prefix
Series applied.
^ permalink raw reply
* Re: [PATCH net-next 0/5] bonding: locking simplifications and cleanup
From: David Miller @ 2013-09-04 4:52 UTC (permalink / raw)
To: nikolay; +Cc: netdev, andy, fubar
In-Reply-To: <1378122702-28943-1-git-send-email-nikolay@redhat.com>
From: Nikolay Aleksandrov <nikolay@redhat.com>
Date: Mon, 2 Sep 2013 13:51:37 +0200
> This small patchset aims to remove some use cases of bond->lock for mutual
> exclusion which will help in the RCUfication of the function users. It also
> does some small style cleanups and fixes.
Series applied.
^ permalink raw reply
* [PATCH net-next 2/2] tuntap: orphan frags before trying to set tx timestamp
From: Jason Wang @ 2013-09-04 4:33 UTC (permalink / raw)
To: davem, netdev, linux-kernel; +Cc: mst, Jason Wang, Richard Cochran
In-Reply-To: <1378269226-5969-1-git-send-email-jasowang@redhat.com>
sock_tx_timestamp() will clear all zerocopy flags of skb which may lead the
frags never to be orphaned. This will break guest to guest traffic when zerocopy
is enabled. Fix this by orphaning the frags before trying to set tx time stamp.
The issue were introduced by commit eda297729171fe16bf34fe5b0419dfb69060f623
(tun: Support software transmit time stamping).
Cc: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/net/tun.c | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 2dddb1b..af9a096 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -749,15 +749,16 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb, struct net_device *dev)
>= dev->tx_queue_len / tun->numqueues)
goto drop;
+ /* Orphan the skb - required as we might hang on to it
+ * for indefinite time. */
+ if (unlikely(skb_orphan_frags(skb, GFP_ATOMIC)))
+ goto drop;
+
if (skb->sk) {
sock_tx_timestamp(skb->sk, &skb_shinfo(skb)->tx_flags);
sw_tx_timestamp(skb);
}
- /* Orphan the skb - required as we might hang on to it
- * for indefinite time. */
- if (unlikely(skb_orphan_frags(skb, GFP_ATOMIC)))
- goto drop;
skb_orphan(skb);
nf_reset(skb);
--
1.7.1
^ permalink raw reply related
* [PATCH net-next 1/2] tuntap: purge socket error queue on detach
From: Jason Wang @ 2013-09-04 4:33 UTC (permalink / raw)
To: davem, netdev, linux-kernel; +Cc: mst, Jason Wang, Richard Cochran
Commit eda297729171fe16bf34fe5b0419dfb69060f623
(tun: Support software transmit time stamping) will queue skbs into error queue
when tx stamping is enabled. But it forgets to purge the error queue during
detach. This patch fixes this.
Cc: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/net/tun.c | 12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 60a1e93..2dddb1b 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -409,6 +409,12 @@ static struct tun_struct *tun_enable_queue(struct tun_file *tfile)
return tun;
}
+static void tun_queue_purge(struct tun_file *tfile)
+{
+ skb_queue_purge(&tfile->sk.sk_receive_queue);
+ skb_queue_purge(&tfile->sk.sk_error_queue);
+}
+
static void __tun_detach(struct tun_file *tfile, bool clean)
{
struct tun_file *ntfile;
@@ -435,7 +441,7 @@ static void __tun_detach(struct tun_file *tfile, bool clean)
synchronize_net();
tun_flow_delete_by_queue(tun, tun->numqueues + 1);
/* Drop read queue */
- skb_queue_purge(&tfile->sk.sk_receive_queue);
+ tun_queue_purge(tfile);
tun_set_real_num_queues(tun);
} else if (tfile->detached && clean) {
tun = tun_enable_queue(tfile);
@@ -487,12 +493,12 @@ static void tun_detach_all(struct net_device *dev)
for (i = 0; i < n; i++) {
tfile = rtnl_dereference(tun->tfiles[i]);
/* Drop read queue */
- skb_queue_purge(&tfile->sk.sk_receive_queue);
+ tun_queue_purge(tfile);
sock_put(&tfile->sk);
}
list_for_each_entry_safe(tfile, tmp, &tun->disabled, next) {
tun_enable_queue(tfile);
- skb_queue_purge(&tfile->sk.sk_receive_queue);
+ tun_queue_purge(tfile);
sock_put(&tfile->sk);
}
BUG_ON(tun->numdisabled != 0);
--
1.7.1
^ permalink raw reply related
* Re: [E1000-devel] [PATCH 0/4] i40e: Neatening and object size reductions
From: Joe Perches @ 2013-09-04 4:31 UTC (permalink / raw)
To: Nelson, Shannon
Cc: Kirsher, Jeffrey T, e1000-devel@lists.sourceforge.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <FC41C24E35F18A40888AACA1A36F3E416C61C0E5@FMSMSX102.amr.corp.intel.com>
On Wed, 2013-09-04 at 01:00 +000, Nelson, Shannon wrote:
> we hadn't noticed the new experimental "--fix" option before. There
> are a lot of good suggestions there, but obviously it needs a lot of
> reading and tweaking before it can be used.
Yes, I think --fix works best on patches.
When you use -f and --fix together, it can do inappropriate things.
Using multiple passes of -f --fix --types=<ONE_SPECIFIC_TYPE> and
changing the "ONE_SPECIFIC_TYPE" can produce more reasonable patch
sequences.
If you do try it, and please remember it is experimental, do let me
know how well it works or doesn't work for you all.
Bug reports (and patches) welcome.
cheers, Joe
^ permalink raw reply
* Re: [PATCH 1/5] net: emac: use platform_{get,set}_drvdata()
From: Jingoo Han @ 2013-09-04 3:00 UTC (permalink / raw)
To: 'David Miller'; +Cc: netdev, pgynther, 'Jingoo Han'
In-Reply-To: <20130903.224003.792091851244921220.davem@davemloft.net>
On Wednesday, September 04, 2013 11:40 AM, David Miller wrote:
>
> From: Jingoo Han <jg1.han@samsung.com>
> Date: Mon, 02 Sep 2013 17:06:52 +0900
>
> > Use the wrapper functions for getting and setting the driver data
> > using platform_device instead of using dev_{get,set}_drvdata()
> > with &pdev->dev, so we can directly pass a struct platform_device.
> > This is a purely cosmetic change.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>
> All 5 patches applied.
>
> Please, in the future, provide an initial "[PATCH 00/nn] " posting for
> a series of patches, giving a top-level description of what is happening.
OK, I will provide an initial "[PATCH 00/nn]" posting.
Thank you for your suggestion. :-)
Best regards,
Jingoo Han
>
> This way I can include that commit message text in a merge commit and
> also I have an appropriate email to reply to if I just want to say
> that I applied everything in the series.
^ permalink raw reply
* Re: Re: [PATCH] USB2NET : SR9700 : One chip USB 1.1 USB2NETSR9700Device Driver Support
From: liujunliang_ljl @ 2013-09-04 2:54 UTC (permalink / raw)
To: David Miller
Cc: horms, joe, romieu, gregkh, netdev, linux-usb, linux-kernel,
sunhecheng
In-Reply-To: <20130903.222708.238851084536537650.davem@davemloft.net>
Dear David Miller ：
Thanks a lot.
I'm sorry that I just wonder to know which kernel version will release this driver, thanks again. \x7f
2013-09-04
liujunliang_ljl
发件人： David Miller
发送时间： 2013-09-04 10:27:14
收件人： liujunliang_ljl
抄送： horms; joe; romieu; gregkh; netdev; linux-usb; linux-kernel; sunhecheng
主题： Re: [PATCH] USB2NET : SR9700 : One chip USB 1.1 USB2NETSR9700Device Driver Support
From: liujunliang_ljl@163.com
Date: Sun, 1 Sep 2013 19:38:08 +0800
> From: Liu Junliang <liujunliang_ljl@163.com>
>
> Signed-off-by: Liu Junliang <liujunliang_ljl@163.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH v2] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300
From: Chen Gang @ 2013-09-04 2:52 UTC (permalink / raw)
To: David Miller; +Cc: paul.gortmaker, ysato, keescook, netdev
In-Reply-To: <20130903.223720.765149153140271341.davem@davemloft.net>
On 09/04/2013 10:37 AM, David Miller wrote:
> From: Chen Gang <gang.chen@asianux.com>
> Date: Mon, 02 Sep 2013 10:20:02 +0800
>
>> Currently only H8300H_AKI3068NET and H8300H_H8MAX define default
>> I/O base and IRQ values for the NE_H8300 driver. Hence builds
>> for other H8300H platforms will fail as per below. Since H8300H
>> does not support multi platform builds, we simply limit building
>> the driver to those two platforms specifically.
>>
>> The release error:
> ...
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>
> Applied, thanks.
>
>
Thank you too.
And h8300 architecture will be remove from Linux kernel (and I am sorry
for forgot to notifying Paul about it),
Do we still need this patch (I am not quite sure, maybe we still need) ?
Thanks.
--
Chen Gang
^ permalink raw reply
* Re: [patch] sfc: check for allocation failure
From: David Miller @ 2013-09-04 2:49 UTC (permalink / raw)
To: dan.carpenter; +Cc: linux-net-drivers, bhutchings, netdev, kernel-janitors
In-Reply-To: <20130902082828.GA30037@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 2 Sep 2013 12:04:42 +0300
> It upsets static analyzers when we don't check for allocation failure.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
This applies cleanly neither to net nor net-next, please send me a
version that does.
Thanks.
^ permalink raw reply
* Re: [PATCH V3 0/6] vhost code cleanup and minor enhancement
From: David Miller @ 2013-09-04 2:47 UTC (permalink / raw)
To: jasowang; +Cc: netdev, virtualization, linux-kernel, kvm, mst
In-Reply-To: <1378111261-14826-1-git-send-email-jasowang@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Date: Mon, 2 Sep 2013 16:40:55 +0800
> This series tries to unify and simplify vhost codes especially for
> zerocopy. With this series, 5% - 10% improvement for per cpu throughput were
> seen during netperf guest sending test.
>
> Plase review.
Applied and patch #5 queued up for -stable, thanks.
^ permalink raw reply
* Re: [PATCH 1/5] net: emac: use platform_{get,set}_drvdata()
From: David Miller @ 2013-09-04 2:40 UTC (permalink / raw)
To: jg1.han; +Cc: netdev, pgynther
In-Reply-To: <000f01cea7b3$6226fd30$2674f790$%han@samsung.com>
From: Jingoo Han <jg1.han@samsung.com>
Date: Mon, 02 Sep 2013 17:06:52 +0900
> Use the wrapper functions for getting and setting the driver data
> using platform_device instead of using dev_{get,set}_drvdata()
> with &pdev->dev, so we can directly pass a struct platform_device.
> This is a purely cosmetic change.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
All 5 patches applied.
Please, in the future, provide an initial "[PATCH 00/nn] " posting for
a series of patches, giving a top-level description of what is happening.
This way I can include that commit message text in a merge commit and
also I have an appropriate email to reply to if I just want to say
that I applied everything in the series.
^ permalink raw reply
* Re: [PATCH v2] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300
From: David Miller @ 2013-09-04 2:37 UTC (permalink / raw)
To: gang.chen; +Cc: paul.gortmaker, ysato, keescook, netdev
In-Reply-To: <5223F5D2.7050504@asianux.com>
From: Chen Gang <gang.chen@asianux.com>
Date: Mon, 02 Sep 2013 10:20:02 +0800
> Currently only H8300H_AKI3068NET and H8300H_H8MAX define default
> I/O base and IRQ values for the NE_H8300 driver. Hence builds
> for other H8300H platforms will fail as per below. Since H8300H
> does not support multi platform builds, we simply limit building
> the driver to those two platforms specifically.
>
> The release error:
...
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-hext] wireless: scan: Remove comment to compare_ether_addr
From: David Miller @ 2013-09-04 2:35 UTC (permalink / raw)
To: joe; +Cc: johannes, linville, linux-wireless, netdev, linux-kernel
In-Reply-To: <1378075707.1953.29.camel@joe-AO722>
From: Joe Perches <joe@perches.com>
Date: Sun, 01 Sep 2013 15:48:27 -0700
> This function is being removed, so remove the reference to it.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH] batman: Remove reference to compare_ether_addr
From: David Miller @ 2013-09-04 2:35 UTC (permalink / raw)
To: joe-6d6DIl74uiNBDgjK7y7TUQ
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
siwu-MaAgPAbsBIVS8oHt8HbXEIQuADTiUCJX,
ordex-GaUfNO9RBHfsrOwW+9ziJQ, lindner_marek-LWAfsSFWpa4
In-Reply-To: <1378075508.1953.27.camel@joe-AO722>
From: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Date: Sun, 01 Sep 2013 15:45:08 -0700
> This function is being removed, rename the reference.
>
> Signed-off-by: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] llc: Use normal etherdevice.h tests
From: David Miller @ 2013-09-04 2:34 UTC (permalink / raw)
To: joe; +Cc: acme, netdev, linux-kernel
In-Reply-To: <1378066315.1953.23.camel@joe-AO722>
From: Joe Perches <joe@perches.com>
Date: Sun, 01 Sep 2013 13:11:55 -0700
> Convert the llc_<foo> static inlines to the
> equivalents from etherdevice.h and remove
> the llc_<foo> static inline functions.
>
> llc_mac_null -> is_zero_ether_addr
> llc_mac_multicast -> is_multicast_ether_addr
> llc_mac_match -> ether_addr_equal
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox