Netdev List
 help / color / mirror / Atom feed
* [PATCH net] MAINTAINERS: mark CAIF as orphan
From: Jann Horn @ 2019-02-21 19:58 UTC (permalink / raw)
  To: David S. Miller, jannh
  Cc: netdev, Dmitry Tarnyagin, abi.dmitryt, linux-kernel

The listed address for the CAIF maintainer bounces with
"553 5.3.0 <dmitry.tarnyagin@lockless.no>... No such user here", and the
only existing email address of the maintainer in git history hasn't
responded in a week.
Therefore, remove the listed maintainer and mark CAIF as orphan.

Signed-off-by: Jann Horn <jannh@google.com>
---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 41ce5f4ad838..98457a87b238 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3390,9 +3390,8 @@ F:	Documentation/media/v4l-drivers/cafe_ccic*
 F:	drivers/media/platform/marvell-ccic/
 
 CAIF NETWORK LAYER
-M:	Dmitry Tarnyagin <dmitry.tarnyagin@lockless.no>
 L:	netdev@vger.kernel.org
-S:	Supported
+S:	Orphan
 F:	Documentation/networking/caif/
 F:	drivers/net/caif/
 F:	include/uapi/linux/caif/
-- 
2.21.0.rc0.258.g878e2cd30e-goog


^ permalink raw reply related

* RE: [PATCH iproute2-next v1 01/19] rdma: update uapi headers
From: Steve Wise @ 2019-02-21 20:02 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-2-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:21 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 01/19] rdma: update uapi headers
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Update rdma_netlink,h file upto kernel commit

Nit:  should be "rdma_netlink.h file up to"

> f2a0e45f36b0 RDMA/nldev: Don't expose number of not-visible entries
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>

Reviewed-by: Steve Wise <swise@opengridcomputing.com>



^ permalink raw reply

* RE: [PATCH iproute2-next v1 02/19] rdma: Remove duplicated print code
From: Steve Wise @ 2019-02-21 20:04 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-3-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:21 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 02/19] rdma: Remove duplicated print
> code
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> There is no need to keep same print functions for
> uint32_t and uint64_t, unify them into one function.
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>

Reviewed-by: Steve Wise <swise@opengridcomputing.com>



^ permalink raw reply

* RE: [PATCH iproute2-next v1 03/19] rdma: Provide unique indexes for all visible objects
From: Steve Wise @ 2019-02-21 20:08 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-4-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:21 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 03/19] rdma: Provide unique indexes for
all
> visible objects
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---

Reviewed-by: Steve Wise <swise@opengridcomputing.com>



^ permalink raw reply

* RE: [PATCH iproute2-next v1 04/19] rdma: Provide parent context index for all objects except CM_ID
From: Steve Wise @ 2019-02-21 20:12 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-5-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:21 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 04/19] rdma: Provide parent context index
> for all objects except CM_ID
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Allow users to correlate allocated object with relevant parent
> 
> [leonro@server ~]$ rdma res show pd
> dev mlx5_0 users 5 pid 0 comm [ib_core] pdn 1
> dev mlx5_0 users 7 pid 0 comm [ib_ipoib] pdn 2
> dev mlx5_0 users 0 pid 0 comm [mlx5_ib] pdn 3
> dev mlx5_0 users 2 pid 548 comm ibv_rc_pingpong ctxn 0 pdn 4
> 
> [leonro@server ~]$ rdma res show cq cqn 0-100
> dev mlx5_0 cqe 2047 users 6 poll-ctx UNBOUND_WORKQUEUE pid 0 comm
> [ib_core] cqn 2
> dev mlx5_0 cqe 255 users 2 poll-ctx SOFTIRQ pid 0 comm [mlx5_ib] cqn 3
> dev mlx5_0 cqe 511 users 1 poll-ctx DIRECT pid 0 comm [ib_ipoib] cqn 4
> dev mlx5_0 cqe 255 users 1 poll-ctx DIRECT pid 0 comm [ib_ipoib] cqn 5
> dev mlx5_0 cqe 255 users 0 poll-ctx SOFTIRQ pid 0 comm [mlx5_ib] cqn 6
> dev mlx5_0 cqe 511 users 2 pid 548 comm ibv_rc_pingpong cqn 7 ctxn 0
> 
> [leonro@server ~]$ rdma res show mr
> dev mlx5_0 mrlen 4096 pid 548 comm ibv_rc_pingpong mrn 4 pdn 0
> 
> [leonro@nps-server-14-015 ~]$ /images/leonro/src/iproute2/rdma/rdma res
> show qp
> link mlx5_0/1 lqpn 0 type SMI state RTS sq-psn 0 pid 0 comm [ib_core]
> link mlx5_0/1 lqpn 1 type GSI state RTS sq-psn 0 pid 0 comm [ib_core]
> link mlx5_0/1 lqpn 7 type UD state RTS sq-psn 0 pid 0 comm [ib_core]
> link mlx5_0/1 lqpn 8 type UD state RTS sq-psn 0 pid 0 comm [ib_ipoib]
> link mlx5_0/1 lqpn 9 pdn 4 rqpn 0 type RC state INIT rq-psn 0 sq-psn 0
path-
> mig-state MIGRATED pid 548 comm ibv_rc_pingpong
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  rdma/res.c | 110 +++++++++++++++++++++++++++++++++++----------------
> --
>  1 file changed, 72 insertions(+), 38 deletions(-)
> 
> diff --git a/rdma/res.c b/rdma/res.c
> index f941de5c..308f66c0 100644
> --- a/rdma/res.c
> +++ b/rdma/res.c
> @@ -320,6 +320,22 @@ static char *get_task_name(uint32_t pid)
>  	return comm;
>  }
> 
> +static void print_key(struct rd *rd, const char *name, uint64_t val)
> +{
> +	if (rd->json_output)
> +		jsonw_xint_field(rd->jw, name, val);
> +	else
> +		pr_out("%s 0x%" PRIx64 " ", name, val);
> +}
> +
> +static void res_print_uint(struct rd *rd, const char *name, uint64_t val)
> +{
> +	if (rd->json_output)
> +		jsonw_uint_field(rd->jw, name, val);
> +	else
> +		pr_out("%s %" PRIu64 " ", name, val);
> +}
> +
>  static int res_qp_parse_cb(const struct nlmsghdr *nlh, void *data)
>  {
>  	struct nlattr *tb[RDMA_NLDEV_ATTR_MAX] = {};
> @@ -343,6 +359,7 @@ static int res_qp_parse_cb(const struct nlmsghdr
> *nlh, void *data)
>  		uint32_t lqpn, rqpn = 0, rq_psn = 0, sq_psn;
>  		uint8_t type, state, path_mig_state = 0;
>  		uint32_t port = 0, pid = 0;
> +		uint32_t pdn = 0;
>  		char *comm = NULL;
>  		int err;
> 
> @@ -369,6 +386,11 @@ static int res_qp_parse_cb(const struct nlmsghdr
> *nlh, void *data)
>  		if (rd_check_is_filtered(rd, "lqpn", lqpn))
>  			continue;
> 
> +		if (nla_line[RDMA_NLDEV_ATTR_RES_PDN])
> +			pdn =
> mnl_attr_get_u32(nla_line[RDMA_NLDEV_ATTR_RES_PDN]);
> +		if (rd_check_is_filtered(rd, "pdn", pdn))
> +			continue;
> +
>  		if (nla_line[RDMA_NLDEV_ATTR_RES_RQPN]) {
>  			rqpn =
> mnl_attr_get_u32(nla_line[RDMA_NLDEV_ATTR_RES_RQPN]);
>  			if (rd_check_is_filtered(rd, "rqpn", rqpn))
> @@ -428,6 +450,8 @@ static int res_qp_parse_cb(const struct nlmsghdr
> *nlh, void *data)
>  		print_link(rd, idx, name, port, nla_line);
> 
>  		print_lqpn(rd, lqpn);
> +		if (nla_line[RDMA_NLDEV_ATTR_RES_PDN])
> +			res_print_uint(rd, "pdn", pdn);
>  		print_rqpn(rd, rqpn, nla_line);
> 
>  		print_type(rd, type);
> @@ -549,22 +573,6 @@ static int ss_ntop(struct nlattr *nla_line, char
> *addr_str, uint16_t *port)
>  	return 0;
>  }
> 
> -static void print_key(struct rd *rd, const char *name, uint64_t val)
> -{
> -	if (rd->json_output)
> -		jsonw_xint_field(rd->jw, name, val);
> -	else
> -		pr_out("%s 0x%" PRIx64 " ", name, val);
> -}
> -
> -static void res_print_uint(struct rd *rd, const char *name, uint64_t val)
> -{
> -	if (rd->json_output)
> -		jsonw_uint_field(rd->jw, name, val);
> -	else
> -		pr_out("%s %" PRIu64 " ", name, val);
> -}
> -
>  static int res_cm_id_parse_cb(const struct nlmsghdr *nlh, void *data)
>  {
>  	struct nlattr *tb[RDMA_NLDEV_ATTR_MAX] = {};
> @@ -768,6 +776,7 @@ static int res_cq_parse_cb(const struct nlmsghdr *nlh,
> void *data)
>  		char *comm = NULL;
>  		uint32_t pid = 0;
>  		uint8_t poll_ctx = 0;
> +		uint32_t ctxn = 0;
>  		uint32_t cqn = 0;
>  		uint64_t users;
>  		uint32_t cqe;
> @@ -815,6 +824,12 @@ static int res_cq_parse_cb(const struct nlmsghdr
> *nlh, void *data)
>  		if (rd_check_is_filtered(rd, "cqn", cqn))
>  			continue;
> 
> +		if (nla_line[RDMA_NLDEV_ATTR_RES_CTXN])
> +			ctxn = mnl_attr_get_u32(
> +				 nla_line[RDMA_NLDEV_ATTR_RES_CTXN]);
> +		if (rd_check_is_filtered(rd, "ctxn", ctxn))
> +			continue;
> +
>  		if (nla_line[RDMA_NLDEV_ATTR_RES_KERN_NAME])
>  			/* discard const from mnl_attr_get_str */
>  			comm = (char *)mnl_attr_get_str(
> @@ -833,6 +848,8 @@ static int res_cq_parse_cb(const struct nlmsghdr *nlh,
> void *data)
> 
>  		if (nla_line[RDMA_NLDEV_ATTR_RES_CQN])
>  			res_print_uint(rd, "cqn", cqn);
> +		if (nla_line[RDMA_NLDEV_ATTR_RES_CTXN])
> +			res_print_uint(rd, "ctxn", ctxn);
> 
>  		if (nla_line[RDMA_NLDEV_ATTR_RES_PID])
>  			free(comm);
> @@ -866,6 +883,7 @@ static int res_mr_parse_cb(const struct nlmsghdr
> *nlh, void *data)
>  		uint32_t rkey = 0, lkey = 0;
>  		uint64_t iova = 0, mrlen;
>  		char *comm = NULL;
> +		uint32_t pdn = 0;
>  		uint32_t mrn = 0;
>  		uint32_t pid = 0;
>  		int err;
> @@ -911,6 +929,12 @@ static int res_mr_parse_cb(const struct nlmsghdr
> *nlh, void *data)
>  		if (rd_check_is_filtered(rd, "mrn", mrn))
>  			continue;
> 
> +		if (nla_line[RDMA_NLDEV_ATTR_RES_PDN])
> +			pdn = mnl_attr_get_u32(
> +				nla_line[RDMA_NLDEV_ATTR_RES_PDN]);
> +		if (rd_check_is_filtered(rd, "pdn", pdn))
> +			continue;
> +
>  		if (nla_line[RDMA_NLDEV_ATTR_RES_KERN_NAME])
>  			/* discard const from mnl_attr_get_str */
>  			comm = (char *)mnl_attr_get_str(
> @@ -933,6 +957,9 @@ static int res_mr_parse_cb(const struct nlmsghdr
> *nlh, void *data)
>  		if (nla_line[RDMA_NLDEV_ATTR_RES_MRN])
>  			res_print_uint(rd, "mrn", mrn);
> 
> +		if (nla_line[RDMA_NLDEV_ATTR_RES_PDN])
> +			res_print_uint(rd, "pdn", pdn);
> +
>  		if (nla_line[RDMA_NLDEV_ATTR_RES_PID])
>  			free(comm);
> 
> @@ -964,6 +991,7 @@ static int res_pd_parse_cb(const struct nlmsghdr
> *nlh, void *data)
>  		uint32_t local_dma_lkey = 0, unsafe_global_rkey = 0;
>  		struct nlattr *nla_line[RDMA_NLDEV_ATTR_MAX] = {};
>  		char *comm = NULL;
> +		uint32_t ctxn = 0;
>  		uint32_t pid = 0;
>  		uint32_t pdn = 0;
>  		uint64_t users;
> @@ -997,7 +1025,13 @@ static int res_pd_parse_cb(const struct nlmsghdr
> *nlh, void *data)
>  			comm = get_task_name(pid);
>  		}
> 
> -		if (rd_check_is_filtered(rd, "pid", pid))
> +                if (rd_check_is_filtered(rd, "pid", pid))

Did this add some whitespace problem?

Reviewed-by: Steve Wise <swise@opengridcomputing.com>



^ permalink raw reply

* RE: [PATCH iproute2-next v1 05/19] rdma: Move resource PD logic to separate file
From: Steve Wise @ 2019-02-21 20:15 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-6-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:21 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 05/19] rdma: Move resource PD logic to
> separate file
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Logically separate resource PD logic to separate file,
> in order to make PD specific logic self-contained.
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---

Why does it need to be self contained?

Reviewed-by: Steve Wise <swise@opengridcomputing.com>



^ permalink raw reply

* RE: [PATCH iproute2-next v1 06/19] rdma: Refactor out resource MR logic to separate file
From: Steve Wise @ 2019-02-21 20:15 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-7-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:21 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 06/19] rdma: Refactor out resource MR
> logic to separate file
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Logically separate resource MR logic to separate file,
> in order to make MR specific logic self-contained.
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---

Ah I guess you're moving them all into their own files. Ok.
Reviewed-by: Steve Wise <swise@opengridcomputing.com>



^ permalink raw reply

* RE: [PATCH iproute2-next v1 07/19] rdma: Move out resource CQ logic to separate file
From: Steve Wise @ 2019-02-21 20:16 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-8-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:21 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 07/19] rdma: Move out resource CQ logic
> to separate file
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Logically separate resource CQ logic to separate file,
> in order to make CQ specific logic self-contained.
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---

Reviewed-by: Steve Wise <swise@opengridcomputing.com>



^ permalink raw reply

* RE: [PATCH iproute2-next v1 08/19] rdma: Move out resource CM-ID logic to separate file
From: Steve Wise @ 2019-02-21 20:17 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-9-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:21 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 08/19] rdma: Move out resource CM-ID
> logic to separate file
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Logically separate resource CM-ID logic to separate file,
> in order to make CM-ID specific logic self-contained.
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>

Reviewed-by: Steve Wise <swise@opengridcomputing.com>



^ permalink raw reply

* RE: [PATCH iproute2-next v1 09/19] rdma: Move resource PD logic to separate file
From: Steve Wise @ 2019-02-21 20:21 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-10-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:21 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 09/19] rdma: Move resource PD logic to
> separate file
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Logically separate resource PD logic to separate file,
> in order to make PD specific logic self-contained.
> 

This should be "QP" not "PD"

> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  rdma/Makefile |   2 +-
>  rdma/res-qp.c | 234
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  rdma/res.c    | 236 --------------------------------------------------
>  rdma/res.h    |  17 ++++
>  4 files changed, 252 insertions(+), 237 deletions(-)
>  create mode 100644 rdma/res-qp.c


Reviewed-by: Steve Wise <swise@opengridcomputing.com>



^ permalink raw reply

* RE: [PATCH iproute2-next v1 10/19] rdma: Properly mark RDMAtool license
From: Steve Wise @ 2019-02-21 20:22 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-11-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:21 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 10/19] rdma: Properly mark RDMAtool
> license
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> RDMA subsystem is dual-licensed with "GPL-2.0 OR Linux-OpenIB" proper
> license and Mellanox submission are supposed to have this type of license.
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  rdma/Makefile | 2 +-
>  rdma/dev.c    | 7 +------
>  rdma/link.c   | 7 +------
>  rdma/rdma.c   | 7 +------
>  rdma/rdma.h   | 7 +------
>  rdma/res.c    | 7 +------
>  rdma/utils.c  | 7 +------
>  7 files changed, 7 insertions(+), 37 deletions(-)


Reviewed-by: Steve Wise <swise@opengridcomputing.com>



^ permalink raw reply

* RE: [PATCH iproute2-next v1 11/19] rdma: Simplify code to reuse existing functions
From: Steve Wise @ 2019-02-21 20:23 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-12-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:21 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 11/19] rdma: Simplify code to reuse
> existing functions
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Remove duplicated functions in favour general res_print_uint() call.
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  rdma/res-cmid.c |  4 ++--
>  rdma/res-cq.c   | 14 +++-----------
>  rdma/res-mr.c   |  2 +-
>  rdma/res-pd.c   |  4 ++--
>  rdma/res-qp.c   | 14 +++-----------
>  rdma/res.c      | 34 ++--------------------------------
>  rdma/res.h      |  3 ---
>  7 files changed, 13 insertions(+), 62 deletions(-)
> 


Reviewed-by: Steve Wise <swise@opengridcomputing.com>




^ permalink raw reply

* RE: [PATCH iproute2-next v1 12/19] rdma: Simplify CM_ID print code
From: Steve Wise @ 2019-02-21 20:26 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-13-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:21 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 12/19] rdma: Simplify CM_ID print code
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Refactor our the CM_ID print code.
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  rdma/res-cmid.c | 246 ++++++++++++++++++++++++------------------------
>  1 file changed, 124 insertions(+), 122 deletions(-)

Not sure why you refactored, but ok.

Reviewed-by: Steve Wise <swise@opengridcomputing.com>



^ permalink raw reply

* RE: [PATCH iproute2-next v1 13/19] rdma: Refactor CQ prints
From: Steve Wise @ 2019-02-21 20:27 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-14-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:22 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 13/19] rdma: Refactor CQ prints
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  rdma/res-cq.c | 177 ++++++++++++++++++++++++++------------------------
>  1 file changed, 91 insertions(+), 86 deletions(-)


Reviewed-by: Steve Wise <swise@opengridcomputing.com>




^ permalink raw reply

* RE: [PATCH iproute2-next v1 14/19] rdma: Separate MR code
From: Steve Wise @ 2019-02-21 20:28 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-15-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:22 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 14/19] rdma: Separate MR code
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  rdma/res-mr.c | 178 +++++++++++++++++++++++++-------------------------
>  1 file changed, 90 insertions(+), 88 deletions(-)

The commit description is wrong.

Reviewed-by: Steve Wise <swise@opengridcomputing.com>




^ permalink raw reply

* RE: [PATCH iproute2-next v1 15/19] rdma: Separate PD code
From: Steve Wise @ 2019-02-21 20:29 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-16-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:22 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 15/19] rdma: Separate PD code
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  rdma/res-pd.c | 170 ++++++++++++++++++++++++++------------------------
>  1 file changed, 89 insertions(+), 81 deletions(-)

commit text is wrong.

Reviewed-by: Steve Wise <swise@opengridcomputing.com>




^ permalink raw reply

* RE: [PATCH iproute2-next v1 16/19] rdma: Move QP code to separate function
From: Steve Wise @ 2019-02-21 20:29 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-17-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:22 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 16/19] rdma: Move QP code to separate
> function
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  rdma/res-qp.c | 253 +++++++++++++++++++++++++-------------------------
>  1 file changed, 127 insertions(+), 126 deletions(-)


Reviewed-by: Steve Wise <swise@opengridcomputing.com>



^ permalink raw reply

* RE: [PATCH iproute2-next v1 17/19] rdma: Unify netlink attribute checks prior to prints
From: Steve Wise @ 2019-02-21 20:31 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-18-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:22 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 17/19] rdma: Unify netlink attribute
checks
> prior to prints
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Place check if netlink attribute available in general place,
> instead of doing the same check in many paces.
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  rdma/res-cmid.c |  9 ++++-----
>  rdma/res-cq.c   | 22 +++++++++++-----------
>  rdma/res-mr.c   | 21 +++++++--------------
>  rdma/res-pd.c   | 20 +++++++++-----------
>  rdma/res-qp.c   | 10 +++++-----
>  rdma/res.c      | 16 +++++++++++++---
>  rdma/res.h      |  6 ++++--
>  7 files changed, 53 insertions(+), 51 deletions(-)


Reviewed-by: Steve Wise <swise@opengridcomputing.com>



^ permalink raw reply

* RE: [PATCH iproute2-next v1 18/19] rdma: Perform single .doit call to query specific objects
From: Steve Wise @ 2019-02-21 20:35 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-19-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:22 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 18/19] rdma: Perform single .doit call to
> query specific objects
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> If user provides specific index, we can speedup query
> by using .doit callback and save full dump and filtering
> after that.
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  rdma/rdma.h     | 10 +++++-
>  rdma/res-cmid.c | 33 +++++++++++++------
>  rdma/res-cq.c   | 34 ++++++++++++++------
>  rdma/res-mr.c   | 33 ++++++++++++++-----
>  rdma/res-pd.c   | 32 ++++++++++++++-----
>  rdma/res-qp.c   | 32 ++++++++++++++-----
>  rdma/res.c      | 34 +++++++++++++++++++-
>  rdma/res.h      | 84 ++++++++++++++++++++++++++++++++-----------------
>  rdma/utils.c    | 20 ++++++++++++
>  9 files changed, 239 insertions(+), 73 deletions(-)
> 


Reviewed-by: Steve Wise <swise@opengridcomputing.com>




^ permalink raw reply

* Re: [PATCH bpf-next v2] bpf, seccomp: fix false positive preemption splat for cbpf->ebpf progs
From: Alexei Starovoitov @ 2019-02-21 20:36 UTC (permalink / raw)
  To: Kees Cook
  Cc: Jann Horn, Daniel Borkmann, Andy Lutomirski, Alexei Starovoitov,
	Network Development
In-Reply-To: <CAGXu5jKE3PzxNDEMagWFG+37_6FLyQgkLRShHQHB7Ufq-8egDA@mail.gmail.com>

On Thu, Feb 21, 2019 at 11:53:06AM -0800, Kees Cook wrote:
> On Thu, Feb 21, 2019 at 11:29 AM Alexei Starovoitov
> <alexei.starovoitov@gmail.com> wrote:
> >
> > On Thu, Feb 21, 2019 at 01:56:53PM +0100, Jann Horn wrote:
> > > On Thu, Feb 21, 2019 at 9:53 AM Daniel Borkmann <daniel@iogearbox.net> wrote:
> > > > On 02/21/2019 06:31 AM, Kees Cook wrote:
> > > > > On Wed, Feb 20, 2019 at 8:03 PM Alexei Starovoitov
> > > > > <alexei.starovoitov@gmail.com> wrote:
> > > > >>
> > > > >> On Wed, Feb 20, 2019 at 3:59 PM Alexei Starovoitov
> > > > >> <alexei.starovoitov@gmail.com> wrote:
> > > > >>>
> > > > >>> On Thu, Feb 21, 2019 at 12:01:35AM +0100, Daniel Borkmann wrote:
> > > > >>>> In 568f196756ad ("bpf: check that BPF programs run with preemption disabled")
> > > > >>>> a check was added for BPF_PROG_RUN() that for every invocation preemption is
> > > > >>>> disabled to not break eBPF assumptions (e.g. per-cpu map). Of course this does
> > > > >>>> not count for seccomp because only cBPF -> eBPF is loaded here and it does
> > > > >>>> not make use of any functionality that would require this assertion. Fix this
> > > > >>>> false positive by adding and using SECCOMP_RUN() variant that does not have
> > > > >>>> the cant_sleep(); check.
> > > > >>>>
> > > > >>>> Fixes: 568f196756ad ("bpf: check that BPF programs run with preemption disabled")
> > > > >>>> Reported-by: syzbot+8bf19ee2aa580de7a2a7@syzkaller.appspotmail.com
> > > > >>>> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> > > > >>>> Acked-by: Kees Cook <keescook@chromium.org>
> > > > >>>
> > > > >>> Applied, Thanks
> > > > >>
> > > > >> Actually I think it's a wrong approach to go long term.
> > > > >> I'm thinking to revert it.
> > > > >> I think it's better to disable preemption for duration of
> > > > >> seccomp cbpf prog.
> > > > >> It's short and there is really no reason for it to be preemptible.
> > > > >> When seccomp switches to ebpf we'll have this weird inconsistency.
> > > > >> Let's just disable preemption for seccomp as well.
> > > > >
> > > > > A lot of changes will be needed for seccomp ebpf -- not the least of
> > > > > which is convincing me there is a use-case. ;)
> > > > >
> > > > > But the main issue is that I'm not a huge fan of dropping two
> > > > > barriers() across syscall entry. That seems pretty heavy-duty for
> > > > > something that is literally not needed right now.
> > > >
> > > > Yeah, I think it's okay to add once actually technically needed. Last
> > > > time I looked, if I recall correctly, at least Chrome installs some
> > > > heavy duty seccomp programs that go close to prog limit.
> > >
> > > Half of that is probably because that seccomp BPF code is so
> > > inefficient, though.
> > >
> > > This snippet shows that those programs constantly recheck the high
> > > halves of arguments:
> > >
> > > Some of the generated code is pointless because all reachable code
> > > from that point on has the same outcome (the last "ret ALLOW" in the
> > > following sample is unreachable because they've already checked that
> > > the high bit of the low half is set, so the low half can't be 3):
> >
> > and with ebpf these optimizations will be available for free
> > because llvm will remove unnecessary loads and simplify branches.
> > There is no technical reason not to use ebpf in seccomp.
> >
> > When we discussed preemption of classic vs extended in socket filters
> > context we agreed to make it a requirement that preemption must be
> > disabled though it's not strictly necessary. RX side of socket filters
> > was already non-preempt while TX was preemptible.
> > We must not make an exception of this rule for seccomp.
> > Hence I've reverted this commit.
> >
> > Here is the actual fix for seccomp:
> > From: Alexei Starovoitov <ast@kernel.org>
> > Date: Thu, 21 Feb 2019 10:40:14 -0800
> > Subject: [PATCH] seccomp, bpf: disable preemption before calling into bpf prog
> >
> > All BPF programs must be called with preemption disabled.
> >
> > Signed-off-by: Alexei Starovoitov <ast@kernel.org>
> > ---
> >  kernel/seccomp.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/kernel/seccomp.c b/kernel/seccomp.c
> > index e815781ed751..a43c601ac252 100644
> > --- a/kernel/seccomp.c
> > +++ b/kernel/seccomp.c
> > @@ -267,6 +267,7 @@ static u32 seccomp_run_filters(const struct seccomp_data *sd,
> >          * All filters in the list are evaluated and the lowest BPF return
> >          * value always takes priority (ignoring the DATA).
> >          */
> > +       preempt_disable();
> >         for (; f; f = f->prev) {
> >                 u32 cur_ret = BPF_PROG_RUN(f->prog, sd);
> >
> > @@ -275,6 +276,7 @@ static u32 seccomp_run_filters(const struct seccomp_data *sd,
> >                         *match = f;
> >                 }
> >         }
> > +       preempt_enable();
> >         return ret;
> >  }
> >  #endif /* CONFIG_SECCOMP_FILTER */
> > --
> >
> > Doing per-cpu increment of cache hot data is practically free and it makes seccomp
> > play by the rules.
> 
> Other accesses should dominate the run time, yes. I'm still not a big
> fan of unconditionally adding this, but I won't NAK. :P

Thank you.

I also would like to touch on your comment:
"A lot of changes will be needed for seccomp ebpf"
There were two attempts to add it in the past and the patches were
small and straightforward.
If I recall correctly both times you nacked them because performance gains
and ease of use arguments were not convincing enough, right?
Are you still not convinced ?


^ permalink raw reply

* RE: [PATCH iproute2-next v1 19/19] rdma: Provide and reuse filter functions
From: Steve Wise @ 2019-02-21 20:39 UTC (permalink / raw)
  To: 'Leon Romanovsky', 'David Ahern'
  Cc: 'Leon Romanovsky', 'netdev',
	'RDMA mailing list', 'Stephen Hemminger'
In-Reply-To: <20190220072136.3840-20-leon@kernel.org>



> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Leon Romanovsky
> Sent: Wednesday, February 20, 2019 1:22 AM
> To: David Ahern <dsahern@gmail.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>; netdev
> <netdev@vger.kernel.org>; RDMA mailing list <linux-
> rdma@vger.kernel.org>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH iproute2-next v1 19/19] rdma: Provide and reuse filter
> functions
> 
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Globally replace all filter function in safer variants of those
> is_filterred functions, which take into account the availability/lack

"is_filterred" -> "is_filtered"

> of netlink attributes.
> 
> Such conversion allowed to fix a number of places in the code, where
> the previous implementation didn't honor filter requests if netlink
> attribute wasn't present.
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  rdma/rdma.h     |  7 +++---
>  rdma/res-cmid.c | 57 +++++++++++++++++++++++++++----------------------
>  rdma/res-cq.c   | 22 +++++++++++--------
>  rdma/res-mr.c   | 12 +++++++----
>  rdma/res-pd.c   | 12 +++++++----
>  rdma/res-qp.c   | 53 ++++++++++++++++++++++-----------------------
>  rdma/utils.c    | 26 ++++++++++++++++++----
>  7 files changed, 112 insertions(+), 77 deletions(-)

Reviewed-by: Steve Wise <swise@opengridcomputing.com>



^ permalink raw reply

* Re: [net 0/5][pull request] Intel Wired LAN Driver Fixes 2019-02-21
From: David Miller @ 2019-02-21 20:53 UTC (permalink / raw)
  To: jeffrey.t.kirsher; +Cc: netdev, nhorman, sassmann
In-Reply-To: <20190221193319.22318-1-jeffrey.t.kirsher@intel.com>

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 21 Feb 2019 11:33:14 -0800

> This series contains fixes to ixgbe and i40e.
> 
> Majority of the fixes are to resolve XDP issues found in both drivers,
> there is only one fix which is not XDP related.  That one fix resolves
> an issue seen on older 10GbE devices, where UDP traffic was either being
> dropped or being transmitted out of order when the bit to enable L3/L4
> filtering for transmit switched packets is enabled on older devices that
> did not support this option.
> 
> Magnus fixes an XDP issue for both ixgbe and i40e, where receive rings
> are created but no buffers are allocated for AF_XDP in zero-copy mode,
> so no packets can be received and no interrupts will be generated so
> that NAPI poll function that allocates buffers to the rings will never
> get executed.
> 
> Björn fixes a race in XDP xmit ring cleanup for i40e, where
> ndo_xdp_xmit() must be taken into consideration.  Added a
> synchronize_rcu() to wait for napi(s) before clearing the queue.
> 
> Jan fixes a ixgbe AF_XDP zero-copy transmit issue which can cause a
> reset to be triggered, so add a check to ensure that netif carrier is
> 'ok' before trying to transmit packets.

Pulled, thanks Jeff.

^ permalink raw reply

* Re: [PATCH net] MAINTAINERS: mark CAIF as orphan
From: David Miller @ 2019-02-21 20:54 UTC (permalink / raw)
  To: jannh; +Cc: netdev, dmitry.tarnyagin, abi.dmitryt, linux-kernel
In-Reply-To: <20190221195816.136157-1-jannh@google.com>

From: Jann Horn <jannh@google.com>
Date: Thu, 21 Feb 2019 20:58:16 +0100

> The listed address for the CAIF maintainer bounces with
> "553 5.3.0 <dmitry.tarnyagin@lockless.no>... No such user here", and the
> only existing email address of the maintainer in git history hasn't
> responded in a week.
> Therefore, remove the listed maintainer and mark CAIF as orphan.
> 
> Signed-off-by: Jann Horn <jannh@google.com>

Applied.

^ permalink raw reply

* Re: [PATCH net-next 0/2] net: phy: improve genphy_read_status
From: David Miller @ 2019-02-21 20:58 UTC (permalink / raw)
  To: hkallweit1; +Cc: andrew, f.fainelli, netdev
In-Reply-To: <1a948543-0dc6-d5df-d50a-49134a2a4118@gmail.com>

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Mon, 18 Feb 2019 20:28:04 +0100

> Series includes two smaller improvements to genphy_read_status.

Series applied.

^ permalink raw reply

* Re: [PATCH net-next 0/4] net: phy: improve generic clause 45 aneg configuration
From: David Miller @ 2019-02-21 21:03 UTC (permalink / raw)
  To: hkallweit1; +Cc: andrew, f.fainelli, netdev
In-Reply-To: <35d86611-9a07-7239-3310-767d8d1050b5@gmail.com>

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Mon, 18 Feb 2019 21:18:35 +0100

> Improve generic clause 45 aneg configuration.

Series applied, thank you.

^ permalink raw reply


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox