From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ian Pilcher <arequipeno@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] libnftnl: Fix res_id byte order
Date: Wed, 19 Oct 2022 08:44:41 +0200 [thread overview]
Message-ID: <Y0+c2Y3VtyXXFijD@salvia> (raw)
In-Reply-To: <20221018164528.250049-2-arequipeno@gmail.com>
On Tue, Oct 18, 2022 at 11:45:28AM -0500, Ian Pilcher wrote:
> The res_id member of struct nfgenmsg is supposed to be in network
> byte order (big endian). Call htons() in __nftnl_nlmsg_build_hdr()
> to ensure that this is true on little endian systems.
LGTM, this is zero all the time at this moment. But it might be useful
in the future to bump it.
next prev parent reply other threads:[~2022-10-19 6:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 16:45 [RFC PATCH 0/1] libnftnl: Incorrect res_id byte order? Ian Pilcher
2022-10-18 16:45 ` [RFC PATCH 1/1] libnftnl: Fix res_id byte order Ian Pilcher
2022-10-19 6:44 ` Pablo Neira Ayuso [this message]
2022-10-20 15:05 ` Ian Pilcher
2022-10-21 9:28 ` Pablo Neira Ayuso
2022-10-25 10:37 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0+c2Y3VtyXXFijD@salvia \
--to=pablo@netfilter.org \
--cc=arequipeno@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox