Am I making a bone-headed mistake with patch-o-matic ?

Am I making a bone-headed mistake with patch-o-matic ?

[netfilter]

Hello.  I am interested in installing the time extension to iptables but I
am unable to run the following command ...

    iptables -m time

I get the resulting output ...

    iptables v1.2.7a: Couldn't load match
`time':/usr/local/lib/iptables/libipt_time.so: cannot open object file: No
such file or directory

I obviously don't have that file.  I've tried running patch-o-matic like so
...

    KERNEL_DIR=/usr/src/linux-2.4.19 | ./runme base  (this is run from
within the patch-o-matic directory)

Everything looks like it works fine, so I go to my kernel source directory
and run a 'make menuconfig' but I don't see any new options for any of the
extension patches that should be installed now.  Am I making a bone-headed
mistake and just completely missing something?  I am running RedHat 7.2 and
obviously trying to setup kernel 2.4.19.  I got the latest patch-o-matic via
cvs and I installed iptables 1.2.7a from a tar.bz2 file from netfilter.org.

Thanks in advance for any help,
Brandon Broyles

Re: Am I making a bone-headed mistake with patch-o-matic ?

[Fabrice MARIE]

Hello,

On Sunday 24 November 2002 00:34, netfilter@drbroyles.com wrote:
> Hello.  I am interested in installing the time extension to iptables but I
> am unable to run the following command ...
>     iptables -m time
> I get the resulting output ...
>     iptables v1.2.7a: Couldn't load match
> `time':/usr/local/lib/iptables/libipt_time.so: cannot open object file: No
> such file or directory
> I obviously don't have that file.

Correct. You need to patch your kernel, and recompile the iptables utility.

>  I've tried running patch-o-matic like so
> ...
>     KERNEL_DIR=/usr/src/linux-2.4.19 | ./runme base  (this is run from
> within the patch-o-matic directory)

Should be a semi colon and not a pipe..

> Everything looks like it works fine, so I go to my kernel source directory
> and run a 'make menuconfig' but I don't see any new options for any of the
> extension patches that should be installed now.  Am I making a bone-headed
> mistake and just completely missing something?  I am running RedHat 7.2 and
> obviously trying to setup kernel 2.4.19.  I got the latest patch-o-matic
> via cvs and I installed iptables 1.2.7a from a tar.bz2 file from
> netfilter.org.

I guess you should read the netfilter-extension-HOWTO from there :
http://www.netfilter.org/documentation/HOWTO/netfilter-extensions-HOWTO.html

There is a problem though (fixed in the CVS, but not yet updated on the HTML page..)
you shouldn't run # make patch-o-matic, but instead from the patch-o-matic directory,
you should run the ./runme script with the patch suite you want to apply as a parameter.
The corrected SGML source of the document is there :
http://cvs.netfilter.org/cgi-bin/cvsweb/~checkout~/netfilter/documentation/HOWTO/netfilter-extensions-HOWTO.sgml

Have a nice day,

Fabrice.
--
Fabrice MARIE

"Silly hacker, root is for administrators"
       -Unknown

Re: Am I making a bone-headed mistake with patch-o-matic ?

[electrode]

----- Original Message -----
From: "Fabrice MARIE" <fabrice@netfilter.org>
To: <netfilter@drbroyles.com>; <netfilter@lists.netfilter.org>
Sent: Saturday, November 23, 2002 11:43 PM
Subject: Re: Am I making a bone-headed mistake with patch-o-matic ?
Welcome to Rusty's Patch-o-matic!

> There is a problem though (fixed in the CVS, but not yet updated on the
HTML page..)
> you shouldn't run # make patch-o-matic, but instead from the patch-o-matic
directory,
> you should run the ./runme script with the patch suite you want to apply
as a parameter.
> The corrected SGML source of the document is there :
>
http://cvs.netfilter.org/cgi-bin/cvsweb/~checkout~/netfilter/documentation/H
OWTO/netfilter-extensions-HOWTO.sgml



From what I read in the above link, I think something may be wrong with my
patch-o-matic I got via CVS.  I ran a (./runme base) and I got the following
output.  In this output the only thing that is "Already applied:" is the
first line.  Nothing else seems to be applied after that.  Plus, that link
above references  switches ( Do you want to apply this patch [N/y/t/f/q/?] )
that I am not getting.

*********************************************************************
Each patch is a new feature: many have minimal impact, some do not.
Almost every one has bugs, so I don't recommend applying them all!
-------------------------------------------------------
Already applied: submitted/2.4.18
                 submitted/ahesp-static
                 submitted/arptables
                 submitted/config-cleanup
                 submitted/conntrack?helper-unregister
                 submitted/conntrack
                 submitted/dscp
                 submitted/DSCP
                 submitted/ecn
                 submitted/ECN
                 submitted/helper
                 submitted/ip6tables-export-symbols
                 submitted/ip6tables-exthdr-bug-ipv6
                 submitted/ip_conntrack_protocol_destroy
                 submitted/ip_conntrack_protocol_unregister
                 submitted/ip_nat_irc-srcaddr-fix
                 submitted/ipt_MIRROR-ttl
                 submitted/ipt_REJECT-checkentry
                 submitted/ipt_unclean-ecn
                 submitted/ipv6-agr-ipv6
                 submitted/irc-dcc-mask
                 submitted/length-ipv6
                 submitted/local-nat
                 submitted/log-tunnel-fix-ipv6
                 submitted/macro-trailing-semicolon-fix
                 submitted/mangle5hooks
                 submitted/nat-export_symbols
                 submitted/nat-memoryleak-fix
                 submitted/netfilter-arp
                 submitted/ownercmd
                 submitted/pkttype
                 submitted/REJECT-dont_fragment
                 submitted/REJECT_mark
                 submitted/remove_no_version
                 submitted/skb_clone_copy
                 submitted/TOS-oops-fix
                 submitted/ulog-module-unload
                 submitted/ulog-nlgroup-shift-fix
                 submitted/ulog-sparc-bitops-fix
                 submitted/unclean-udpchecksum
                 submitted/z-newnat16
                 submitted/z-newnat_assertfix
                 submitted/z-newnat_changeexpect-lockfix
                 pending/newnat-udp-helper
                 base/ahesp6-ipv6
                 base/frag6-ipv6
                 base/fuzzy
                 base/iplimit
                 base/ipt_unclean-ubit
                 base/ipv4options
                 base/IPV4OPTSSTRIP
                 base/ipv6header-ipv6
                 base/mport
                 base/NETLINK
                 base/NETMAP
                 base/nth
                 base/opts6-ipv6
                 base/pool
                 base/psd
                 base/quota
                 base/random
                 base/realm
                 base/REJECT-ipv6
                 base/route6-ipv6
                 base/SAME
                 base/time
                 base/TTL

-----------------------------------------------------------------
No more patches to apply! Q to Quit or ? for options [Q/a/r/b/?]
Excellent! Kernel is now ready for compilation.
*********************************************************************

I never get a chance to choose which patches I wish to install.  Before I
wrote that first message to this mail list, I had already tried recompiling
the kernel and iptables after I ran (./runme base).  Does it look like my
patch-o-matic is working incorrectly?

Thanks,
Brandon Broyles

Re: Am I making a bone-headed mistake with patch-o-matic ?

[Brandon Broyles]

----- Original Message ----- 
From: "Fabrice MARIE" <fabrice@netfilter.org>
To: <netfilter@drbroyles.com>; <netfilter@lists.netfilter.org>
Sent: Saturday, November 23, 2002 11:43 PM
Subject: Re: Am I making a bone-headed mistake with patch-o-matic ?

> There is a problem though (fixed in the CVS, but not yet updated on the
HTML page..)
> you shouldn't run # make patch-o-matic, but instead from the patch-o-matic
directory,
> you should run the ./runme script with the patch suite you want to apply
as a parameter.
> The corrected SGML source of the document is there :
>
http://cvs.netfilter.org/cgi-bin/cvsweb/~checkout~/netfilter/documentation/H
OWTO/netfilter-extensions-HOWTO.sgml


From what I read in the above link, I think something may be wrong with my
patch-o-matic I got via CVS.  I ran a (./runme base) and I got the following
output.  In this output the only thing that is "Already applied:" is the
first line.  Nothing else seems to be applied after that.  Plus, that link
above references  switches ( Do you want to apply this patch [N/y/t/f/q/?] )
that I am not getting.

*********************************************************************
Each patch is a new feature: many have minimal impact, some do not.
Almost every one has bugs, so I don't recommend applying them all!
-------------------------------------------------------
Already applied: submitted/2.4.18
                 submitted/ahesp-static
                 submitted/arptables
                 submitted/config-cleanup
                 submitted/conntrack?helper-unregister
                 submitted/conntrack
                 submitted/dscp
                 submitted/DSCP
                 submitted/ecn
                 submitted/ECN
                 submitted/helper
                 submitted/ip6tables-export-symbols
                 submitted/ip6tables-exthdr-bug-ipv6
                 submitted/ip_conntrack_protocol_destroy
                 submitted/ip_conntrack_protocol_unregister
                 submitted/ip_nat_irc-srcaddr-fix
                 submitted/ipt_MIRROR-ttl
                 submitted/ipt_REJECT-checkentry
                 submitted/ipt_unclean-ecn
                 submitted/ipv6-agr-ipv6
                 submitted/irc-dcc-mask
                 submitted/length-ipv6
                 submitted/local-nat
                 submitted/log-tunnel-fix-ipv6
                 submitted/macro-trailing-semicolon-fix
                 submitted/mangle5hooks
                 submitted/nat-export_symbols
                 submitted/nat-memoryleak-fix
                 submitted/netfilter-arp
                 submitted/ownercmd
                 submitted/pkttype
                 submitted/REJECT-dont_fragment
                 submitted/REJECT_mark
                 submitted/remove_no_version
                 submitted/skb_clone_copy
                 submitted/TOS-oops-fix
                 submitted/ulog-module-unload
                 submitted/ulog-nlgroup-shift-fix
                 submitted/ulog-sparc-bitops-fix
                 submitted/unclean-udpchecksum
                 submitted/z-newnat16
                 submitted/z-newnat_assertfix
                 submitted/z-newnat_changeexpect-lockfix
                 pending/newnat-udp-helper
                 base/ahesp6-ipv6
                 base/frag6-ipv6
                 base/fuzzy
                 base/iplimit
                 base/ipt_unclean-ubit
                 base/ipv4options
                 base/IPV4OPTSSTRIP
                 base/ipv6header-ipv6
                 base/mport
                 base/NETLINK
                 base/NETMAP
                 base/nth
                 base/opts6-ipv6
                 base/pool
                 base/psd
                 base/quota
                 base/random
                 base/realm
                 base/REJECT-ipv6
                 base/route6-ipv6
                 base/SAME
                 base/time
                 base/TTL

-----------------------------------------------------------------
No more patches to apply! Q to Quit or ? for options [Q/a/r/b/?]
Excellent! Kernel is now ready for compilation.
*********************************************************************

I never get a chance to choose which patches I wish to install.  Before I
wrote that first message to this mail list, I had already tried recompiling
the kernel and iptables after I ran (./runme base).  Does it look like my
patch-o-matic is working incorrectly?

Thanks,
Brandon Broyles

Is there something wrong with patch-o-matic?

[Brandon Broyles]

----- Original Message -----
From: "Brandon Broyles" <netfilter@drbroyles.com>
To: <fabrice@netfilter.org>; <netfilter@lists.netfilter.org>
Sent: Sunday, November 24, 2002 12:53 AM
Subject: Re: Am I making a bone-headed mistake with patch-o-matic ?


> From what I read in the above link, I think something may be wrong with my
> patch-o-matic I got via CVS.  I ran a (./runme base) and I got the following
> output.  In this output the only thing that is "Already applied:" is the
> first line.  Nothing else seems to be applied after that.  Plus, that link
> above references  switches ( Do you want to apply this patch [N/y/t/f/q/?] )
> that I am not getting.

I think I may have a clue on where to start.  I was looking at the 'isapplied'
script that came with patch-o-matic.  In line 32 it references a command that
doesn't exist for me.  It reads as such...

MISSING_FILES=`patch -R -s -f -p1 < $PATCH | grep "No file to patch" | wc -l`


I have no 'patch' command and there isn't one anywhere under my netfilter
directory I got from CVS.  I'm not too keen with shell scripting, so I'm not
sure how the absence of a patch command will effect the overall workings of the
'runme' script.


Is this as it should be or is something wrong with the patch-o-matic that I
downloaded?

Thanks,
Brandon Broyles

Re: Is there something wrong with patch-o-matic?

[Alexandros Papadopoulos]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 24 November 2002 12:32, Brandon Broyles wrote:
<snip>
> I think I may have a clue on where to start.  I was looking at the
> 'isapplied' script that came with patch-o-matic.  In line 32 it
> references a command that doesn't exist for me.  It reads as such...
>
> MISSING_FILES=`patch -R -s -f -p1 < $PATCH | grep "No file to patch"
> | wc -l`
>
>
> I have no 'patch' command and there isn't one anywhere under my
> netfilter directory I got from CVS.  I'm not too keen with shell
> scripting, so I'm not sure how the absence of a patch command will
> effect the overall workings of the 'runme' script.
>

No "patch" command on a linux system? It *should* be there, and it 
*should* be in your path.

If the "which patch" command returns nothing, then this is the problem. 
Get and install "patch" somewhere in your path (/usr/bin on my system) 
and you should be set.

- -A
- -- 
http://andrew.cmu.edu/~apapadop/pub_key.asc
3DAD 8435 DB52 F17B 640F  D78C 8260 0CC1 0B75 8265
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE94RA0gmAMwQt1gmURArl/AJ94tAH6UCbWe+LuxXUDz/a78eSKBgCeKd1g
j+et0zsmE1c2qJcaH/UrW28=
=pB6e
-----END PGP SIGNATURE-----

Re: Is there something wrong with patch-o-matic?

[electrode]

----- Original Message -----
From: "Alexandros Papadopoulos" <apapadop@cmu.edu>
To: "Brandon Broyles" <netfilter@drbroyles.com>
Cc: <netfilter@lists.netfilter.org>
Sent: Sunday, November 24, 2002 12:45 PM
Subject: Re: Is there something wrong with patch-o-matic?


Hash: SHA1

On Sunday 24 November 2002 12:32, Brandon Broyles wrote:
<snip>
>> I think I may have a clue on where to start.  I was looking at the
>> 'isapplied' script that came with patch-o-matic.  In line 32 it
>> references a command that doesn't exist for me.  It reads as such...
>>
>> MISSING_FILES=`patch -R -s -f -p1 < $PATCH | grep "No file to patch"
>> | wc -l`
>>
>>
>> I have no 'patch' command and there isn't one anywhere under my
>> netfilter directory I got from CVS.  I'm not too keen with shell
>> scripting, so I'm not sure how the absence of a patch command will
>> effect the overall workings of the 'runme' script.
>
>No "patch" command on a linux system? It *should* be there, and it
>*should* be in your path.
>
>If the "which patch" command returns nothing, then this is the problem.
>Get and install "patch" somewhere in your path (/usr/bin on my system)
>and you should be set.

Thank you.  That was the missing piece of the problem.  I didn't have the patch
program on my system.  I guess that it isn't automatically come with the
installation that I choose and I haven't ever needed it yet.  I installed the
RPM for it and the (runme) script ran the way I would expect.

Thank you,
Brandon Broyles

Re: Is there something wrong with patch-o-matic?

[Fabrice MARIE]

Hello Brandon,

On Monday 25 November 2002 01:32, Brandon Broyles wrote:
> [...]
> I think I may have a clue on where to start.  I was looking at the
> 'isapplied' script that came with patch-o-matic.  In line 32 it references
> a command that doesn't exist for me.  It reads as such...
> MISSING_FILES=`patch -R -s -f -p1 < $PATCH | grep "No file to patch" | wc -l`
> I have no 'patch' command and there isn't one anywhere under my netfilter
> directory I got from CVS.  I'm not too keen with shell scripting, so I'm
> not sure how the absence of a patch command will effect the overall
> workings of the 'runme' script.
> Is this as it should be or is something wrong with the patch-o-matic that I
> downloaded?

patch-o-matic is all about helping you applying your patches automatically
with the 'patch' command. Without patch command there's simply no patch-o-matic.
If you want to use the netfilter extensions which are provided only in patch(-o-matic)
format, then just install 'patch' tool first.

On mandrake, you can simply run
# urpmi patch
it will download and install the tool for you along with dependencies.

BTW, are you really sure you don't have patch ? :)
(usually, patch is /usr/bin/patch)

Have a nice day,

Fabrice.
--
Fabrice MARIE

"Silly hacker, root is for administrators"
       -Unknown

Re: Is there something wrong with patch-o-matic?

[Brandon Broyles]

----- Original Message -----
From: "Fabrice MARIE" <fabrice@netfilter.org>
To: "Brandon Broyles" <netfilter@drbroyles.com>; <netfilter@lists.netfilter.org>
Sent: Wednesday, November 27, 2002 9:24 PM
Subject: Re: Is there something wrong with patch-o-matic?


>
> BTW, are you really sure you don't have patch ? :)
> (usually, patch is /usr/bin/patch)
>
> Have a nice day,
>
> Fabrice.
> --
> Fabrice MARIE
>
> "Silly hacker, root is for administrators"
>        -Unknown
>

Nope, I didn't have patch installed.  Based on the message from Alexandros
Papadopoulos
(http://lists.netfilter.org/pipermail/netfilter/2002-November/040283.html) I
discovered that patch was a common command that should be on any Linux system.
I then installed it from my RedHat cd and then the patch-o-matic worked like it
should.  I am now using the time patch which was my goal from all of the
patching.  Thank you and thank you Alexandros.

Brandon Broyles