* [PATCH] netfs: fix the mismatch used for CONFIG_FSCACHE_DEBUG
@ 2024-03-23 9:23 yangerkun
2024-03-23 15:57 ` Jeff Layton
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: yangerkun @ 2024-03-23 9:23 UTC (permalink / raw)
To: dhowells, jlayton, hsiangkao, netfs; +Cc: yangerkun
The name of debug config used in fs/netfs/internal.h has a mismatch
compared to the define in fs/netfs/Kconfig, which lead to that debug for
netfs won't work.
Signed-off-by: yangerkun <yangerkun@huawei.com>
---
fs/netfs/internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/netfs/internal.h b/fs/netfs/internal.h
index ec7045d24400..53d61ead35fd 100644
--- a/fs/netfs/internal.h
+++ b/fs/netfs/internal.h
@@ -349,7 +349,7 @@ void fscache_create_volume(struct fscache_volume *volume, bool wait);
#define _leave(FMT, ...) kleave(FMT, ##__VA_ARGS__)
#define _debug(FMT, ...) kdebug(FMT, ##__VA_ARGS__)
-#elif defined(CONFIG_NETFS_DEBUG)
+#elif defined(CONFIG_FSCACHE_DEBUG)
#define _enter(FMT, ...) \
do { \
if (netfs_debug) \
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] netfs: fix the mismatch used for CONFIG_FSCACHE_DEBUG
2024-03-23 9:23 [PATCH] netfs: fix the mismatch used for CONFIG_FSCACHE_DEBUG yangerkun
@ 2024-03-23 15:57 ` Jeff Layton
2024-03-24 16:13 ` Gao Xiang
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Jeff Layton @ 2024-03-23 15:57 UTC (permalink / raw)
To: yangerkun, dhowells, hsiangkao, netfs
On Sat, 2024-03-23 at 17:23 +0800, yangerkun wrote:
> The name of debug config used in fs/netfs/internal.h has a mismatch
> compared to the define in fs/netfs/Kconfig, which lead to that debug for
> netfs won't work.
>
> Signed-off-by: yangerkun <yangerkun@huawei.com>
> ---
> fs/netfs/internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/netfs/internal.h b/fs/netfs/internal.h
> index ec7045d24400..53d61ead35fd 100644
> --- a/fs/netfs/internal.h
> +++ b/fs/netfs/internal.h
> @@ -349,7 +349,7 @@ void fscache_create_volume(struct fscache_volume *volume, bool wait);
> #define _leave(FMT, ...) kleave(FMT, ##__VA_ARGS__)
> #define _debug(FMT, ...) kdebug(FMT, ##__VA_ARGS__)
>
> -#elif defined(CONFIG_NETFS_DEBUG)
> +#elif defined(CONFIG_FSCACHE_DEBUG)
> #define _enter(FMT, ...) \
> do { \
> if (netfs_debug) \
Nice catch!
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] netfs: fix the mismatch used for CONFIG_FSCACHE_DEBUG
2024-03-23 9:23 [PATCH] netfs: fix the mismatch used for CONFIG_FSCACHE_DEBUG yangerkun
2024-03-23 15:57 ` Jeff Layton
@ 2024-03-24 16:13 ` Gao Xiang
2024-04-24 11:17 ` yangerkun
2024-08-19 11:28 ` David Howells
3 siblings, 0 replies; 6+ messages in thread
From: Gao Xiang @ 2024-03-24 16:13 UTC (permalink / raw)
To: yangerkun, dhowells, jlayton, netfs
On 2024/3/23 17:23, yangerkun wrote:
> The name of debug config used in fs/netfs/internal.h has a mismatch
> compared to the define in fs/netfs/Kconfig, which lead to that debug for
> netfs won't work.
>
> Signed-off-by: yangerkun <yangerkun@huawei.com>
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] netfs: fix the mismatch used for CONFIG_FSCACHE_DEBUG
2024-03-23 9:23 [PATCH] netfs: fix the mismatch used for CONFIG_FSCACHE_DEBUG yangerkun
2024-03-23 15:57 ` Jeff Layton
2024-03-24 16:13 ` Gao Xiang
@ 2024-04-24 11:17 ` yangerkun
2024-08-19 11:28 ` David Howells
3 siblings, 0 replies; 6+ messages in thread
From: yangerkun @ 2024-04-24 11:17 UTC (permalink / raw)
To: dhowells, jlayton, hsiangkao, netfs
Ping...
在 2024/3/23 17:23, yangerkun 写道:
> The name of debug config used in fs/netfs/internal.h has a mismatch
> compared to the define in fs/netfs/Kconfig, which lead to that debug for
> netfs won't work.
>
> Signed-off-by: yangerkun <yangerkun@huawei.com>
> ---
> fs/netfs/internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/netfs/internal.h b/fs/netfs/internal.h
> index ec7045d24400..53d61ead35fd 100644
> --- a/fs/netfs/internal.h
> +++ b/fs/netfs/internal.h
> @@ -349,7 +349,7 @@ void fscache_create_volume(struct fscache_volume *volume, bool wait);
> #define _leave(FMT, ...) kleave(FMT, ##__VA_ARGS__)
> #define _debug(FMT, ...) kdebug(FMT, ##__VA_ARGS__)
>
> -#elif defined(CONFIG_NETFS_DEBUG)
> +#elif defined(CONFIG_FSCACHE_DEBUG)
> #define _enter(FMT, ...) \
> do { \
> if (netfs_debug) \
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] netfs: fix the mismatch used for CONFIG_FSCACHE_DEBUG
2024-03-23 9:23 [PATCH] netfs: fix the mismatch used for CONFIG_FSCACHE_DEBUG yangerkun
` (2 preceding siblings ...)
2024-04-24 11:17 ` yangerkun
@ 2024-08-19 11:28 ` David Howells
2024-08-19 11:36 ` yangerkun
3 siblings, 1 reply; 6+ messages in thread
From: David Howells @ 2024-08-19 11:28 UTC (permalink / raw)
To: yangerkun; +Cc: dhowells, jlayton, hsiangkao, netfs
yangerkun <yangerkun@huawei.com> wrote:
> The name of debug config used in fs/netfs/internal.h has a mismatch
> compared to the define in fs/netfs/Kconfig, which lead to that debug for
> netfs won't work.
Thanks, however this patch is now obsolete as of commit
fcad93360df4d04b172dba85b976c9f38ee0d5e0:
netfs: Rename CONFIG_FSCACHE_DEBUG to CONFIG_NETFS_DEBUG
David
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] netfs: fix the mismatch used for CONFIG_FSCACHE_DEBUG
2024-08-19 11:28 ` David Howells
@ 2024-08-19 11:36 ` yangerkun
0 siblings, 0 replies; 6+ messages in thread
From: yangerkun @ 2024-08-19 11:36 UTC (permalink / raw)
To: David Howells; +Cc: jlayton, hsiangkao, netfs
在 2024/8/19 19:28, David Howells 写道:
> yangerkun <yangerkun@huawei.com> wrote:
>
>> The name of debug config used in fs/netfs/internal.h has a mismatch
>> compared to the define in fs/netfs/Kconfig, which lead to that debug for
>> netfs won't work.
>
> Thanks, however this patch is now obsolete as of commit
> fcad93360df4d04b172dba85b976c9f38ee0d5e0:
>
> netfs: Rename CONFIG_FSCACHE_DEBUG to CONFIG_NETFS_DEBUG
Oh, sorry, I have not check the latest kernel does this problem still
exist, it's me fault, thanks a lot for you point out this.
>
> David
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-08-19 11:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-23 9:23 [PATCH] netfs: fix the mismatch used for CONFIG_FSCACHE_DEBUG yangerkun
2024-03-23 15:57 ` Jeff Layton
2024-03-24 16:13 ` Gao Xiang
2024-04-24 11:17 ` yangerkun
2024-08-19 11:28 ` David Howells
2024-08-19 11:36 ` yangerkun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox