[PATCH 00/40] [Set 8] Rid W=1 warnings from GPU

[PATCH 00/40] [Set 8] Rid W=1 warnings from GPU

[Lee Jones]

This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Only 900 (from 5000) to go!

Lee Jones (40):
  drm/radeon/radeon_device: Consume our own header where the prototypes
    are located
  drm/amd/amdgpu/amdgpu_ttm: Add description for 'page_flags'
  drm/amd/amdgpu/amdgpu_ib: Provide docs for 'amdgpu_ib_schedule()'s
    'job' param
  drm/amd/amdgpu/amdgpu_virt: Correct possible copy/paste or doc-rot
    misnaming issue
  drm/amd/amdgpu/cik_ih: Supply description for 'ih' in
    'cik_ih_{get,set}_wptr()'
  drm/amd/amdgpu/uvd_v4_2: Fix some kernel-doc misdemeanours
  drm/amd/amdgpu/dce_v8_0: Supply description for 'async'
  drm/amd/amdgpu/cik_sdma: Supply some missing function param
    descriptions
  drm/amd/amdgpu/gfx_v7_0: Clean-up a bunch of kernel-doc related issues
  drm/msm/disp/dpu1/dpu_core_perf: Fix kernel-doc formatting issues
  drm/msm/disp/dpu1/dpu_hw_blk: Add one missing and remove an extra
    param description
  drm/msm/disp/dpu1/dpu_formats: Demote non-conformant kernel-doc header
  drm/msm/disp/dpu1/dpu_hw_catalog: Remove duplicated initialisation of
    'max_linewidth'
  drm/msm/disp/dpu1/dpu_hw_catalog: Move definitions to the only place
    they are used
  drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc
  drm/amd/amdgpu/si_dma: Fix a bunch of function documentation issues
  drm/amd/amdgpu/gfx_v6_0: Supply description for
    'gfx_v6_0_ring_test_ib()'s 'timeout' param
  drm/msm/disp/dpu1/dpu_encoder: Fix a few parameter/member formatting
    issues
  drm/msm/disp/dpu1/dpu_hw_lm: Fix misnaming of parameter 'ctx'
  drm/msm/disp/dpu1/dpu_hw_sspp: Fix kernel-doc formatting abuse
  drm/amd/amdgpu/uvd_v3_1: Fix-up some documentation issues
  drm/amd/amdgpu/dce_v6_0: Fix formatting and missing parameter
    description issues
  drm/amd/include/vega20_ip_offset: Mark top-level IP_BASE definition as
    __maybe_unused
  drm/amd/include/navi10_ip_offset: Mark top-level IP_BASE as
    __maybe_unused
  drm/amd/include/arct_ip_offset: Mark top-level IP_BASE definition as
    __maybe_unused
  drm/amd/include/navi14_ip_offset: Mark top-level IP_BASE as
    __maybe_unused
  drm/amd/include/navi12_ip_offset: Mark top-level IP_BASE as
    __maybe_unused
  drm/amd/include/sienna_cichlid_ip_offset: Mark top-level IP_BASE as
    __maybe_unused
  drm/amd/include/vangogh_ip_offset: Mark top-level IP_BASE as
    __maybe_unused
  drm/amd/include/dimgrey_cavefish_ip_offset: Mark top-level IP_BASE as
    __maybe_unused
  drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply
    'global_state' description
  drm/msm/disp/dpu1/dpu_vbif: Fix a couple of function param
    descriptions
  drm/amd/amdgpu/cik_sdma: Add one and remove another function param
    description
  drm/amd/amdgpu/uvd_v4_2: Add one and remove another function param
    description
  drm/msm/disp/dpu1/dpu_plane: Fix some spelling and missing function
    param descriptions
  drm/amd/amdgpu/gmc_v7_0: Add some missing kernel-doc descriptions
  drm/amd/amdgpu/gmc_v8_0: Fix more issues attributed to copy/paste
  drm/msm/msm_drv: Make '_msm_ioremap()' static
  drm/amd/amdgpu/gmc_v9_0: Remove unused table
    'ecc_umc_mcumc_status_addrs'
  drm/amd/amdgpu/gmc_v9_0: Suppy some missing function doc descriptions

 drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c        |   1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c       |   1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c      |  12 +-
 drivers/gpu/drm/amd/amdgpu/cik_ih.c           |   2 +
 drivers/gpu/drm/amd/amdgpu/cik_sdma.c         |  18 ++-
 drivers/gpu/drm/amd/amdgpu/dce_v6_0.c         |   2 +-
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c         |   1 +
 drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c         |   1 +
 drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c         |  33 +++--
 drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c         |   7 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c         |   5 +
 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c         |  38 +----
 drivers/gpu/drm/amd/amdgpu/si_dma.c           |  14 +-
 drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c         |  10 +-
 drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c         |  10 +-
 drivers/gpu/drm/amd/include/arct_ip_offset.h  |   4 +-
 .../amd/include/dimgrey_cavefish_ip_offset.h  |   2 +-
 .../gpu/drm/amd/include/navi10_ip_offset.h    |   2 +-
 .../gpu/drm/amd/include/navi12_ip_offset.h    |   2 +-
 .../gpu/drm/amd/include/navi14_ip_offset.h    |   2 +-
 .../amd/include/sienna_cichlid_ip_offset.h    |   2 +-
 .../gpu/drm/amd/include/vangogh_ip_offset.h   |   2 +-
 .../gpu/drm/amd/include/vega20_ip_offset.h    |   2 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c |  17 +--
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c   |  15 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c   |   2 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c    |   2 +-
 .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c    |  75 +++++++++-
 .../drm/msm/disp/dpu1/dpu_hw_catalog_format.h |  88 ------------
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c     |   2 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c   |   4 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c     |  19 ++-
 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c        |   5 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c      |   2 +-
 drivers/gpu/drm/msm/msm_drv.c                 |   4 +-
 .../gpu/drm/nouveau/nvkm/subdev/bios/init.c   | 136 +++++++++---------
 drivers/gpu/drm/radeon/radeon_device.c        |   1 +
 37 files changed, 277 insertions(+), 268 deletions(-)
 delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@linux.ie>
Cc: Drew Davenport <ddavenport@chromium.org>
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Cc: Fritz Koenig <frkoenig@google.com>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Jerome Glisse <glisse@freedesktop.org>
Cc: Jiansong Chen <Jiansong.Chen@amd.com>
Cc: Jonathan Marek <jonathan@marek.ca>
Cc: Kalyan Thota <kalyan_t@codeaurora.org>
Cc: Likun Gao <Likun.Gao@amd.com>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: Luben Tuikov <luben.tuikov@amd.com>
Cc: nouveau@lists.freedesktop.org
Cc: Qinglang Miao <miaoqinglang@huawei.com>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Sonny Jiang <sonny.jiang@amd.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Tao Zhou <tao.zhou1@amd.com>
-- 
2.25.1

_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

[PATCH 15/40] drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved'
 drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: Function parameter or member 'init' not described in 'init_done'
 drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:622: warning: Function parameter or member 'init' not described in 'init_io_restrict_prog'
 drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:659: warning: Function parameter or member 'init' not described in 'init_repeat'
 drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:685: warning: Function parameter or member 'init' not described in 'init_io_restrict_pll'
 drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:725: warning: Function parameter or member 'init' not described in 'init_end_repeat'

NB: Trimmed for brevity (lots of these!)

Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 .../gpu/drm/nouveau/nvkm/subdev/bios/init.c   | 136 +++++++++---------
 1 file changed, 68 insertions(+), 68 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
index 9de74f41dcd2a..68e35219cf757 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
@@ -575,7 +575,7 @@ init_tmds_reg(struct nvbios_init *init, u8 tmds)
  * init opcode handlers
  *****************************************************************************/
 
-/**
+/*
  * init_reserved - stub for various unknown/unused single-byte opcodes
  *
  */
@@ -602,7 +602,7 @@ init_reserved(struct nvbios_init *init)
 	init->offset += length;
 }
 
-/**
+/*
  * INIT_DONE - opcode 0x71
  *
  */
@@ -613,7 +613,7 @@ init_done(struct nvbios_init *init)
 	init->offset = 0x0000;
 }
 
-/**
+/*
  * INIT_IO_RESTRICT_PROG - opcode 0x32
  *
  */
@@ -650,7 +650,7 @@ init_io_restrict_prog(struct nvbios_init *init)
 	trace("}]\n");
 }
 
-/**
+/*
  * INIT_REPEAT - opcode 0x33
  *
  */
@@ -676,7 +676,7 @@ init_repeat(struct nvbios_init *init)
 	init->repeat = repeat;
 }
 
-/**
+/*
  * INIT_IO_RESTRICT_PLL - opcode 0x34
  *
  */
@@ -716,7 +716,7 @@ init_io_restrict_pll(struct nvbios_init *init)
 	trace("}]\n");
 }
 
-/**
+/*
  * INIT_END_REPEAT - opcode 0x36
  *
  */
@@ -732,7 +732,7 @@ init_end_repeat(struct nvbios_init *init)
 	}
 }
 
-/**
+/*
  * INIT_COPY - opcode 0x37
  *
  */
@@ -759,7 +759,7 @@ init_copy(struct nvbios_init *init)
 	init_wrvgai(init, port, index, data);
 }
 
-/**
+/*
  * INIT_NOT - opcode 0x38
  *
  */
@@ -771,7 +771,7 @@ init_not(struct nvbios_init *init)
 	init_exec_inv(init);
 }
 
-/**
+/*
  * INIT_IO_FLAG_CONDITION - opcode 0x39
  *
  */
@@ -788,7 +788,7 @@ init_io_flag_condition(struct nvbios_init *init)
 		init_exec_set(init, false);
 }
 
-/**
+/*
  * INIT_GENERIC_CONDITION - opcode 0x3a
  *
  */
@@ -840,7 +840,7 @@ init_generic_condition(struct nvbios_init *init)
 	}
 }
 
-/**
+/*
  * INIT_IO_MASK_OR - opcode 0x3b
  *
  */
@@ -859,7 +859,7 @@ init_io_mask_or(struct nvbios_init *init)
 	init_wrvgai(init, 0x03d4, index, data &= ~(1 << or));
 }
 
-/**
+/*
  * INIT_IO_OR - opcode 0x3c
  *
  */
@@ -878,7 +878,7 @@ init_io_or(struct nvbios_init *init)
 	init_wrvgai(init, 0x03d4, index, data | (1 << or));
 }
 
-/**
+/*
  * INIT_ANDN_REG - opcode 0x47
  *
  */
@@ -895,7 +895,7 @@ init_andn_reg(struct nvbios_init *init)
 	init_mask(init, reg, mask, 0);
 }
 
-/**
+/*
  * INIT_OR_REG - opcode 0x48
  *
  */
@@ -912,7 +912,7 @@ init_or_reg(struct nvbios_init *init)
 	init_mask(init, reg, 0, mask);
 }
 
-/**
+/*
  * INIT_INDEX_ADDRESS_LATCHED - opcode 0x49
  *
  */
@@ -942,7 +942,7 @@ init_idx_addr_latched(struct nvbios_init *init)
 	}
 }
 
-/**
+/*
  * INIT_IO_RESTRICT_PLL2 - opcode 0x4a
  *
  */
@@ -977,7 +977,7 @@ init_io_restrict_pll2(struct nvbios_init *init)
 	trace("}]\n");
 }
 
-/**
+/*
  * INIT_PLL2 - opcode 0x4b
  *
  */
@@ -994,7 +994,7 @@ init_pll2(struct nvbios_init *init)
 	init_prog_pll(init, reg, freq);
 }
 
-/**
+/*
  * INIT_I2C_BYTE - opcode 0x4c
  *
  */
@@ -1025,7 +1025,7 @@ init_i2c_byte(struct nvbios_init *init)
 	}
 }
 
-/**
+/*
  * INIT_ZM_I2C_BYTE - opcode 0x4d
  *
  */
@@ -1051,7 +1051,7 @@ init_zm_i2c_byte(struct nvbios_init *init)
 	}
 }
 
-/**
+/*
  * INIT_ZM_I2C - opcode 0x4e
  *
  */
@@ -1085,7 +1085,7 @@ init_zm_i2c(struct nvbios_init *init)
 	}
 }
 
-/**
+/*
  * INIT_TMDS - opcode 0x4f
  *
  */
@@ -1111,7 +1111,7 @@ init_tmds(struct nvbios_init *init)
 	init_wr32(init, reg + 0, addr);
 }
 
-/**
+/*
  * INIT_ZM_TMDS_GROUP - opcode 0x50
  *
  */
@@ -1138,7 +1138,7 @@ init_zm_tmds_group(struct nvbios_init *init)
 	}
 }
 
-/**
+/*
  * INIT_CR_INDEX_ADDRESS_LATCHED - opcode 0x51
  *
  */
@@ -1168,7 +1168,7 @@ init_cr_idx_adr_latch(struct nvbios_init *init)
 	init_wrvgai(init, 0x03d4, addr0, save0);
 }
 
-/**
+/*
  * INIT_CR - opcode 0x52
  *
  */
@@ -1188,7 +1188,7 @@ init_cr(struct nvbios_init *init)
 	init_wrvgai(init, 0x03d4, addr, val | data);
 }
 
-/**
+/*
  * INIT_ZM_CR - opcode 0x53
  *
  */
@@ -1205,7 +1205,7 @@ init_zm_cr(struct nvbios_init *init)
 	init_wrvgai(init, 0x03d4, addr, data);
 }
 
-/**
+/*
  * INIT_ZM_CR_GROUP - opcode 0x54
  *
  */
@@ -1229,7 +1229,7 @@ init_zm_cr_group(struct nvbios_init *init)
 	}
 }
 
-/**
+/*
  * INIT_CONDITION_TIME - opcode 0x56
  *
  */
@@ -1256,7 +1256,7 @@ init_condition_time(struct nvbios_init *init)
 	init_exec_set(init, false);
 }
 
-/**
+/*
  * INIT_LTIME - opcode 0x57
  *
  */
@@ -1273,7 +1273,7 @@ init_ltime(struct nvbios_init *init)
 		mdelay(msec);
 }
 
-/**
+/*
  * INIT_ZM_REG_SEQUENCE - opcode 0x58
  *
  */
@@ -1298,7 +1298,7 @@ init_zm_reg_sequence(struct nvbios_init *init)
 	}
 }
 
-/**
+/*
  * INIT_PLL_INDIRECT - opcode 0x59
  *
  */
@@ -1317,7 +1317,7 @@ init_pll_indirect(struct nvbios_init *init)
 	init_prog_pll(init, reg, freq);
 }
 
-/**
+/*
  * INIT_ZM_REG_INDIRECT - opcode 0x5a
  *
  */
@@ -1336,7 +1336,7 @@ init_zm_reg_indirect(struct nvbios_init *init)
 	init_wr32(init, addr, data);
 }
 
-/**
+/*
  * INIT_SUB_DIRECT - opcode 0x5b
  *
  */
@@ -1362,7 +1362,7 @@ init_sub_direct(struct nvbios_init *init)
 	init->offset += 3;
 }
 
-/**
+/*
  * INIT_JUMP - opcode 0x5c
  *
  */
@@ -1380,7 +1380,7 @@ init_jump(struct nvbios_init *init)
 		init->offset += 3;
 }
 
-/**
+/*
  * INIT_I2C_IF - opcode 0x5e
  *
  */
@@ -1407,7 +1407,7 @@ init_i2c_if(struct nvbios_init *init)
 	init_exec_force(init, false);
 }
 
-/**
+/*
  * INIT_COPY_NV_REG - opcode 0x5f
  *
  */
@@ -1433,7 +1433,7 @@ init_copy_nv_reg(struct nvbios_init *init)
 	init_mask(init, dreg, ~dmask, (data & smask) ^ sxor);
 }
 
-/**
+/*
  * INIT_ZM_INDEX_IO - opcode 0x62
  *
  */
@@ -1451,7 +1451,7 @@ init_zm_index_io(struct nvbios_init *init)
 	init_wrvgai(init, port, index, data);
 }
 
-/**
+/*
  * INIT_COMPUTE_MEM - opcode 0x63
  *
  */
@@ -1469,7 +1469,7 @@ init_compute_mem(struct nvbios_init *init)
 	init_exec_force(init, false);
 }
 
-/**
+/*
  * INIT_RESET - opcode 0x65
  *
  */
@@ -1496,7 +1496,7 @@ init_reset(struct nvbios_init *init)
 	init_exec_force(init, false);
 }
 
-/**
+/*
  * INIT_CONFIGURE_MEM - opcode 0x66
  *
  */
@@ -1555,7 +1555,7 @@ init_configure_mem(struct nvbios_init *init)
 	init_exec_force(init, false);
 }
 
-/**
+/*
  * INIT_CONFIGURE_CLK - opcode 0x67
  *
  */
@@ -1589,7 +1589,7 @@ init_configure_clk(struct nvbios_init *init)
 	init_exec_force(init, false);
 }
 
-/**
+/*
  * INIT_CONFIGURE_PREINIT - opcode 0x68
  *
  */
@@ -1615,7 +1615,7 @@ init_configure_preinit(struct nvbios_init *init)
 	init_exec_force(init, false);
 }
 
-/**
+/*
  * INIT_IO - opcode 0x69
  *
  */
@@ -1655,7 +1655,7 @@ init_io(struct nvbios_init *init)
 	init_wrport(init, port, data | value);
 }
 
-/**
+/*
  * INIT_SUB - opcode 0x6b
  *
  */
@@ -1682,7 +1682,7 @@ init_sub(struct nvbios_init *init)
 	init->offset += 2;
 }
 
-/**
+/*
  * INIT_RAM_CONDITION - opcode 0x6d
  *
  */
@@ -1701,7 +1701,7 @@ init_ram_condition(struct nvbios_init *init)
 		init_exec_set(init, false);
 }
 
-/**
+/*
  * INIT_NV_REG - opcode 0x6e
  *
  */
@@ -1719,7 +1719,7 @@ init_nv_reg(struct nvbios_init *init)
 	init_mask(init, reg, ~mask, data);
 }
 
-/**
+/*
  * INIT_MACRO - opcode 0x6f
  *
  */
@@ -1743,7 +1743,7 @@ init_macro(struct nvbios_init *init)
 	init->offset += 2;
 }
 
-/**
+/*
  * INIT_RESUME - opcode 0x72
  *
  */
@@ -1755,7 +1755,7 @@ init_resume(struct nvbios_init *init)
 	init_exec_set(init, true);
 }
 
-/**
+/*
  * INIT_STRAP_CONDITION - opcode 0x73
  *
  */
@@ -1773,7 +1773,7 @@ init_strap_condition(struct nvbios_init *init)
 		init_exec_set(init, false);
 }
 
-/**
+/*
  * INIT_TIME - opcode 0x74
  *
  */
@@ -1794,7 +1794,7 @@ init_time(struct nvbios_init *init)
 	}
 }
 
-/**
+/*
  * INIT_CONDITION - opcode 0x75
  *
  */
@@ -1811,7 +1811,7 @@ init_condition(struct nvbios_init *init)
 		init_exec_set(init, false);
 }
 
-/**
+/*
  * INIT_IO_CONDITION - opcode 0x76
  *
  */
@@ -1828,7 +1828,7 @@ init_io_condition(struct nvbios_init *init)
 		init_exec_set(init, false);
 }
 
-/**
+/*
  * INIT_ZM_REG16 - opcode 0x77
  *
  */
@@ -1845,7 +1845,7 @@ init_zm_reg16(struct nvbios_init *init)
 	init_wr32(init, addr, data);
 }
 
-/**
+/*
  * INIT_INDEX_IO - opcode 0x78
  *
  */
@@ -1867,7 +1867,7 @@ init_index_io(struct nvbios_init *init)
 	init_wrvgai(init, port, index, data | value);
 }
 
-/**
+/*
  * INIT_PLL - opcode 0x79
  *
  */
@@ -1884,7 +1884,7 @@ init_pll(struct nvbios_init *init)
 	init_prog_pll(init, reg, freq);
 }
 
-/**
+/*
  * INIT_ZM_REG - opcode 0x7a
  *
  */
@@ -1904,7 +1904,7 @@ init_zm_reg(struct nvbios_init *init)
 	init_wr32(init, addr, data);
 }
 
-/**
+/*
  * INIT_RAM_RESTRICT_PLL - opcde 0x87
  *
  */
@@ -1934,7 +1934,7 @@ init_ram_restrict_pll(struct nvbios_init *init)
 	}
 }
 
-/**
+/*
  * INIT_RESET_BEGUN - opcode 0x8c
  *
  */
@@ -1945,7 +1945,7 @@ init_reset_begun(struct nvbios_init *init)
 	init->offset += 1;
 }
 
-/**
+/*
  * INIT_RESET_END - opcode 0x8d
  *
  */
@@ -1956,7 +1956,7 @@ init_reset_end(struct nvbios_init *init)
 	init->offset += 1;
 }
 
-/**
+/*
  * INIT_GPIO - opcode 0x8e
  *
  */
@@ -1972,7 +1972,7 @@ init_gpio(struct nvbios_init *init)
 		nvkm_gpio_reset(gpio, DCB_GPIO_UNUSED);
 }
 
-/**
+/*
  * INIT_RAM_RESTRICT_ZM_GROUP - opcode 0x8f
  *
  */
@@ -2010,7 +2010,7 @@ init_ram_restrict_zm_reg_group(struct nvbios_init *init)
 	}
 }
 
-/**
+/*
  * INIT_COPY_ZM_REG - opcode 0x90
  *
  */
@@ -2027,7 +2027,7 @@ init_copy_zm_reg(struct nvbios_init *init)
 	init_wr32(init, dreg, init_rd32(init, sreg));
 }
 
-/**
+/*
  * INIT_ZM_REG_GROUP - opcode 0x91
  *
  */
@@ -2049,7 +2049,7 @@ init_zm_reg_group(struct nvbios_init *init)
 	}
 }
 
-/**
+/*
  * INIT_XLAT - opcode 0x96
  *
  */
@@ -2077,7 +2077,7 @@ init_xlat(struct nvbios_init *init)
 	init_mask(init, daddr, ~dmask, data);
 }
 
-/**
+/*
  * INIT_ZM_MASK_ADD - opcode 0x97
  *
  */
@@ -2098,7 +2098,7 @@ init_zm_mask_add(struct nvbios_init *init)
 	init_wr32(init, addr, data);
 }
 
-/**
+/*
  * INIT_AUXCH - opcode 0x98
  *
  */
@@ -2122,7 +2122,7 @@ init_auxch(struct nvbios_init *init)
 	}
 }
 
-/**
+/*
  * INIT_AUXCH - opcode 0x99
  *
  */
@@ -2144,7 +2144,7 @@ init_zm_auxch(struct nvbios_init *init)
 	}
 }
 
-/**
+/*
  * INIT_I2C_LONG_IF - opcode 0x9a
  *
  */
@@ -2183,7 +2183,7 @@ init_i2c_long_if(struct nvbios_init *init)
 	init_exec_set(init, false);
 }
 
-/**
+/*
  * INIT_GPIO_NE - opcode 0xa9
  *
  */
-- 
2.25.1

Re: [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU

[Christian König]

Only skimmed over them, but over all looks sane to me.

Series is Acked-by: Christian König <christian.koenig@amd.com>

Thanks,
Christian.

Am 23.11.20 um 12:18 schrieb Lee Jones:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Only 900 (from 5000) to go!
>
> Lee Jones (40):
>    drm/radeon/radeon_device: Consume our own header where the prototypes
>      are located
>    drm/amd/amdgpu/amdgpu_ttm: Add description for 'page_flags'
>    drm/amd/amdgpu/amdgpu_ib: Provide docs for 'amdgpu_ib_schedule()'s
>      'job' param
>    drm/amd/amdgpu/amdgpu_virt: Correct possible copy/paste or doc-rot
>      misnaming issue
>    drm/amd/amdgpu/cik_ih: Supply description for 'ih' in
>      'cik_ih_{get,set}_wptr()'
>    drm/amd/amdgpu/uvd_v4_2: Fix some kernel-doc misdemeanours
>    drm/amd/amdgpu/dce_v8_0: Supply description for 'async'
>    drm/amd/amdgpu/cik_sdma: Supply some missing function param
>      descriptions
>    drm/amd/amdgpu/gfx_v7_0: Clean-up a bunch of kernel-doc related issues
>    drm/msm/disp/dpu1/dpu_core_perf: Fix kernel-doc formatting issues
>    drm/msm/disp/dpu1/dpu_hw_blk: Add one missing and remove an extra
>      param description
>    drm/msm/disp/dpu1/dpu_formats: Demote non-conformant kernel-doc header
>    drm/msm/disp/dpu1/dpu_hw_catalog: Remove duplicated initialisation of
>      'max_linewidth'
>    drm/msm/disp/dpu1/dpu_hw_catalog: Move definitions to the only place
>      they are used
>    drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc
>    drm/amd/amdgpu/si_dma: Fix a bunch of function documentation issues
>    drm/amd/amdgpu/gfx_v6_0: Supply description for
>      'gfx_v6_0_ring_test_ib()'s 'timeout' param
>    drm/msm/disp/dpu1/dpu_encoder: Fix a few parameter/member formatting
>      issues
>    drm/msm/disp/dpu1/dpu_hw_lm: Fix misnaming of parameter 'ctx'
>    drm/msm/disp/dpu1/dpu_hw_sspp: Fix kernel-doc formatting abuse
>    drm/amd/amdgpu/uvd_v3_1: Fix-up some documentation issues
>    drm/amd/amdgpu/dce_v6_0: Fix formatting and missing parameter
>      description issues
>    drm/amd/include/vega20_ip_offset: Mark top-level IP_BASE definition as
>      __maybe_unused
>    drm/amd/include/navi10_ip_offset: Mark top-level IP_BASE as
>      __maybe_unused
>    drm/amd/include/arct_ip_offset: Mark top-level IP_BASE definition as
>      __maybe_unused
>    drm/amd/include/navi14_ip_offset: Mark top-level IP_BASE as
>      __maybe_unused
>    drm/amd/include/navi12_ip_offset: Mark top-level IP_BASE as
>      __maybe_unused
>    drm/amd/include/sienna_cichlid_ip_offset: Mark top-level IP_BASE as
>      __maybe_unused
>    drm/amd/include/vangogh_ip_offset: Mark top-level IP_BASE as
>      __maybe_unused
>    drm/amd/include/dimgrey_cavefish_ip_offset: Mark top-level IP_BASE as
>      __maybe_unused
>    drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply
>      'global_state' description
>    drm/msm/disp/dpu1/dpu_vbif: Fix a couple of function param
>      descriptions
>    drm/amd/amdgpu/cik_sdma: Add one and remove another function param
>      description
>    drm/amd/amdgpu/uvd_v4_2: Add one and remove another function param
>      description
>    drm/msm/disp/dpu1/dpu_plane: Fix some spelling and missing function
>      param descriptions
>    drm/amd/amdgpu/gmc_v7_0: Add some missing kernel-doc descriptions
>    drm/amd/amdgpu/gmc_v8_0: Fix more issues attributed to copy/paste
>    drm/msm/msm_drv: Make '_msm_ioremap()' static
>    drm/amd/amdgpu/gmc_v9_0: Remove unused table
>      'ecc_umc_mcumc_status_addrs'
>    drm/amd/amdgpu/gmc_v9_0: Suppy some missing function doc descriptions
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c        |   1 +
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c       |   1 +
>   drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c      |  12 +-
>   drivers/gpu/drm/amd/amdgpu/cik_ih.c           |   2 +
>   drivers/gpu/drm/amd/amdgpu/cik_sdma.c         |  18 ++-
>   drivers/gpu/drm/amd/amdgpu/dce_v6_0.c         |   2 +-
>   drivers/gpu/drm/amd/amdgpu/dce_v8_0.c         |   1 +
>   drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c         |   1 +
>   drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c         |  33 +++--
>   drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c         |   7 +-
>   drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c         |   5 +
>   drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c         |  38 +----
>   drivers/gpu/drm/amd/amdgpu/si_dma.c           |  14 +-
>   drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c         |  10 +-
>   drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c         |  10 +-
>   drivers/gpu/drm/amd/include/arct_ip_offset.h  |   4 +-
>   .../amd/include/dimgrey_cavefish_ip_offset.h  |   2 +-
>   .../gpu/drm/amd/include/navi10_ip_offset.h    |   2 +-
>   .../gpu/drm/amd/include/navi12_ip_offset.h    |   2 +-
>   .../gpu/drm/amd/include/navi14_ip_offset.h    |   2 +-
>   .../amd/include/sienna_cichlid_ip_offset.h    |   2 +-
>   .../gpu/drm/amd/include/vangogh_ip_offset.h   |   2 +-
>   .../gpu/drm/amd/include/vega20_ip_offset.h    |   2 +-
>   drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c |  17 +--
>   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c   |  15 +-
>   drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c   |   2 +-
>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c    |   2 +-
>   .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c    |  75 +++++++++-
>   .../drm/msm/disp/dpu1/dpu_hw_catalog_format.h |  88 ------------
>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c     |   2 +-
>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c   |   4 +-
>   drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c     |  19 ++-
>   drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c        |   5 +-
>   drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c      |   2 +-
>   drivers/gpu/drm/msm/msm_drv.c                 |   4 +-
>   .../gpu/drm/nouveau/nvkm/subdev/bios/init.c   | 136 +++++++++---------
>   drivers/gpu/drm/radeon/radeon_device.c        |   1 +
>   37 files changed, 277 insertions(+), 268 deletions(-)
>   delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Drew Davenport <ddavenport@chromium.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Cc: Fritz Koenig <frkoenig@google.com>
> Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> Cc: Huang Rui <ray.huang@amd.com>
> Cc: Jerome Glisse <glisse@freedesktop.org>
> Cc: Jiansong Chen <Jiansong.Chen@amd.com>
> Cc: Jonathan Marek <jonathan@marek.ca>
> Cc: Kalyan Thota <kalyan_t@codeaurora.org>
> Cc: Likun Gao <Likun.Gao@amd.com>
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-media@vger.kernel.org
> Cc: Luben Tuikov <luben.tuikov@amd.com>
> Cc: nouveau@lists.freedesktop.org
> Cc: Qinglang Miao <miaoqinglang@huawei.com>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Sonny Jiang <sonny.jiang@amd.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Tao Zhou <tao.zhou1@amd.com>

_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU

[Lee Jones]

On Mon, 23 Nov 2020, Christian König wrote:

> Only skimmed over them, but over all looks sane to me.
> 
> Series is Acked-by: Christian König <christian.koenig@amd.com>

Thanks Christian, much appreciated.

> Am 23.11.20 um 12:18 schrieb Lee Jones:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> > 
> > Only 900 (from 5000) to go!
> > 
> > Lee Jones (40):
> >    drm/radeon/radeon_device: Consume our own header where the prototypes
> >      are located
> >    drm/amd/amdgpu/amdgpu_ttm: Add description for 'page_flags'
> >    drm/amd/amdgpu/amdgpu_ib: Provide docs for 'amdgpu_ib_schedule()'s
> >      'job' param
> >    drm/amd/amdgpu/amdgpu_virt: Correct possible copy/paste or doc-rot
> >      misnaming issue
> >    drm/amd/amdgpu/cik_ih: Supply description for 'ih' in

[...]

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno