[Bug 33165] [NVA3, NVA8] gpu lockup during driver probe - bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ

From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [Bug 33165] [NVA3, NVA8] gpu lockup during driver probe
Date: Sun, 09 Mar 2014 16:34:36 +0000	[thread overview]
Message-ID: <bug-33165-8800-AWHsrZi7lj@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-33165-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>


[-- Attachment #1.1: Type: text/plain, Size: 1073 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=33165

--- Comment #30 from Oleg Bulatov <oleg-BA2faJl1U0oSAix4rjypdw@public.gmane.org> ---
Comment on attachment 95408
  --> https://bugs.freedesktop.org/attachment.cgi?id=95408
initialize stuff for gddr5 ram

Review of attachment 95408:
-----------------------------------------------------------------

::: drivers/gpu/drm/nouveau/core/subdev/fb/ramnva3.c
@@ +365,5 @@
> +		/* XXX this algorithm is insane, find some sanity to it. */
> +		/* [1] MMIO32 R 0x100268 0x30030200 PFB.SUBPART_CONFIG => { SELECT_MASK = 0x2 | UNK16 = 0x3 | ENABLE_MASK = 0x3 } */
> +		nv_wr32(pfb, 0x10fcac, 0x00001f01);
> +		for (o = 0; o < 4; o++) {
> +			int off = offsets[i];

maybe int off = offsets[o]; ?

@@ +387,5 @@
> +			for (i = 0x20, idx = 0; i < 0x30; i++, idx++) {
> +				int pat = pattern[2 + (idx % 2)];
> +				if (i == 0x26)
> +					pat = 0;
> +				if (i == 0x1f)

looks like this condition is always false in this for-loop

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2505 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau