* [Bug 68456] [NV4B] null deref on load, NvI2C=1 makes it work
[not found] ` <bug-68456-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>
@ 2013-08-22 23:00 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2013-08-23 1:13 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2013-08-22 23:00 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
[-- Attachment #1.1: Type: text/plain, Size: 529 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=68456
Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|kernel NULL pointer |[NV4B] null deref on load,
|dereference on 'modprobe |NvI2C=1 makes it work
|nouveau' |
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1126 bytes --]
[-- Attachment #2: Type: text/plain, Size: 181 bytes --]
_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug 68456] [NV4B] null deref on load, NvI2C=1 makes it work
[not found] ` <bug-68456-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>
2013-08-22 23:00 ` [Bug 68456] [NV4B] null deref on load, NvI2C=1 makes it work bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
@ 2013-08-23 1:13 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2013-08-23 1:46 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2013-08-23 1:13 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
[-- Attachment #1.1: Type: text/plain, Size: 890 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=68456
--- Comment #1 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
The code decodes to
1c: 51 push %rcx
1d: 48 8b 47 18 mov 0x18(%rdi),%rax
21: 48 8b 38 mov (%rax),%rdi
24: 48 8b 87 50 03 00 00 mov 0x350(%rdi),%rax
2b:* 48 8b 00 mov (%rax),%rax <-- trapping
instruction
2e: 48 85 c0 test %rax,%rax
31: 74 02 je 0x35
33: ff d0 callq *%rax
35: 31 c0 xor %eax,%eax
37: 5a pop %rdx
38: c3 retq
Which means that port->func is NULL. Still trying to work out exactly how that
happens.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1640 bytes --]
[-- Attachment #2: Type: text/plain, Size: 181 bytes --]
_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug 68456] [NV4B] null deref on load, NvI2C=1 makes it work
[not found] ` <bug-68456-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>
2013-08-22 23:00 ` [Bug 68456] [NV4B] null deref on load, NvI2C=1 makes it work bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2013-08-23 1:13 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
@ 2013-08-23 1:46 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2013-08-23 16:54 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2013-09-26 23:06 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2013-08-23 1:46 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
[-- Attachment #1.1: Type: text/plain, Size: 601 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=68456
--- Comment #2 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
Created attachment 84484
--> https://bugs.freedesktop.org/attachment.cgi?id=84484&action=edit
pass i2c functions into create func
Can you give this patch a shot? It compiles, but I haven't tested it beyond
that. Should fix the null deref. But it might still not work. (Obviously
without the NvI2C=1 thing.) BTW, how are you hitting this? Did you set
something in i2c like bit_test=1?
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1590 bytes --]
[-- Attachment #2: Type: text/plain, Size: 181 bytes --]
_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug 68456] [NV4B] null deref on load, NvI2C=1 makes it work
[not found] ` <bug-68456-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>
` (2 preceding siblings ...)
2013-08-23 1:46 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
@ 2013-08-23 16:54 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2013-09-26 23:06 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2013-08-23 16:54 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
[-- Attachment #1.1: Type: text/plain, Size: 402 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=68456
--- Comment #3 from Hans-Peter Deifel <hpdeifel-Mmb7MZpHnFY@public.gmane.org> ---
Your patch did work, thank you very much. I could load the module and use it
for a few hours without problems.
I had indeed set bit_test=1 for i2c_algo_bit although I had forgotten about it.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1152 bytes --]
[-- Attachment #2: Type: text/plain, Size: 181 bytes --]
_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug 68456] [NV4B] null deref on load, NvI2C=1 makes it work
[not found] ` <bug-68456-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>
` (3 preceding siblings ...)
2013-08-23 16:54 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
@ 2013-09-26 23:06 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2013-09-26 23:06 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
[-- Attachment #1.1: Type: text/plain, Size: 570 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=68456
Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
This patch should now be in 3.12-rc1.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1974 bytes --]
[-- Attachment #2: Type: text/plain, Size: 181 bytes --]
_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 6+ messages in thread