From: Timur Tabi <ttabi@nvidia.com>
To: "nova-gpu@lists.linux.dev" <nova-gpu@lists.linux.dev>,
Alexandre Courbot <acourbot@nvidia.com>,
"dakr@kernel.org" <dakr@kernel.org>,
Eliot Courtney <ecourtney@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>
Subject: Re: [PATCH 2/5] gpu: nova-core: merge LibosParams into GspFwHeapParams
Date: Sat, 14 Nov 2026 04:09:22 +0000 [thread overview]
Message-ID: <98758da2d21737964536bfb73fa3e21db8558995.camel@nvidia.com> (raw)
In-Reply-To: <DMS64VZKSLOP.2RCSK9BCHD47C@nvidia.com>
On Wed, 2026-11-11 at 15:30 +0900, Eliot Courtney wrote:
> The direction of this series looks good to me, but I think there's some
> unnecessary churn from moving the functions from LibosParams now, rather
> than switching over after adding the TLV values to GspFwHeapParams. What
> about doing essentially patch #1 then patch #3 (which doesn't need the
> zero dummy vals if #2 is removed) of this series, then a patch each for
> switching over
> - non-wpr heap + pmu reserved size (+drop hal functions)
> - vGPU stuff
> - WPR2 heap size
>
> I tried this locally and it seems to remove a bunch of the churn.
Yeah, this is an improvement. I'll post a v2 soon. It's broken down into smaller changes than
your list, but it's the same idea.
next prev parent reply other threads:[~2026-11-14 4:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 23:10 [PATCH 0/5] Transition nova-core to use TLV variables for heap sizes Timur Tabi
2026-11-10 23:10 ` [PATCH 1/5] gpu: nova-core: add Tlv.get_u64 Timur Tabi
2026-11-11 0:20 ` John Hubbard
2026-11-11 2:59 ` Timur Tabi
2026-11-11 3:45 ` John Hubbard
2026-11-11 5:21 ` Eliot Courtney
2026-11-11 5:27 ` Eliot Courtney
2026-11-10 23:10 ` [PATCH 2/5] gpu: nova-core: merge LibosParams into GspFwHeapParams Timur Tabi
2026-11-11 6:30 ` Eliot Courtney
2026-11-14 4:09 ` Timur Tabi [this message]
2026-11-10 23:10 ` [PATCH 3/5] gpu: nova-core: read GSP heap variables from TLV Timur Tabi
2026-11-10 23:10 ` [PATCH 4/5] gpu: nova-core: use the TLV heap sizes Timur Tabi
2026-11-10 23:10 ` [PATCH 5/5] gpu: nova-core: remove heap size related HAL functions Timur Tabi
2026-11-10 23:21 ` [PATCH 0/5] Transition nova-core to use TLV variables for heap sizes Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98758da2d21737964536bfb73fa3e21db8558995.camel@nvidia.com \
--to=ttabi@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=dakr@kernel.org \
--cc=ecourtney@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=nova-gpu@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox