Linux PCI Non-Transparent Bridge framework and drivers
 help / color / mirror / Atom feed
* [PATCH] ntb: fix SKX NTB config space size register offsets
@ 2016-12-13 16:03 Dave Jiang
  2016-12-21 16:54 ` Jon Mason
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Jiang @ 2016-12-13 16:03 UTC (permalink / raw)
  To: Allen.Hubbe, jdmason; +Cc: linux-ntb, Sandeep Mann, Zachary Ross

The offsets for the SZ registers are wrong. Updated.

Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Reported-by: Sandeep Mann <sandeep@purestorage.com>
Tested-by: Zachary Ross <zacharyx.ross@intel.com>
---
 drivers/ntb/hw/intel/ntb_hw_intel.h |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.h b/drivers/ntb/hw/intel/ntb_hw_intel.h
index 6e8c182..f2cf8a7 100644
--- a/drivers/ntb/hw/intel/ntb_hw_intel.h
+++ b/drivers/ntb/hw/intel/ntb_hw_intel.h
@@ -152,10 +152,10 @@
 #define XEON_SPAD_COUNT			16
 
 /* Intel Skylake Xeon hardware */
-#define SKX_IMBAR1SZ_OFFSET		0x00d1
-#define SKX_IMBAR2SZ_OFFSET		0x00d5
-#define SKX_EMBAR1SZ_OFFSET		0x00d3
-#define SKX_EMBAR2SZ_OFFSET		0x00d6
+#define SKX_IMBAR1SZ_OFFSET		0x00d0
+#define SKX_IMBAR2SZ_OFFSET		0x00d1
+#define SKX_EMBAR1SZ_OFFSET		0x00d2
+#define SKX_EMBAR2SZ_OFFSET		0x00d3
 #define SKX_DEVCTRL_OFFSET		0x0098
 #define SKX_DEVSTS_OFFSET		0x009a
 #define SKX_UNCERRSTS_OFFSET		0x014c


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ntb: fix SKX NTB config space size register offsets
  2016-12-13 16:03 [PATCH] ntb: fix SKX NTB config space size register offsets Dave Jiang
@ 2016-12-21 16:54 ` Jon Mason
  0 siblings, 0 replies; 2+ messages in thread
From: Jon Mason @ 2016-12-21 16:54 UTC (permalink / raw)
  To: Dave Jiang; +Cc: Allen.Hubbe, linux-ntb, Sandeep Mann, Zachary Ross

On Tue, Dec 13, 2016 at 09:03:13AM -0700, Dave Jiang wrote:
> The offsets for the SZ registers are wrong. Updated.
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> Reported-by: Sandeep Mann <sandeep@purestorage.com>
> Tested-by: Zachary Ross <zacharyx.ross@intel.com>

Applied to my ntb branch

Thanks,
Jon

> ---
>  drivers/ntb/hw/intel/ntb_hw_intel.h |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.h b/drivers/ntb/hw/intel/ntb_hw_intel.h
> index 6e8c182..f2cf8a7 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_intel.h
> +++ b/drivers/ntb/hw/intel/ntb_hw_intel.h
> @@ -152,10 +152,10 @@
>  #define XEON_SPAD_COUNT			16
>  
>  /* Intel Skylake Xeon hardware */
> -#define SKX_IMBAR1SZ_OFFSET		0x00d1
> -#define SKX_IMBAR2SZ_OFFSET		0x00d5
> -#define SKX_EMBAR1SZ_OFFSET		0x00d3
> -#define SKX_EMBAR2SZ_OFFSET		0x00d6
> +#define SKX_IMBAR1SZ_OFFSET		0x00d0
> +#define SKX_IMBAR2SZ_OFFSET		0x00d1
> +#define SKX_EMBAR1SZ_OFFSET		0x00d2
> +#define SKX_EMBAR2SZ_OFFSET		0x00d3
>  #define SKX_DEVCTRL_OFFSET		0x0098
>  #define SKX_DEVSTS_OFFSET		0x009a
>  #define SKX_UNCERRSTS_OFFSET		0x014c
> 
> -- 
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com.
> To post to this group, send email to linux-ntb@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/148164499341.194663.8632238363765425811.stgit%40djiang5-desk3.ch.intel.com.
> For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-12-21 16:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-13 16:03 [PATCH] ntb: fix SKX NTB config space size register offsets Dave Jiang
2016-12-21 16:54 ` Jon Mason

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox