* [PATCH] ntb_transport: Pick an unused queue
@ 2017-02-13 22:46 Aaron Sierra
2017-02-14 14:20 ` Allen Hubbe
0 siblings, 1 reply; 3+ messages in thread
From: Aaron Sierra @ 2017-02-13 22:46 UTC (permalink / raw)
To: Jon Mason, Dave Jiang, Allen Hubbe; +Cc: linux-ntb, Thomas Vanselus
From: Thomas VanSelus <tvanselus@xes-inc.com>
Fix typo causing ntb_transport_create_queue to select the first
queue every time, instead of using the next free queue.
Signed-off-by: Thomas VanSelus <tvanselus@xes-inc.com>
Signed-off-by: Aaron Sierra <asierra@xes-inc.com>
---
drivers/ntb/ntb_transport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
index f81aa4b..95b5540 100644
--- a/drivers/ntb/ntb_transport.c
+++ b/drivers/ntb/ntb_transport.c
@@ -1802,7 +1802,7 @@ ntb_transport_create_queue(void *data, struct device *client_dev,
node = dev_to_node(&ndev->dev);
- free_queue = ffs(nt->qp_bitmap);
+ free_queue = ffs(nt->qp_bitmap_free);
if (!free_queue)
goto err;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: ntb_transport: Pick an unused queue
2017-02-13 22:46 [PATCH] ntb_transport: Pick an unused queue Aaron Sierra
@ 2017-02-14 14:20 ` Allen Hubbe
2017-02-17 1:14 ` Jon Mason
0 siblings, 1 reply; 3+ messages in thread
From: Allen Hubbe @ 2017-02-14 14:20 UTC (permalink / raw)
To: 'Aaron Sierra', 'Jon Mason', 'Dave Jiang'
Cc: linux-ntb, 'Thomas Vanselus'
From: Aaron Sierra
> From: Thomas VanSelus <tvanselus@xes-inc.com>
>
> Fix typo causing ntb_transport_create_queue to select the first
> queue every time, instead of using the next free queue.
>
> Signed-off-by: Thomas VanSelus <tvanselus@xes-inc.com>
> Signed-off-by: Aaron Sierra <asierra@xes-inc.com>
Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>
> ---
> drivers/ntb/ntb_transport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> index f81aa4b..95b5540 100644
> --- a/drivers/ntb/ntb_transport.c
> +++ b/drivers/ntb/ntb_transport.c
> @@ -1802,7 +1802,7 @@ ntb_transport_create_queue(void *data, struct device *client_dev,
>
> node = dev_to_node(&ndev->dev);
>
> - free_queue = ffs(nt->qp_bitmap);
> + free_queue = ffs(nt->qp_bitmap_free);
> if (!free_queue)
> goto err;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ntb_transport: Pick an unused queue
2017-02-14 14:20 ` Allen Hubbe
@ 2017-02-17 1:14 ` Jon Mason
0 siblings, 0 replies; 3+ messages in thread
From: Jon Mason @ 2017-02-17 1:14 UTC (permalink / raw)
To: Allen Hubbe
Cc: 'Aaron Sierra', 'Dave Jiang', linux-ntb,
'Thomas Vanselus'
On Tue, Feb 14, 2017 at 09:20:00AM -0500, Allen Hubbe wrote:
> From: Aaron Sierra
> > From: Thomas VanSelus <tvanselus@xes-inc.com>
> >
> > Fix typo causing ntb_transport_create_queue to select the first
> > queue every time, instead of using the next free queue.
> >
> > Signed-off-by: Thomas VanSelus <tvanselus@xes-inc.com>
> > Signed-off-by: Aaron Sierra <asierra@xes-inc.com>
>
> Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>
Good catch! This has been in there from the beginning.
Add a
Fixes: fce8a7bb5 ("PCI-Express Non-Transparent Bridge Support")
and applied to my ntb branch.
Thanks,
Jon
>
> > ---
> > drivers/ntb/ntb_transport.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> > index f81aa4b..95b5540 100644
> > --- a/drivers/ntb/ntb_transport.c
> > +++ b/drivers/ntb/ntb_transport.c
> > @@ -1802,7 +1802,7 @@ ntb_transport_create_queue(void *data, struct device *client_dev,
> >
> > node = dev_to_node(&ndev->dev);
> >
> > - free_queue = ffs(nt->qp_bitmap);
> > + free_queue = ffs(nt->qp_bitmap_free);
> > if (!free_queue)
> > goto err;
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-17 1:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-13 22:46 [PATCH] ntb_transport: Pick an unused queue Aaron Sierra
2017-02-14 14:20 ` Allen Hubbe
2017-02-17 1:14 ` Jon Mason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox