[PATCH] ntb: Correct modinfo usage statement for ntb_perf

[PATCH] ntb: Correct modinfo usage statement for ntb_perf

[Gary R Hook]

The order parameters are powers of 2; adjust the usage information
to use correct mathematical representations.

Signed-off-by: Gary R Hook <gary.hook@amd.com>
---
 drivers/ntb/test/ntb_perf.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
index 9c4a21f1a9d9..42756a98a728 100644
--- a/drivers/ntb/test/ntb_perf.c
+++ b/drivers/ntb/test/ntb_perf.c
@@ -91,11 +91,11 @@
 
 static unsigned int seg_order = 19; /* 512K */
 module_param(seg_order, uint, 0644);
-MODULE_PARM_DESC(seg_order, "size order [n^2] of buffer segment for testing");
+MODULE_PARM_DESC(seg_order, "size order [2^n] of buffer segment for testing");
 
 static unsigned int run_order = 32; /* 4G */
 module_param(run_order, uint, 0644);
-MODULE_PARM_DESC(run_order, "size order [n^2] of total data to transfer");
+MODULE_PARM_DESC(run_order, "size order [2^n] of total data to transfer");
 
 static bool use_dma; /* default to 0 */
 module_param(use_dma, bool, 0644);

Re: [PATCH] ntb: Correct modinfo usage statement for ntb_perf

[Dave Jiang]

On 05/04/2017 09:36 AM, Gary R Hook wrote:
> The order parameters are powers of 2; adjust the usage information
> to use correct mathematical representations.
> 
> Signed-off-by: Gary R Hook <gary.hook@amd.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>

> ---
>  drivers/ntb/test/ntb_perf.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> index 9c4a21f1a9d9..42756a98a728 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -91,11 +91,11 @@
>  
>  static unsigned int seg_order = 19; /* 512K */
>  module_param(seg_order, uint, 0644);
> -MODULE_PARM_DESC(seg_order, "size order [n^2] of buffer segment for testing");
> +MODULE_PARM_DESC(seg_order, "size order [2^n] of buffer segment for testing");
>  
>  static unsigned int run_order = 32; /* 4G */
>  module_param(run_order, uint, 0644);
> -MODULE_PARM_DESC(run_order, "size order [n^2] of total data to transfer");
> +MODULE_PARM_DESC(run_order, "size order [2^n] of total data to transfer");
>  
>  static bool use_dma; /* default to 0 */
>  module_param(use_dma, bool, 0644);
> 

Re: [PATCH] ntb: Correct modinfo usage statement for ntb_perf

[Jon Mason]

On Thu, May 04, 2017 at 09:47:44AM -0700, Dave Jiang wrote:
> 
> 
> On 05/04/2017 09:36 AM, Gary R Hook wrote:
> > The order parameters are powers of 2; adjust the usage information
> > to use correct mathematical representations.
> > 
> > Signed-off-by: Gary R Hook <gary.hook@amd.com>
> Acked-by: Dave Jiang <dave.jiang@intel.com>

Sorry, I think I missed this one.  Adding to my ntb branch with the
following line

Fixes: 8a7b6a778a85 ("ntb: ntb perf tool")

This enables the stable kernels it is a bug fix and to pick it up.

> 
> > ---
> >  drivers/ntb/test/ntb_perf.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> > index 9c4a21f1a9d9..42756a98a728 100644
> > --- a/drivers/ntb/test/ntb_perf.c
> > +++ b/drivers/ntb/test/ntb_perf.c
> > @@ -91,11 +91,11 @@
> >  
> >  static unsigned int seg_order = 19; /* 512K */
> >  module_param(seg_order, uint, 0644);
> > -MODULE_PARM_DESC(seg_order, "size order [n^2] of buffer segment for testing");
> > +MODULE_PARM_DESC(seg_order, "size order [2^n] of buffer segment for testing");
> >  
> >  static unsigned int run_order = 32; /* 4G */
> >  module_param(run_order, uint, 0644);
> > -MODULE_PARM_DESC(run_order, "size order [n^2] of total data to transfer");
> > +MODULE_PARM_DESC(run_order, "size order [2^n] of total data to transfer");
> >  
> >  static bool use_dma; /* default to 0 */
> >  module_param(use_dma, bool, 0644);
> >