* [Ocfs2-devel] ocfs2: should not use le32_add_cpu to set ocfs2_dinode i_flags [not found] <54BFE80E.7090002@oracle.com> @ 2015-01-22 1:07 ` Joseph Qi 2015-01-22 1:12 ` Srinivas Eeda 0 siblings, 1 reply; 2+ messages in thread From: Joseph Qi @ 2015-01-22 1:07 UTC (permalink / raw) To: ocfs2-devel Hi Srini, On 2015/1/22 1:55, Srinivas Eeda wrote: > Hi Joesph, > > thanks a lot for submitting the above patch. I am trying to understand what kind of flag corruption have you noticed and under what circumstances ? I agree with the patch that bitwise operations are better than adding, but I am not able to understand the corruption it could cause. Can you please share! > Suppose a the following case: The dinode i_flag already has the OCFS2_ORPHANED_FL bit set, and calling le32_add_cpu again. Then it will corrupt the i_flag. -- Joseph > Thanks, > --Srini > > > ^ permalink raw reply [flat|nested] 2+ messages in thread
* [Ocfs2-devel] ocfs2: should not use le32_add_cpu to set ocfs2_dinode i_flags 2015-01-22 1:07 ` [Ocfs2-devel] ocfs2: should not use le32_add_cpu to set ocfs2_dinode i_flags Joseph Qi @ 2015-01-22 1:12 ` Srinivas Eeda 0 siblings, 0 replies; 2+ messages in thread From: Srinivas Eeda @ 2015-01-22 1:12 UTC (permalink / raw) To: ocfs2-devel Ok, understood. Thanks for explaining :) On 01/21/2015 05:07 PM, Joseph Qi wrote: > Hi Srini, > > On 2015/1/22 1:55, Srinivas Eeda wrote: >> Hi Joesph, >> >> thanks a lot for submitting the above patch. I am trying to understand what kind of flag corruption have you noticed and under what circumstances ? I agree with the patch that bitwise operations are better than adding, but I am not able to understand the corruption it could cause. Can you please share! >> > Suppose a the following case: > The dinode i_flag already has the OCFS2_ORPHANED_FL bit set, and calling > le32_add_cpu again. Then it will corrupt the i_flag. > > -- > Joseph > >> Thanks, >> --Srini >> >> >> > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-22 1:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <54BFE80E.7090002@oracle.com>
2015-01-22 1:07 ` [Ocfs2-devel] ocfs2: should not use le32_add_cpu to set ocfs2_dinode i_flags Joseph Qi
2015-01-22 1:12 ` Srinivas Eeda
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox