build fail with --disable-atmodem

build fail with --disable-atmodem

[=?unknown-8bit?b?7Jik7J247Zi4?=]

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 2618 bytes --]

[-- Attachment #3: 201106011457769_LP7KBSL8.jpg --]
[-- Type: image/jpeg, Size: 72722 bytes --]

Re: build fail with --disable-atmodem

[Aki Niemi]

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

On Wed, 2011-06-01 at 05:57 +0000, ext 오인호 wrote:
> i tried to compile with --disable-atmodem, an error occurred.
> 
> please help what to do. (i want only isimodem)
> 
> - without --disable-atmodem, compile success.

I sent a patch on 24.3. that fixes the issue. Gatchat is now required to
build core, but gets disabled along with atmodem.

Maybe Marcel or Denis could take a look at that patch (reattaching it
here).

Cheers,
Aki

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-build-Add-gatchat-to-core-sources.patch --]
[-- Type: text/x-patch, Size: 1426 bytes --]

>From 1920b813a4db120f0d6692e9d4d86f3fe313a263 Mon Sep 17 00:00:00 2001
From: Aki Niemi <aki.niemi@nokia.com>
Date: Thu, 24 Mar 2011 17:30:12 +0200
Subject: [PATCH] build: Add gatchat to core sources
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Otherwise, --disable-atmodem breaks build.
---
 Makefile.am |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index b0cbcd7..39d8962 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -154,8 +154,7 @@ endif
 
 if ATMODEM
 builtin_modules += atmodem
-builtin_sources += $(gatchat_sources) \
-				drivers/atmodem/atmodem.h \
+builtin_sources += drivers/atmodem/atmodem.h \
 				drivers/atmodem/atmodem.c \
 				drivers/atmodem/call-settings.c \
 				drivers/atmodem/sms.c \
@@ -365,9 +364,9 @@ builtin_sources += plugins/push-notification.c
 
 sbin_PROGRAMS = src/ofonod
 
-src_ofonod_SOURCES = $(gdbus_sources) $(builtin_sources) src/ofono.ver \
-			src/main.c src/ofono.h src/log.c src/plugin.c \
-			src/modem.c src/common.h src/common.c \
+src_ofonod_SOURCES = $(gdbus_sources) $(builtin_sources) $(gatchat_sources) \
+			src/ofono.ver src/main.c src/ofono.h src/log.c \
+			src/plugin.c src/modem.c src/common.h src/common.c \
 			src/manager.c src/dbus.c src/util.h src/util.c \
 			src/network.c src/voicecall.c src/ussd.c src/sms.c \
 			src/call-settings.c src/call-forwarding.c \
-- 
1.7.1