[PATCH] ppp: fix missing breaks in switchs

[PATCH] ppp: fix missing breaks in switchs

[Kristen Carlson Accardi]

[-- Attachment #1: Type: text/plain, Size: 1554 bytes --]

---
 gatchat/ppp_cp.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c
index d5f7c92..cf2f5fa 100644
--- a/gatchat/ppp_cp.c
+++ b/gatchat/ppp_cp.c
@@ -591,7 +591,7 @@ static void pppcp_down_event(struct pppcp_data *data, guint8 *packet, guint len)
 	case OPENED:
 		pppcp_transition_state(STARTING, data);
 		pppcp_this_layer_down(data);
-		/* fall through */
+		break;
 	case INITIAL:
 	case STARTING:
 		/* illegal */
@@ -840,7 +840,7 @@ static void pppcp_rca_event(struct pppcp_data *data, guint8 *packet, guint len)
 		/* scr/6x */
 		pppcp_send_configure_request(data);
 		pppcp_transition_state(REQSENT, data);
-		/* fall through */
+		break;
 	case ACKSENT:
 		pppcp_initialize_restart_count(&data->config_timer_data);
 		pppcp_this_layer_up(data);
@@ -870,7 +870,7 @@ static void pppcp_rcn_event(struct pppcp_data *data, guint8 *packet, guint len)
 	case CLOSING:
 	case STOPPING:
 		pppcp_transition_state(data->state, data);
-		/* fall through */
+		break;
 	case REQSENT:
 		pppcp_initialize_restart_count(&data->config_timer_data);
 		pppcp_send_configure_request(data);
@@ -905,10 +905,9 @@ static void pppcp_rtr_event(struct pppcp_data *data, guint8 *packet, guint len)
 	switch (data->state) {
 	case CLOSED:
 	case STOPPED:
-		pppcp_send_terminate_ack(data, packet);
-		/* fall through */
 	case CLOSING:
 	case STOPPING:
+		pppcp_send_terminate_ack(data, packet);
 		break;
 	case REQSENT:
 	case ACKRCVD:
-- 
1.6.6.1

Re: [PATCH] ppp: fix missing breaks in switchs

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

Hi Kristen,

> ---
>  gatchat/ppp_cp.c |    9 ++++-----
>  1 files changed, 4 insertions(+), 5 deletions(-)

patch has been applied. Thanks.

Regards

Marcel