From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH v2 1/3] u8500: add plugin for u8500
Date: Tue, 01 Feb 2011 16:41:45 +0100 [thread overview]
Message-ID: <1296574905.1520.270.camel@aeonflux> (raw)
In-Reply-To: <fabc1533cadfaf5d418d3d27833e7fe8d05a8739.1296569048.git.jessica.j.nilsson@stericsson.com>
[-- Attachment #1: Type: text/plain, Size: 1644 bytes --]
Hi Jessica,
> Makefile.am | 4 +
> plugins/ofono.rules | 3 +
> plugins/u8500.c | 507 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 514 insertions(+), 0 deletions(-)
> create mode 100644 plugins/u8500.c
as mentioned in the other email. Put ofono.rules and udev.c changes into
one patch.
> diff --git a/Makefile.am b/Makefile.am
> index a38fcb9..4762cc8 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -110,6 +110,7 @@ builtin_sources += $(gisi_sources) \
> drivers/isimodem/mtc.h \
> drivers/isimodem/debug.h \
> drivers/isimodem/isiutil.h \
> + drivers/isimodem/version.h \
> drivers/isimodem/debug.c \
> drivers/isimodem/phonebook.c \
> drivers/isimodem/devinfo.c \
This does not belong here. Please be careful what is in your patches.
> @@ -144,6 +145,9 @@ builtin_sources += plugins/isiusb.c
>
> builtin_modules += n900
> builtin_sources += plugins/n900.c plugins/nokia-gpio.h plugins/nokia-gpio.c
> +
> +builtin_modules += u8500
> +builtin_sources += plugins/u8500.c
> endif
>
> if ATMODEM
> diff --git a/plugins/ofono.rules b/plugins/ofono.rules
> index 111f071..333bff0 100644
> --- a/plugins/ofono.rules
> +++ b/plugins/ofono.rules
> @@ -356,6 +356,9 @@ SUBSYSTEMS=="usb", ENV{OFONO_DRIVER}="isiusb", ENV{OFONO_ISI_ADDRESS}="16"
> # Nokia N900 modem
> SUBSYSTEMS=="hsi", ENV{OFONO_DRIVER}="n900", ENV{OFONO_ISI_ADDRESS}="108"
>
> +# STE u8500
> +KERNEL=="shrm0", ENV{OFONO_DRIVER}="u8500"
> +
> LABEL="ofono_isi_end"
>
> SUBSYSTEM!="usb", GOTO="ofono_end"
Regards
Marcel
next prev parent reply other threads:[~2011-02-01 15:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 14:13 [PATCH v2 0/3] ISI modem version detection with plugin Jessica Nilsson
2011-02-01 14:13 ` [PATCH v2 1/3] u8500: add plugin for u8500 Jessica Nilsson
2011-02-01 15:41 ` Marcel Holtmann [this message]
2011-02-01 14:13 ` [PATCH v2 2/3] udev: u8500 support and style fix Jessica Nilsson
2011-02-01 15:39 ` Marcel Holtmann
2011-02-01 15:55 ` Andreas WESTIN
2011-02-01 16:12 ` Marcel Holtmann
2011-02-01 14:13 ` [PATCH v2 3/3] isimodem: header updates for ISI2.5 Jessica Nilsson
2011-02-01 15:43 ` Marcel Holtmann
2011-02-01 16:29 ` Andreas WESTIN
2011-02-01 19:32 ` Aki Niemi
2011-02-02 9:03 ` Andreas WESTIN
2011-02-02 13:03 ` Aki Niemi
2011-02-03 9:32 ` Andreas WESTIN
2011-02-04 9:05 ` Aki Niemi
2011-02-02 10:47 ` Marcel Holtmann
2011-02-08 15:16 ` Aki Niemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296574905.1520.270.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox