Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

Hi Aki,

> > > +enum isi_version {
> > > +	ISI_20 = 0,
> > > +	ISI_25 = 1
> > > +};
> > 
> > so what is the final decision here now. ISI doing auto-detection and
> > this gets not exposed to the modem drivers or we do.
> 
> Like I replied earlier, I don't see the need for this. Also, it will not
> work well with the isiusb plugin, which has the potential to work with
> any ISI modem. I'm not willing to break that potential until we just
> absolutely have to.
> 
> So, my stance holds: we quirk based on resource ID and based on the
> server's ISI version.

good to know. I was just double-checking in case you guys agreed on
something different on a private channel.

> I'm starting to think me just saying this out loud is not concrete
> enough, so I guess one way forward here could be for me to go ahead and
> adapt e.g. the netreg driver to work with N900 and later ISI modems. The
> netreg driver would make a good example, as it is one of those where the
> resource ID changes post N900, and the messages do vary based on it.

I think having an example on how you want this handled would be a good
idea. I don't have time to get myself familiar enough with ISI that I
can do any proper review here. So this is in your hands.

Regards

Marcel