From: Aki Niemi <aki.niemi@nokia.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5
Date: Wed, 02 Feb 2011 15:03:47 +0200 [thread overview]
Message-ID: <1296651827.2619.119.camel@tucson> (raw)
In-Reply-To: <4D491DDE.5000901@stericsson.com>
[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]
On Wed, 2011-02-02 at 10:03 +0100, ext Andreas WESTIN wrote:
> On 2011-02-01 20:32, Aki Niemi wrote:
> > Like I replied earlier, I don't see the need for this. Also, it will not
> > work well with the isiusb plugin, which has the potential to work with
> > any ISI modem. I'm not willing to break that potential until we just
> > absolutely have to.
>
> U8500 uses shrm driver and will not be recognized via isiusb.
I don't see what that has to do with the device supporting the "PC
suite" USB profile, which allows modem access using cdc_phonet.
> > So, my stance holds: we quirk based on resource ID and based on the
> > server's ISI version.
>
> From the information we have regarding ISI version from each server is
> that it is not consistent, meaning the value you get is not really the
> ISI version but the version of the server.
That is exactly what I meant. This version allows building quirks inside
the drivers. An example in pseudo-code:
if GIsiVersion.major == 15 and GIsiVersion.minor >= 3:
send( { FOO, value, filler, filler}, callback1 )
else:
send( { FOO, value }, callback2 )
Cheers,
Aki
next prev parent reply other threads:[~2011-02-02 13:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 14:13 [PATCH v2 0/3] ISI modem version detection with plugin Jessica Nilsson
2011-02-01 14:13 ` [PATCH v2 1/3] u8500: add plugin for u8500 Jessica Nilsson
2011-02-01 15:41 ` Marcel Holtmann
2011-02-01 14:13 ` [PATCH v2 2/3] udev: u8500 support and style fix Jessica Nilsson
2011-02-01 15:39 ` Marcel Holtmann
2011-02-01 15:55 ` Andreas WESTIN
2011-02-01 16:12 ` Marcel Holtmann
2011-02-01 14:13 ` [PATCH v2 3/3] isimodem: header updates for ISI2.5 Jessica Nilsson
2011-02-01 15:43 ` Marcel Holtmann
2011-02-01 16:29 ` Andreas WESTIN
2011-02-01 19:32 ` Aki Niemi
2011-02-02 9:03 ` Andreas WESTIN
2011-02-02 13:03 ` Aki Niemi [this message]
2011-02-03 9:32 ` Andreas WESTIN
2011-02-04 9:05 ` Aki Niemi
2011-02-02 10:47 ` Marcel Holtmann
2011-02-08 15:16 ` Aki Niemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296651827.2619.119.camel@tucson \
--to=aki.niemi@nokia.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox