Open Source Telephony
 help / color / mirror / Atom feed
From: Dragos Tatulea <dragos@endocode.com>
To: ofono@ofono.org
Subject: [PATCH 10/11] plugins/ublox: read network mode
Date: Mon, 14 Mar 2016 16:51:03 +0100	[thread overview]
Message-ID: <1457970664-20782-11-git-send-email-dragos@endocode.com> (raw)
In-Reply-To: <1457970664-20782-1-git-send-email-dragos@endocode.com>

[-- Attachment #1: Type: text/plain, Size: 2830 bytes --]

From: Dongsu Park <dongsu@endocode.com>

Read network mode into modem string. This will let the gprs-context
drive know what to do.
---
 plugins/ublox.c | 47 ++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 42 insertions(+), 5 deletions(-)

diff --git a/plugins/ublox.c b/plugins/ublox.c
index 8f6b3f1..b71e2c0 100644
--- a/plugins/ublox.c
+++ b/plugins/ublox.c
@@ -42,6 +42,7 @@
 #include <drivers/atmodem/atutil.h>
 #include <drivers/atmodem/vendor.h>
 
+static const char *ubmconf_prefix[] = { "+UBMCONF:", NULL };
 static const char *none_prefix[] = { NULL };
 
 enum supported_models {
@@ -52,11 +53,17 @@ enum supported_models {
 	TOBYL2_HIGH_THROUGHPUT_MODE 	= 1146,
 };
 
+enum ublox_net_mode {
+	UBLOX_TOBYL2_NET_MODE_ROUTER = 1,
+	UBLOX_TOBYL2_NET_MODE_BRIDGE = 2,
+};
+
 struct ublox_data {
 	GAtChat *modem;
 	GAtChat *aux;
 	int model_id;
 	enum ofono_vendor vendor_family;
+	enum ublox_net_mode net_mode;
 };
 
 static void ublox_debug(const char *str, void *user_data)
@@ -93,6 +100,39 @@ static void ublox_remove(struct ofono_modem *modem)
 	g_free(data);
 }
 
+static void read_ubmconf_cb(gboolean ok, GAtResult *result, gpointer user_data)
+{
+	struct ofono_modem *modem = (struct ofono_modem *) user_data;
+	struct ublox_data *data = ofono_modem_get_data(modem);
+	int mode = 0;
+	GAtResultIter iter;
+
+	g_at_result_iter_init(&iter, result);
+
+	while (!g_at_result_iter_next(&iter, "+UBMCONF:"))
+		;	/* skip every other line that is not UBMCONF */
+
+	g_at_result_iter_next_number(&iter, &mode);
+
+	data->net_mode = mode;
+	DBG("mode=%d", mode);
+	if (mode == 1)
+		ofono_modem_set_string(modem, "NetworkMode", "routed");
+	else if (mode == 2)
+		ofono_modem_set_string(modem, "NetworkMode", "bridged");
+}
+
+static void read_net_mode(struct ofono_modem *modem)
+{
+	struct ublox_data *data = ofono_modem_get_data(modem);
+
+	if (!data->aux)
+		return;
+
+	g_at_chat_send(data->aux, "AT+UBMCONF?",
+			ubmconf_prefix, read_ubmconf_cb, modem, NULL);
+}
+
 static GAtChat *open_device(struct ofono_modem *modem,
 				const char *key, char *debug)
 {
@@ -142,11 +182,6 @@ static void cfun_enable(gboolean ok, GAtResult *result, gpointer user_data)
 		return;
 	}
 
-	if (data->model_id == TOBYL2_HIGH_THROUGHPUT_MODE)
-		/* use bridged mode until routed mode support is added */
-		g_at_chat_send(data->aux, "AT+UBMCONF=2", none_prefix,
-						NULL, NULL, NULL);
-
 	ofono_modem_set_powered(modem, TRUE);
 }
 
@@ -206,6 +241,8 @@ static int ublox_enable(struct ofono_modem *modem)
 	g_at_chat_send(data->aux, "ATE0 +CMEE=1", none_prefix,
 					NULL, NULL, NULL);
 
+	read_net_mode(modem);
+
 	g_at_chat_send(data->aux, "AT+CFUN=4", none_prefix,
 					cfun_enable, modem, NULL);
 
-- 
2.5.0


  parent reply	other threads:[~2016-03-14 15:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14 15:50 [PATCH v1 00/11] Support for U-Blox Toby L2 modems Dragos Tatulea
2016-03-14 15:50 ` [PATCH 01/11] plugins/udevng: support different interface strings to detect TOBY series Dragos Tatulea
2016-03-16 18:00   ` Denis Kenzior
2016-03-14 15:50 ` [PATCH 02/11] plugins/ublox: allow enabling of TOBY L2 modems Dragos Tatulea
2016-03-16 18:12   ` Denis Kenzior
2016-03-14 15:50 ` [PATCH 03/11] plugins/ublox: use vendor from structure instead of fixed Dragos Tatulea
2016-03-16 18:20   ` Denis Kenzior
2016-03-14 15:50 ` [PATCH 04/11] atmodem: add support for U-Blox TOBY L2 modems Dragos Tatulea
2016-03-16 18:20   ` Denis Kenzior
2016-03-14 15:50 ` [PATCH 05/11] plugins/ublox: give names to model ids Dragos Tatulea
2016-03-16 18:22   ` Denis Kenzior
2016-03-14 15:50 ` [PATCH 06/11] ubloxmodem: add Toby L2 gprs context driver Dragos Tatulea
2016-03-16 23:25   ` Denis Kenzior
2016-03-17 10:33     ` Dragos Tatulea
2016-03-17 14:26       ` Denis Kenzior
2016-03-14 15:51 ` [PATCH 07/11] plugins/ublox: enable ubloxmodem driver when possible Dragos Tatulea
2016-03-14 15:51 ` [PATCH 08/11] plugins/ublox: support more internet contexts Dragos Tatulea
2016-03-14 15:51 ` [PATCH 09/11] ubloxmodem: support authentication Dragos Tatulea
2016-03-14 15:51 ` Dragos Tatulea [this message]
2016-03-14 15:51 ` [PATCH 11/11] ubloxmodem: add routed mode support Dragos Tatulea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457970664-20782-11-git-send-email-dragos@endocode.com \
    --to=dragos@endocode.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox