From: Dragos Tatulea <dragos@endocode.com>
To: ofono@ofono.org
Subject: [PATCH 03/11] plugins/ublox: use vendor from structure instead of fixed
Date: Mon, 14 Mar 2016 16:50:56 +0100 [thread overview]
Message-ID: <1457970664-20782-4-git-send-email-dragos@endocode.com> (raw)
In-Reply-To: <1457970664-20782-1-git-send-email-dragos@endocode.com>
[-- Attachment #1: Type: text/plain, Size: 1563 bytes --]
That's because we need to differentiate between multiple ublox
devices.
---
plugins/ublox.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/plugins/ublox.c b/plugins/ublox.c
index eab4ed4..d930efe 100644
--- a/plugins/ublox.c
+++ b/plugins/ublox.c
@@ -267,8 +267,8 @@ static void ublox_pre_sim(struct ofono_modem *modem)
DBG("%p", modem);
- ofono_devinfo_create(modem, 0, "atmodem", data->aux);
- sim = ofono_sim_create(modem, OFONO_VENDOR_UBLOX, "atmodem",
+ ofono_devinfo_create(modem, data->vendor_family, "atmodem", data->aux);
+ sim = ofono_sim_create(modem, data->vendor_family, "atmodem",
data->aux);
if (sim)
@@ -283,10 +283,10 @@ static void ublox_post_sim(struct ofono_modem *modem)
DBG("%p", modem);
- gprs = ofono_gprs_create(modem, OFONO_VENDOR_UBLOX, "atmodem",
+ gprs = ofono_gprs_create(modem, data->vendor_family, "atmodem",
data->aux);
- gc = ofono_gprs_context_create(modem, OFONO_VENDOR_UBLOX, "atmodem",
- data->modem);
+ gc = ofono_gprs_context_create(modem, data->vendor_family, "atmodem",
+ data->modem ? data->modem : data->aux);
if (gprs && gc)
ofono_gprs_add_context(gprs, gc);
@@ -296,7 +296,7 @@ static void ublox_post_online(struct ofono_modem *modem)
{
struct ublox_data *data = ofono_modem_get_data(modem);
- ofono_netreg_create(modem, 0, "atmodem", data->aux);
+ ofono_netreg_create(modem, data->vendor_family, "atmodem", data->aux);
}
static struct ofono_modem_driver ublox_driver = {
--
2.5.0
next prev parent reply other threads:[~2016-03-14 15:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 15:50 [PATCH v1 00/11] Support for U-Blox Toby L2 modems Dragos Tatulea
2016-03-14 15:50 ` [PATCH 01/11] plugins/udevng: support different interface strings to detect TOBY series Dragos Tatulea
2016-03-16 18:00 ` Denis Kenzior
2016-03-14 15:50 ` [PATCH 02/11] plugins/ublox: allow enabling of TOBY L2 modems Dragos Tatulea
2016-03-16 18:12 ` Denis Kenzior
2016-03-14 15:50 ` Dragos Tatulea [this message]
2016-03-16 18:20 ` [PATCH 03/11] plugins/ublox: use vendor from structure instead of fixed Denis Kenzior
2016-03-14 15:50 ` [PATCH 04/11] atmodem: add support for U-Blox TOBY L2 modems Dragos Tatulea
2016-03-16 18:20 ` Denis Kenzior
2016-03-14 15:50 ` [PATCH 05/11] plugins/ublox: give names to model ids Dragos Tatulea
2016-03-16 18:22 ` Denis Kenzior
2016-03-14 15:50 ` [PATCH 06/11] ubloxmodem: add Toby L2 gprs context driver Dragos Tatulea
2016-03-16 23:25 ` Denis Kenzior
2016-03-17 10:33 ` Dragos Tatulea
2016-03-17 14:26 ` Denis Kenzior
2016-03-14 15:51 ` [PATCH 07/11] plugins/ublox: enable ubloxmodem driver when possible Dragos Tatulea
2016-03-14 15:51 ` [PATCH 08/11] plugins/ublox: support more internet contexts Dragos Tatulea
2016-03-14 15:51 ` [PATCH 09/11] ubloxmodem: support authentication Dragos Tatulea
2016-03-14 15:51 ` [PATCH 10/11] plugins/ublox: read network mode Dragos Tatulea
2016-03-14 15:51 ` [PATCH 11/11] ubloxmodem: add routed mode support Dragos Tatulea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457970664-20782-4-git-send-email-dragos@endocode.com \
--to=dragos@endocode.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox