Open Source Telephony
 help / color / mirror / Atom feed
From: Dragos Tatulea <dragos@endocode.com>
To: ofono@ofono.org
Subject: [PATCH 02/11] plugins/ublox: allow enabling of TOBY L2 modems
Date: Mon, 14 Mar 2016 16:50:55 +0100	[thread overview]
Message-ID: <1457970664-20782-3-git-send-email-dragos@endocode.com> (raw)
In-Reply-To: <1457970664-20782-1-git-send-email-dragos@endocode.com>

[-- Attachment #1: Type: text/plain, Size: 2549 bytes --]

For this we need to:
* Set the vendor family based on model id.
* Not use modem interface for the TOBY L2 family.
---
 plugins/ublox.c | 51 ++++++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 42 insertions(+), 9 deletions(-)

diff --git a/plugins/ublox.c b/plugins/ublox.c
index 89ca709..eab4ed4 100644
--- a/plugins/ublox.c
+++ b/plugins/ublox.c
@@ -47,6 +47,7 @@ static const char *none_prefix[] = { NULL };
 struct ublox_data {
 	GAtChat *modem;
 	GAtChat *aux;
+	enum ofono_vendor vendor_family;
 };
 
 static void ublox_debug(const char *str, void *user_data)
@@ -138,24 +139,56 @@ static void cfun_enable(gboolean ok, GAtResult *result, gpointer user_data)
 static int ublox_enable(struct ofono_modem *modem)
 {
 	struct ublox_data *data = ofono_modem_get_data(modem);
+	const char *model_str = NULL;
+	int model_id;
 
 	DBG("%p", modem);
 
-	data->modem = open_device(modem, "Modem", "Modem: ");
-	if (data->modem == NULL)
+	model_str = ofono_modem_get_string(modem, "Model");
+	if (model_str == NULL)
 		return -EINVAL;
 
+	/*
+	 * Toby L2 devices are more complex and special than previously
+	 * supported U-Blox devices. So they need a vendor of their own.
+	 */
+	model_id = atoi(model_str);
+	switch (model_id) {
+	case 1102:
+		data->vendor_family = OFONO_VENDOR_UBLOX;
+		break;
+	case 1141:
+	case 1146:
+		data->vendor_family = OFONO_VENDOR_UBLOX_TOBY_L2;
+		break;
+	case 1143:
+		DBG("low/medium throughtput profile unsupported");
+	default:
+		DBG("unknown ublox model id %d", model_id);
+		return -EINVAL;
+	}
+
 	data->aux = open_device(modem, "Aux", "Aux: ");
-	if (data->aux == NULL) {
-		g_at_chat_unref(data->modem);
-		data->modem = NULL;
-		return -EIO;
+	if (data->aux == NULL)
+		return -EINVAL;
+
+	if (data->vendor_family == OFONO_VENDOR_UBLOX) {
+		data->modem = open_device(modem, "Modem", "Modem: ");
+		if (data->modem == NULL) {
+			g_at_chat_unref(data->aux);
+			data->aux = NULL;
+			return -EIO;
+		}
+
+		g_at_chat_set_slave(data->modem, data->aux);
+
+		g_at_chat_send(data->modem, "ATE0 +CMEE=1", none_prefix,
+						NULL, NULL, NULL);
 	}
 
-	g_at_chat_set_slave(data->modem, data->aux);
+	/* The modem can take a while to wake up if just powered on. */
+	g_at_chat_set_wakeup_command(data->aux, "AT\r", 1000, 11000);
 
-	g_at_chat_send(data->modem, "ATE0 +CMEE=1", none_prefix,
-					NULL, NULL, NULL);
 	g_at_chat_send(data->aux, "ATE0 +CMEE=1", none_prefix,
 					NULL, NULL, NULL);
 
-- 
2.5.0


  parent reply	other threads:[~2016-03-14 15:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14 15:50 [PATCH v1 00/11] Support for U-Blox Toby L2 modems Dragos Tatulea
2016-03-14 15:50 ` [PATCH 01/11] plugins/udevng: support different interface strings to detect TOBY series Dragos Tatulea
2016-03-16 18:00   ` Denis Kenzior
2016-03-14 15:50 ` Dragos Tatulea [this message]
2016-03-16 18:12   ` [PATCH 02/11] plugins/ublox: allow enabling of TOBY L2 modems Denis Kenzior
2016-03-14 15:50 ` [PATCH 03/11] plugins/ublox: use vendor from structure instead of fixed Dragos Tatulea
2016-03-16 18:20   ` Denis Kenzior
2016-03-14 15:50 ` [PATCH 04/11] atmodem: add support for U-Blox TOBY L2 modems Dragos Tatulea
2016-03-16 18:20   ` Denis Kenzior
2016-03-14 15:50 ` [PATCH 05/11] plugins/ublox: give names to model ids Dragos Tatulea
2016-03-16 18:22   ` Denis Kenzior
2016-03-14 15:50 ` [PATCH 06/11] ubloxmodem: add Toby L2 gprs context driver Dragos Tatulea
2016-03-16 23:25   ` Denis Kenzior
2016-03-17 10:33     ` Dragos Tatulea
2016-03-17 14:26       ` Denis Kenzior
2016-03-14 15:51 ` [PATCH 07/11] plugins/ublox: enable ubloxmodem driver when possible Dragos Tatulea
2016-03-14 15:51 ` [PATCH 08/11] plugins/ublox: support more internet contexts Dragos Tatulea
2016-03-14 15:51 ` [PATCH 09/11] ubloxmodem: support authentication Dragos Tatulea
2016-03-14 15:51 ` [PATCH 10/11] plugins/ublox: read network mode Dragos Tatulea
2016-03-14 15:51 ` [PATCH 11/11] ubloxmodem: add routed mode support Dragos Tatulea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457970664-20782-3-git-send-email-dragos@endocode.com \
    --to=dragos@endocode.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox