From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC PATCH 1/3] call-barring: removed +CSSI type SS notifications
Date: Wed, 09 Feb 2011 21:04:54 -0600 [thread overview]
Message-ID: <4D5355D6.9000503@gmail.com> (raw)
In-Reply-To: <7f7cc862a685786b014377e6e97c789d8d65666b.1297244230.git.Andras.Domokos@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
Hi Andras
On 02/09/2011 04:33 AM, Andras Domokos wrote:
> ---
> src/call-barring.c | 74 ----------------------------------------------------
> 1 files changed, 0 insertions(+), 74 deletions(-)
>
> diff --git a/src/call-barring.c b/src/call-barring.c
> index 649826e..84ed277 100644
> --- a/src/call-barring.c
> +++ b/src/call-barring.c
> @@ -58,9 +58,6 @@ struct ofono_call_barring {
> int ss_req_lock;
> struct ofono_ssn *ssn;
You forgot to remove this part in your patch. I applied your patch and
fixed this in a follow on patch.
> struct ofono_ussd *ussd;
> - unsigned int incoming_bar_watch;
> - unsigned int outgoing_bar_watch;
> - unsigned int ssn_watch;
> unsigned int ussd_watch;
> const struct ofono_call_barring_driver *driver;
> void *driver_data;
Regards,
-Denis
next prev parent reply other threads:[~2011-02-10 3:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 10:33 [PATCH 0/3] Voice call SS notifications Andras Domokos
2011-02-09 10:33 ` [RFC PATCH 1/3] call-barring: removed +CSSI type " Andras Domokos
2011-02-10 3:04 ` Denis Kenzior [this message]
2011-02-10 8:43 ` Andras Domokos
2011-02-09 10:34 ` [RFC PATCH 2/3] ssn: add code and call id to notifications Andras Domokos
2011-02-10 3:08 ` Denis Kenzior
2011-02-10 9:12 ` Andras Domokos
2011-02-22 12:07 ` Sankar
2011-02-24 11:43 ` Andras Domokos
2011-02-24 15:43 ` Denis Kenzior
2011-02-24 16:11 ` Andras Domokos
2011-02-24 16:14 ` Denis Kenzior
2011-02-24 16:21 ` Andras Domokos
2011-02-09 10:34 ` [RFC PATCH 3/3] voicecall: handle voice call SS notifications Andras Domokos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5355D6.9000503@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox