Open Source Telephony
 help / color / mirror / Atom feed
From: Andras Domokos <andras.domokos@nokia.com>
To: ofono@ofono.org
Subject: Re: [RFC PATCH 1/3] call-barring: removed +CSSI type SS notifications
Date: Thu, 10 Feb 2011 10:43:14 +0200	[thread overview]
Message-ID: <4D53A522.1040407@nokia.com> (raw)
In-Reply-To: <4D5355D6.9000503@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]

Hi Denis,

On 02/10/2011 05:04 AM, ext Denis Kenzior wrote:
> Hi Andras
>
> On 02/09/2011 04:33 AM, Andras Domokos wrote:
>> ---
>>   src/call-barring.c |   74 ----------------------------------------------------
>>   1 files changed, 0 insertions(+), 74 deletions(-)
>>
>> diff --git a/src/call-barring.c b/src/call-barring.c
>> index 649826e..84ed277 100644
>> --- a/src/call-barring.c
>> +++ b/src/call-barring.c
>> @@ -58,9 +58,6 @@ struct ofono_call_barring {
>>   	int ss_req_lock;
>>   	struct ofono_ssn *ssn;
> You forgot to remove this part in your patch.  I applied your patch and
> fixed this in a follow on patch.
Indeed I did. Thanks a lot for the fix!
>>   	struct ofono_ussd *ussd;
>> -	unsigned int incoming_bar_watch;
>> -	unsigned int outgoing_bar_watch;
>> -	unsigned int ssn_watch;
>>   	unsigned int ussd_watch;
>>   	const struct ofono_call_barring_driver *driver;
>>   	void *driver_data;
> Regards,
> -Denis
Regards,
Andras

  reply	other threads:[~2011-02-10  8:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-09 10:33 [PATCH 0/3] Voice call SS notifications Andras Domokos
2011-02-09 10:33 ` [RFC PATCH 1/3] call-barring: removed +CSSI type " Andras Domokos
2011-02-10  3:04   ` Denis Kenzior
2011-02-10  8:43     ` Andras Domokos [this message]
2011-02-09 10:34 ` [RFC PATCH 2/3] ssn: add code and call id to notifications Andras Domokos
2011-02-10  3:08   ` Denis Kenzior
2011-02-10  9:12     ` Andras Domokos
2011-02-22 12:07       ` Sankar
2011-02-24 11:43         ` Andras Domokos
2011-02-24 15:43           ` Denis Kenzior
2011-02-24 16:11             ` Andras Domokos
2011-02-24 16:14               ` Denis Kenzior
2011-02-24 16:21                 ` Andras Domokos
2011-02-09 10:34 ` [RFC PATCH 3/3] voicecall: handle voice call SS notifications Andras Domokos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D53A522.1040407@nokia.com \
    --to=andras.domokos@nokia.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox