Re: [RFC PATCH 2/3] ssn: add code and call id to notifications

[Andras Domokos <andras.domokos@nokia.com>]

[-- Attachment #1: Type: text/plain, Size: 2824 bytes --]

Hi Denis and Sankar,

The call SS notification handling patches hasn't been (fully) applied, I 
think we need to do something about it.

Regards,
Andras


On 02/22/2011 02:07 PM, ext Sankar wrote:
> Hi Denis/Andras,
>
> Is this patch applied and available in the GIT?
>
> Regards,
> Sankar.
>
> On Thu, Feb 10, 2011 at 2:42 PM, Andras Domokos 
> <andras.domokos(a)nokia.com <mailto:andras.domokos@nokia.com>> wrote:
>
>     Hi Denis,
>
>
>     On 02/10/2011 05:08 AM, ext Denis Kenzior wrote:
>
>         Hi Andras,
>
>             diff --git a/include/ssn.h b/include/ssn.h
>             index d640cad..ba3701b 100644
>             --- a/include/ssn.h
>             +++ b/include/ssn.h
>             @@ -37,9 +37,10 @@ struct ofono_ssn_driver {
>              };
>
>              /* SSN notifications (CSSI and CSSU).  */
>             -void ofono_ssn_cssi_notify(struct ofono_ssn *ssn, int
>             code, int index);
>             -void ofono_ssn_cssu_notify(struct ofono_ssn *ssn, int
>             code, int index,
>             -                               const struct
>             ofono_phone_number *number);
>             +void ofono_ssn_cssi_notify(struct ofono_ssn *ssn,
>             unsigned int id,
>             +                               int code1, int index);
>             +void ofono_ssn_cssu_notify(struct ofono_ssn *ssn,
>             unsigned int id, int code2,
>             +                       int index, const struct
>             ofono_phone_number *number);
>
>              int ofono_ssn_driver_register(const struct
>             ofono_ssn_driver *d);
>              void ofono_ssn_driver_unregister(const struct
>             ofono_ssn_driver *d);
>
>         Right now I'm not seeing any users (or even potential ones) of
>         the SSN
>         atom besides voicecall.  What do you think of removing the SSN
>         atom and
>         moving these to the voicecall atom?
>
>     Yes, we talked about removing the SSN atom, but I thought I would
>     keep it for now, it can be removed any time later, anyways, doesn't
>     save much removing it.
>
>
>         The only one I'm not sure about is<code2>  from 27.007:
>         6       forward check SS message received (can be received
>         whenever)
>
>         Any idea what this one is about?
>
>     Never encountered this message, and I am not sure what is it for.
>     A patch for handling this message can be submitted later, if a real
>     life case is found for it.
>
>         Regards,
>         -Denis
>
>     Regards,
>     Andras
>
>     _______________________________________________
>     ofono mailing list
>     ofono(a)ofono.org <mailto:ofono@ofono.org>
>     http://lists.ofono.org/listinfo/ofono
>
>


[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 5571 bytes --]