Possible ofono patches

Possible ofono patches

[piggz1]

Hi all

A few weeks ago, i started a personal project to try to rebase the jolla ofonalo dbus api's and changes ontop of current ofono.  I am writing about it here https://www.piggz.co.uk/sites/pgz/blog

My current work is against 2.5 with patches that are somewhat working with my pinephone. My tree of individual patches is available at https://github.com/piggz/ofono-upstream/tree/main/rpm

I wondered if anyone would care to scan over them and provide feedback as to whether any are suitable to upatream into ofono.  I appreciate not all will be, but with some rework, others may be of interest.

There is a working voicecall implementation for qmimodem, which includes a refactored call-list implementation.  Many of the others add dbus interfaces for sailfish so may not be interesting. 

Thanks to anyone who takes a look

Adam

-- 
Sent from my Sailfish device

Re: Possible ofono patches

[Denis Kenzior]

Hi Adam,

On 3/13/24 02:59, piggz1@gmail.com wrote:
> Hi all
> 
> A few weeks ago, i started a personal project to try to rebase the jolla ofonalo dbus api's and changes ontop of current ofono.  I am writing about it here https://www.piggz.co.uk/sites/pgz/blog
> 

Nice!

> My current work is against 2.5 with patches that are somewhat working with my pinephone. My tree of individual patches is available at https://github.com/piggz/ofono-upstream/tree/main/rpm
> 
> I wondered if anyone would care to scan over them and provide feedback as to whether any are suitable to upatream into ofono.  I appreciate not all will be, but with some rework, others may be of interest.

Hard to say since the commits lack any context information for _why_ the given 
code exists and what problem it is trying to solve.  Perhaps Jolla can help with 
that?

Also, I'd like to eradicate the use of glib in favor of ell in oFono, starting 
with qmi modem driver (which is now 99.9% glib free).  To this end, my 
preference is not to accept any new code that is glib based unless there's a 
strong reason to do so.

> 
> There is a working voicecall implementation for qmimodem, which includes a refactored call-list implementation.  Many of the others add dbus interfaces for sailfish so may not be interesting.

The voicecall driver is definitely something I'd take upstream and can help 
shepherd along.

Regards,
-Denis

Re: Possible ofono patches

[Adam Pigg]

Hi Denis

On Friday, 15 March 2024 13:56:00 GMT Denis Kenzior wrote:
> Hi Adam,
> 
> On 3/13/24 02:59, piggz1@gmail.com wrote:
> > Hi all
> > 
> > A few weeks ago, i started a personal project to try to rebase the jolla
> > ofonalo dbus api's and changes ontop of current ofono.  I am writing
> > about it here https://www.piggz.co.uk/sites/pgz/blog
> Nice!
> 
> > My current work is against 2.5 with patches that are somewhat working with
> > my pinephone. My tree of individual patches is available at
> > https://github.com/piggz/ofono-upstream/tree/main/rpm
> > 
> > I wondered if anyone would care to scan over them and provide feedback as
> > to whether any are suitable to upatream into ofono.  I appreciate not all
> > will be, but with some rework, others may be of interest.
> Hard to say since the commits lack any context information for _why_ the
> given code exists and what problem it is trying to solve.  Perhaps Jolla
> can help with that?
> 
> Also, I'd like to eradicate the use of glib in favor of ell in oFono,
> starting with qmi modem driver (which is now 99.9% glib free).  To this
> end, my preference is not to accept any new code that is glib based unless
> there's a strong reason to do so.
> 
> > There is a working voicecall implementation for qmimodem, which includes a
> > refactored call-list implementation.  Many of the others add dbus
> > interfaces for sailfish so may not be interesting.
> The voicecall driver is definitely something I'd take upstream and can help
> shepherd along.
>
I thought this would be most likely.  I do some re-work on it and make sure 
there is no glib before I submit it to the ML.

Currently it seems to be working for me, at least when in 2g or 3g mode.  
Calls fail in 4g, i think because the connection needs to be downgraded at 
this point. 
> Regards,
> -Denis