public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Alexander Kanavin <alex.kanavin@gmail.com>,
	Ross Burton <Ross.Burton@arm.com>
Cc: "raj.khem@gmail.com" <raj.khem@gmail.com>,
	Kai Kang <kai.kang@windriver.com>,
	 "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v2] mesa: Add native patch via a variable
Date: Wed, 26 Oct 2022 15:13:25 +0100	[thread overview]
Message-ID: <0a4ef0a929727c647d740827a4ae9905e2f64925.camel@linuxfoundation.org> (raw)
In-Reply-To: <CANNYZj_f6tNzH-DjZ+R3Az0v3LzU7x9fu87+u+gwX9+QW0psEg@mail.gmail.com>

On Wed, 2022-10-19 at 18:04 +0200, Alexander Kanavin wrote:
> Khem, sorry but no. We have well defined mechanisms for reuse, and
> including bits and pieces of recipes from completely different layers
> is not one of them. I do not want to hear even more complaints about
> 'breaking' things than I already do when trying to make things better,
> simpler and more maintainable, and I do not want to be paralysed by
> fear of invisible breakage in custom layers when doing so.
> 
> If you *really* want to make bits of mesa recipe 'public', put them in
> a bbclass.

I disagree with this a bit. The .inc files are there to allow this in
some cases. It used to be something which happened a lot as there were
many versions of things. Thankfully we don't have so many versions now.

Removing .inc files which aren't needed is fine, but removing them
where there is BSP usage seems a bit unfair. We should try and ensure
the .inc files really only include the common packaging code.

Obviously those using the .inc files do so knowing they can change from
under them.

Cheers,

Richard





  reply	other threads:[~2022-10-26 14:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18 23:08 [PATCH v2] mesa: Add native patch via a variable Khem Raj
2022-10-19  5:42 ` [OE-core] " Alexander Kanavin
2022-10-19  6:34   ` Khem Raj
2022-10-19  6:54     ` Alexander Kanavin
2022-10-19 15:04       ` Khem Raj
     [not found]     ` <171F65F5948858B5.6129@lists.openembedded.org>
2022-10-19 10:35       ` Alexander Kanavin
2022-10-26 14:34         ` Mark Hatle
2022-10-26 16:03           ` Alexander Kanavin
2022-10-26 17:20             ` Mark Hatle
2022-10-26 17:48               ` Joshua Watt
2022-10-26 18:01                 ` Alexander Kanavin
2022-10-27  0:46                   ` Mark Hatle
2022-10-28 10:59                     ` Alexander Kanavin
2022-10-28 18:01                       ` Mark Hatle
2022-10-26 20:58                 ` Mark Hatle
2022-10-19 15:29     ` Ross Burton
2022-10-19 16:04       ` Alexander Kanavin
2022-10-26 14:13         ` Richard Purdie [this message]
2022-10-19 16:05       ` Martin Jansa
2022-10-21 21:59       ` Khem Raj
     [not found] ` <171F61FEE1540458.9064@lists.openembedded.org>
2022-10-19  5:50   ` Alexander Kanavin
2022-10-19  5:55     ` Kai
2022-10-19  5:58     ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a4ef0a929727c647d740827a4ae9905e2f64925.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Ross.Burton@arm.com \
    --cc=alex.kanavin@gmail.com \
    --cc=kai.kang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox