Re: [OE-core] [PATCH v2] mesa: Add native patch via a variable

[Mark Hatle <mark.hatle@kernel.crashing.org>]

On 10/19/22 5:35 AM, Alexander Kanavin wrote:
> This also begs the question if mesa-gl is actually used by anyone, and
> what warrants its continued inclusion in core as opposed to
> product/BSP layers. I'll propose dropping the recipe and merging .inc
> into mesa.bb once patches start flowing.
> 
> The original commit was:
> https://git.yoctoproject.org/poky/commit/?h=master-next&id=015cb13

(I just saw this, so a little late on the reply, but..)

mesa-gl is ABSOLUTELY still being used.  It's needed for libmali usage.  Not 
everyone wants to use lima support for graphics.

It was broken into two separate packages so that is was VERY clear if you were 
using mesa for 'everything' (mesa), or mesa JUST for 'gl' (not gles).

--Mark

> Alex
> 
> On Wed, 19 Oct 2022 at 08:54, Alexander Kanavin via
> lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org>
> wrote:
>>
>> On Wed, 19 Oct 2022 at 08:34, Khem Raj <raj.khem@gmail.com> wrote:
>>>
>>> On Tue, Oct 18, 2022 at 10:42 PM Alexander Kanavin
>>> <alex.kanavin@gmail.com> wrote:
>>>>
>>>> Can you show examples where this is needed? Custom variable does not seem a good idea. I also worry that it’ll break automated updates (it’s bad enough with mesa-gl, this might make it worse).
>>>
>>> https://github.com/ndechesne/meta-qcom/blob/master/recipes-graphics/mesa/mesa_git.bb
>>
>> "require recipes-graphics/mesa/mesa.inc"
>>
>> Using recipe includes across layers like this is not a good idea. It
>> imposes requirements on core to continue providing the .inc, and not
>> doing anything with mesa that can 'break' users of that include.
>>
>> Please make it self-contained.
>>
>> Alex
>>
>>
>>
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#171964): https://lists.openembedded.org/g/openembedded-core/message/171964
>> Mute This Topic: https://lists.openembedded.org/mt/94420106/3616948
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mark.hatle@kernel.crashing.org]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>