From: Ross Burton <Ross.Burton@arm.com>
To: "raj.khem@gmail.com" <raj.khem@gmail.com>
Cc: Alexander Kanavin <alex.kanavin@gmail.com>,
Kai Kang <kai.kang@windriver.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v2] mesa: Add native patch via a variable
Date: Wed, 19 Oct 2022 15:29:24 +0000 [thread overview]
Message-ID: <E6C978BA-94B2-43D9-9275-29EC0323CDC1@arm.com> (raw)
In-Reply-To: <CAMKF1srnBDVj5ig2ZF_fX+-UZ5jtp0U89uG8qE5cuW1SjX0AfQ@mail.gmail.com>
On 19 Oct 2022, at 07:34, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
>
> On Tue, Oct 18, 2022 at 10:42 PM Alexander Kanavin
> <alex.kanavin@gmail.com> wrote:
>>
>> Can you show examples where this is needed? Custom variable does not seem a good idea. I also worry that it’ll break automated updates (it’s bad enough with mesa-gl, this might make it worse).
>
> https://github.com/ndechesne/meta-qcom/blob/master/recipes-graphics/mesa/mesa_git.bb
That is, well, horrible.
*If* we’re going to expose a mesa.inc that people outside of core can use to package up their own random Mesa SHA then mesa.inc should just be the packaging logic.
However, I don’t understand something about the patch.
Why do we only need to apply it on native builds? It’s a backport from upstream, so should be the fix. If it breaks when applied to target builds, is there a bug upstream for that?
Ross
next prev parent reply other threads:[~2022-10-19 15:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 23:08 [PATCH v2] mesa: Add native patch via a variable Khem Raj
2022-10-19 5:42 ` [OE-core] " Alexander Kanavin
2022-10-19 6:34 ` Khem Raj
2022-10-19 6:54 ` Alexander Kanavin
2022-10-19 15:04 ` Khem Raj
[not found] ` <171F65F5948858B5.6129@lists.openembedded.org>
2022-10-19 10:35 ` Alexander Kanavin
2022-10-26 14:34 ` Mark Hatle
2022-10-26 16:03 ` Alexander Kanavin
2022-10-26 17:20 ` Mark Hatle
2022-10-26 17:48 ` Joshua Watt
2022-10-26 18:01 ` Alexander Kanavin
2022-10-27 0:46 ` Mark Hatle
2022-10-28 10:59 ` Alexander Kanavin
2022-10-28 18:01 ` Mark Hatle
2022-10-26 20:58 ` Mark Hatle
2022-10-19 15:29 ` Ross Burton [this message]
2022-10-19 16:04 ` Alexander Kanavin
2022-10-26 14:13 ` Richard Purdie
2022-10-19 16:05 ` Martin Jansa
2022-10-21 21:59 ` Khem Raj
[not found] ` <171F61FEE1540458.9064@lists.openembedded.org>
2022-10-19 5:50 ` Alexander Kanavin
2022-10-19 5:55 ` Kai
2022-10-19 5:58 ` Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E6C978BA-94B2-43D9-9275-29EC0323CDC1@arm.com \
--to=ross.burton@arm.com \
--cc=alex.kanavin@gmail.com \
--cc=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox