Re: [OE-core][PATCH] devtool/standard: avoid KeyError

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2023-12-26 at 12:44 +0800, Chen Qi via lists.openembedded.org
wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
> 
> The initial_revs["."] does not have an initial value, resulting
> in the following error:
> 
>   KeyError: '.'
> 
> The problem could be reproduced by running:
> 
>   devtool modify -n systemd </path/to/my/local/systemd/repo>
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  scripts/lib/devtool/standard.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
> index 559fd45676..5d9b86ed6a 100644
> --- a/scripts/lib/devtool/standard.py
> +++ b/scripts/lib/devtool/standard.py
> @@ -905,6 +905,7 @@ def modify(args, config, basepath, workspace):
>                      (stdout, _) = bb.process.run('git rev-list --reverse devtool-base..HEAD', cwd=submodule_path)
>                      commits[submodule] = stdout.split()
>          else:
> +            initial_revs["."] = None
>              if os.path.exists(os.path.join(srctree, '.git')):
>                  # Check if it's a tree previously extracted by us. This is done
>                  # by ensuring that devtool-base and args.branch (devtool) exist.

Why aren't we seeing other reports of this? How is it reproduced?
Should we be adding an extra test to improve coverage?

I'm assuming this isn't related to:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=15318

?

Cheers,

Richard