public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: ChenQi <Qi.Chen@windriver.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH] devtool/standard: avoid KeyError
Date: Fri, 19 Jan 2024 11:28:36 +0800	[thread overview]
Message-ID: <b79b6994-6516-4c42-46ef-7d6a583600fb@windriver.com> (raw)
In-Reply-To: <20231226044457.3699093-1-Qi.Chen@windriver.com>

ping

On 12/26/23 12:44, Chen Qi via lists.openembedded.org wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> The initial_revs["."] does not have an initial value, resulting
> in the following error:
>
>    KeyError: '.'
>
> The problem could be reproduced by running:
>
>    devtool modify -n systemd </path/to/my/local/systemd/repo>
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>   scripts/lib/devtool/standard.py | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
> index 559fd45676..5d9b86ed6a 100644
> --- a/scripts/lib/devtool/standard.py
> +++ b/scripts/lib/devtool/standard.py
> @@ -905,6 +905,7 @@ def modify(args, config, basepath, workspace):
>                       (stdout, _) = bb.process.run('git rev-list --reverse devtool-base..HEAD', cwd=submodule_path)
>                       commits[submodule] = stdout.split()
>           else:
> +            initial_revs["."] = None
>               if os.path.exists(os.path.join(srctree, '.git')):
>                   # Check if it's a tree previously extracted by us. This is done
>                   # by ensuring that devtool-base and args.branch (devtool) exist.
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#192906): https://lists.openembedded.org/g/openembedded-core/message/192906
> Mute This Topic: https://lists.openembedded.org/mt/103366660/7304865
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [Qi.Chen@eng.windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>



  reply	other threads:[~2024-01-19  3:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-26  4:44 [OE-core][PATCH] devtool/standard: avoid KeyError Qi.Chen
2024-01-19  3:28 ` ChenQi [this message]
2024-01-19 17:19 ` Richard Purdie
2024-01-22  5:00   ` ChenQi
     [not found]   ` <17AC92B461D40AF5.16230@lists.openembedded.org>
2024-01-22  5:31     ` ChenQi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b79b6994-6516-4c42-46ef-7d6a583600fb@windriver.com \
    --to=qi.chen@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox