Openembedded Core Discussions
 help / color / mirror / Atom feed
* Re: [OE-core] nanbield: grpc_1.56.2 fails nativesdk build
       [not found] <17B23A54B6BB5F11.15017@lists.openembedded.org>
@ 2024-02-13 14:08 ` Joakim Tjernlund
  2024-02-13 14:14   ` Vyacheslav Yurkov
  0 siblings, 1 reply; 6+ messages in thread
From: Joakim Tjernlund @ 2024-02-13 14:08 UTC (permalink / raw)
  To: openembedded-core@lists.openembedded.org, steve@sakoman.com

On Fri, 2024-02-09 at 15:09 +0000, Joakim Tjernlund via lists.openembedded.org wrote:
> Whatever I try I always get:
> >   The imported target "protobuf::protoc" references the file
> > 
> >      "/home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/usr/bin/protoc-23.4.0"
> > 
> >   but this file does not exist.  Possible reasons include:
> > 
> >   * The file was deleted, renamed, or moved to another location.
> > 
> >   * An install or uninstall procedure did not complete successfully.
> > 
> >   * The installation package was faulty and contained
> > 
> >      "/home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/usr/lib/cmake/protobuf/protobuf-targets.cmake"
> > 
> >   but not all the files it references.
> 
> Looking at failing path:
> s /home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/usr/
> ./  ../  include/  lib/  share/
> 
> There in no bin dir at all. In lib there are lots of libs, including libprotobuf-c.so
> To me it feels like bitbake somehow failed to install  required bin/protoc-23.4.0 files
> but misses the bin files as these are normally not needed when building.
> 
> or perhaps it is rewriting  the passed path? What is passed to cmake is:
> "/home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot-native/usr/bin/protoc"
> 
> but bitbake somehow rewrite this to:
> 
> "/home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/usr/bin/protoc-23.4.0"
> 
> Notice the change to "recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/" in the middle.
> 
>  Joakim

FYI, this works around the problem:
cat ./meta-xr/recipes-devtools/grpc/grpc_%.bbappend
#Hack the nativesdk-grpc, copy protobuf's protoc* from sysroot to ${SDKPATHNATIVE}
#For some reason nativesdk-grpc will not find it and build fails otherwise.
#Unclear what the bug is but suspect upstream bug

do_configure:prepend:class-nativesdk () {
    MY_PREFIX="${TOPDIR}/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/${PV}"
    MY_FROM="/recipe-sysroot-native/usr/bin/"
    MY_TO="/recipe-sysroot/${SDKPATHNATIVE}/usr/bin/"
    mkdir -p "${MY_PREFIX}${MY_TO}" # Create missing DEST dir
    cp -ap "${MY_PREFIX}${MY_FROM}"protoc* "${MY_PREFIX}${MY_TO}"
}

CCing you Steve should you have missed this report.

 Joakim

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] nanbield: grpc_1.56.2 fails nativesdk build
  2024-02-13 14:08 ` [OE-core] nanbield: grpc_1.56.2 fails nativesdk build Joakim Tjernlund
@ 2024-02-13 14:14   ` Vyacheslav Yurkov
  2024-02-13 14:45     ` Joakim Tjernlund
  0 siblings, 1 reply; 6+ messages in thread
From: Vyacheslav Yurkov @ 2024-02-13 14:14 UTC (permalink / raw)
  To: Joakim.Tjernlund, openembedded-core@lists.openembedded.org,
	steve@sakoman.com
  Cc: openembedded-devel

Joakim,
I answered you last week on the this topic. Quoting it again:

Could this 
https://git.openembedded.org/meta-openembedded/commit/meta-oe/recipes-devtools/protobuf?id=b1deec0de476d8f0a0c6427919f57ee5f681ea0e 
fix your failure?

Note, oe-core is a wrong list for this discussion, I changed the CC 
accordingly.

Slava

On 13.02.2024 15:08, Joakim Tjernlund via lists.openembedded.org wrote:
> On Fri, 2024-02-09 at 15:09 +0000, Joakim Tjernlund via lists.openembedded.org wrote:
>> Whatever I try I always get:
>>>    The imported target "protobuf::protoc" references the file
>>>
>>>       "/home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/usr/bin/protoc-23.4.0"
>>>
>>>    but this file does not exist.  Possible reasons include:
>>>
>>>    * The file was deleted, renamed, or moved to another location.
>>>
>>>    * An install or uninstall procedure did not complete successfully.
>>>
>>>    * The installation package was faulty and contained
>>>
>>>       "/home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/usr/lib/cmake/protobuf/protobuf-targets.cmake"
>>>
>>>    but not all the files it references.
>> Looking at failing path:
>> s /home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/usr/
>> ./  ../  include/  lib/  share/
>>
>> There in no bin dir at all. In lib there are lots of libs, including libprotobuf-c.so
>> To me it feels like bitbake somehow failed to install  required bin/protoc-23.4.0 files
>> but misses the bin files as these are normally not needed when building.
>>
>> or perhaps it is rewriting  the passed path? What is passed to cmake is:
>> "/home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot-native/usr/bin/protoc"
>>
>> but bitbake somehow rewrite this to:
>>
>> "/home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/usr/bin/protoc-23.4.0"
>>
>> Notice the change to "recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/" in the middle.
>>
>>   Joakim
> FYI, this works around the problem:
> cat ./meta-xr/recipes-devtools/grpc/grpc_%.bbappend
> #Hack the nativesdk-grpc, copy protobuf's protoc* from sysroot to ${SDKPATHNATIVE}
> #For some reason nativesdk-grpc will not find it and build fails otherwise.
> #Unclear what the bug is but suspect upstream bug
>
> do_configure:prepend:class-nativesdk () {
>      MY_PREFIX="${TOPDIR}/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/${PV}"
>      MY_FROM="/recipe-sysroot-native/usr/bin/"
>      MY_TO="/recipe-sysroot/${SDKPATHNATIVE}/usr/bin/"
>      mkdir -p "${MY_PREFIX}${MY_TO}" # Create missing DEST dir
>      cp -ap "${MY_PREFIX}${MY_FROM}"protoc* "${MY_PREFIX}${MY_TO}"
> }
>
> CCing you Steve should you have missed this report.
>
>   Joakim



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] nanbield: grpc_1.56.2 fails nativesdk build
  2024-02-13 14:14   ` Vyacheslav Yurkov
@ 2024-02-13 14:45     ` Joakim Tjernlund
  2024-02-13 15:19       ` Joakim Tjernlund
  0 siblings, 1 reply; 6+ messages in thread
From: Joakim Tjernlund @ 2024-02-13 14:45 UTC (permalink / raw)
  To: openembedded-core@lists.openembedded.org, steve@sakoman.com,
	uvv.mail@gmail.com
  Cc: openembedded-devel@lists.openembedded.org

On Tue, 2024-02-13 at 15:14 +0100, Vyacheslav Yurkov wrote:
> Joakim,
> I answered you last week on the this topic. Quoting it again:

ahh, somehow I missed that, sorry. I will check and report

 Joakim

>
> Could this
> https://git.openembedded.org/meta-openembedded/commit/meta-oe/recipes-devtools/protobuf?id=b1deec0de476d8f0a0c6427919f57ee5f681ea0e
> fix your failure?
>
> Note, oe-core is a wrong list for this discussion, I changed the CC
> accordingly.
>
> Slava
>
> On 13.02.2024 15:08, Joakim Tjernlund via lists.openembedded.org wrote:
> > On Fri, 2024-02-09 at 15:09 +0000, Joakim Tjernlund via lists.openembedded.org wrote:
> > > Whatever I try I always get:
> > > >    The imported target "protobuf::protoc" references the file
> > > >
> > > >       "/home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/usr/bin/protoc-23.4.0"
> > > >
> > > >    but this file does not exist.  Possible reasons include:
> > > >
> > > >    * The file was deleted, renamed, or moved to another location.
> > > >
> > > >    * An install or uninstall procedure did not complete successfully.
> > > >
> > > >    * The installation package was faulty and contained
> > > >
> > > >       "/home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/usr/lib/cmake/protobuf/protobuf-targets.cmake"
> > > >
> > > >    but not all the files it references.
> > > Looking at failing path:
> > > s /home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/usr/
> > > ./  ../  include/  lib/  share/
> > >
> > > There in no bin dir at all. In lib there are lots of libs, including libprotobuf-c.so
> > > To me it feels like bitbake somehow failed to install  required bin/protoc-23.4.0 files
> > > but misses the bin files as these are normally not needed when building.
> > >
> > > or perhaps it is rewriting  the passed path? What is passed to cmake is:
> > > "/home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot-native/usr/bin/protoc"
> > >
> > > but bitbake somehow rewrite this to:
> > >
> > > "/home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/usr/bin/protoc-23.4.0"
> > >
> > > Notice the change to "recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/" in the middle.
> > >
> > >   Joakim
> > FYI, this works around the problem:
> > cat ./meta-xr/recipes-devtools/grpc/grpc_%.bbappend
> > #Hack the nativesdk-grpc, copy protobuf's protoc* from sysroot to ${SDKPATHNATIVE}
> > #For some reason nativesdk-grpc will not find it and build fails otherwise.
> > #Unclear what the bug is but suspect upstream bug
> >
> > do_configure:prepend:class-nativesdk () {
> >      MY_PREFIX="${TOPDIR}/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/${PV}"
> >      MY_FROM="/recipe-sysroot-native/usr/bin/"
> >      MY_TO="/recipe-sysroot/${SDKPATHNATIVE}/usr/bin/"
> >      mkdir -p "${MY_PREFIX}${MY_TO}" # Create missing DEST dir
> >      cp -ap "${MY_PREFIX}${MY_FROM}"protoc* "${MY_PREFIX}${MY_TO}"
> > }
> >
> > CCing you Steve should you have missed this report.
> >
> >   Joakim
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] nanbield: grpc_1.56.2 fails nativesdk build
  2024-02-13 14:45     ` Joakim Tjernlund
@ 2024-02-13 15:19       ` Joakim Tjernlund
  2024-02-13 18:40         ` Vyacheslav Yurkov
  0 siblings, 1 reply; 6+ messages in thread
From: Joakim Tjernlund @ 2024-02-13 15:19 UTC (permalink / raw)
  To: openembedded-core@lists.openembedded.org, steve@sakoman.com,
	uvv.mail@gmail.com
  Cc: openembedded-devel@lists.openembedded.org

On Tue, 2024-02-13 at 15:45 +0100, Joakim Tjernlund wrote:
> On Tue, 2024-02-13 at 15:14 +0100, Vyacheslav Yurkov wrote:
> > Joakim,
> > I answered you last week on the this topic. Quoting it again:
>
> ahh, somehow I missed that, sorry. I will check and report

Tested and works too, but I see this patch was reverted:


Revert "protobuf: stage protoc binary to sysroot"

    This reverts commit a0557fe5433620717eeb00d3b16801711337b1a4.

    As said by Ross[Ø]:
    "Putting the _target_ protoc into the sysroot for executation at _build_
    time isn't useful because even if it has the right architecture, the
    tune might be incompatible.  Recipes which want protoc should just depend
    on protobuf-native."

    This has been reverted recently by Samuli[1]:
    "If protoc is enabled for the build, recipes using protobuf will
    fail when protoc is not available in the recipe sysroot"

    Be the revert is incorret as This is an issue coming from qtgrpc
    other recipes that use protobuf or gRPC compiler, proplery looks for
    the binary in the correct sysroot folder.

    Qtgrpc recipe should fix this issue at the recipe level, for example this
    is what I've done for "etcd-cpp-apiv3" recipe[2] that doesn't need this
    patch to properly compile.

    So keeping this hack doesn't seems to be a correct fix.

    Note that qtgrpc recipe isn't available on meta-oe nor any other public
    layers.

    0: https://patchwork.yoctoproject.org/project/oe/patch/20230904161230.377450-1-ross.burton@arm.com/
    1: https://patchwork.yoctoproject.org/project/oe/patch/20230927051101.3088498-1-samuli.piippo@qt.io/
    2: https://github.com/etcd-cpp-apiv3/etcd-cpp-apiv3/commit/47f0d9e0326f3cc31c801a0ecf7312d1049ece3e

    CC: Samuli Piippo <samuli.piippo@gmail.com>
    CC: Ross Burton <ross.burton@arm.com>
    Signed-off-by: Clément Péron <peron.clem@gmail.com>
    Signed-off-by: Khem Raj <raj.khem@gmail.com>
    (cherry picked from commit bfb626a23022d871ce3c0c64cb9e5d1cc17c737e)
    Signed-off-by: Armin Kuster <akuster808@gmail.com>

So then what is the correct fix for grpc ?

 Joakim

>
>  Joakim
>
> >
> > Could this
> > https://git.openembedded.org/meta-openembedded/commit/meta-oe/recipes-devtools/protobuf?id=b1deec0de476d8f0a0c6427919f57ee5f681ea0e
> > fix your failure?
> >
> > Note, oe-core is a wrong list for this discussion, I changed the CC
> > accordingly.
> >
> > Slava
> >
> > On 13.02.2024 15:08, Joakim Tjernlund via lists.openembedded.org wrote:
> > > On Fri, 2024-02-09 at 15:09 +0000, Joakim Tjernlund via lists.openembedded.org wrote:
> > > > Whatever I try I always get:
> > > > >    The imported target "protobuf::protoc" references the file
> > > > >
> > > > >       "/home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/usr/bin/protoc-23.4.0"
> > > > >
> > > > >    but this file does not exist.  Possible reasons include:
> > > > >
> > > > >    * The file was deleted, renamed, or moved to another location.
> > > > >
> > > > >    * An install or uninstall procedure did not complete successfully.
> > > > >
> > > > >    * The installation package was faulty and contained
> > > > >
> > > > >       "/home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/usr/lib/cmake/protobuf/protobuf-targets.cmake"
> > > > >
> > > > >    but not all the files it references.
> > > > Looking at failing path:
> > > > s /home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/usr/
> > > > ./  ../  include/  lib/  share/
> > > >
> > > > There in no bin dir at all. In lib there are lots of libs, including libprotobuf-c.so
> > > > To me it feels like bitbake somehow failed to install  required bin/protoc-23.4.0 files
> > > > but misses the bin files as these are normally not needed when building.
> > > >
> > > > or perhaps it is rewriting  the passed path? What is passed to cmake is:
> > > > "/home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot-native/usr/bin/protoc"
> > > >
> > > > but bitbake somehow rewrite this to:
> > > >
> > > > "/home/jocke/yocto-xr/build/infn-xr/gmcu/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/usr/bin/protoc-23.4.0"
> > > >
> > > > Notice the change to "recipe-sysroot/opt/infn-xr/1.0/sysroots/x86_64-xrsdk-linux/" in the middle.
> > > >
> > > >   Joakim
> > > FYI, this works around the problem:
> > > cat ./meta-xr/recipes-devtools/grpc/grpc_%.bbappend
> > > #Hack the nativesdk-grpc, copy protobuf's protoc* from sysroot to ${SDKPATHNATIVE}
> > > #For some reason nativesdk-grpc will not find it and build fails otherwise.
> > > #Unclear what the bug is but suspect upstream bug
> > >
> > > do_configure:prepend:class-nativesdk () {
> > >      MY_PREFIX="${TOPDIR}/tmp/work/x86_64-nativesdk-xrsdk-linux/nativesdk-grpc/${PV}"
> > >      MY_FROM="/recipe-sysroot-native/usr/bin/"
> > >      MY_TO="/recipe-sysroot/${SDKPATHNATIVE}/usr/bin/"
> > >      mkdir -p "${MY_PREFIX}${MY_TO}" # Create missing DEST dir
> > >      cp -ap "${MY_PREFIX}${MY_FROM}"protoc* "${MY_PREFIX}${MY_TO}"
> > > }
> > >
> > > CCing you Steve should you have missed this report.
> > >
> > >   Joakim
> >
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] nanbield: grpc_1.56.2 fails nativesdk build
  2024-02-13 15:19       ` Joakim Tjernlund
@ 2024-02-13 18:40         ` Vyacheslav Yurkov
  2024-02-14  9:42           ` Joakim Tjernlund
  0 siblings, 1 reply; 6+ messages in thread
From: Vyacheslav Yurkov @ 2024-02-13 18:40 UTC (permalink / raw)
  To: Joakim Tjernlund, openembedded-core@lists.openembedded.org,
	steve@sakoman.com
  Cc: openembedded-devel@lists.openembedded.org

[-- Attachment #1: Type: text/plain, Size: 2167 bytes --]

On 13.02.2024 16:19, Joakim Tjernlund wrote:
> Tested and works too, but I see this patch was reverted:
>
>
> Revert "protobuf: stage protoc binary to sysroot"
>
>      This reverts commit a0557fe5433620717eeb00d3b16801711337b1a4.
>
>      As said by Ross[Ø]:
>      "Putting the _target_ protoc into the sysroot for executation at _build_
>      time isn't useful because even if it has the right architecture, the
>      tune might be incompatible.  Recipes which want protoc should just depend
>      on protobuf-native."
>
>      This has been reverted recently by Samuli[1]:
>      "If protoc is enabled for the build, recipes using protobuf will
>      fail when protoc is not available in the recipe sysroot"
>
>      Be the revert is incorret as This is an issue coming from qtgrpc
>      other recipes that use protobuf or gRPC compiler, proplery looks for
>      the binary in the correct sysroot folder.
>
>      Qtgrpc recipe should fix this issue at the recipe level, for example this
>      is what I've done for "etcd-cpp-apiv3" recipe[2] that doesn't need this
>      patch to properly compile.
>
>      So keeping this hack doesn't seems to be a correct fix.
>
>      Note that qtgrpc recipe isn't available on meta-oe nor any other public
>      layers.
>
>      0:https://patchwork.yoctoproject.org/project/oe/patch/20230904161230.377450-1-ross.burton@arm.com/
>      1:https://patchwork.yoctoproject.org/project/oe/patch/20230927051101.3088498-1-samuli.piippo@qt.io/
>      2:https://github.com/etcd-cpp-apiv3/etcd-cpp-apiv3/commit/47f0d9e0326f3cc31c801a0ecf7312d1049ece3e
>
>      CC: Samuli Piippo<samuli.piippo@gmail.com>
>      CC: Ross Burton<ross.burton@arm.com>
>      Signed-off-by: Clément Péron<peron.clem@gmail.com>
>      Signed-off-by: Khem Raj<raj.khem@gmail.com>
>      (cherry picked from commit bfb626a23022d871ce3c0c64cb9e5d1cc17c737e)
>      Signed-off-by: Armin Kuster<akuster808@gmail.com>
>
> So then what is the correct fix for grpc ?
>
>   Joakim
>

Reverted and then applied again :)

If you are interested, see the full discussion here 
https://lists.openembedded.org/g/openembedded-devel/topic/101679410#105284

Slava

[-- Attachment #2: Type: text/html, Size: 3464 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [OE-core] nanbield: grpc_1.56.2 fails nativesdk build
  2024-02-13 18:40         ` Vyacheslav Yurkov
@ 2024-02-14  9:42           ` Joakim Tjernlund
  0 siblings, 0 replies; 6+ messages in thread
From: Joakim Tjernlund @ 2024-02-14  9:42 UTC (permalink / raw)
  To: openembedded-core@lists.openembedded.org, steve@sakoman.com,
	uvv.mail@gmail.com
  Cc: openembedded-devel@lists.openembedded.org

[-- Attachment #1: Type: text/plain, Size: 3108 bytes --]

On Tue, 2024-02-13 at 19:40 +0100, Vyacheslav Yurkov via lists.openembedded.org wrote:
On 13.02.2024 16:19, Joakim Tjernlund wrote:


Tested and works too, but I see this patch was reverted:



Revert "protobuf: stage protoc binary to sysroot"


    This reverts commit a0557fe5433620717eeb00d3b16801711337b1a4.


    As said by Ross[Ø]:

    "Putting the _target_ protoc into the sysroot for executation at _build_

    time isn't useful because even if it has the right architecture, the

    tune might be incompatible.  Recipes which want protoc should just depend

    on protobuf-native."


    This has been reverted recently by Samuli[1]:

    "If protoc is enabled for the build, recipes using protobuf will

    fail when protoc is not available in the recipe sysroot"


    Be the revert is incorret as This is an issue coming from qtgrpc

    other recipes that use protobuf or gRPC compiler, proplery looks for

    the binary in the correct sysroot folder.


    Qtgrpc recipe should fix this issue at the recipe level, for example this

    is what I've done for "etcd-cpp-apiv3" recipe[2] that doesn't need this

    patch to properly compile.


    So keeping this hack doesn't seems to be a correct fix.


    Note that qtgrpc recipe isn't available on meta-oe nor any other public

    layers.


    0: https://patchwork.yoctoproject.org/project/oe/patch/20230904161230.377450-1-ross.burton@arm.com/

    1: https://patchwork.yoctoproject.org/project/oe/patch/20230927051101.3088498-1-samuli.piippo@qt.io/

    2: https://github.com/etcd-cpp-apiv3/etcd-cpp-apiv3/commit/47f0d9e0326f3cc31c801a0ecf7312d1049ece3e


    CC: Samuli Piippo <samuli.piippo@gmail.com><mailto:samuli.piippo@gmail.com>

    CC: Ross Burton <ross.burton@arm.com><mailto:ross.burton@arm.com>

    Signed-off-by: Clément Péron <peron.clem@gmail.com><mailto:peron.clem@gmail.com>

    Signed-off-by: Khem Raj <raj.khem@gmail.com><mailto:raj.khem@gmail.com>

    (cherry picked from commit bfb626a23022d871ce3c0c64cb9e5d1cc17c737e)

    Signed-off-by: Armin Kuster <akuster808@gmail.com><mailto:akuster808@gmail.com>


So then what is the correct fix for grpc ?


 Joakim


Reverted and then applied again :)

If you are interested, see the full discussion herehttps://lists.openembedded.org/g/openembedded-devel/topic/101679410#105284

Read the thread, seems to be some consensus but I cannot see it reapplied again and that is why my nativesdk is failing.
Steve?

 Joakim


Slava

-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.

View/Reply Online (#195426): https://lists.openembedded.org/g/openembedded-core/message/195426

Mute This Topic: https://lists.openembedded.org/mt/104260010/7472049

Group Owner: openembedded-core+owner@lists.openembedded.org<mailto:openembedded-core+owner@lists.openembedded.org>

Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [Joakim.Tjernlund@infinera.com<mailto:Joakim.Tjernlund@infinera.com>]

-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 7010 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-02-14  9:42 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <17B23A54B6BB5F11.15017@lists.openembedded.org>
2024-02-13 14:08 ` [OE-core] nanbield: grpc_1.56.2 fails nativesdk build Joakim Tjernlund
2024-02-13 14:14   ` Vyacheslav Yurkov
2024-02-13 14:45     ` Joakim Tjernlund
2024-02-13 15:19       ` Joakim Tjernlund
2024-02-13 18:40         ` Vyacheslav Yurkov
2024-02-14  9:42           ` Joakim Tjernlund

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox