Re: Pull request with misc changes

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2011-05-10 at 11:33 -0700, Tom Rini wrote:
> On 05/10/2011 11:13 AM, Martin Jansa wrote:
> > I'm using slightly modified script for pull requests from gitorious.
> > 
> > send-pull-request are the same as long as you use git send-email and
> > have sendemail.to defined in repo.
> > 
> > To modify it for github is as simple as this I guess.
> > 
> > $ diff -uNr shr-core/openembedded-core/scripts/create-pull-request ~/bin/meta-efl-create-pull-request 
> > --- shr-core/openembedded-core/scripts/create-pull-request 2011-04-04 09:35:47.973626385 +0200
> > +++ /OE/bin/meta-efl-create-pull-request        2011-05-10 13:33:20.349688815 +0200
> > @@ -2,9 +2,11 @@
> >  ODIR=pull-$$
> >  RELATIVE_TO="master"
> >  COMMIT_ID="HEAD"
> > -PULL_URL="git://git.openembedded.org/openembedded-core-contrib"
> > -WEB_URL_PREFIX="http://git.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h="
> > -PREFIX="PATCH"
> > +#PULL_URL="git://git.openembedded.org/meta-openembedded-contrib"
> > +#WEB_URL_PREFIX="http://git.openembedded.org/cgit.cgi/meta-openembedded-contrib/log/?h="
> > +PULL_URL="git://gitorious.org/shr/meta-openembedded.git"
> > +WEB_URL_PREFIX="http://gitorious.org/shr/meta-openembedded/commits/"
> > +PREFIX="meta-efl][PATCH"
> >  
> >  usage() {
> >  CMD=$(basename $0)
> 
> Hmmm.  I'm going to take a stab at making this a create-pull-request
> option...

Martin/Tom: Serious question - why not use the contrib repo for this?

I have nightmares about all the development being spread to all the
corners of the globe and people not being able to see what is being
worked on. For short lived branches its not so much of a problem but as
we take on longer lived feature development it will be a problem. I'd
therefore like to understand why the dislike of it...

Cheers,

Richard