Re: Pull request with misc changes

[Saul Wold <sgw@linux.intel.com>]

On 05/09/2011 12:15 PM, Otavio Salvador wrote:
> Hello,
>
> This pull request fixes some issues I found since the last pull
> request and should be preferred against the first.
>
Otavio,

Next time, please use the create-pull-request script, which will 
generate a set of patch emails so that we can review this information 
via email. I will make a couple of additional comments below associated 
with each patch.

> The following changes since commit d0dc2b5bb02ef55a41e7a97b6831c72391ae7f36:
>
>    u-boot: correct COPYING MD5SUM (2011-05-08 23:56:11 -0700)
>
> are available in the git repository at:
>    git://github.com/OSSystems/oe-core master
>
> Otavio Salvador (10):
>        meta/conf/local.conf.sample: fix mklibs comment line split and typo
>        scripts/oe-setup-builddir: fix typo
>        syslinux: improve packaging
>        busybox: add support to mdev
>        libxkbfile: disable xcb
>        insane.bbclass: skip license checksum if LICENSE is "CLOSED"
I assume you are adding this for layers and commercial work, we should 
never have CLOSED in any open layer.

>        cmake.bbclass: fix qmake and rpath issues
>        qmake_base.bbclass: add generate_qt_config_file task
>        cmake: add support for oe qt4 tools names
Please add a comment to the patch explaining it's purpose and origin, 
and include a Signed-off-by: if appropriate. Any patches that you have 
modified or added should include the above info.

>        fuse: drop since it is not used by other recipes
>
>   .../fuse-2.7.2/not-run-updaterc.d-on-host.patch    |   15 ----
>   meta-demoapps/recipes-kernel/fuse/fuse.inc         |   13 ---
>   meta-demoapps/recipes-kernel/fuse/fuse_2.7.2.bb    |   22 -----
>   meta/classes/cmake.bbclass                         |   19 ++++-
>   meta/classes/insane.bbclass                        |    4 +
>   meta/classes/qmake_base.bbclass                    |   15 ++++
>   meta/conf/local.conf.sample                        |    7 +-
>   meta/recipes-core/busybox/busybox.inc              |   14 +++-
>   meta/recipes-core/busybox/busybox_1.18.4.bb        |    2 +
>   meta/recipes-core/busybox/files/mdev               |    7 ++
>   meta/recipes-core/busybox/files/mdev.conf          |   35 ++++++++
>   meta/recipes-devtools/cmake/cmake-native_2.8.3.bb  |    2 +-
>   meta/recipes-devtools/cmake/cmake.inc              |    3 +-
>   .../cmake/cmake/support-oe-qt4-tools-names.patch   |   85 ++++++++++++++++++++
>   meta/recipes-devtools/syslinux/syslinux_4.03.bb    |   12 +++-
>   meta/recipes-graphics/xorg-lib/libxkbfile_1.0.7.bb |    4 +-
>   scripts/oe-setup-builddir                          |    2 +-
>   17 files changed, 199 insertions(+), 62 deletions(-)
>   delete mode 100644
> meta-demoapps/recipes-kernel/fuse/fuse-2.7.2/not-run-updaterc.d-on-host.patch
>   delete mode 100644 meta-demoapps/recipes-kernel/fuse/fuse.inc
>   delete mode 100644 meta-demoapps/recipes-kernel/fuse/fuse_2.7.2.bb
>   create mode 100755 meta/recipes-core/busybox/files/mdev
>   create mode 100644 meta/recipes-core/busybox/files/mdev.conf
>   create mode 100644
> meta/recipes-devtools/cmake/cmake/support-oe-qt4-tools-names.patch
>
>