Re: Pull request with misc changes

[Tom Rini <tom_rini@mentor.com>]

On 05/10/2011 11:13 AM, Martin Jansa wrote:
> On Tue, May 10, 2011 at 11:00:07AM -0700, Saul Wold wrote:
>> On 05/10/2011 05:53 AM, Otavio Salvador wrote:
>>> On Tue, May 10, 2011 at 02:17, Saul Wold<sgw@linux.intel.com>  wrote:
>>>> Next time, please use the create-pull-request script, which will generate a
>>>> set of patch emails so that we can review this information via email. I will
>>>> make a couple of additional comments below associated with each patch.
>>>
>>> It has a problem to me since it depends on using the contrib repo and
>>> I am using github.
>>> ...
>> Is there a reason you can't use the oe-core-contrib repo and create a 
>> branch there?  Can the script be modified to support github also?
> 
> I'm using slightly modified script for pull requests from gitorious.
> 
> send-pull-request are the same as long as you use git send-email and
> have sendemail.to defined in repo.
> 
> To modify it for github is as simple as this I guess.
> 
> $ diff -uNr shr-core/openembedded-core/scripts/create-pull-request ~/bin/meta-efl-create-pull-request 
> --- shr-core/openembedded-core/scripts/create-pull-request 2011-04-04 09:35:47.973626385 +0200
> +++ /OE/bin/meta-efl-create-pull-request        2011-05-10 13:33:20.349688815 +0200
> @@ -2,9 +2,11 @@
>  ODIR=pull-$$
>  RELATIVE_TO="master"
>  COMMIT_ID="HEAD"
> -PULL_URL="git://git.openembedded.org/openembedded-core-contrib"
> -WEB_URL_PREFIX="http://git.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h="
> -PREFIX="PATCH"
> +#PULL_URL="git://git.openembedded.org/meta-openembedded-contrib"
> +#WEB_URL_PREFIX="http://git.openembedded.org/cgit.cgi/meta-openembedded-contrib/log/?h="
> +PULL_URL="git://gitorious.org/shr/meta-openembedded.git"
> +WEB_URL_PREFIX="http://gitorious.org/shr/meta-openembedded/commits/"
> +PREFIX="meta-efl][PATCH"
>  
>  usage() {
>  CMD=$(basename $0)

Hmmm.  I'm going to take a stab at making this a create-pull-request
option...

-- 
Tom Rini
Mentor Graphics Corporation