Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: adding meta-intel layers breaks parsing, was Re: Updating u-boot for oe-core or meta-yocto
Date: Wed, 25 May 2011 22:31:16 +0100	[thread overview]
Message-ID: <1306359076.27470.65.camel@rex> (raw)
In-Reply-To: <4DDD60E3.606@linux.intel.com>

On Wed, 2011-05-25 at 13:04 -0700, Darren Hart wrote:
> 
> On 05/25/2011 12:11 PM, Phil Blundell wrote:
> > On Wed, 2011-05-25 at 11:56 -0700, Darren Hart wrote:
> >> If it is indeed space separated then I should be able to remedy both
> >> issues by simply using the append operator and not self-referencing.
> >> Correct?
> > 
> > I think that's true, yes.  But, space separation is fairly undesirable
> > for anything involving paths (particularly absolute ones) and it is
> > tempting to say that we should change that variable to have a different
> > separator. 
> > 
> 
> The only example I see of concatenating this variable is a prepend which
> uses colons. RP also mentioned he was pretty sure it should be colons.
> I'll figure it out for certain and fix the path assignments in meta-intel.

I checked the code and it is currently setup to use spaces but all the
users I've seen use colons.

There is significant precedent for *PATH* variables (FILESPATH, BBPATH,
PATH) being colon delimited so I'm tempted to say the utils.bbclass code
handling this should be fixed for EXTRAFILESPATH.

Also, the self referencing of that variable is correct. What is missing
is a default value for it, again that needs fixing in the core...

Cheers,

Richard



 





  reply	other threads:[~2011-05-25 21:34 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24 16:36 Updating u-boot for oe-core or meta-yocto Darren Hart
2011-05-24 17:13 ` Koen Kooi
2011-05-24 18:04   ` Darren Hart
2011-05-24 17:23 ` Khem Raj
2011-05-24 17:51   ` adding meta-intel layers breaks parsing, was " Koen Kooi
2011-05-24 18:07     ` Tom Zanussi
2011-05-25 14:28       ` Tom Zanussi
2011-05-25 14:31         ` Koen Kooi
2011-05-25 14:38         ` Phil Blundell
2011-05-25 14:52           ` Tom Zanussi
2011-05-25 18:56           ` Darren Hart
2011-05-25 19:11             ` Phil Blundell
2011-05-25 20:04               ` Darren Hart
2011-05-25 21:31                 ` Richard Purdie [this message]
2011-05-25 23:18                   ` Darren Hart
2011-05-24 18:23   ` Darren Hart
2011-05-24 18:35     ` Khem Raj
2011-05-24 18:48       ` Phil Blundell
2011-05-24 19:33       ` Darren Hart
2011-05-24 17:33 ` Martin Jansa
2011-05-25 15:51 ` Richard Purdie
2011-05-25 16:36   ` Khem Raj
2011-05-25 16:49     ` Henning Heinold
2011-05-25 18:40       ` Darren Hart
2011-05-26  6:12         ` Anders Darander
2011-05-26 13:54           ` Darren Hart
2011-05-25 21:51     ` Richard Purdie
2011-05-25 23:31       ` Jason Kridner
2011-05-26 18:07         ` Darren Hart
2011-05-27  5:36           ` Anders Darander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306359076.27470.65.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox